)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ac4f35f82701ca068a3e030285563c854fb8db56","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Add get_all method for AmphoraHealthRepository so we can pass non equality comparation in it,"},{"line_number":18,"context_line":"also make a test for it in test_repositories.py"},{"line_number":19,"context_line":"Changed the name of test_all and get_all to be test_all_filter and get_all_filter"},{"line_number":20,"context_line":"Changed code based on Brando\u0027sn and Adam\u0027s suggestions."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ic356dee139e743a9617d401f9658cfefcb49d15f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"1a6ced46_87430f41","line":20,"updated":"2015-03-25 21:01:27.000000000","message":"i won\u0027t -1 for this but the commit message contains changes you\u0027ve done to patchsets within this review.  Like \"changed code based on Brandon\u0027s and Adam\u0027s suggestions\".  Others above that too.  If the code was added in this review, but you\u0027ve had to change that code up in patchsets, you shouldn\u0027t have to put that in the commit message because it won\u0027t have any historical value when viewed after it gets merged.\n\nIf you have to do another PS you should remove these references.","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"fb2dcfc00e0a81e327f3196f329d4013608afde3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Add get_all method for AmphoraHealthRepository so we can pass non equality comparation in it,"},{"line_number":18,"context_line":"also make a test for it in test_repositories.py"},{"line_number":19,"context_line":"Changed the name of test_all and get_all to be test_all_filter and get_all_filter"},{"line_number":20,"context_line":"Changed code based on Brando\u0027sn and Adam\u0027s suggestions."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ic356dee139e743a9617d401f9658cfefcb49d15f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"1a6ced46_4225855a","line":20,"in_reply_to":"1a6ced46_87430f41","updated":"2015-03-25 21:34:44.000000000","message":"got it, will do","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"}],"doc-requirements.txt":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9938b5816b38f6dcaaab0e2a7c9f9279d0b92b37","unresolved":false,"context_lines":[{"line_number":4,"context_line":"nwdiag"},{"line_number":5,"context_line":"oslosphinx"},{"line_number":6,"context_line":"seqdiag"},{"line_number":7,"context_line":"sphinx\u003d\u003d1.2.3"},{"line_number":8,"context_line":"sphinxcontrib-actdiag"},{"line_number":9,"context_line":"sphinxcontrib-blockdiag"},{"line_number":10,"context_line":"sphinxcontrib-nwdiag"}],"source_content_type":"text/plain","patch_set":29,"id":"1a6ced46_270dfbe9","line":7,"updated":"2015-03-25 20:55:58.000000000","message":"I don\u0027t think we need to add that to very review. Just make an extra patch and we can merge it if needed.","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"fb2dcfc00e0a81e327f3196f329d4013608afde3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"nwdiag"},{"line_number":5,"context_line":"oslosphinx"},{"line_number":6,"context_line":"seqdiag"},{"line_number":7,"context_line":"sphinx\u003d\u003d1.2.3"},{"line_number":8,"context_line":"sphinxcontrib-actdiag"},{"line_number":9,"context_line":"sphinxcontrib-blockdiag"},{"line_number":10,"context_line":"sphinxcontrib-nwdiag"}],"source_content_type":"text/plain","patch_set":29,"id":"1a6ced46_02bd4dd8","line":7,"in_reply_to":"1a6ced46_270dfbe9","updated":"2015-03-25 21:34:44.000000000","message":"if we dont have this line, the pep8 will have warning, not sure who should make the extra patch.","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"}],"octavia/amphorae/drivers/noop_driver/driver.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9b826f9a52b6f4376bf9323079e7762e3e3ebfb6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class LoggingMixIn(driver_base.HealthMixin, driver_base.StatsMixin):"},{"line_number":24,"context_line":"    def update_stats(self, stats):"},{"line_number":25,"context_line":"        LOG.debug(\"Amphora %s no-op, update stats %s\","},{"line_number":26,"context_line":"                  self.__class__.__name__, stats)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_0fc2b284","line":23,"updated":"2015-02-11 22:21:57.000000000","message":"That should be a new class -- logging is logging the results whereas now we are writing them to the DB. So please keep logging the same and create a new one for writing to the DB\n\nAlso remove the StatsMixin since we are just doing health","commit_id":"564c3f145651ed2169558c73207ab27a0a7777c2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9b826f9a52b6f4376bf9323079e7762e3e3ebfb6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class LoggingMixIn(driver_base.HealthMixin, driver_base.StatsMixin):"},{"line_number":24,"context_line":"    def update_stats(self, stats):"},{"line_number":25,"context_line":"        LOG.debug(\"Amphora %s no-op, update stats %s\","},{"line_number":26,"context_line":"                  self.__class__.__name__, stats)"},{"line_number":27,"context_line":"        self.stats \u003d stats"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_0f49d230","line":24,"updated":"2015-02-11 22:21:57.000000000","message":"Remove","commit_id":"564c3f145651ed2169558c73207ab27a0a7777c2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9b826f9a52b6f4376bf9323079e7762e3e3ebfb6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def update_health(self, health):"},{"line_number":30,"context_line":"        LOG.debug(\"Amphora %s no-op, update health %s\","},{"line_number":31,"context_line":"                  self.__class__.__name__, health)"},{"line_number":32,"context_line":"        self.health \u003d health"},{"line_number":33,"context_line":"        # the following is the process map information, include update amphora"},{"line_number":34,"context_line":"        # status, update error status in db for other tables"},{"line_number":35,"context_line":"        # \u003cxgerman_\u003e the update code does:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_6f5faee5","line":32,"updated":"2015-02-11 22:21:57.000000000","message":"Not needed when we write to the DB","commit_id":"564c3f145651ed2169558c73207ab27a0a7777c2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9b826f9a52b6f4376bf9323079e7762e3e3ebfb6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.pool_repo \u003d repo.PoolRepository()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # if the pass amphora is healthy, we update its db infor"},{"line_number":63,"context_line":"        if health[\"amphora-status\"] is \"HEALTHY\":"},{"line_number":64,"context_line":"            amphora_id \u003d health[\"amphora-id\"]"},{"line_number":65,"context_line":"            self.amphora_health_repo.update(self.session,"},{"line_number":66,"context_line":"                                            amphora_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_0ff712d4","line":63,"updated":"2015-02-11 22:21:57.000000000","message":"see if there is a constant we can use","commit_id":"564c3f145651ed2169558c73207ab27a0a7777c2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9b826f9a52b6f4376bf9323079e7762e3e3ebfb6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # if the pass amphora is healthy, we update its db infor"},{"line_number":63,"context_line":"        if health[\"amphora-status\"] is \"HEALTHY\":"},{"line_number":64,"context_line":"            amphora_id \u003d health[\"amphora-id\"]"},{"line_number":65,"context_line":"            self.amphora_health_repo.update(self.session,"},{"line_number":66,"context_line":"                                            amphora_id,"},{"line_number":67,"context_line":"                                            last_update\u003dfunc.now())"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_8fef821d","line":65,"updated":"2015-02-11 22:21:57.000000000","message":"use db_apis.get_session() (and import db_api first)","commit_id":"564c3f145651ed2169558c73207ab27a0a7777c2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9b826f9a52b6f4376bf9323079e7762e3e3ebfb6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    pool_id \u003d new_member.pool_id"},{"line_number":87,"context_line":"                    if v \u003d\u003d \"HEALTHY\":"},{"line_number":88,"context_line":"                        self.member_repo.update(self.session, id\u003dk,"},{"line_number":89,"context_line":"                                                operating_status\u003d\"ACTIVE\")"},{"line_number":90,"context_line":"                        self.pool_repo.update(self.session, pool_id,"},{"line_number":91,"context_line":"                                              operating_status\u003d\"ACTIVE\")"},{"line_number":92,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_6fd40e20","line":89,"updated":"2015-02-11 22:21:57.000000000","message":"I think there is a constant (in common.constants) we can use","commit_id":"564c3f145651ed2169558c73207ab27a0a7777c2"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.amphorae.drivers import driver_base as driver_base"},{"line_number":16,"context_line":"from octavia.openstack.common import log as logging"},{"line_number":17,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_31069921","line":16,"updated":"2015-03-04 18:04:33.000000000","message":"I think this whitespace needs to be present between the imports and a line of actual code...","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.amphorae.drivers import driver_base as driver_base"},{"line_number":16,"context_line":"from octavia.openstack.common import log as logging"},{"line_number":17,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_4cc1b42d","line":16,"in_reply_to":"9a80dd14_31069921","updated":"2015-03-04 18:15:15.000000000","message":"will do","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"}],"octavia/common/data_models.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":193,"context_line":"class Amphora(BaseDataModel):"},{"line_number":194,"context_line":"    def __init__(self, id\u003dNone, load_balancer_id\u003dNone, compute_id\u003dNone,"},{"line_number":195,"context_line":"                 status\u003dNone, lb_network_ip\u003dNone, load_balancer\u003dNone,"},{"line_number":196,"context_line":"                 healthmanager\u003dNone):"},{"line_number":197,"context_line":"        self.id \u003d id"},{"line_number":198,"context_line":"        self.load_balancer_id \u003d load_balancer_id"},{"line_number":199,"context_line":"        self.compute_id \u003d compute_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_9a28dd87","line":196,"updated":"2015-01-29 23:21:01.000000000","message":"health_manager","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":193,"context_line":"class Amphora(BaseDataModel):"},{"line_number":194,"context_line":"    def __init__(self, id\u003dNone, load_balancer_id\u003dNone, compute_id\u003dNone,"},{"line_number":195,"context_line":"                 status\u003dNone, lb_network_ip\u003dNone, load_balancer\u003dNone,"},{"line_number":196,"context_line":"                 healthmanager\u003dNone):"},{"line_number":197,"context_line":"        self.id \u003d id"},{"line_number":198,"context_line":"        self.load_balancer_id \u003d load_balancer_id"},{"line_number":199,"context_line":"        self.compute_id \u003d compute_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_c3650cb6","line":196,"in_reply_to":"fa81d914_9a28dd87","updated":"2015-01-30 00:47:45.000000000","message":"will do","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.status \u003d status"},{"line_number":201,"context_line":"        self.lb_network_ip \u003d lb_network_ip"},{"line_number":202,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":203,"context_line":"        self.healthmanager \u003d healthmanager"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class HealthManager(BaseDataModel):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_1a430d43","line":203,"updated":"2015-01-29 23:21:01.000000000","message":"self.health_manager \u003d health_manager","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.status \u003d status"},{"line_number":201,"context_line":"        self.lb_network_ip \u003d lb_network_ip"},{"line_number":202,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":203,"context_line":"        self.healthmanager \u003d healthmanager"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class HealthManager(BaseDataModel):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_035c84ec","line":203,"in_reply_to":"fa81d914_1a430d43","updated":"2015-01-30 00:47:45.000000000","message":"will do","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"4afda5ea3b9f01254aa1bbaad87f064c74703072","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class AmphoraHealth(BaseDataModel):"},{"line_number":205,"context_line":"    def __init__(self, amphora_id\u003dNone, last_update\u003dNone):"},{"line_number":206,"context_line":"        self.amphora_id \u003d amphora_id"},{"line_number":207,"context_line":"        self.last_update \u003d last_update"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_2617f6a4","line":204,"updated":"2015-02-23 22:25:44.000000000","message":"nit: Should have a newline maybe here?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class AmphoraHealth(BaseDataModel):"},{"line_number":205,"context_line":"    def __init__(self, amphora_id\u003dNone, last_update\u003dNone):"},{"line_number":206,"context_line":"        self.amphora_id \u003d amphora_id"},{"line_number":207,"context_line":"        self.last_update \u003d last_update"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_b31c03c3","line":204,"in_reply_to":"ba7be1f8_2617f6a4","updated":"2015-02-23 22:51:29.000000000","message":"nit: +1","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8009b784ac18ef40d9a6c76de519ecc42f06d669","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class AmphoraHealth(BaseDataModel):"},{"line_number":205,"context_line":"    def __init__(self, amphora_id\u003dNone, last_update\u003dNone):"},{"line_number":206,"context_line":"        self.amphora_id \u003d amphora_id"},{"line_number":207,"context_line":"        self.last_update \u003d last_update"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_f3083b93","line":204,"in_reply_to":"ba7be1f8_2617f6a4","updated":"2015-02-23 22:32:53.000000000","message":"will do , thanks for taking care of the details :)","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"eb673cc01e6cde342b959d872a45506398634cb8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class AmphoraHealth(BaseDataModel):"},{"line_number":205,"context_line":"    def __init__(self, amphora_id\u003dNone, last_update\u003dNone):"},{"line_number":206,"context_line":"        self.amphora_id \u003d amphora_id"},{"line_number":207,"context_line":"        self.last_update \u003d last_update"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_49423a3f","line":204,"in_reply_to":"ba7be1f8_b31c03c3","updated":"2015-02-23 23:06:44.000000000","message":"will do","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"}],"octavia/controller/healthmanager/update_health_mixin.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            }"},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        # first setup repo for amphora, listener,member(nodes),pool"},{"line_number":67,"context_line":"        session \u003d db_api.get_session()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # if the input amphora is healthy, we update its db infor"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_852e1ff9","line":66,"updated":"2015-02-13 21:49:56.000000000","message":"comment doesn\u0027t match what is going on --","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for x in range(len(listener)):"},{"line_number":86,"context_line":"            key \u003d listener.keys()[x]"},{"line_number":87,"context_line":"            if listener[key][\"listener-status\"] \u003d\u003d constants.ONLINE:"},{"line_number":88,"context_line":"                self.listener_repo.update(session, key,"},{"line_number":89,"context_line":"                                          operating_status\u003dconstants.ONLINE)"},{"line_number":90,"context_line":"            elif listener[key][\"listener-status\"] \u003d\u003d constants.AMPHORA_DOWN:"},{"line_number":91,"context_line":"                self.listener_repo.update(session, key,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_a5cfa328","line":88,"updated":"2015-02-13 21:49:56.000000000","message":"wrap that in try..catch in case the listener got deleted","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                self.listener_repo.update(session, key,"},{"line_number":89,"context_line":"                                          operating_status\u003dconstants.ONLINE)"},{"line_number":90,"context_line":"            elif listener[key][\"listener-status\"] \u003d\u003d constants.AMPHORA_DOWN:"},{"line_number":91,"context_line":"                self.listener_repo.update(session, key,"},{"line_number":92,"context_line":"                                          operating_status\u003dconstants.ERROR)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            nodes \u003d listener[key][\"nodes\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_e5d8bbf2","line":91,"updated":"2015-02-13 21:49:56.000000000","message":"ditto","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    if v \u003d\u003d constants.ONLINE:"},{"line_number":102,"context_line":"                        self.member_repo.update("},{"line_number":103,"context_line":"                            session, id\u003dk, operating_status\u003dconstants.ONLINE)"},{"line_number":104,"context_line":"                        self.pool_repo.update(session, pool_id,"},{"line_number":105,"context_line":"                                              operating_status\u003dconstants.ONLINE"},{"line_number":106,"context_line":"                                              )"},{"line_number":107,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_05d6afc3","line":104,"updated":"2015-02-13 21:49:56.000000000","message":"ditto","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                              )"},{"line_number":107,"context_line":"                    else:"},{"line_number":108,"context_line":"                        self.member_repo.update("},{"line_number":109,"context_line":"                            session, id\u003dk, operating_status\u003dconstants.ERROR)"},{"line_number":110,"context_line":"                        self.pool_repo.update("},{"line_number":111,"context_line":"                          session, pool_id,operating_status\u003dconstants.DEGRADED)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_45e0a796","line":109,"updated":"2015-02-13 21:49:56.000000000","message":"ditto","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"3b623885845c7ce5ed15751f48369b06054a968c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    self.amphora_health_repo.create(session,"},{"line_number":81,"context_line":"                                                  amphora_id\u003damphora_id,"},{"line_number":82,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":83,"context_line":"                except Exception as e:"},{"line_number":84,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_bc2bdd80","line":83,"updated":"2015-02-17 19:03:20.000000000","message":"not sure what the right exception is. I am wondering if we can check if the NoResultFound Exceptipon would work?","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    self.amphora_health_repo.create(session,"},{"line_number":81,"context_line":"                                                  amphora_id\u003damphora_id,"},{"line_number":82,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":83,"context_line":"                except Exception as e:"},{"line_number":84,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_99bf67aa","line":83,"updated":"2015-02-14 00:30:48.000000000","message":"we know that we are creating this db entry so no try..catch needed","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    self.amphora_health_repo.create(session,"},{"line_number":81,"context_line":"                                                  amphora_id\u003damphora_id,"},{"line_number":82,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":83,"context_line":"                except Exception as e:"},{"line_number":84,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_5ce1019a","line":83,"in_reply_to":"da86d52c_99bf67aa","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    self.amphora_health_repo.create(session,"},{"line_number":81,"context_line":"                                                  amphora_id\u003damphora_id,"},{"line_number":82,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":83,"context_line":"                except Exception as e:"},{"line_number":84,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_bcf3dd71","line":83,"in_reply_to":"da86d52c_bc2bdd80","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                except Exception as e:"},{"line_number":84,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                try:"},{"line_number":87,"context_line":"                    self.amphora_health_repo.update(session, amphora_id,"},{"line_number":88,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":89,"context_line":"                except Exception as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_b9db4b20","line":86,"updated":"2015-02-14 00:30:48.000000000","message":"ditto","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                except Exception as e:"},{"line_number":84,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                try:"},{"line_number":87,"context_line":"                    self.amphora_health_repo.update(session, amphora_id,"},{"line_number":88,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":89,"context_line":"                except Exception as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_fce9d57f","line":86,"in_reply_to":"da86d52c_b9db4b20","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                try:"},{"line_number":97,"context_line":"                    self.listener_repo.update(session, key,"},{"line_number":98,"context_line":"                                          operating_status\u003dconstants.ONLINE)"},{"line_number":99,"context_line":"                except Exception as e:"},{"line_number":100,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":101,"context_line":"            elif listener[key][\"listener-status\"] \u003d\u003d constants.AMPHORA_DOWN:"},{"line_number":102,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_39cf5b59","line":99,"updated":"2015-02-14 00:30:48.000000000","message":"make sure that we only catch the exception of the listener not being in the DB -- NOT all exceptions","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                try:"},{"line_number":97,"context_line":"                    self.listener_repo.update(session, key,"},{"line_number":98,"context_line":"                                          operating_status\u003dconstants.ONLINE)"},{"line_number":99,"context_line":"                except Exception as e:"},{"line_number":100,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":101,"context_line":"            elif listener[key][\"listener-status\"] \u003d\u003d constants.AMPHORA_DOWN:"},{"line_number":102,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_3cffed35","line":99,"in_reply_to":"da86d52c_39cf5b59","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    self.listener_repo.update(session, key,"},{"line_number":98,"context_line":"                                          operating_status\u003dconstants.ONLINE)"},{"line_number":99,"context_line":"                except Exception as e:"},{"line_number":100,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":101,"context_line":"            elif listener[key][\"listener-status\"] \u003d\u003d constants.AMPHORA_DOWN:"},{"line_number":102,"context_line":"                try:"},{"line_number":103,"context_line":"                    self.listener_repo.update(session, key,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_d9071f80","line":100,"updated":"2015-02-14 00:30:48.000000000","message":"Having that happen is a \"normal\" thing so just log it as DEBUG","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    self.listener_repo.update(session, key,"},{"line_number":98,"context_line":"                                          operating_status\u003dconstants.ONLINE)"},{"line_number":99,"context_line":"                except Exception as e:"},{"line_number":100,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":101,"context_line":"            elif listener[key][\"listener-status\"] \u003d\u003d constants.AMPHORA_DOWN:"},{"line_number":102,"context_line":"                try:"},{"line_number":103,"context_line":"                    self.listener_repo.update(session, key,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_7cf5e54f","line":100,"in_reply_to":"da86d52c_d9071f80","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                try:"},{"line_number":103,"context_line":"                    self.listener_repo.update(session, key,"},{"line_number":104,"context_line":"                                          operating_status\u003dconstants.ERROR)"},{"line_number":105,"context_line":"                except Exception as e:"},{"line_number":106,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            nodes \u003d listener[key][\"nodes\"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_99eda7ba","line":105,"updated":"2015-02-14 00:30:48.000000000","message":"same here","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                try:"},{"line_number":103,"context_line":"                    self.listener_repo.update(session, key,"},{"line_number":104,"context_line":"                                          operating_status\u003dconstants.ERROR)"},{"line_number":105,"context_line":"                except Exception as e:"},{"line_number":106,"context_line":"                    LOG.ERROR(e.message)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            nodes \u003d listener[key][\"nodes\"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_9c9539e6","line":105,"in_reply_to":"da86d52c_99eda7ba","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                            session, id\u003dk, operating_status\u003dconstants.ONLINE)"},{"line_number":119,"context_line":"                            self.pool_repo.update(session, pool_id,"},{"line_number":120,"context_line":"                                              operating_status\u003dconstants.ONLINE"},{"line_number":121,"context_line":"                                              )"},{"line_number":122,"context_line":"                        except Exception as e:"},{"line_number":123,"context_line":"                            LOG.ERROR(e.message)"},{"line_number":124,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_593a4f35","line":121,"updated":"2015-02-14 00:30:48.000000000","message":"same here","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                            session, id\u003dk, operating_status\u003dconstants.ONLINE)"},{"line_number":119,"context_line":"                            self.pool_repo.update(session, pool_id,"},{"line_number":120,"context_line":"                                              operating_status\u003dconstants.ONLINE"},{"line_number":121,"context_line":"                                              )"},{"line_number":122,"context_line":"                        except Exception as e:"},{"line_number":123,"context_line":"                            LOG.ERROR(e.message)"},{"line_number":124,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_5f47334c","line":121,"in_reply_to":"da86d52c_593a4f35","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                            session, id\u003dk, operating_status\u003dconstants.ERROR)"},{"line_number":128,"context_line":"                            self.pool_repo.update("},{"line_number":129,"context_line":"                          session, pool_id,operating_status\u003dconstants.DEGRADED)"},{"line_number":130,"context_line":"                        except Exception as e:"},{"line_number":131,"context_line":"                              LOG.ERROR(e.message)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_9944c7b8","line":130,"updated":"2015-02-14 00:30:48.000000000","message":"same here","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d176ea67b9d57b9fc179833ebe981cb0ce054e6a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                            session, id\u003dk, operating_status\u003dconstants.ERROR)"},{"line_number":128,"context_line":"                            self.pool_repo.update("},{"line_number":129,"context_line":"                          session, pool_id,operating_status\u003dconstants.DEGRADED)"},{"line_number":130,"context_line":"                        except Exception as e:"},{"line_number":131,"context_line":"                              LOG.ERROR(e.message)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_df6a43b4","line":130,"in_reply_to":"da86d52c_9944c7b8","updated":"2015-02-17 19:29:22.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"67c4667a9be0cc4b61dce94e5eca1b4a2255d415","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"},{"line_number":112,"context_line":"                    new_member \u003d self.member_repo.get(session, id\u003dk)"},{"line_number":113,"context_line":"                    if not new_member:"},{"line_number":114,"context_line":"                        continue"},{"line_number":115,"context_line":"                    pool_id \u003d new_member.pool_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_1d6e4796","line":112,"updated":"2015-02-19 17:35:22.000000000","message":"On second thought I think we need to catch NoResultFound exception and then continue.","commit_id":"3c14d0fce00fbba5e58e9bd852c236da468aa18e"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"b6c360d4f1f8a82394ae7027bc7d983c2f405be2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"},{"line_number":112,"context_line":"                    new_member \u003d self.member_repo.get(session, id\u003dk)"},{"line_number":113,"context_line":"                    if not new_member:"},{"line_number":114,"context_line":"                        continue"},{"line_number":115,"context_line":"                    pool_id \u003d new_member.pool_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_11b0f041","line":112,"in_reply_to":"da86d52c_1d6e4796","updated":"2015-02-19 18:27:55.000000000","message":"will change it","commit_id":"3c14d0fce00fbba5e58e9bd852c236da468aa18e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \"amphora-status\": \"HEALTHY\","},{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"HEALTHY\","},{"line_number":57,"context_line":"                                  \"nodes\": {"},{"line_number":58,"context_line":"                                      \"node-id-1\": \"HEALTHY\","},{"line_number":59,"context_line":"                                      \"node-id-2\": \"HEALTHY\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_f693c94c","line":56,"updated":"2015-02-23 22:51:29.000000000","message":"These docs are inconsistent with the code below.  The example status is \"HEALTHY\" but before you are checking for \"ONLINE\".\nThese should all line up with the specification.","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"eb673cc01e6cde342b959d872a45506398634cb8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \"amphora-status\": \"HEALTHY\","},{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"HEALTHY\","},{"line_number":57,"context_line":"                                  \"nodes\": {"},{"line_number":58,"context_line":"                                      \"node-id-1\": \"HEALTHY\","},{"line_number":59,"context_line":"                                      \"node-id-2\": \"HEALTHY\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_a947364a","line":56,"in_reply_to":"ba7be1f8_f693c94c","updated":"2015-02-23 23:06:44.000000000","message":"will do","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"4afda5ea3b9f01254aa1bbaad87f064c74703072","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"HEALTHY\","},{"line_number":57,"context_line":"                                  \"nodes\": {"},{"line_number":58,"context_line":"                                      \"node-id-1\": \"HEALTHY\","},{"line_number":59,"context_line":"                                      \"node-id-2\": \"HEALTHY\""},{"line_number":60,"context_line":"                                  }"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_33b9f3e9","line":57,"updated":"2015-02-23 22:25:44.000000000","message":"What are nodes?  Is this supposed to be pool members?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"HEALTHY\","},{"line_number":57,"context_line":"                                  \"nodes\": {"},{"line_number":58,"context_line":"                                      \"node-id-1\": \"HEALTHY\","},{"line_number":59,"context_line":"                                      \"node-id-2\": \"HEALTHY\""},{"line_number":60,"context_line":"                                  }"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_535f4741","line":57,"in_reply_to":"ba7be1f8_33b9f3e9","updated":"2015-02-23 22:51:29.000000000","message":"We probably should use the terminology of \"member\"\nWhat does the specification say?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8009b784ac18ef40d9a6c76de519ecc42f06d669","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"HEALTHY\","},{"line_number":57,"context_line":"                                  \"nodes\": {"},{"line_number":58,"context_line":"                                      \"node-id-1\": \"HEALTHY\","},{"line_number":59,"context_line":"                                      \"node-id-2\": \"HEALTHY\""},{"line_number":60,"context_line":"                                  }"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_534027a5","line":57,"in_reply_to":"ba7be1f8_33b9f3e9","updated":"2015-02-23 22:32:53.000000000","message":"yes, it is a pool memeber","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"eb673cc01e6cde342b959d872a45506398634cb8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"HEALTHY\","},{"line_number":57,"context_line":"                                  \"nodes\": {"},{"line_number":58,"context_line":"                                      \"node-id-1\": \"HEALTHY\","},{"line_number":59,"context_line":"                                      \"node-id-2\": \"HEALTHY\""},{"line_number":60,"context_line":"                                  }"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_097042a4","line":57,"in_reply_to":"ba7be1f8_535f4741","updated":"2015-02-23 23:06:44.000000000","message":"i think it is member, since in libra we use node, here i just use node as well, will change","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":105,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            nodes \u003d listener[key][\"nodes\"]"},{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_d332570f","line":107,"updated":"2015-02-23 22:51:29.000000000","message":"Same here, nodes-\u003emembers?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"                        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":128,"context_line":"                            LOG.DEBUG(\"New Pool item is not in DB\")"},{"line_number":129,"context_line":"                    else:"},{"line_number":130,"context_line":"                        try:"},{"line_number":131,"context_line":"                            self.member_repo.update("},{"line_number":132,"context_line":"                                session, id\u003dk,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_d6dec510","line":129,"updated":"2015-02-23 22:51:29.000000000","message":"Nit: Is it safe to assume that any status going forward other than ONLINE is an error?\nI like to see code that logs warnings if it gets status codes it doesn\u0027t know.  Or at least fails the unit test.  This way it notifies devs that update the status options that this code also needs to be updated to handle those status.","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0ccfd9085e2b1dc534a25112cb648660561f7b4a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":128,"context_line":"                            LOG.DEBUG(\"New Pool item is not in DB\")"},{"line_number":129,"context_line":"                    else:"},{"line_number":130,"context_line":"                        try:"},{"line_number":131,"context_line":"                            self.member_repo.update("},{"line_number":132,"context_line":"                                session, id\u003dk,"},{"line_number":133,"context_line":"                                operating_status\u003dconstants.ERROR)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_276fedfe","line":130,"updated":"2015-02-24 00:27:44.000000000","message":"The more I think about this, I think we are missing some logic here.  If the node is market offline by the customer it should not be listed as in ERROR and make the pool degraded.","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"527bb2c0a2540b871b8569f84f969e2595c75cdb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"},{"line_number":112,"context_line":"                    if v \u003d\u003d constants.ONLINE:"},{"line_number":113,"context_line":"                        try:"},{"line_number":114,"context_line":"                            self.member_repo.update("}],"source_content_type":"text/x-python","patch_set":13,"id":"ba7be1f8_fa7455ff","line":111,"updated":"2015-02-25 00:46:57.000000000","message":"Replace lines 112-125 with something like this:\n\nif v in consts.OPERATING_STATUS:\ntry:\nself.pool_repo.update(\t\n\tsession, id\u003dpool_id,\t\t\n\toperating_status\u003dk)\nexcept ...","commit_id":"b012a2cf640403c1ae9f0a086265b3fd444d7cd8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from octavia.db import repositories as repo"},{"line_number":21,"context_line":"from octavia.openstack.common import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from sqlalchemy.sql import func"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_fdd6a1c2","line":23,"updated":"2015-02-27 03:56:01.000000000","message":"this should be moved to the first section with sqlalchemy.","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from octavia.db import repositories as repo"},{"line_number":21,"context_line":"from octavia.openstack.common import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from sqlalchemy.sql import func"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_6bc3a78a","line":23,"in_reply_to":"ba7be1f8_fdd6a1c2","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.pool_repo \u003d repo.PoolRepository()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def update_health(self, health):"},{"line_number":39,"context_line":"        \"\"\"This function is to update db infor based on amphora status"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param health: map object that contains amphora, listener,member info"},{"line_number":42,"context_line":"        :type map: string"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_dd247d10","line":39,"updated":"2015-02-27 03:56:01.000000000","message":"nit: infor \u003d info","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.pool_repo \u003d repo.PoolRepository()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def update_health(self, health):"},{"line_number":39,"context_line":"        \"\"\"This function is to update db infor based on amphora status"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param health: map object that contains amphora, listener,member info"},{"line_number":42,"context_line":"        :type map: string"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_8bc0db7d","line":39,"in_reply_to":"ba7be1f8_dd247d10","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def update_health(self, health):"},{"line_number":39,"context_line":"        \"\"\"This function is to update db infor based on amphora status"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param health: map object that contains amphora, listener,member info"},{"line_number":42,"context_line":"        :type map: string"},{"line_number":43,"context_line":"        :returns: null"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_5d788df8","line":41,"updated":"2015-02-27 03:56:01.000000000","message":"nit: space after listener,","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def update_health(self, health):"},{"line_number":39,"context_line":"        \"\"\"This function is to update db infor based on amphora status"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param health: map object that contains amphora, listener,member info"},{"line_number":42,"context_line":"        :type map: string"},{"line_number":43,"context_line":"        :returns: null"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_0b630bb2","line":41,"in_reply_to":"ba7be1f8_5d788df8","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"ONLINE\","},{"line_number":57,"context_line":"                                  \"member\": {"},{"line_number":58,"context_line":"                                      \"member-id-1\": \"ONLINE\","},{"line_number":59,"context_line":"                                      \"member-id-2\": \"ONLINE\""},{"line_number":60,"context_line":"                                  }"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_dd0abd26","line":57,"updated":"2015-02-27 03:56:01.000000000","message":"we should change this to members","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"amphora-id\": 1234,"},{"line_number":55,"context_line":"            \"listeners\": {"},{"line_number":56,"context_line":"                \"listener-id-1\": {\"listener-status\": \"ONLINE\","},{"line_number":57,"context_line":"                                  \"member\": {"},{"line_number":58,"context_line":"                                      \"member-id-1\": \"ONLINE\","},{"line_number":59,"context_line":"                                      \"member-id-2\": \"ONLINE\""},{"line_number":60,"context_line":"                                  }"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_8bca9b6c","line":57,"in_reply_to":"ba7be1f8_dd0abd26","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        session \u003d db_api.get_session()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # if the input amphora is healthy, we update its db infor"},{"line_number":75,"context_line":"        # before update db, we need to check if the db has been created,"},{"line_number":76,"context_line":"        # if not, we need to create first"},{"line_number":77,"context_line":"        if health[\"amphora-status\"] is constants.AMPHORA_UP:"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_fd4f81bc","line":74,"updated":"2015-02-27 03:56:01.000000000","message":"nit: infor","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        session \u003d db_api.get_session()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # if the input amphora is healthy, we update its db infor"},{"line_number":75,"context_line":"        # before update db, we need to check if the db has been created,"},{"line_number":76,"context_line":"        # if not, we need to create first"},{"line_number":77,"context_line":"        if health[\"amphora-status\"] is constants.AMPHORA_UP:"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_2bab6f8a","line":74,"in_reply_to":"ba7be1f8_fd4f81bc","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        # update listener and nodes db information"},{"line_number":90,"context_line":"        listener \u003d health[\"listeners\"]"},{"line_number":91,"context_line":"        for x in range(len(listener)):"},{"line_number":92,"context_line":"            key \u003d listener.keys()[x]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            if listener[key][\"listener-status\"] \u003d\u003d constants.ONLINE:"},{"line_number":95,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_1d9295f6","line":92,"updated":"2015-02-27 03:56:01.000000000","message":"if health[\u0027listeners\u0027] is supposed to be a dict, then all you need to do here is:\n\nfor listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():\n\nthen anytime you need to check an attribute of the listener its just listener.get(\u0027attribute\u0027)\n\nI would use the .get() of a dictionary here just to be safe.","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":105,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            nodes \u003d listener[key][\"member\"]"},{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_1d053514","line":107,"updated":"2015-02-27 03:56:01.000000000","message":"this should be members","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":105,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            nodes \u003d listener[key][\"member\"]"},{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_42679dea","line":107,"in_reply_to":"ba7be1f8_1d053514","updated":"2015-02-27 22:14:56.000000000","message":"will remove it in the new code","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            nodes \u003d listener[key][\"member\"]"},{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_201c906a","line":108,"updated":"2015-02-27 03:56:01.000000000","message":"is there a possibility that it wont be a dictionary?  If you\u0027re worried about it being None, then you can just do:\n\nnodes \u003d listener.get(\u0027member\u0027, {})","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            nodes \u003d listener[key][\"member\"]"},{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_6264a1e5","line":108,"in_reply_to":"ba7be1f8_201c906a","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"},{"line_number":112,"context_line":"                    if v in constants.SUPPORTED_OPERATING_STATUSES:"},{"line_number":113,"context_line":"                        try:"},{"line_number":114,"context_line":"                            self.member_repo.update("}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_802a9c7c","line":111,"updated":"2015-02-27 03:56:01.000000000","message":"use iteritems() like i mentioned above.","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if isinstance(nodes, dict):"},{"line_number":109,"context_line":"                for y in range(len(nodes)):"},{"line_number":110,"context_line":"                    k \u003d nodes.keys()[y]"},{"line_number":111,"context_line":"                    v \u003d nodes[k]"},{"line_number":112,"context_line":"                    if v in constants.SUPPORTED_OPERATING_STATUSES:"},{"line_number":113,"context_line":"                        try:"},{"line_number":114,"context_line":"                            self.member_repo.update("}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_826195d5","line":111,"in_reply_to":"ba7be1f8_802a9c7c","updated":"2015-02-27 22:14:56.000000000","message":"Done","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f1e1c558eabfa46cb6185ac350bfa41120dd5f79","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # update listener and nodes db information"},{"line_number":89,"context_line":"        for listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            key \u003d listener_id"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            if listener.get(\"listener-status\") \u003d\u003d constants.ONLINE:"},{"line_number":94,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba7be1f8_1ffc173e","line":91,"updated":"2015-02-28 03:43:44.000000000","message":"shouldn\u0027t remap to key, just use listener_id below.","commit_id":"7d94255ed88a81d3296d53de471484b20726f07f"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e8e07374fe223cf8ebf8b2aafc7f7c79fc3184d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # update listener and nodes db information"},{"line_number":89,"context_line":"        for listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            key \u003d listener_id"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            if listener.get(\"listener-status\") \u003d\u003d constants.ONLINE:"},{"line_number":94,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba7be1f8_7c63561a","line":91,"in_reply_to":"ba7be1f8_1ffc173e","updated":"2015-02-28 22:22:08.000000000","message":"Done","commit_id":"7d94255ed88a81d3296d53de471484b20726f07f"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"18a3b283ad02ddd88f0a9fc109086116b1ca5345","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright(c) 2014 HP,  Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_d2a406bb","line":1,"updated":"2015-03-02 16:48:33.000000000","message":"If the copyright line has to be there (it seems unnecessary), use 2015.\nUse of author names are discouraged. They are kept in the git history. If there are multiple authors, they can be added to the commit message by using:\nCo-Authored-By: name \u003cname@example.com\u003e","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"a674a8c1f009d4bbcb4d0a20cd9466ddcf900107","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright(c) 2014 HP,  Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_7817b145","line":1,"in_reply_to":"ba7be1f8_d2a406bb","updated":"2015-03-02 19:57:15.000000000","message":"will keep the copyright line based on your suggestion above, thanks!","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"18a3b283ad02ddd88f0a9fc109086116b1ca5345","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        health \u003d {"},{"line_number":52,"context_line":"            \"amphora-status\": \"AMPHORA_UP\","},{"line_number":53,"context_line":"            \"amphora-id\": 1234,"},{"line_number":54,"context_line":"            \"listeners\": {"},{"line_number":55,"context_line":"                \"listener-id-1\": {\"listener-status\": \"ONLINE\","},{"line_number":56,"context_line":"                                  \"members\": {"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_93b45036","line":53,"updated":"2015-03-02 16:48:33.000000000","message":"Just for clarification, isn\u0027t this id a uuid? it is shown as an integer here.","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"a674a8c1f009d4bbcb4d0a20cd9466ddcf900107","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        health \u003d {"},{"line_number":52,"context_line":"            \"amphora-status\": \"AMPHORA_UP\","},{"line_number":53,"context_line":"            \"amphora-id\": 1234,"},{"line_number":54,"context_line":"            \"listeners\": {"},{"line_number":55,"context_line":"                \"listener-id-1\": {\"listener-status\": \"ONLINE\","},{"line_number":56,"context_line":"                                  \"members\": {"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_18cb1554","line":53,"in_reply_to":"ba7be1f8_93b45036","updated":"2015-03-02 19:57:15.000000000","message":"have changed into uuid","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"18a3b283ad02ddd88f0a9fc109086116b1ca5345","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        session, listener_id,"},{"line_number":95,"context_line":"                        operating_status\u003dconstants.ONLINE)"},{"line_number":96,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":97,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            elif listener.get(\"listener-status\") \u003d\u003d constants.ERROR:"},{"line_number":100,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_d86187a9","line":97,"updated":"2015-03-02 16:48:33.000000000","message":"for debuging purposes, wouldn\u0027t it be good to say which listener is not in DB?","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"a674a8c1f009d4bbcb4d0a20cd9466ddcf900107","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        session, listener_id,"},{"line_number":95,"context_line":"                        operating_status\u003dconstants.ONLINE)"},{"line_number":96,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":97,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            elif listener.get(\"listener-status\") \u003d\u003d constants.ERROR:"},{"line_number":100,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_bba763bc","line":97,"in_reply_to":"ba7be1f8_d86187a9","updated":"2015-03-02 19:57:15.000000000","message":"added the listener id in the debug message","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"18a3b283ad02ddd88f0a9fc109086116b1ca5345","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    self.listener_repo.update(session, listener_id,"},{"line_number":102,"context_line":"                                              operating_status\u003dconstants.ERROR)"},{"line_number":103,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":104,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            for member_id, member in listener.get(\u0027members\u0027, {}).iteritems():"},{"line_number":107,"context_line":"                    if member in constants.SUPPORTED_OPERATING_STATUSES:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_58911799","line":104,"updated":"2015-03-02 16:48:33.000000000","message":"same as above.","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"a674a8c1f009d4bbcb4d0a20cd9466ddcf900107","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    self.listener_repo.update(session, listener_id,"},{"line_number":102,"context_line":"                                              operating_status\u003dconstants.ERROR)"},{"line_number":103,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":104,"context_line":"                    LOG.DEBUG(\"Listener is not in DB\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            for member_id, member in listener.get(\u0027members\u0027, {}).iteritems():"},{"line_number":107,"context_line":"                    if member in constants.SUPPORTED_OPERATING_STATUSES:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_1b96af4c","line":104,"in_reply_to":"ba7be1f8_58911799","updated":"2015-03-02 19:57:15.000000000","message":"added listener id in the debug message","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"18a3b283ad02ddd88f0a9fc109086116b1ca5345","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                session, id\u003dmember_id,"},{"line_number":111,"context_line":"                                operating_status\u003dmember)"},{"line_number":112,"context_line":"                        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":113,"context_line":"                            LOG.DEBUG(\"Member is not able to update in DB\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_58bf57fc","line":113,"updated":"2015-03-02 16:48:33.000000000","message":"which member/listener?","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"a674a8c1f009d4bbcb4d0a20cd9466ddcf900107","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                session, id\u003dmember_id,"},{"line_number":111,"context_line":"                                operating_status\u003dmember)"},{"line_number":112,"context_line":"                        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":113,"context_line":"                            LOG.DEBUG(\"Member is not able to update in DB\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_bbd92359","line":113,"in_reply_to":"ba7be1f8_58bf57fc","updated":"2015-03-02 19:57:15.000000000","message":"add the member id in the log debug message to make it more friendly","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73f372bd4ea0d51bfb8f922b1bfffa7048845a6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright(c) 2015 HP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_2f93ff5b","line":1,"updated":"2015-03-03 17:20:00.000000000","message":"Should be:\n# Copyright 2015 Hewlett-Packard Development Company, L.P.","commit_id":"c56218d6d256dd12afff88f676738c32a3f2eff1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # if the input amphora is healthy, we update its db info"},{"line_number":74,"context_line":"        # before update db, we need to check if the db has been created,"},{"line_number":75,"context_line":"        # if not, we need to create first"},{"line_number":76,"context_line":"        if health[\"amphora-status\"] is constants.AMPHORA_UP:"},{"line_number":77,"context_line":"            amphora_id \u003d health[\"amphora-id\"]"},{"line_number":78,"context_line":"            amphora \u003d self.amphora_health_repo.get("},{"line_number":79,"context_line":"                session, amphora_id\u003damphora_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_acf31009","line":76,"updated":"2015-03-04 18:04:33.000000000","message":"For string comparisons, you should use `\u003d\u003d` and not `is`.","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # if the input amphora is healthy, we update its db info"},{"line_number":74,"context_line":"        # before update db, we need to check if the db has been created,"},{"line_number":75,"context_line":"        # if not, we need to create first"},{"line_number":76,"context_line":"        if health[\"amphora-status\"] is constants.AMPHORA_UP:"},{"line_number":77,"context_line":"            amphora_id \u003d health[\"amphora-id\"]"},{"line_number":78,"context_line":"            amphora \u003d self.amphora_health_repo.get("},{"line_number":79,"context_line":"                session, amphora_id\u003damphora_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_8cbbacc3","line":76,"in_reply_to":"9a80dd14_acf31009","updated":"2015-03-04 18:15:15.000000000","message":"will do","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # update listener and nodes db information"},{"line_number":89,"context_line":"        for listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            if listener.get(\"listener-status\") \u003d\u003d constants.ONLINE:"},{"line_number":92,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_ec4a6826","line":89,"updated":"2015-03-04 18:04:33.000000000","message":"I think there is an issue using iteritems() directly like this for compatibility with PY2/PY3. Check out six.iteritems().","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"ab61293a4a012baf0dbdc92603abc4da6b10b209","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # update listener and nodes db information"},{"line_number":89,"context_line":"        for listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            if listener.get(\"listener-status\") \u003d\u003d constants.ONLINE:"},{"line_number":92,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_b731940d","line":89,"in_reply_to":"9a80dd14_6cb678de","updated":"2015-03-04 20:43:52.000000000","message":"Yes, Brandon and I agree -- you will need to use six here. See: http://pythonhosted.org/six/#six.iteritems","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"318098c021e099fd95800b465f1ae86e55478e1f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # update listener and nodes db information"},{"line_number":89,"context_line":"        for listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            if listener.get(\"listener-status\") \u003d\u003d constants.ONLINE:"},{"line_number":92,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_bdba53df","line":89,"in_reply_to":"9a80dd14_b731940d","updated":"2015-03-04 21:13:18.000000000","message":"will do","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                last_update\u003dfunc.now())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # update listener and nodes db information"},{"line_number":89,"context_line":"        for listener_id, listener in health.get(\u0027listeners\u0027, {}).iteritems():"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            if listener.get(\"listener-status\") \u003d\u003d constants.ONLINE:"},{"line_number":92,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_6cb678de","line":89,"in_reply_to":"9a80dd14_ec4a6826","updated":"2015-03-04 18:15:15.000000000","message":"this change is from Brandon\u0027s suggestion, can you talk to him and let me know which one is good for both of you :)","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ef437536a38b4acf517bbcaecd88ee870056def7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        This function has the following 3 goals:"},{"line_number":47,"context_line":"        1)Update the health_manager table based on amphora status is up/down"},{"line_number":48,"context_line":"        2)Update related DB status to be ERROR/DOWN when amphora is down"},{"line_number":49,"context_line":"        3)Update related DB status to be ACTIVATE/UP when amphora is up"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        The input health data structure is shown as below:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_32dcd274","line":49,"updated":"2015-03-11 06:21:03.000000000","message":"so there seems to be another goal of tracking the status of the members as well.  That should be listed as well.  Then again, maybe thats not the goal of this, but the input parameter definitely looks like its gonig to do that.","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"}],"octavia/db/migration/alembic_migrations/versions/92fe9857279_create_healthmanager_table.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.create_table("},{"line_number":32,"context_line":"        u\u0027healthmanager\u0027,"},{"line_number":33,"context_line":"        sa.Column(u\u0027amphora_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":34,"context_line":"        sa.Column(u\u0027last_update\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":35,"context_line":"        sa.PrimaryKeyConstraint(u\u0027amphora_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_e8167254","line":32,"updated":"2015-01-29 23:21:01.000000000","message":"health_manager","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.create_table("},{"line_number":32,"context_line":"        u\u0027healthmanager\u0027,"},{"line_number":33,"context_line":"        sa.Column(u\u0027amphora_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":34,"context_line":"        sa.Column(u\u0027last_update\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":35,"context_line":"        sa.PrimaryKeyConstraint(u\u0027amphora_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_43711c75","line":32,"in_reply_to":"fa81d914_e8167254","updated":"2015-01-30 00:47:45.000000000","message":"will do","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def downgrade():"},{"line_number":42,"context_line":"    op.drop_table(\u0027healthmanager\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_3a129157","line":42,"updated":"2015-01-29 23:21:01.000000000","message":"health_manager","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def downgrade():"},{"line_number":42,"context_line":"    op.drop_table(\u0027healthmanager\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_636aa082","line":42,"in_reply_to":"fa81d914_3a129157","updated":"2015-01-30 00:47:45.000000000","message":"will do","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.create_table("},{"line_number":32,"context_line":"        u\u0027health_manager\u0027,"},{"line_number":33,"context_line":"        sa.Column(u\u0027amphora_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":34,"context_line":"        sa.Column(u\u0027last_update\u0027, sa.DateTime(timezone\u003dTrue),"},{"line_number":35,"context_line":"                  nullable\u003dFalse)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_fdcce163","line":33,"updated":"2015-02-27 03:56:01.000000000","message":"was there a reason why this isn\u0027t linked to a foreign key to the amphora table?","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.create_table("},{"line_number":32,"context_line":"        u\u0027health_manager\u0027,"},{"line_number":33,"context_line":"        sa.Column(u\u0027amphora_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":34,"context_line":"        sa.Column(u\u0027last_update\u0027, sa.DateTime(timezone\u003dTrue),"},{"line_number":35,"context_line":"                  nullable\u003dFalse)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_4295dd86","line":33,"in_reply_to":"ba7be1f8_fdcce163","updated":"2015-02-27 22:14:56.000000000","message":"there was a discussion about it, we used to put a foreign key here, then in the discussion they agreed on make this table independent","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73f372bd4ea0d51bfb8f922b1bfffa7048845a6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2014 HP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_8f894b28","line":1,"updated":"2015-03-03 17:20:00.000000000","message":"# Copyright 2014 Hewlett-Packard Development Company, L.P.","commit_id":"c56218d6d256dd12afff88f676738c32a3f2eff1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ac4f35f82701ca068a3e030285563c854fb8db56","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.create_table("},{"line_number":32,"context_line":"        u\u0027health_manager\u0027,"},{"line_number":33,"context_line":"        sa.Column(u\u0027amphora_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":34,"context_line":"        sa.Column(u\u0027last_update\u0027, sa.DateTime(timezone\u003dTrue),"},{"line_number":35,"context_line":"                  nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_27333b64","line":32,"updated":"2015-03-25 21:01:27.000000000","message":"i\u0027d prefer this table be named amphora_health","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"fb2dcfc00e0a81e327f3196f329d4013608afde3","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.create_table("},{"line_number":32,"context_line":"        u\u0027health_manager\u0027,"},{"line_number":33,"context_line":"        sa.Column(u\u0027amphora_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":34,"context_line":"        sa.Column(u\u0027last_update\u0027, sa.DateTime(timezone\u003dTrue),"},{"line_number":35,"context_line":"                  nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_bd1bb871","line":32,"in_reply_to":"1a6ced46_27333b64","updated":"2015-03-25 21:34:44.000000000","message":"will think about it","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"}],"octavia/db/models.py":[{"author":{"_account_id":10750,"name":"Jorge Miramontes","email":"jorge.miramontes@rackspace.com","username":"jorgem"},"change_message_id":"e9a222591005512eb12f60676a81ddc3c868188b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                      name\u003d\"fk_container_provisioning_status_name\"))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class HealthManager(base_models.BASE):"},{"line_number":330,"context_line":"    __data_model__ \u003d data_models.HealthManager"},{"line_number":331,"context_line":"    __tablename__ \u003d \"healthmanager\""},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_7ac32957","line":329,"updated":"2015-01-29 23:37:51.000000000","message":"I feel like we should rename this as it conflicts with with actual HealthManager class that uses this data model. How about something like AmphoraHealth?\n\nOr...\n\nPerhaps we should just add the \u0027last_update\u0027 column to the Amphora table and keep the table structure flat. We can always unflatten the table structure later if we need to add more attributes. Also, locking shouldn\u0027t be an issue since we would be using the amphora id index when updating the table. Hit me up on IRC if you want to talk about this more.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                      name\u003d\"fk_container_provisioning_status_name\"))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class HealthManager(base_models.BASE):"},{"line_number":330,"context_line":"    __data_model__ \u003d data_models.HealthManager"},{"line_number":331,"context_line":"    __tablename__ \u003d \"healthmanager\""},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_e33f7085","line":329,"in_reply_to":"fa81d914_3d0b6b2b","updated":"2015-01-30 00:47:45.000000000","message":"I prefer to put the last_updated property in the new data table health manager too, while for the rename thing, do we necessarily rename it to be a new one, or this one can work as well?","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"837359dc99ad633017111a5c7c8b0830dd4435d4","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                      name\u003d\"fk_container_provisioning_status_name\"))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class HealthManager(base_models.BASE):"},{"line_number":330,"context_line":"    __data_model__ \u003d data_models.HealthManager"},{"line_number":331,"context_line":"    __tablename__ \u003d \"healthmanager\""},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_3d0b6b2b","line":329,"in_reply_to":"fa81d914_7ac32957","updated":"2015-01-30 00:10:34.000000000","message":"I am ok changing the name to something else, but I really want this to remain a separate table from the Amphora table.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5371deb96b284adcb9ae915e134b4809a9af853d","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                      name\u003d\"fk_container_provisioning_status_name\"))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class HealthManager(base_models.BASE):"},{"line_number":330,"context_line":"    __data_model__ \u003d data_models.HealthManager"},{"line_number":331,"context_line":"    __tablename__ \u003d \"healthmanager\""},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3e04bd14","line":329,"in_reply_to":"fa81d914_e33f7085","updated":"2015-01-30 23:32:23.000000000","message":"AmphoraHealth seems fine to me. I agree we should keep this table separate.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class HealthManager(base_models.BASE):"},{"line_number":330,"context_line":"    __data_model__ \u003d data_models.HealthManager"},{"line_number":331,"context_line":"    __tablename__ \u003d \"healthmanager\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    amphora_id \u003d sa.Column("},{"line_number":334,"context_line":"        sa.String(36),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_68544221","line":331,"updated":"2015-01-29 23:21:01.000000000","message":"health_manager","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class HealthManager(base_models.BASE):"},{"line_number":330,"context_line":"    __data_model__ \u003d data_models.HealthManager"},{"line_number":331,"context_line":"    __tablename__ \u003d \"healthmanager\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    amphora_id \u003d sa.Column("},{"line_number":334,"context_line":"        sa.String(36),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_03456416","line":331,"in_reply_to":"fa81d914_68544221","updated":"2015-01-30 00:47:45.000000000","message":"will do","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10750,"name":"Jorge Miramontes","email":"jorge.miramontes@rackspace.com","username":"jorgem"},"change_message_id":"4e13a7e582db0d3b82ed42345dc7d970e2b2ffb8","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        sa.String(36),"},{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_6c5f7373","line":337,"updated":"2015-01-30 20:27:57.000000000","message":"If we are planning on having this table be in Redis (or other) database then we can\u0027t have the foreign key constraint. Thus, we should remove it.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1c464641b57b47c7e495254f1153a67786ff11de","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        sa.String(36),"},{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d2daba16","line":337,"in_reply_to":"da86d52c_6c5f7373","updated":"2015-01-30 21:21:53.000000000","message":"I think the foreign key adds value in the v0.5 release as this is coded.  It gives relational integrity and cascading deletes.  If/when we decide Redis is necessary I agree, this whole class will need to change.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5371deb96b284adcb9ae915e134b4809a9af853d","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        sa.String(36),"},{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1e2619bb","line":337,"in_reply_to":"da86d52c_d2daba16","updated":"2015-01-30 23:32:23.000000000","message":"We shouldn\u0027t have a FK here since this should be easily usable in a separate DB (like Redis). As Jorge was saying, doing this prevents us from separating it, which was the whole reason it is a distinct table to begin with. I know you have concerns about Cascading Deletes working, but I\u0027d probably recommend breaking the direct tie now, and just making sure to clean up this data manually.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"90786e6aaaba39ac008e95d4a46e9fe57f252ebf","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_ca048680","line":338,"updated":"2015-01-28 20:14:06.000000000","message":"Do we want to have the update happening here? Should this be passed in from the controller/manager that calls the model? Its always going to say it updated regardless of any failures or anything of that nature if thatas even a possibility.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5371deb96b284adcb9ae915e134b4809a9af853d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_fe686589","line":338,"in_reply_to":"fa81d914_20225e52","updated":"2015-01-30 23:32:23.000000000","message":"Now that I see what you\u0027re using this for, I think you want to do it a little differently:\n\nhttp://docs.sqlalchemy.org/en/rel_0_9/core/defaults.html#sql-expressions\n\nUse func.utc_timestamp() instead of Python\u0027s datetime, so it actually forwards the logic through to the DB layer.\n\nI believe func is:\n\nfrom sqlalchemy.sql import func","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_20225e52","line":338,"in_reply_to":"fa81d914_28696a25","updated":"2015-01-30 00:47:45.000000000","message":"will update the alermbic properly","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_28696a25","line":338,"in_reply_to":"fa81d914_7900d001","updated":"2015-01-29 23:21:01.000000000","message":"I don\u0027t think the default being done here is a problem.  There is a problem that this default is in the models but not in the alembic migration.  They need to match.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"1addc4343693eacf7c88da342d700f88515683c4","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        sa.ForeignKey(\"amphora.id\","},{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_7900d001","line":338,"in_reply_to":"fa81d914_ca048680","updated":"2015-01-28 23:25:40.000000000","message":"ideally, we want to use this property to represent the last updated amphora, so we will always update this property whenever we found that the same amphora has been updated. right now, we just design this table very simple.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d2b5dd410214e8eb55c45756f5001a7182730021","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","},{"line_number":342,"context_line":"                                                   uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_48abfe1c","line":339,"updated":"2015-01-29 23:21:01.000000000","message":"i dont see the point in having this onupdate right now. once the row is in the database, there arent any other columns to update, so we wouldn\u0027t be updating this row.  Plus onupdates have proven more problematic than beneficial in my experience, but I\u0027m sure my experiences are unique.  Either way, there\u0027s nothing else to update in this table to trigger the on update.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10750,"name":"Jorge Miramontes","email":"jorge.miramontes@rackspace.com","username":"jorgem"},"change_message_id":"e9a222591005512eb12f60676a81ddc3c868188b","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","},{"line_number":342,"context_line":"                                                   uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_ddf16f02","line":339,"in_reply_to":"fa81d914_48abfe1c","updated":"2015-01-29 23:37:51.000000000","message":"I agree on this as well. Triggers are good in certain situations and can be problematic in others.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"837359dc99ad633017111a5c7c8b0830dd4435d4","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","},{"line_number":342,"context_line":"                                                   uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_e0076616","line":339,"in_reply_to":"fa81d914_ddf16f02","updated":"2015-01-30 00:10:34.000000000","message":"I agree, the onupdate trigger should be removed.","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"afd5cd562a4c4e7ceb191c8dba45cc21bde6d203","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                      name\u003d\"fk_healthmanager_amphora_id\"),"},{"line_number":337,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":338,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":339,"context_line":"                            nullable\u003dFalse, onupdate\u003ddatetime.datetime.utcnow)"},{"line_number":340,"context_line":"    amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"},{"line_number":341,"context_line":"                               backref\u003dorm.backref(\"healthmanager\","},{"line_number":342,"context_line":"                                                   uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_8015cae6","line":339,"in_reply_to":"fa81d914_e0076616","updated":"2015-01-30 00:47:45.000000000","message":"will remove the onupdate part","commit_id":"da8771f496d62bb1eec3efc33a97ab2f44ce32e1"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"4afda5ea3b9f01254aa1bbaad87f064c74703072","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":339,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003dfunc.now(),"},{"line_number":340,"context_line":"                            nullable\u003dFalse)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    # last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":343,"context_line":"    #                         nullable\u003dFalse)"},{"line_number":344,"context_line":"    # amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_a1fe7036","line":341,"updated":"2015-02-23 22:25:44.000000000","message":"nit: Can these comments be cleaned up, or are they placeholders for later?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":339,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003dfunc.now(),"},{"line_number":340,"context_line":"                            nullable\u003dFalse)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    # last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":343,"context_line":"    #                         nullable\u003dFalse)"},{"line_number":344,"context_line":"    # amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_b647914a","line":341,"in_reply_to":"ba7be1f8_a1fe7036","updated":"2015-02-23 22:51:29.000000000","message":"+1","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8009b784ac18ef40d9a6c76de519ecc42f06d669","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":339,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003dfunc.now(),"},{"line_number":340,"context_line":"                            nullable\u003dFalse)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    # last_update \u003d sa.Column(sa.DateTime, default\u003ddatetime.datetime.utcnow,"},{"line_number":343,"context_line":"    #                         nullable\u003dFalse)"},{"line_number":344,"context_line":"    # amphora \u003d orm.relationship(\"Amphora\", uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_1385cfcf","line":341,"in_reply_to":"ba7be1f8_a1fe7036","updated":"2015-02-23 22:32:53.000000000","message":"i will delete them, they are the previous version which are not valid anymore","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"18a3b283ad02ddd88f0a9fc109086116b1ca5345","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    __tablename__ \u003d \"health_manager\""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    amphora_id \u003d sa.Column("},{"line_number":335,"context_line":"        sa.String(36), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":336,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003dfunc.now(),"},{"line_number":337,"context_line":"                            nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_f8abab86","line":335,"updated":"2015-03-02 16:48:33.000000000","message":"Shouldn\u0027t this be a Foreign key? May be I am misunderstanding this but if amphora_id is the id of an Amphora being referenced here, then this will be a foreign key.","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"a674a8c1f009d4bbcb4d0a20cd9466ddcf900107","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    __tablename__ \u003d \"health_manager\""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    amphora_id \u003d sa.Column("},{"line_number":335,"context_line":"        sa.String(36), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":336,"context_line":"    last_update \u003d sa.Column(sa.DateTime, default\u003dfunc.now(),"},{"line_number":337,"context_line":"                            nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_2a07a21e","line":335,"in_reply_to":"ba7be1f8_f8abab86","updated":"2015-03-02 19:57:15.000000000","message":"after reading your comment in the patch, I assume that you dont have this question anymore.","commit_id":"a512666ba73cb629c6c6c998e46180d6b7e97767"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ac4f35f82701ca068a3e030285563c854fb8db56","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"class AmphoraHealth(base_models.BASE):"},{"line_number":331,"context_line":"    __data_model__ \u003d data_models.AmphoraHealth"},{"line_number":332,"context_line":"    __tablename__ \u003d \"health_manager\""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    amphora_id \u003d sa.Column("},{"line_number":335,"context_line":"        sa.String(36), nullable\u003dFalse, primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_e744c3b8","line":332,"updated":"2015-03-25 21:01:27.000000000","message":"id prefer this table be named amphora_health","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"}],"octavia/db/repositories.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"90aa9d9ef840d5fe94836bad02f31cf4236b8c23","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def get_all(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":16,"id":"ba7be1f8_23e3c134","line":346,"updated":"2015-02-27 00:21:21.000000000","message":"this has the same name as the get_all in the BaseRepo but behaves differently. So I would suggest picking a different name to avoid that confusion, e.g. get_all_with_filter or so","commit_id":"acb691380fdf225f2cc27d5a9e22ddd6697fd905"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"1ef854fb2e21ccc66b5f71bcafc8aacc4ee75a93","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def get_all(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":16,"id":"ba7be1f8_e39e0954","line":346,"in_reply_to":"ba7be1f8_23e3c134","updated":"2015-02-27 00:29:29.000000000","message":"i had the same confusion before, and then i thought this new function actually can tolerate more kinds of arguments, the only difference is that the argument here needs to be sql expression instead of keyword expression, but adapt your advice.","commit_id":"acb691380fdf225f2cc27d5a9e22ddd6697fd905"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7d3e54cb915ed70de5676fea994e2dcd694e7415","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def get_all_filter(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_00d94c83","line":346,"updated":"2015-02-27 03:56:01.000000000","message":"so unless there are a ton of different uses we will need for this method, I\u0027d suggest going with a simple method that does the one thing you need (such as compare against last_updated), and get that.  That way this method won\u0027t be confusing between the base get.  It also means not having code calling this import sqlalchemy (sometimes) and/or passing odd parameters.","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5b10b3dd160f1122c293bd546c9a142e079a9654","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def get_all_filter(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_c2e8ed18","line":346,"in_reply_to":"ba7be1f8_00d94c83","updated":"2015-02-27 22:14:56.000000000","message":"so in the base class, we have method get and get_all, here we need to pass sql query for health manager service, and we believe that this get_all_filter method will be called constantly to check the failover for those amphora whose update is out of date. In order to take care all of these scenarios, we created this method under class AmphoraHealthRepository with a different name which will not overwrite the base class.","commit_id":"8aba9a4c9d3027cc88703784c1341ba5542398b0"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f1e1c558eabfa46cb6185ac350bfa41120dd5f79","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def get_all_filter(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":21,"id":"ba7be1f8_3fe0fb95","line":346,"updated":"2015-02-28 03:43:44.000000000","message":"continuing from PS17:\n\ncould you enumerate how this method is planned to be used?\n\nIf all you need to do is get a list of amphorae that have an update out of date, then make a method called get_out_of_date_amphorae().  \n\nif you also want a method to check if a specific amphora is out of date, then make a method called is_amphora_out_of_date(amphora_id).\n\nThat way we dont have to pass in ugly sqlalchemy/sql strings whenever we call it.\n\nJust wondering if there any more uses that will be needed out of this.","commit_id":"7d94255ed88a81d3296d53de471484b20726f07f"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e8e07374fe223cf8ebf8b2aafc7f7c79fc3184d","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def get_all_filter(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":21,"id":"ba7be1f8_3c81de8f","line":346,"in_reply_to":"ba7be1f8_3fe0fb95","updated":"2015-02-28 22:22:08.000000000","message":"will change the name to be check_amphora_out_of_date, btw, the old name is not that ugly,right ?\n:)","commit_id":"7d94255ed88a81d3296d53de471484b20726f07f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7a4b7cc4fa14a0997a8df1d9ae21879c2e732548","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":344,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def check_amphora_out_of_date(self, session, *criterion):"},{"line_number":347,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_2673214f","line":346,"updated":"2015-03-03 19:40:17.000000000","message":"so i still think this method should not take  *criterion parameter.  this should take session, and amphora_id.  Possibly even a date keyword argument that defaults to datetime.utcnow().  that way the method hides the ugly sqlalchemy (also decoupling as well),  the caller of the method just uses normal python.  the method then uses those parameters to do sqlalchemy calls with the filter.\n\nif you need to get a list of out of date amphorae then create another method called get_all_out_of_date_amphorae, and do the same thing except obviously not taking in an amphora_id","commit_id":"c56218d6d256dd12afff88f676738c32a3f2eff1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":346,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def check_amphora_out_of_date(self, session, amphora_id,"},{"line_number":349,"context_line":"                                  date\u003dfunc.now()):"},{"line_number":350,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_71ee518d","line":348,"updated":"2015-03-04 18:04:33.000000000","message":"This takes a specific amphora ID, but (per the docstring, and looking at the return structure) isn\u0027t at all related to a specific amphora.\n\nAlso, if this retrieves a list of entities, could this method be named something more intuitive? Right now the method name would imply to me a check for a specific amphora.","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":346,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def check_amphora_out_of_date(self, session, amphora_id,"},{"line_number":349,"context_line":"                                  date\u003dfunc.now()):"},{"line_number":350,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_ec25080b","line":348,"in_reply_to":"9a80dd14_71ee518d","updated":"2015-03-04 18:15:15.000000000","message":"the reason that i pass in amphora_id from based on Brandon\u0027s suggestion, please discuss with him and let me know which one is good for both of you.","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"5a851af87b02acd2283e2f1e12502809dbc2e373","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":346,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def check_amphora_out_of_date(self, session, amphora_id,"},{"line_number":349,"context_line":"                                  date\u003dfunc.now()):"},{"line_number":350,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_8690e8ed","line":348,"in_reply_to":"9a80dd14_a304fe7e","updated":"2015-03-04 19:32:07.000000000","message":"i will do more research about it, thanks for the tips :)","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4587a44b9892f8662377252e47996af06c65056d","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":346,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def check_amphora_out_of_date(self, session, amphora_id,"},{"line_number":349,"context_line":"                                  date\u003dfunc.now()):"},{"line_number":350,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_a304fe7e","line":348,"in_reply_to":"9a80dd14_ec25080b","updated":"2015-03-04 18:58:58.000000000","message":"I looked at Brandon\u0027s comments, and it looks like you may have misunderstood what he was saying -- if this method was still checking the status of a single amphora, passing an amphora_id would make sense. You\u0027ve combined the two methods he was suggesting into one method, so it\u0027s a bit strange. You probably want two methods:\n\n* one that checks the status of a single amphora (using this method\u0027s name) and does take an amphora_id and datetime object, returning a Boolean\n\n* another method that will return a list of all out of date amphorae, that takes just a session and a datetime object","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def check_amphora_out_of_date(self, session, amphora_id,"},{"line_number":349,"context_line":"                                  date\u003dfunc.now()):"},{"line_number":350,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_76180785","line":349,"updated":"2015-03-04 18:04:33.000000000","message":"I would prefer to just pass a Python datetime object -- if people want \"NOW\", they can do datetime.datetime.utcnow() and get essentially the same result, without having to deal with SQLAlchemy specific functions. I am pretty sure SQLAlchemy can handle datetime objects automatically.\n\nAlso, defaulting to NOW means that *all* amphorae would return as out-of-date, wouldn\u0027t it? Not a huge deal, since \"out-of-date\" is fairly subjective, but I thought there might be a better default.","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                amphora_id\u003damphora_id).update(model_kwargs)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def check_amphora_out_of_date(self, session, amphora_id,"},{"line_number":349,"context_line":"                                  date\u003dfunc.now()):"},{"line_number":350,"context_line":"        \"\"\"Retrieves a list of entities from the health manager database."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        :param session: A Sql Alchemy database session."}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_8c7e4ce3","line":349,"in_reply_to":"9a80dd14_76180785","updated":"2015-03-04 18:15:15.000000000","message":"will do after the final design of this function has been done","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":353,"context_line":"        :param amphora_id: id of an amphora object"},{"line_number":354,"context_line":"        :param date: standard date which used to see if an amphora needs to be"},{"line_number":355,"context_line":"        updated"},{"line_number":356,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":357,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_11c7d546","line":354,"updated":"2015-03-04 18:04:33.000000000","message":"If this is supposed to be a \"standard date\", I would definitely expect a datetime object (per above comment).","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":353,"context_line":"        :param amphora_id: id of an amphora object"},{"line_number":354,"context_line":"        :param date: standard date which used to see if an amphora needs to be"},{"line_number":355,"context_line":"        updated"},{"line_number":356,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":357,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_cc8844ea","line":354,"in_reply_to":"9a80dd14_11c7d546","updated":"2015-03-04 18:15:15.000000000","message":"same as above","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        updated"},{"line_number":356,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        amphora_health \u003d self.get(session, amphora_id\u003damphora_id)"},{"line_number":359,"context_line":"        filterquery \u003d amphora_health.last_update \u003c date"},{"line_number":360,"context_line":"        model_list \u003d session.query(self.model_class).filter(filterquery).all()"},{"line_number":361,"context_line":"        data_model_list \u003d [model.to_data_model() for model in model_list]"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_11235506","line":358,"updated":"2015-03-04 18:04:33.000000000","message":"Why is this being fetched for a specific amphora, when the function is not related to a specific amphora?","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13c4982d163cb81414b8eff028c367450a0d66ea","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        amphora_health \u003d self.get(session, amphora_id\u003damphora_id)"},{"line_number":359,"context_line":"        filterquery \u003d amphora_health.last_update \u003c date"},{"line_number":360,"context_line":"        model_list \u003d session.query(self.model_class).filter(filterquery).all()"},{"line_number":361,"context_line":"        data_model_list \u003d [model.to_data_model() for model in model_list]"},{"line_number":362,"context_line":"        return data_model_list"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_b18369cb","line":359,"updated":"2015-03-04 18:04:33.000000000","message":"This is not how filters work -- you want self.model_class.last_update \u003c date\n\namphora_health.last_update is an ACTUAL DATE, so the return from this comparison will just be a boolean...","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"6822aae2722355193482dd8f557b289eb08fc96f","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        amphora_health \u003d self.get(session, amphora_id\u003damphora_id)"},{"line_number":359,"context_line":"        filterquery \u003d amphora_health.last_update \u003c date"},{"line_number":360,"context_line":"        model_list \u003d session.query(self.model_class).filter(filterquery).all()"},{"line_number":361,"context_line":"        data_model_list \u003d [model.to_data_model() for model in model_list]"},{"line_number":362,"context_line":"        return data_model_list"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_4c7454fd","line":359,"in_reply_to":"9a80dd14_b18369cb","updated":"2015-03-04 18:15:15.000000000","message":"same as above","commit_id":"9d56aa528257cecc9fd0e2e3b1cbb13c798e439c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3f2b1b0de812b64b99c9d85874bba45b250cfdb7","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":341,"context_line":"        :param amphora_id: id of an amphora object"},{"line_number":342,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":343,"context_line":"        amphora needs to be updated"},{"line_number":344,"context_line":"        :returns: boolean"},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_f1ef5c85","line":343,"updated":"2015-03-05 19:55:38.000000000","message":"Might want to mention that you\u0027re defaulting to \"ten seconds before now\". Not sure exactly how to word that though...","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"c47923f9011611c9828c317b13d2e72ef1b5bec1","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":341,"context_line":"        :param amphora_id: id of an amphora object"},{"line_number":342,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":343,"context_line":"        amphora needs to be updated"},{"line_number":344,"context_line":"        :returns: boolean"},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_9778cbf3","line":343,"in_reply_to":"9a80dd14_f1ef5c85","updated":"2015-03-05 22:33:39.000000000","message":"Done","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3f2b1b0de812b64b99c9d85874bba45b250cfdb7","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":356,"context_line":"        :param timestamp: A standard datetime which is used to see if"},{"line_number":357,"context_line":"        amphora need to be updated"},{"line_number":358,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":359,"context_line":"        \"\"\""},{"line_number":360,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_31ead475","line":357,"updated":"2015-03-05 19:55:38.000000000","message":"Same as above, might want to mention the default.","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"c47923f9011611c9828c317b13d2e72ef1b5bec1","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":356,"context_line":"        :param timestamp: A standard datetime which is used to see if"},{"line_number":357,"context_line":"        amphora need to be updated"},{"line_number":358,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":359,"context_line":"        \"\"\""},{"line_number":360,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_b7730f14","line":357,"in_reply_to":"9a80dd14_31ead475","updated":"2015-03-05 22:33:39.000000000","message":"Done","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3f2b1b0de812b64b99c9d85874bba45b250cfdb7","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if not timestamp:"},{"line_number":361,"context_line":"            timestamp \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":362,"context_line":"                seconds\u003d10)"},{"line_number":363,"context_line":"        filterquery \u003d self.model_class.last_update \u003c timestamp"},{"line_number":364,"context_line":"        model_list \u003d session.query(self.model_class).filter(filterquery).all()"},{"line_number":365,"context_line":"        data_model_list \u003d [model.to_data_model() for model in model_list]"},{"line_number":366,"context_line":"        return data_model_list"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_b14a44c3","line":363,"updated":"2015-03-05 19:55:38.000000000","message":"I am not sure *exactly* how the SQLAlchemy filter magic actually works -- if you do the filter condition as a separate operation outside of the filter() function definition, does it still work as expected? Brandon was speculating that it was handled somehow via metaclass magic, which I would assumed wouldn\u0027t work properly if the comparison wasn\u0027t done directly in the call.\n\nMin: Nothing needs change here at the moment, I am just curious about SQLAlchemy internals. Have you verified this works?","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"33353f77f99ee9c6d732e7ea9ad6e45010ab6796","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":343,"context_line":"        amphora needs to be updated, the default value is to use current time"},{"line_number":344,"context_line":"        minus 10 seconds, this is just simple case, in future along with the"},{"line_number":345,"context_line":"        development of the project, we will make the timestamp much solid"},{"line_number":346,"context_line":"        :returns: boolean"},{"line_number":347,"context_line":"        \"\"\""},{"line_number":348,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_e9e37ad6","line":345,"updated":"2015-03-09 21:52:14.000000000","message":"This wording is a little bit odd. Maybe something using the actual formula in shorthand, like:\n\nA standard datetime which is used to see if an amphora needs to be updated (default: utcnow() - timedelta(seconds\u003d10))\n\nor:\n\nA standard datetime which is used to see if an amphora needs to be updated (default: now - 10s)","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d12dc93781d28f27fc37534a462378cc7a6ebb21","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":343,"context_line":"        amphora needs to be updated, the default value is to use current time"},{"line_number":344,"context_line":"        minus 10 seconds, this is just simple case, in future along with the"},{"line_number":345,"context_line":"        development of the project, we will make the timestamp much solid"},{"line_number":346,"context_line":"        :returns: boolean"},{"line_number":347,"context_line":"        \"\"\""},{"line_number":348,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_894d9ec6","line":345,"in_reply_to":"9a80dd14_e9e37ad6","updated":"2015-03-09 21:54:23.000000000","message":"will do ,thanks for the input","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"33353f77f99ee9c6d732e7ea9ad6e45010ab6796","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":359,"context_line":"        amphora needs to be updated, the default value is to use current time"},{"line_number":360,"context_line":"        minus 10 seconds, this is just simple case, in future along with the"},{"line_number":361,"context_line":"        development of the project, we will make the timestamp much solid"},{"line_number":362,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_89dafe14","line":361,"updated":"2015-03-09 21:52:14.000000000","message":"As above.","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d12dc93781d28f27fc37534a462378cc7a6ebb21","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":359,"context_line":"        amphora needs to be updated, the default value is to use current time"},{"line_number":360,"context_line":"        minus 10 seconds, this is just simple case, in future along with the"},{"line_number":361,"context_line":"        development of the project, we will make the timestamp much solid"},{"line_number":362,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_a948a2b3","line":361,"in_reply_to":"9a80dd14_89dafe14","updated":"2015-03-09 21:54:23.000000000","message":"will do, thanks for the input","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ef437536a38b4acf517bbcaecd88ee870056def7","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        filterquery \u003d self.model_class.last_update \u003c timestamp"},{"line_number":368,"context_line":"        model_list \u003d session.query(self.model_class).filter(filterquery).all()"},{"line_number":369,"context_line":"        data_model_list \u003d [model.to_data_model() for model in model_list]"},{"line_number":370,"context_line":"        return data_model_list"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_3295b288","line":370,"updated":"2015-03-11 06:21:03.000000000","message":"ah yes finally got back to reviewing this.  This is exactly what i was talking about when i last commented on the review.  Thanks Min and Adam","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9938b5816b38f6dcaaab0e2a7c9f9279d0b92b37","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":341,"context_line":"        :param amphora_id: id of an amphora object"},{"line_number":342,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":343,"context_line":"        amphora needs to be updated (default: now - 10s)"},{"line_number":344,"context_line":"        :returns: boolean"},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_e7ecc3f5","line":343,"updated":"2015-03-25 20:55:58.000000000","message":"NIT: use utcnow as Adam suggested...","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"fb2dcfc00e0a81e327f3196f329d4013608afde3","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":341,"context_line":"        :param amphora_id: id of an amphora object"},{"line_number":342,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":343,"context_line":"        amphora needs to be updated (default: now - 10s)"},{"line_number":344,"context_line":"        :returns: boolean"},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_5d0d6436","line":343,"in_reply_to":"1a6ced46_e7ecc3f5","updated":"2015-03-25 21:34:44.000000000","message":"look at the if condition below, it handles the default case, make it to be now -10s","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9938b5816b38f6dcaaab0e2a7c9f9279d0b92b37","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":356,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":357,"context_line":"        amphora needs to be updated (default: now - 10s)"},{"line_number":358,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":359,"context_line":"        \"\"\""},{"line_number":360,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_87d06f20","line":357,"updated":"2015-03-25 20:55:58.000000000","message":"same","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"fb2dcfc00e0a81e327f3196f329d4013608afde3","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param session: A Sql Alchemy database session."},{"line_number":356,"context_line":"        :param timestamp: A standard datetime which is used to see if an"},{"line_number":357,"context_line":"        amphora needs to be updated (default: now - 10s)"},{"line_number":358,"context_line":"        :returns: [octavia.common.data_model]"},{"line_number":359,"context_line":"        \"\"\""},{"line_number":360,"context_line":"        if not timestamp:"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6ced46_9d127c55","line":357,"in_reply_to":"1a6ced46_87d06f20","updated":"2015-03-25 21:34:44.000000000","message":"same as above","commit_id":"9bb84318001af7c31c42aec7b4ef172d74c113e9"}],"octavia/tests/functional/db/test_models.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"4afda5ea3b9f01254aa1bbaad87f064c74703072","unresolved":false,"context_lines":[{"line_number":575,"context_line":"            amphora_id\u003damphora_health.amphora_id).first()"},{"line_number":576,"context_line":"        self.assertIsNone(new_amphora_health)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    # def test_healthmanager_relationship(self):"},{"line_number":579,"context_line":"    #     healthmanager \u003d self.create_healthmanager(self.session)"},{"line_number":580,"context_line":"    #   new_healthmanager \u003d self.session.query(models.HealthManager).filter_by("},{"line_number":581,"context_line":"    #         amphora_id\u003dhealthmanager.amphora_id).first()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_a108302e","line":578,"updated":"2015-02-23 22:25:44.000000000","message":"nit: Are the methods commented here removable or do they need uncommented/work?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8009b784ac18ef40d9a6c76de519ecc42f06d669","unresolved":false,"context_lines":[{"line_number":575,"context_line":"            amphora_id\u003damphora_health.amphora_id).first()"},{"line_number":576,"context_line":"        self.assertIsNone(new_amphora_health)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    # def test_healthmanager_relationship(self):"},{"line_number":579,"context_line":"    #     healthmanager \u003d self.create_healthmanager(self.session)"},{"line_number":580,"context_line":"    #   new_healthmanager \u003d self.session.query(models.HealthManager).filter_by("},{"line_number":581,"context_line":"    #         amphora_id\u003dhealthmanager.amphora_id).first()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_135cef7d","line":578,"in_reply_to":"ba7be1f8_a108302e","updated":"2015-02-23 22:32:53.000000000","message":"will delete them, they are just for testing","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        self.check_amphora_data_model(amphora)"},{"line_number":687,"context_line":"        if check_load_balancer:"},{"line_number":688,"context_line":"            self.check_load_balancer(amphora.load_balancer)"},{"line_number":689,"context_line":"    # def check_amphora(self, amphora, check_load_balancer\u003dTrue,"},{"line_number":690,"context_line":"    #                   check_healthmanager\u003dTrue):"},{"line_number":691,"context_line":"    #     self.assertIsInstance(amphora, data_models.Amphora)"},{"line_number":692,"context_line":"    #     self.check_amphora_data_model(amphora)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_76ab59d6","line":689,"updated":"2015-02-23 22:51:29.000000000","message":"Can these be cleaned up too?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"eb673cc01e6cde342b959d872a45506398634cb8","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        self.check_amphora_data_model(amphora)"},{"line_number":687,"context_line":"        if check_load_balancer:"},{"line_number":688,"context_line":"            self.check_load_balancer(amphora.load_balancer)"},{"line_number":689,"context_line":"    # def check_amphora(self, amphora, check_load_balancer\u003dTrue,"},{"line_number":690,"context_line":"    #                   check_healthmanager\u003dTrue):"},{"line_number":691,"context_line":"    #     self.assertIsInstance(amphora, data_models.Amphora)"},{"line_number":692,"context_line":"    #     self.check_amphora_data_model(amphora)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_896352db","line":689,"in_reply_to":"ba7be1f8_76ab59d6","updated":"2015-02-23 23:06:44.000000000","message":"yes, will do","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        self.assertEqual(self.FAKE_UUID_1, amphora.amphora_id)"},{"line_number":825,"context_line":"        self.assertEqual(self.FAKE_UUID_1, amphora.load_balancer_id)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    # def check_healthmanager_data_model(self, healthmanager):"},{"line_number":828,"context_line":"    #     self.assertEqual(self.FAKE_UUID_1, lhealthmanager.amphora_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_167e9d6b","line":827,"updated":"2015-02-23 22:51:29.000000000","message":"Same, cleanup?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"eb673cc01e6cde342b959d872a45506398634cb8","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        self.assertEqual(self.FAKE_UUID_1, amphora.amphora_id)"},{"line_number":825,"context_line":"        self.assertEqual(self.FAKE_UUID_1, amphora.load_balancer_id)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    # def check_healthmanager_data_model(self, healthmanager):"},{"line_number":828,"context_line":"    #     self.assertEqual(self.FAKE_UUID_1, lhealthmanager.amphora_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_a95e5610","line":827,"in_reply_to":"ba7be1f8_167e9d6b","updated":"2015-02-23 23:06:44.000000000","message":"sure, will do","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"}],"octavia/tests/functional/db/test_repositories.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3f2b1b0de812b64b99c9d85874bba45b250cfdb7","unresolved":false,"context_lines":[{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    def test_check_amphora_out_of_date(self):"},{"line_number":1139,"context_line":"        self.create_amphora_health(self.amphora.id)"},{"line_number":1140,"context_line":"        time.sleep(20)"},{"line_number":1141,"context_line":"        new_amphora_health \u003d self.amphora_health_repo.check_amphora_expired("},{"line_number":1142,"context_line":"            self.session, self.amphora.id)"},{"line_number":1143,"context_line":"        self.assertTrue(new_amphora_health)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_114f9093","line":1140,"updated":"2015-03-05 19:55:38.000000000","message":"I would avoid actually inserting sleep() into tests -- this makes the tests run arbitrarily long, and imagine if multiple tests did this!\nInstead, I think you can set the last_updated time on the object to sometime in the past manually?","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"c47923f9011611c9828c317b13d2e72ef1b5bec1","unresolved":false,"context_lines":[{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    def test_check_amphora_out_of_date(self):"},{"line_number":1139,"context_line":"        self.create_amphora_health(self.amphora.id)"},{"line_number":1140,"context_line":"        time.sleep(20)"},{"line_number":1141,"context_line":"        new_amphora_health \u003d self.amphora_health_repo.check_amphora_expired("},{"line_number":1142,"context_line":"            self.session, self.amphora.id)"},{"line_number":1143,"context_line":"        self.assertTrue(new_amphora_health)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_6acd2e5d","line":1140,"in_reply_to":"9a80dd14_114f9093","updated":"2015-03-05 22:33:39.000000000","message":"Done","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3f2b1b0de812b64b99c9d85874bba45b250cfdb7","unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    def test_get_expired_amphorae(self):"},{"line_number":1146,"context_line":"        self.create_amphora_health(self.amphora.id)"},{"line_number":1147,"context_line":"        time.sleep(20)"},{"line_number":1148,"context_line":"        amphora_list \u003d self.amphora_health_repo.get_expired_amphorae("},{"line_number":1149,"context_line":"            self.session)"},{"line_number":1150,"context_line":"        return len(amphora_list)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_b159645c","line":1147,"updated":"2015-03-05 19:55:38.000000000","message":"Same as above.","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"c47923f9011611c9828c317b13d2e72ef1b5bec1","unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    def test_get_expired_amphorae(self):"},{"line_number":1146,"context_line":"        self.create_amphora_health(self.amphora.id)"},{"line_number":1147,"context_line":"        time.sleep(20)"},{"line_number":1148,"context_line":"        amphora_list \u003d self.amphora_health_repo.get_expired_amphorae("},{"line_number":1149,"context_line":"            self.session)"},{"line_number":1150,"context_line":"        return len(amphora_list)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_aad726ec","line":1147,"in_reply_to":"9a80dd14_b159645c","updated":"2015-03-05 22:33:39.000000000","message":"Done","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3f2b1b0de812b64b99c9d85874bba45b250cfdb7","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        time.sleep(20)"},{"line_number":1148,"context_line":"        amphora_list \u003d self.amphora_health_repo.get_expired_amphorae("},{"line_number":1149,"context_line":"            self.session)"},{"line_number":1150,"context_line":"        return len(amphora_list)"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def test_create(self):"},{"line_number":1153,"context_line":"        amphora_health \u003d self.create_amphora_health(self.FAKE_UUID_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_74defa6e","line":1150,"updated":"2015-03-05 19:55:38.000000000","message":"I think you mean to do some asserts here, instead of returning this? Like, self.assertEquals(len(amphora_list), 1) in this case?","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"c47923f9011611c9828c317b13d2e72ef1b5bec1","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        time.sleep(20)"},{"line_number":1148,"context_line":"        amphora_list \u003d self.amphora_health_repo.get_expired_amphorae("},{"line_number":1149,"context_line":"            self.session)"},{"line_number":1150,"context_line":"        return len(amphora_list)"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def test_create(self):"},{"line_number":1153,"context_line":"        amphora_health \u003d self.create_amphora_health(self.FAKE_UUID_1)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_0a003266","line":1150,"in_reply_to":"9a80dd14_74defa6e","updated":"2015-03-05 22:33:39.000000000","message":"Done","commit_id":"a490b84185f97680e2eef23b7e4851b6d9eb2b21"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"33353f77f99ee9c6d732e7ea9ad6e45010ab6796","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    def create_amphora_health(self, amphora_id):"},{"line_number":1122,"context_line":"        today \u003d datetime.datetime.today()"},{"line_number":1123,"context_line":"        newdate \u003d today.replace(year\u003dtoday.year - 1)"},{"line_number":1124,"context_line":"        amphora_health \u003d self.amphora_health_repo.create("},{"line_number":1125,"context_line":"            self.session, amphora_id\u003damphora_id,"},{"line_number":1126,"context_line":"            last_update\u003dnewdate)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_c9d6b627","line":1123,"updated":"2015-03-09 21:52:14.000000000","message":"You might just want to subtract a timedelta object","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d12dc93781d28f27fc37534a462378cc7a6ebb21","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    def create_amphora_health(self, amphora_id):"},{"line_number":1122,"context_line":"        today \u003d datetime.datetime.today()"},{"line_number":1123,"context_line":"        newdate \u003d today.replace(year\u003dtoday.year - 1)"},{"line_number":1124,"context_line":"        amphora_health \u003d self.amphora_health_repo.create("},{"line_number":1125,"context_line":"            self.session, amphora_id\u003damphora_id,"},{"line_number":1126,"context_line":"            last_update\u003dnewdate)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_e9661a50","line":1123,"in_reply_to":"9a80dd14_c9d6b627","updated":"2015-03-09 21:54:23.000000000","message":"will do","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"33353f77f99ee9c6d732e7ea9ad6e45010ab6796","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"        amphora_health \u003d self.create_amphora_health(self.FAKE_UUID_1)"},{"line_number":1151,"context_line":"        self.assertEqual(self.FAKE_UUID_1, amphora_health.amphora_id)"},{"line_number":1152,"context_line":"        newdate \u003d datetime.datetime.today().strftime(\"%d/%m/%Y\")"},{"line_number":1153,"context_line":"        olddate \u003d amphora_health.last_update.replace(year\u003d2015).strftime("},{"line_number":1154,"context_line":"            \"%d/%m/%Y\")"},{"line_number":1155,"context_line":"        self.assertEqual(newdate, olddate)"},{"line_number":1156,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_69e5ca07","line":1153,"updated":"2015-03-09 21:52:14.000000000","message":"These tests will fail once we\u0027re in 2016 -- you probably just want to compare using a timedelta.","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"d12dc93781d28f27fc37534a462378cc7a6ebb21","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"        amphora_health \u003d self.create_amphora_health(self.FAKE_UUID_1)"},{"line_number":1151,"context_line":"        self.assertEqual(self.FAKE_UUID_1, amphora_health.amphora_id)"},{"line_number":1152,"context_line":"        newdate \u003d datetime.datetime.today().strftime(\"%d/%m/%Y\")"},{"line_number":1153,"context_line":"        olddate \u003d amphora_health.last_update.replace(year\u003d2015).strftime("},{"line_number":1154,"context_line":"            \"%d/%m/%Y\")"},{"line_number":1155,"context_line":"        self.assertEqual(newdate, olddate)"},{"line_number":1156,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_095a8e82","line":1153,"in_reply_to":"9a80dd14_69e5ca07","updated":"2015-03-09 21:54:23.000000000","message":"will do","commit_id":"0960e82604f3f861cb14d908a92c4ff3b80a1288"}],"octavia/tests/unit/controller/test_health_mixin.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @mock.patch(\u0027sqlalchemy.sql.func.now\u0027)"},{"line_number":42,"context_line":"    def test_update_health(self, lastupdate, session):"},{"line_number":43,"context_line":"        health \u003d {"},{"line_number":44,"context_line":"            \"amphora-status\": constants.AMPHORA_UP,"},{"line_number":45,"context_line":"            \"amphora-id\": 1234,"},{"line_number":46,"context_line":"            \"listeners\": {"},{"line_number":47,"context_line":"                \"listener-id-1\": {\"listener-status\": constants.ONLINE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_854d3f9c","line":44,"updated":"2015-02-13 21:49:56.000000000","message":"please add additional tests for AMPHORA_DOWN","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.hm.update_health(health)"},{"line_number":67,"context_line":"        # first test amphora_health_repo with only one instance"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            self.amphora_health_repo.update.assert_called_once_with("},{"line_number":70,"context_line":"                \u0027blah\u0027, 12345, last_update\u003d\u00272014-02-12\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_45a50746","line":68,"updated":"2015-02-13 21:49:56.000000000","message":"don\u0027t put into try... catch this is the test and if it fails the test fails","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        listener \u003d health[\"listeners\"]"},{"line_number":79,"context_line":"        for x in range(len(listener)):"},{"line_number":80,"context_line":"            key \u003d listener.keys()[x]"},{"line_number":81,"context_line":"            try:"},{"line_number":82,"context_line":"                self.listener_repo.update.assert_any_call("},{"line_number":83,"context_line":"                    \u0027blah\u0027, key, operating_status\u003dconstants.ONLINE)"},{"line_number":84,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_e5743bd2","line":81,"updated":"2015-02-13 21:49:56.000000000","message":"no try...catch","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"96594c57017cb740645f8e1bf538f6c485c6a43f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        nodes \u003d listener[key][\"nodes\"]"},{"line_number":89,"context_line":"        for y in range(len(nodes)):"},{"line_number":90,"context_line":"            k \u003d nodes.keys()[y]"},{"line_number":91,"context_line":"            try:"},{"line_number":92,"context_line":"                self.member_repo.update.assert_any_call("},{"line_number":93,"context_line":"                    \u0027blah\u0027, id\u003dk, operating_status\u003dconstants.ONLINE)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_05722fe3","line":91,"updated":"2015-02-13 21:49:56.000000000","message":"no try..catch","commit_id":"85ca0be9dd305d3f77e41f1df4fc858aadb2c4e3"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4bdcdbd1c5b3a33548d50c0795a2e0e7ba61c10d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"             self.amphora_health_repo.update.assert_called_once_with(\u0027blah\u0027,"},{"line_number":68,"context_line":"                                                 1234,last_update\u003d\u00272014-02-12\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        except Exception as e:"},{"line_number":71,"context_line":"            print (\u0027Failed to update amphora :\u0027+ e.message)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # test listener, member"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_1987f7d8","line":70,"updated":"2015-02-14 00:30:48.000000000","message":"please remove exceptions ...","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"994d661037892e5d9f9872f67d6f340af172f9c8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"             self.amphora_health_repo.update.assert_called_once_with(\u0027blah\u0027,"},{"line_number":68,"context_line":"                                                 1234,last_update\u003d\u00272014-02-12\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        except Exception as e:"},{"line_number":71,"context_line":"            print (\u0027Failed to update amphora :\u0027+ e.message)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # test listener, member"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_9fe9ab1c","line":70,"in_reply_to":"da86d52c_1987f7d8","updated":"2015-02-17 19:29:50.000000000","message":"will do","commit_id":"836af382d0de2484fb30fffe09e59486d77f9e89"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"4afda5ea3b9f01254aa1bbaad87f064c74703072","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @mock.patch(\u0027octavia.db.api.get_session\u0027)"},{"line_number":40,"context_line":"    @mock.patch(\u0027sqlalchemy.sql.func.now\u0027)"},{"line_number":41,"context_line":"    def test_update_health_Online(self, lastupdate, session):"},{"line_number":42,"context_line":"        # health \u003d {"},{"line_number":43,"context_line":"        # \"amphora-status\": constants.AMPHORA_UP,"},{"line_number":44,"context_line":"        #     \"amphora-id\": 1234,"},{"line_number":45,"context_line":"        #     \"listeners\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_33aad3d4","line":42,"updated":"2015-02-23 22:25:44.000000000","message":"nit: Should this comment block be removed?","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8009b784ac18ef40d9a6c76de519ecc42f06d669","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @mock.patch(\u0027octavia.db.api.get_session\u0027)"},{"line_number":40,"context_line":"    @mock.patch(\u0027sqlalchemy.sql.func.now\u0027)"},{"line_number":41,"context_line":"    def test_update_health_Online(self, lastupdate, session):"},{"line_number":42,"context_line":"        # health \u003d {"},{"line_number":43,"context_line":"        # \"amphora-status\": constants.AMPHORA_UP,"},{"line_number":44,"context_line":"        #     \"amphora-id\": 1234,"},{"line_number":45,"context_line":"        #     \"listeners\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_d3641724","line":42,"in_reply_to":"ba7be1f8_33aad3d4","updated":"2015-02-23 22:32:53.000000000","message":"since in our test method, we just assume that there is one listener , one pool member for each health object, but in reality every health object has multiple listeners and members,will need to use this in future test.","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"eb673cc01e6cde342b959d872a45506398634cb8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @mock.patch(\u0027octavia.db.api.get_session\u0027)"},{"line_number":40,"context_line":"    @mock.patch(\u0027sqlalchemy.sql.func.now\u0027)"},{"line_number":41,"context_line":"    def test_update_health_Online(self, lastupdate, session):"},{"line_number":42,"context_line":"        # health \u003d {"},{"line_number":43,"context_line":"        # \"amphora-status\": constants.AMPHORA_UP,"},{"line_number":44,"context_line":"        #     \"amphora-id\": 1234,"},{"line_number":45,"context_line":"        #     \"listeners\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_89ba7221","line":42,"in_reply_to":"ba7be1f8_766ef997","updated":"2015-02-23 23:06:44.000000000","message":"ok, will remove it","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c9d2d260e8e02eec6f4ebad3b891040508117a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @mock.patch(\u0027octavia.db.api.get_session\u0027)"},{"line_number":40,"context_line":"    @mock.patch(\u0027sqlalchemy.sql.func.now\u0027)"},{"line_number":41,"context_line":"    def test_update_health_Online(self, lastupdate, session):"},{"line_number":42,"context_line":"        # health \u003d {"},{"line_number":43,"context_line":"        # \"amphora-status\": constants.AMPHORA_UP,"},{"line_number":44,"context_line":"        #     \"amphora-id\": 1234,"},{"line_number":45,"context_line":"        #     \"listeners\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_766ef997","line":42,"in_reply_to":"ba7be1f8_d3641724","updated":"2015-02-23 22:51:29.000000000","message":"We can probably recreate this when we get to the multiple listener scenario, I would remove","commit_id":"efa351f322ba7bef11aa1558418316c1941c8bd3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73f372bd4ea0d51bfb8f922b1bfffa7048845a6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright(c) 2015 HP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_ef9ba763","line":1,"updated":"2015-03-03 17:20:00.000000000","message":"# Copyright 2015 Hewlett-Packard Development Company, L.P.","commit_id":"c56218d6d256dd12afff88f676738c32a3f2eff1"}]}
