)]}'
{"octavia/amphorae/drivers/haproxy/jinja/jinja_cfg.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"93b58797430165cd38b7e29e15d22163ebbbd6a6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE_PENDING_STATUSES \u003d constants.SUPPORTED_PROVISIONING_STATUSES + ("},{"line_number":38,"context_line":"    constants.DEGRADED,)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":41,"context_line":"BASE_CERT_PATH \u003d BASE_PATH + \u0027/listeners\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"TEMPLATES_DIR \u003d os.path.abspath("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_7845f141","line":40,"updated":"2015-03-02 23:45:52.000000000","message":"please make configurable","commit_id":"01968dc63a1c1c17415fadd302559561bcb786f2"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c7257b598e2373c83daa6226c8dd43cf217e3819","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE_PENDING_STATUSES \u003d constants.SUPPORTED_PROVISIONING_STATUSES + ("},{"line_number":38,"context_line":"    constants.DEGRADED,)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":41,"context_line":"BASE_CERT_PATH \u003d BASE_PATH + \u0027/listeners\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"TEMPLATES_DIR \u003d os.path.abspath("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_2df16b01","line":40,"in_reply_to":"ba7be1f8_7845f141","updated":"2015-03-03 03:44:46.000000000","message":"Going to put this in WIP. I actually wanted to make other things configurable also, so thanks for pointing this out actually :)\n\nI need to redo this a bit and update tests before its \u0027ready ready\u0027, but itll generate a config for testing for the time being. \n\nI dont think this class should access the config object and rather the driver init with the needed values. Is this an OK solution?","commit_id":"01968dc63a1c1c17415fadd302559561bcb786f2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    constants.LB_ALGORITHM_SOURCE_IP: \u0027source\u0027"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"ACTIVE_PENDING_STATUSES \u003d constants.SUPPORTED_PROVISIONING_STATUSES + ("},{"line_number":36,"context_line":"    constants.DEGRADED,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_b10caded","line":35,"updated":"2015-03-13 18:45:37.000000000","message":"Should this be constants.SUPPORTED_OPERATING_STATUSES ?\nOr should the check below be adjusted to check against the provisioning status?","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"ACTIVE_PENDING_STATUSES \u003d constants.SUPPORTED_PROVISIONING_STATUSES + ("},{"line_number":36,"context_line":"    constants.DEGRADED,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":39,"context_line":"BASE_CRT_DIR \u003d \u0027/listeners\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HAPROXY_TEMPLATE \u003d os.path.abspath("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_11cc9988","line":38,"updated":"2015-03-13 18:45:37.000000000","message":"This should be in the config file","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    constants.DEGRADED,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":39,"context_line":"BASE_CRT_DIR \u003d \u0027/listeners\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HAPROXY_TEMPLATE \u003d os.path.abspath("},{"line_number":42,"context_line":"    os.path.join(os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_717a35f2","line":39,"updated":"2015-03-13 18:45:37.000000000","message":"Can we make this an absolute path and in the config file?\n\nWe discussed putting this in a RAM based encrypted temporal disk space to protect the certificate data.","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"18110d74d4b7174982dc8b1343f0b6b8f7cc98dc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    constants.DEGRADED,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":39,"context_line":"BASE_CRT_DIR \u003d \u0027/listeners\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HAPROXY_TEMPLATE \u003d os.path.abspath("},{"line_number":42,"context_line":"    os.path.join(os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_3f46bf7b","line":39,"in_reply_to":"9a80dd14_1ffd7b6e","updated":"2015-03-13 20:33:38.000000000","message":"I am not a fan of having hidden defaults so making them required is probably a good idea.","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c132505155c7245cd9d7c03d1a82ef26fd990ba9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    constants.DEGRADED,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":39,"context_line":"BASE_CRT_DIR \u003d \u0027/listeners\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HAPROXY_TEMPLATE \u003d os.path.abspath("},{"line_number":42,"context_line":"    os.path.join(os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_1ffd7b6e","line":39,"in_reply_to":"9a80dd14_717a35f2","updated":"2015-03-13 20:27:01.000000000","message":"Both of these will be supplied from a config provided by the caller. I can remove these and make the init require these params. These were only here to ensure it defaults to something but making the driver provide even the defaults eliminates the need for these strings.\n\nYes, this is correct, this is the location where the data will live regardless of the system its being stored on, the operator defines this.","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":52,"context_line":"                 haproxy_template\u003dNone):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        \"\"\":param base_amp_path: Base path for amphora data"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_8405a912","line":54,"updated":"2015-03-13 18:45:37.000000000","message":"This doc string format is not right.\nThe first line should be a title/summary line, so move the \"HaProxy configuration generation\" up","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c132505155c7245cd9d7c03d1a82ef26fd990ba9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":52,"context_line":"                 haproxy_template\u003dNone):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        \"\"\":param base_amp_path: Base path for amphora data"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_1faf3b7e","line":54,"in_reply_to":"9a80dd14_8405a912","updated":"2015-03-13 20:27:01.000000000","message":"Will take care of these","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.haproxy_template \u003d (haproxy_template if haproxy_template"},{"line_number":67,"context_line":"                                 else HAPROXY_TEMPLATE)"},{"line_number":68,"context_line":"        self.cert_store_path \u003d \u0027{0}{1}\u0027.format(self.base_amp_path,"},{"line_number":69,"context_line":"                                               self.base_crt_dir)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def build_config(self, listener, tls_cert,"},{"line_number":72,"context_line":"                     socket_path\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_31e27da0","line":69,"updated":"2015-03-13 18:45:37.000000000","message":"Same comment about absolute path","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c132505155c7245cd9d7c03d1a82ef26fd990ba9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.haproxy_template \u003d (haproxy_template if haproxy_template"},{"line_number":67,"context_line":"                                 else HAPROXY_TEMPLATE)"},{"line_number":68,"context_line":"        self.cert_store_path \u003d \u0027{0}{1}\u0027.format(self.base_amp_path,"},{"line_number":69,"context_line":"                                               self.base_crt_dir)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def build_config(self, listener, tls_cert,"},{"line_number":72,"context_line":"                     socket_path\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_3f0ebf8c","line":69,"in_reply_to":"9a80dd14_31e27da0","updated":"2015-03-13 20:27:01.000000000","message":"Ill update this.","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def build_config(self, listener, tls_cert,"},{"line_number":72,"context_line":"                     socket_path\u003dNone,"},{"line_number":73,"context_line":"                     user_group\u003d\u0027nogroup\u0027):"},{"line_number":74,"context_line":"        \"\"\"Convert a logical configuration to the HAProxy version.\"\"\""},{"line_number":75,"context_line":"        return self.render_loadbalancer_obj(listener,"},{"line_number":76,"context_line":"                                            tls_cert\u003dtls_cert,"},{"line_number":77,"context_line":"                                            user_group\u003duser_group,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_842cc99a","line":74,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                tls_cert\u003dNone,"},{"line_number":94,"context_line":"                                user_group\u003d\u0027nogroup\u0027,"},{"line_number":95,"context_line":"                                socket_path\u003dNone):"},{"line_number":96,"context_line":"        \"\"\"Renders a templated configuration from a load balancer object.\"\"\""},{"line_number":97,"context_line":"        loadbalancer \u003d self._transform_loadbalancer("},{"line_number":98,"context_line":"            listener.loadbalancer,"},{"line_number":99,"context_line":"            listener,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_442e518d","line":96,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    def _transform_loadbalancer(self, loadbalancer, listener, tls_cert):"},{"line_number":110,"context_line":"        \"\"\"Transforms a load balanacer into an object that will"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"           be processed by the templating system"},{"line_number":113,"context_line":"        \"\"\""},{"line_number":114,"context_line":"        listener \u003d self._transform_listener(listener, tls_cert)"},{"line_number":115,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_84884972","line":112,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\"Transforms a listener into an object that will"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            be processed by the templating system"},{"line_number":125,"context_line":"        \"\"\""},{"line_number":126,"context_line":"        ret_value \u003d {"},{"line_number":127,"context_line":"            \u0027id\u0027: listener.id,"},{"line_number":128,"context_line":"            \u0027protocol_port\u0027: listener.protocol_port,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_c47ec169","line":125,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \"\"\"Transforms a pool into an object that will"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            be processed by the templating system"},{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        ret_value \u003d {"},{"line_number":151,"context_line":"            \u0027id\u0027: pool.id,"},{"line_number":152,"context_line":"            \u0027protocol\u0027: PROTOCOL_MAP[pool.protocol],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_e4966593","line":149,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def _transform_session_persistence(self, persistence):"},{"line_number":173,"context_line":"        \"\"\"Transforms session persistence into an object that will"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"            be processed by the templating system"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        return {"},{"line_number":178,"context_line":"            \u0027type\u0027: persistence.type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_248ddd7c","line":175,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    def _transform_member(self, member):"},{"line_number":183,"context_line":"        \"\"\"Transforms a member into an object that will"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            be processed by the templating system"},{"line_number":186,"context_line":"        \"\"\""},{"line_number":187,"context_line":"        return {"},{"line_number":188,"context_line":"            \u0027id\u0027: member.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_84ef691d","line":185,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        \"\"\"Transforms a health monitor into an object that will"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"            be processed by the templating system"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        return {"},{"line_number":203,"context_line":"            \u0027id\u0027: monitor.id,"},{"line_number":204,"context_line":"            \u0027type\u0027: monitor.type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_c4f5e1ed","line":201,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            \u0027type\u0027: monitor.type,"},{"line_number":205,"context_line":"            \u0027delay\u0027: monitor.delay,"},{"line_number":206,"context_line":"            \u0027timeout\u0027: monitor.timeout,"},{"line_number":207,"context_line":"            \u0027fall_threshold\u0027: monitor.fall_threshold,"},{"line_number":208,"context_line":"            \u0027http_method\u0027: monitor.http_method,"},{"line_number":209,"context_line":"            \u0027url_path\u0027: monitor.url_path,"},{"line_number":210,"context_line":"            \u0027expected_codes\u0027: \u0027|\u0027.join("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_64327511","line":207,"updated":"2015-03-13 18:45:37.000000000","message":"rise_threshold?","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c132505155c7245cd9d7c03d1a82ef26fd990ba9","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            \u0027type\u0027: monitor.type,"},{"line_number":205,"context_line":"            \u0027delay\u0027: monitor.delay,"},{"line_number":206,"context_line":"            \u0027timeout\u0027: monitor.timeout,"},{"line_number":207,"context_line":"            \u0027fall_threshold\u0027: monitor.fall_threshold,"},{"line_number":208,"context_line":"            \u0027http_method\u0027: monitor.http_method,"},{"line_number":209,"context_line":"            \u0027url_path\u0027: monitor.url_path,"},{"line_number":210,"context_line":"            \u0027expected_codes\u0027: \u0027|\u0027.join("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_df068385","line":207,"in_reply_to":"9a80dd14_64327511","updated":"2015-03-13 20:27:01.000000000","message":"not sure why that didnt make it in. Good catch","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        \"\"\"Members that should be included"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            Return only those that meet the criteria for templating"},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        return ("},{"line_number":221,"context_line":"            member.operating_status in"},{"line_number":222,"context_line":"            ACTIVE_PENDING_STATUSES and"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_04db797c","line":219,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        \"\"\"Expand the expected code string in set of codes."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        200-204 -\u003e 200, 201, 202, 204"},{"line_number":230,"context_line":"        200, 203 -\u003e 200, 203"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        retval \u003d set()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_e4c4a593","line":230,"updated":"2015-03-13 18:45:37.000000000","message":"docstring param missing","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"}],"octavia/amphorae/drivers/haproxy/jinja/templates/haproxy_base.template":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"07672a8aaf7f92b596a32acd2feadff7cd74674a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    option redispatch"},{"line_number":29,"context_line":"    timeout connect 5000"},{"line_number":30,"context_line":"    timeout client 50000"},{"line_number":31,"context_line":"    timeout server 50000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% block proxies %}{% endblock proxies %}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a80dd14_c77083a6","line":31,"updated":"2015-03-13 18:45:37.000000000","message":"We should make these configurable\nCustomers like to adjust these","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"26c390f2a81bc3df3436c5da3e04183fe08915fb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    option redispatch"},{"line_number":29,"context_line":"    timeout connect 5000"},{"line_number":30,"context_line":"    timeout client 50000"},{"line_number":31,"context_line":"    timeout server 50000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% block proxies %}{% endblock proxies %}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a80dd14_c949ffb8","line":31,"in_reply_to":"9a80dd14_c77083a6","updated":"2015-03-17 15:23:50.000000000","message":"Would this be in etc/octavia.conf?","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"2e66bf5584f781b6d8a3be7ca8bd02ca0b4721ac","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    option redispatch"},{"line_number":29,"context_line":"    timeout connect 5000"},{"line_number":30,"context_line":"    timeout client 50000"},{"line_number":31,"context_line":"    timeout server 50000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% block proxies %}{% endblock proxies %}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a80dd14_0935d7f6","line":31,"in_reply_to":"9a80dd14_c949ffb8","updated":"2015-03-17 15:26:12.000000000","message":"I think to make these configurable for the user would be to add these as values to maybe the load balancer object. Is that what youre think Michael?","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"183d50b23e832f624ca26cca7cccdc20a179a084","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    option redispatch"},{"line_number":29,"context_line":"    timeout connect 5000"},{"line_number":30,"context_line":"    timeout client 50000"},{"line_number":31,"context_line":"    timeout server 50000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% block proxies %}{% endblock proxies %}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a80dd14_c901ff07","line":31,"in_reply_to":"9a80dd14_c949ffb8","updated":"2015-03-17 15:27:19.000000000","message":"Yes.","commit_id":"ceeb1f340a8007f9404316fa1dcb402ca44f7f6f"}]}
