)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"e53eafee6ff598603421b35ef092e2f4e39bbc13","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the config file for nova compute drive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include a certificate , key and user data"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I98577e180159030ad2546ca7badf0b8b04589516"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_f34b5728","line":9,"updated":"2015-03-20 23:21:45.000000000","message":"SUPER nit: extra space","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"925747da9d67fe480fefe2c5a06714bcb852d44d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the config file for nova compute drive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include a certificate , key and user data"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I98577e180159030ad2546ca7badf0b8b04589516"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_b3fb9f79","line":9,"in_reply_to":"9a80dd14_f34b5728","updated":"2015-03-20 23:37:57.000000000","message":"will delete the extra space","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"}],"doc-requirements.txt":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":4,"context_line":"nwdiag"},{"line_number":5,"context_line":"oslosphinx"},{"line_number":6,"context_line":"seqdiag"},{"line_number":7,"context_line":"sphinx\u003d\u003d1.2.3"},{"line_number":8,"context_line":"sphinxcontrib-actdiag"},{"line_number":9,"context_line":"sphinxcontrib-blockdiag"},{"line_number":10,"context_line":"sphinxcontrib-nwdiag"}],"source_content_type":"text/plain","patch_set":3,"id":"9a80dd14_ad012e08","line":7,"updated":"2015-03-17 17:49:53.000000000","message":"Make sure that there wasn\u0027t a fix in master","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":4,"context_line":"nwdiag"},{"line_number":5,"context_line":"oslosphinx"},{"line_number":6,"context_line":"seqdiag"},{"line_number":7,"context_line":"sphinx\u003d\u003d1.2.3"},{"line_number":8,"context_line":"sphinxcontrib-actdiag"},{"line_number":9,"context_line":"sphinxcontrib-blockdiag"},{"line_number":10,"context_line":"sphinxcontrib-nwdiag"}],"source_content_type":"text/plain","patch_set":3,"id":"9a80dd14_5881494c","line":7,"in_reply_to":"9a80dd14_ad012e08","updated":"2015-03-17 19:23:10.000000000","message":"will check","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b39eb4e4b9c2dfc17e3b5718cdf372d686eb8e0d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"nwdiag"},{"line_number":5,"context_line":"oslosphinx"},{"line_number":6,"context_line":"seqdiag"},{"line_number":7,"context_line":"sphinx\u003d\u003d1.2.3"},{"line_number":8,"context_line":"sphinxcontrib-actdiag"},{"line_number":9,"context_line":"sphinxcontrib-blockdiag"},{"line_number":10,"context_line":"sphinxcontrib-nwdiag"}],"source_content_type":"text/plain","patch_set":6,"id":"1a6ced46_66879010","line":7,"updated":"2015-03-21 20:44:46.000000000","message":"not a huge deal but this change seems out of scope of the review, or am i missing something?  I\u0027m fine with keeping it in this change, just wondering if it is because of some doc requirements this version has.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"1f8cf674a60a2efdd7838cf9d56e7645385b86c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"nwdiag"},{"line_number":5,"context_line":"oslosphinx"},{"line_number":6,"context_line":"seqdiag"},{"line_number":7,"context_line":"sphinx\u003d\u003d1.2.3"},{"line_number":8,"context_line":"sphinxcontrib-actdiag"},{"line_number":9,"context_line":"sphinxcontrib-blockdiag"},{"line_number":10,"context_line":"sphinxcontrib-nwdiag"}],"source_content_type":"text/plain","patch_set":6,"id":"1a6ced46_a9877060","line":7,"in_reply_to":"1a6ced46_66879010","updated":"2015-03-23 16:54:49.000000000","message":"without this line, when I run tox, will give me doc error, so I talked with Adam, he suggested me to put this line here, and it works without error now.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"}],"etc/octavia.conf":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# debug \u003d False"},{"line_number":6,"context_line":"# bind_host \u003d 0.0.0.0"},{"line_number":7,"context_line":"# bind_port \u003d 9191"},{"line_number":8,"context_line":"# nova_configdrive_amp_certificate \u003d /etc/ssl/certs/amp-certificate.pem"},{"line_number":9,"context_line":"# nova_confgidrive_amp_key \u003d /etc/ssl/certs/amp-cert-key.pem"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[database]"}],"source_content_type":"text/plain","patch_set":3,"id":"9a80dd14_683564da","line":8,"updated":"2015-03-17 17:49:53.000000000","message":"The config drive is supposed to be a generic vehicle to transfer files. So I am confused why we define certs here.","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# debug \u003d False"},{"line_number":6,"context_line":"# bind_host \u003d 0.0.0.0"},{"line_number":7,"context_line":"# bind_port \u003d 9191"},{"line_number":8,"context_line":"# nova_configdrive_amp_certificate \u003d /etc/ssl/certs/amp-certificate.pem"},{"line_number":9,"context_line":"# nova_confgidrive_amp_key \u003d /etc/ssl/certs/amp-cert-key.pem"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[database]"}],"source_content_type":"text/plain","patch_set":3,"id":"9a80dd14_b8f5e5ee","line":8,"in_reply_to":"9a80dd14_683564da","updated":"2015-03-17 19:23:10.000000000","message":"will comment them out","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"6c567105e1ea066a67a2e03e65f2c9a5f6868843","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# debug \u003d False"},{"line_number":6,"context_line":"# bind_host \u003d 0.0.0.0"},{"line_number":7,"context_line":"# bind_port \u003d 9191"},{"line_number":8,"context_line":"# nova_configdrive_amp_certificate \u003d /etc/ssl/certs/amp-certificate.pem"},{"line_number":9,"context_line":"# nova_confgidrive_amp_key \u003d /etc/ssl/certs/amp-cert-key.pem"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[database]"}],"source_content_type":"text/plain","patch_set":3,"id":"9a80dd14_7c8a4a65","line":8,"in_reply_to":"9a80dd14_b8f5e5ee","updated":"2015-03-18 18:58:43.000000000","message":"I think we need to delete since we will generate them dynamically with the controller. So no need to have them in config","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"}],"octavia/common/config.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt(\u0027nova_region_name\u0027,"},{"line_number":74,"context_line":"               help\u003d_(\u0027Name of nova region to use. Useful if keystone manages\u0027"},{"line_number":75,"context_line":"                      \u0027 more than one region.\u0027)),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027nova_configdrive_amp_certificate\u0027,"},{"line_number":77,"context_line":"               help\u003d_(\u0027Path for amphora certificate to transfer via config\u0027"},{"line_number":78,"context_line":"                      \u0027drive.\u0027)),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027nova_configdirve_amp_cert_key\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_a82f5c87","line":76,"updated":"2015-03-17 17:49:53.000000000","message":"same","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"6c567105e1ea066a67a2e03e65f2c9a5f6868843","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt(\u0027nova_region_name\u0027,"},{"line_number":74,"context_line":"               help\u003d_(\u0027Name of nova region to use. Useful if keystone manages\u0027"},{"line_number":75,"context_line":"                      \u0027 more than one region.\u0027)),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027nova_configdrive_amp_certificate\u0027,"},{"line_number":77,"context_line":"               help\u003d_(\u0027Path for amphora certificate to transfer via config\u0027"},{"line_number":78,"context_line":"                      \u0027drive.\u0027)),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027nova_configdirve_amp_cert_key\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_fcf55aed","line":76,"in_reply_to":"9a80dd14_78d28d5c","updated":"2015-03-18 18:58:43.000000000","message":"Just delete. They will be generated dynamically --","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt(\u0027nova_region_name\u0027,"},{"line_number":74,"context_line":"               help\u003d_(\u0027Name of nova region to use. Useful if keystone manages\u0027"},{"line_number":75,"context_line":"                      \u0027 more than one region.\u0027)),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027nova_configdrive_amp_certificate\u0027,"},{"line_number":77,"context_line":"               help\u003d_(\u0027Path for amphora certificate to transfer via config\u0027"},{"line_number":78,"context_line":"                      \u0027drive.\u0027)),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027nova_configdirve_amp_cert_key\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_78d28d5c","line":76,"in_reply_to":"9a80dd14_a82f5c87","updated":"2015-03-17 19:23:10.000000000","message":"we need to use it later","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b39eb4e4b9c2dfc17e3b5718cdf372d686eb8e0d","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"core_cli_opts \u003d []"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Register the configuration optional"},{"line_number":92,"context_line":"cfg.CONF.register_opts(core_opts)"},{"line_number":93,"context_line":"cfg.CONF.register_opts(keystone_authtoken_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":94,"context_line":"cfg.CONF.register_opts(networking_opts, group\u003d\u0027networking\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_46829401","line":91,"updated":"2015-03-21 20:44:46.000000000","message":"why was this changed? this made sense before.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"1f8cf674a60a2efdd7838cf9d56e7645385b86c7","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"core_cli_opts \u003d []"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Register the configuration optional"},{"line_number":92,"context_line":"cfg.CONF.register_opts(core_opts)"},{"line_number":93,"context_line":"cfg.CONF.register_opts(keystone_authtoken_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":94,"context_line":"cfg.CONF.register_opts(networking_opts, group\u003d\u0027networking\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_69e4983b","line":91,"in_reply_to":"1a6ced46_46829401","updated":"2015-03-23 16:54:49.000000000","message":"hmm, let me change it back again.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"}],"octavia/compute/compute_base.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fbc63a0f8ffbd46edabf0ba35dee71d6c81a2605","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @abc.abstractmethod"},{"line_number":32,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":33,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":34,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":35,"context_line":"        \"\"\"Build a new amphora."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        :param name: Optional name for Amphora"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_0264d1b7","line":34,"updated":"2015-03-23 21:58:59.000000000","message":"config_drive_files?","commit_id":"d2108458081f5a580468ae15e5ba099ff81da67a"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3aa1ea6f2a02044960eec060ed6a2033bb14d1fd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @abc.abstractmethod"},{"line_number":32,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":33,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":34,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":35,"context_line":"        \"\"\"Build a new amphora."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        :param name: Optional name for Amphora"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_38abbad9","line":34,"in_reply_to":"1a6ced46_0264d1b7","updated":"2015-03-23 22:54:02.000000000","message":"same as the reply in the other comment","commit_id":"d2108458081f5a580468ae15e5ba099ff81da67a"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        #                     \u0027/etc/ssl/certs/amp-certificate.pem\u0027:"},{"line_number":75,"context_line":"        # fileobject2}"},{"line_number":76,"context_line":"        #"},{"line_number":77,"context_line":"        # user_data \u003d open(\u0027/etc/octavia/userdata/sample_userdata.txt\u0027, \u0027r\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            nics \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_e89eb4b7","line":77,"updated":"2015-03-17 17:49:53.000000000","message":"if the code is not needed please delete it","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        #                     \u0027/etc/ssl/certs/amp-certificate.pem\u0027:"},{"line_number":75,"context_line":"        # fileobject2}"},{"line_number":76,"context_line":"        #"},{"line_number":77,"context_line":"        # user_data \u003d open(\u0027/etc/octavia/userdata/sample_userdata.txt\u0027, \u0027r\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            nics \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f8bd9d04","line":77,"in_reply_to":"9a80dd14_e89eb4b7","updated":"2015-03-17 19:23:10.000000000","message":"will do","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                nics\u003dnics,"},{"line_number":88,"context_line":"                config_drive_files\u003dconfig_drive_files,"},{"line_number":89,"context_line":"                user_data\u003duser_data,"},{"line_number":90,"context_line":"                config_dirver\u003dTrue"},{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            return amphora.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_4866e0ef","line":90,"updated":"2015-03-17 17:49:53.000000000","message":"this looks misspelled -","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                nics\u003dnics,"},{"line_number":88,"context_line":"                config_drive_files\u003dconfig_drive_files,"},{"line_number":89,"context_line":"                user_data\u003duser_data,"},{"line_number":90,"context_line":"                config_dirver\u003dTrue"},{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            return amphora.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_b8116506","line":90,"in_reply_to":"9a80dd14_4866e0ef","updated":"2015-03-17 19:23:10.000000000","message":"oops, will correct it","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            return amphora.id"},{"line_number":94,"context_line":"        except Exception:"},{"line_number":95,"context_line":"            LOG.exception(_LE(\"Error building nova virtual machine.\"))"},{"line_number":96,"context_line":"            raise exceptions.ComputeBuildException()"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_683c84c0","line":94,"updated":"2015-03-17 17:49:53.000000000","message":"Too broad an Exception to catch.","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            return amphora.id"},{"line_number":94,"context_line":"        except Exception:"},{"line_number":95,"context_line":"            LOG.exception(_LE(\"Error building nova virtual machine.\"))"},{"line_number":96,"context_line":"            raise exceptions.ComputeBuildException()"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7860cda4","line":94,"in_reply_to":"9a80dd14_683c84c0","updated":"2015-03-17 19:23:10.000000000","message":"that is the original design","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"6c567105e1ea066a67a2e03e65f2c9a5f6868843","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            return amphora.id"},{"line_number":94,"context_line":"        except Exception:"},{"line_number":95,"context_line":"            LOG.exception(_LE(\"Error building nova virtual machine.\"))"},{"line_number":96,"context_line":"            raise exceptions.ComputeBuildException()"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1cc30e8b","line":94,"in_reply_to":"9a80dd14_7860cda4","updated":"2015-03-18 18:58:43.000000000","message":"ok, still broad... but it\u0027s more of  a nit","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"e53eafee6ff598603421b35ef092e2f4e39bbc13","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_730687cf","line":50,"updated":"2015-03-20 23:21:45.000000000","message":"This func is a bit overdo for a kwargs conversion.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"1f8cf674a60a2efdd7838cf9d56e7645385b86c7","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_89bab4df","line":50,"in_reply_to":"1a6ced46_c675a433","updated":"2015-03-23 16:54:49.000000000","message":"will add it in the interface method , thanks for the input","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b39eb4e4b9c2dfc17e3b5718cdf372d686eb8e0d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_c675a433","line":50,"in_reply_to":"9a80dd14_133b8b38","updated":"2015-03-21 20:44:46.000000000","message":"not sure if this is what doug meant, but this is changing the interface this class is implementing, so these parameters should be added to the interface method as well.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"925747da9d67fe480fefe2c5a06714bcb852d44d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_133b8b38","line":50,"in_reply_to":"9a80dd14_730687cf","updated":"2015-03-20 23:37:57.000000000","message":"Hey Doug, thanks for the input, can you explain a little bit what you mean here, so we need to pass the 2 arguments config_driver_files, user_data in this function, do you want me to change the name for the arguments or you have other better idea.","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"e53eafee6ff598603421b35ef092e2f4e39bbc13","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        :param key_name: keypair to add to the virtual machine"},{"line_number":57,"context_line":"        :param sec_groups: Security group IDs for virtual machine"},{"line_number":58,"context_line":"        :param network_ids: Network IDs to include on virtual machine"},{"line_number":59,"context_line":"        :config_drive_files:  A dict of files to overrwrite on"},{"line_number":60,"context_line":"        the server upon boot. Keys are file names (i.e. /etc/passwd)l"},{"line_number":61,"context_line":"        and values are the file contents (either as a string or as"},{"line_number":62,"context_line":"        a file-like object). A maximum of five entries is allowed,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_93093bdf","line":59,"updated":"2015-03-20 23:21:45.000000000","message":"nit: config_driveR_files...  though doesn\u0027t it make more sense without the R?","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"925747da9d67fe480fefe2c5a06714bcb852d44d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        :param key_name: keypair to add to the virtual machine"},{"line_number":57,"context_line":"        :param sec_groups: Security group IDs for virtual machine"},{"line_number":58,"context_line":"        :param network_ids: Network IDs to include on virtual machine"},{"line_number":59,"context_line":"        :config_drive_files:  A dict of files to overrwrite on"},{"line_number":60,"context_line":"        the server upon boot. Keys are file names (i.e. /etc/passwd)l"},{"line_number":61,"context_line":"        and values are the file contents (either as a string or as"},{"line_number":62,"context_line":"        a file-like object). A maximum of five entries is allowed,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_7305a778","line":59,"in_reply_to":"9a80dd14_93093bdf","updated":"2015-03-20 23:37:57.000000000","message":"will change it","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fbc63a0f8ffbd46edabf0ba35dee71d6c81a2605","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_a255bdc7","line":50,"updated":"2015-03-23 21:58:59.000000000","message":"shouldn\u0027t this be config_drive_files? or am I mistaken?","commit_id":"d2108458081f5a580468ae15e5ba099ff81da67a"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"7b18de1a2c6ce7962a97d2e1ea05a14e014dc01c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_f87ad9ef","line":50,"in_reply_to":"1a6ced46_385e5ae7","updated":"2015-03-24 18:48:55.000000000","message":"ok, will change it to be config dirve then!","commit_id":"d2108458081f5a580468ae15e5ba099ff81da67a"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3aa1ea6f2a02044960eec060ed6a2033bb14d1fd","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_b85faa0d","line":50,"in_reply_to":"1a6ced46_a255bdc7","updated":"2015-03-23 22:54:02.000000000","message":"i used to use config_drive_files, then it was pointed to be a typo, so I changed to this one, please give me guidance on what should be the right one","commit_id":"d2108458081f5a580468ae15e5ba099ff81da67a"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3e2cb4eb26819f906a8c1f380905872e360ffc1f","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone, image_id\u003dNone,"},{"line_number":49,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":50,"context_line":"              config_driver_files\u003dNone, user_data\u003dNone):"},{"line_number":51,"context_line":"        \u0027\u0027\u0027Create a new virtual machine."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param name: optional name for amphora"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_385e5ae7","line":50,"in_reply_to":"1a6ced46_b85faa0d","updated":"2015-03-23 23:03:06.000000000","message":"if it is doing what this is doing:\n\nhttp://docs.openstack.org/user-guide/content/enable_config_drive.html\n\nthen I\u0027d say it should be config drive.","commit_id":"d2108458081f5a580468ae15e5ba099ff81da67a"}],"octavia/tests/unit/compute/drivers/test_nova_driver.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"82d59414850a8e21e8d090ad91aaad4463f92f44","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        super(TestNovaClient, self).setUp()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_bluild(self):"},{"line_number":56,"context_line":"        fileobject1 \u003d open(\u0027/etc/ssl/certs/amp-cert-key.pem\u0027, \u0027r\u0027)"},{"line_number":57,"context_line":"        fileobject2 \u003d open(\u0027/etc/ssl/certs/amp-certificate.pem\u0027, \u0027r\u0027)"},{"line_number":58,"context_line":"        conf_drive_files \u003d {\u0027/etc/ssl/certs/amp-cert-key.pem\u0027: fileobject1,"},{"line_number":59,"context_line":"                            \u0027/etc/ssl/certs/amp-certificate.pem\u0027: fileobject2}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_48c26087","line":56,"updated":"2015-03-17 17:49:53.000000000","message":"unit tests can\u0027t assume files in specific directories. Consider mocking or using constants","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"e1f8818ac6bba90bf4e17b08f039cd5f43084516","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        super(TestNovaClient, self).setUp()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_bluild(self):"},{"line_number":56,"context_line":"        fileobject1 \u003d open(\u0027/etc/ssl/certs/amp-cert-key.pem\u0027, \u0027r\u0027)"},{"line_number":57,"context_line":"        fileobject2 \u003d open(\u0027/etc/ssl/certs/amp-certificate.pem\u0027, \u0027r\u0027)"},{"line_number":58,"context_line":"        conf_drive_files \u003d {\u0027/etc/ssl/certs/amp-cert-key.pem\u0027: fileobject1,"},{"line_number":59,"context_line":"                            \u0027/etc/ssl/certs/amp-certificate.pem\u0027: fileobject2}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_38fd75b2","line":56,"in_reply_to":"9a80dd14_48c26087","updated":"2015-03-17 19:23:10.000000000","message":"will think about it and change accordingly","commit_id":"719aa9f247f120c34bc3f124101b331be80cfdc2"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"0c76849e686e0e2e137be50c9040408c47392332","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        file_mock \u003d mock.mock_open()"},{"line_number":57,"context_line":"        user_data_mock \u003d mock.MagicMock(spec\u003d\u0027user data file content\u0027)"},{"line_number":58,"context_line":"        conf_file_mock \u003d mock.MagicMock(spec\u003d\u0027conf file content\u0027)"},{"line_number":59,"context_line":"        with mock.patch(\u0027__builtin__.open\u0027, file_mock, create\u003dTrue):"},{"line_number":60,"context_line":"            amphora_id \u003d self.manager.build(amphora_flavor\u003d1, image_id\u003d1,"},{"line_number":61,"context_line":"                                            key_name\u003d1, sec_groups\u003d1,"},{"line_number":62,"context_line":"                                            network_ids\u003d[1],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_4e0d838e","line":59,"updated":"2015-03-20 03:57:58.000000000","message":"I don\u0027t think a file is opened so you don\u0027t need to use that patch. Since you are just checking if they are passed correctly to the mocked Nova call you could just use strings, e.g. user_data \u003d \u0027Blah\u0027, config_driver_files\u003d\u0027Files Blah\u0027","commit_id":"c13bd52ccfd1a21d8a6c42591bfdb7994002af7a"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"4af5da576f44585ffcc648f74e91cf60be969454","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        file_mock \u003d mock.mock_open()"},{"line_number":57,"context_line":"        user_data_mock \u003d mock.MagicMock(spec\u003d\u0027user data file content\u0027)"},{"line_number":58,"context_line":"        conf_file_mock \u003d mock.MagicMock(spec\u003d\u0027conf file content\u0027)"},{"line_number":59,"context_line":"        with mock.patch(\u0027__builtin__.open\u0027, file_mock, create\u003dTrue):"},{"line_number":60,"context_line":"            amphora_id \u003d self.manager.build(amphora_flavor\u003d1, image_id\u003d1,"},{"line_number":61,"context_line":"                                            key_name\u003d1, sec_groups\u003d1,"},{"line_number":62,"context_line":"                                            network_ids\u003d[1],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_19d83352","line":59,"in_reply_to":"9a80dd14_4e0d838e","updated":"2015-03-20 04:40:52.000000000","message":"thank you for the input, will update it in the new patch","commit_id":"c13bd52ccfd1a21d8a6c42591bfdb7994002af7a"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b39eb4e4b9c2dfc17e3b5718cdf372d686eb8e0d","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        super(TestNovaClient, self).setUp()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_bluild(self):"},{"line_number":56,"context_line":"        amphora_id \u003d self.manager.build(amphora_flavor\u003d1, image_id\u003d1,"},{"line_number":57,"context_line":"                                        key_name\u003d1,"},{"line_number":58,"context_line":"                                        sec_groups\u003d1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_e672a048","line":55,"updated":"2015-03-21 20:44:46.000000000","message":"nit: build","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"1f8cf674a60a2efdd7838cf9d56e7645385b86c7","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        super(TestNovaClient, self).setUp()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_bluild(self):"},{"line_number":56,"context_line":"        amphora_id \u003d self.manager.build(amphora_flavor\u003d1, image_id\u003d1,"},{"line_number":57,"context_line":"                                        key_name\u003d1,"},{"line_number":58,"context_line":"                                        sec_groups\u003d1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_09cec483","line":55,"in_reply_to":"1a6ced46_e672a048","updated":"2015-03-23 16:54:49.000000000","message":"oops, will correct it!","commit_id":"2c0c375242ff644cfb8eaf1eb41dfed5555eb8b3"}]}