)]}'
{"octavia/amphorae/drivers/driver_base.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c5ab27e8b0cab7735bda3b8f03f61c17dc36bfae","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        pass"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def post_network_plug(self, amphora):"},{"line_number":148,"context_line":"        \"\"\"Called after amphora added to network"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_79d1c1fa","line":147,"updated":"2015-03-23 18:40:36.000000000","message":"How is that different from finalize amphora?","commit_id":"4c8e6d8ab22d88cbf3eb20ab72696dcb7910a41c"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"f862dfb8fec7ad4dbd72576cbb958be08b199e87","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        pass"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def post_network_plug(self, amphora):"},{"line_number":148,"context_line":"        \"\"\"Called after amphora added to network"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_b9fc1940","line":147,"in_reply_to":"1a6ced46_79d1c1fa","updated":"2015-03-23 18:44:43.000000000","message":"finalize_amphora is used before listeners.  When adding a member on a different subnet, we\u0027ll have to create a new interface (in our implementation), which wouldn\u0027t be an accurate use of \"finalize_amphora\"","commit_id":"4c8e6d8ab22d88cbf3eb20ab72696dcb7910a41c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"435f07fd59e0525eb316d6c1062824b83397e2aa","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        pass"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def post_network_plug(self, amphora):"},{"line_number":148,"context_line":"        \"\"\"Called after amphora added to network"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_623bca3a","line":147,"in_reply_to":"1a6ced46_9cacabef","updated":"2015-03-23 20:03:19.000000000","message":"I think finalize_amphora has a different or additional purpose, so I agree that we should add this.","commit_id":"4c8e6d8ab22d88cbf3eb20ab72696dcb7910a41c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0830dbdaded9f5e6568679fd2f9f34ad08aca58e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        pass"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def post_network_plug(self, amphora):"},{"line_number":148,"context_line":"        \"\"\"Called after amphora added to network"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_9cacabef","line":147,"in_reply_to":"1a6ced46_b9fc1940","updated":"2015-03-23 18:53:50.000000000","message":"unless finalize_amphora is called last every operation sequence, this will be needed.  I\u0027d be fine with redefining finalize_amphora to do this, but the description says it will be called only after the amphora is built.","commit_id":"4c8e6d8ab22d88cbf3eb20ab72696dcb7910a41c"}]}