)]}'
{"octavia/common/config.py":[{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"3056c89afbe8ac790fd4e4d4bbbfa78f878043d0","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"keystone_auth_extra_opts \u003d ["},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027admin_project_id\u0027, help\u003d_(\u0027ID of admin project\u0027))"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"core_cli_opts \u003d []"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_62bb8fe6","line":84,"updated":"2015-03-31 06:56:23.000000000","message":"The option admin_project_id is not required, the required parameters are already configured.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ad44af95ec01d9e0e56716ebaf6900934f07e9af","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"keystone_auth_extra_opts \u003d ["},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027admin_project_id\u0027, help\u003d_(\u0027ID of admin project\u0027))"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"core_cli_opts \u003d []"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_a53521db","line":84,"in_reply_to":"da9b358b_62bb8fe6","updated":"2015-03-31 07:13:50.000000000","message":"if that is the case, then it was wrong in the first place.  i\u0027d be happy not to have to put this here though.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"3056c89afbe8ac790fd4e4d4bbbfa78f878043d0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"cfg.CONF.register_cli_opts(core_cli_opts)"},{"line_number":92,"context_line":"cfg.CONF.import_group(\u0027keystone_authtoken\u0027, \u0027keystonemiddleware.auth_token\u0027)"},{"line_number":93,"context_line":"cfg.CONF.register_opts(keystone_auth_extra_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# Ensure that the control exchange is set correctly"},{"line_number":96,"context_line":"messaging.set_transport_defaults(control_exchange\u003d\u0027octavia\u0027)"},{"line_number":97,"context_line":"_SQL_CONNECTION_DEFAULT \u003d \u0027sqlite://\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_62a26fb0","line":94,"updated":"2015-03-31 06:56:23.000000000","message":"No need to register the group, the import is enough.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"}],"octavia/common/keystone.py":[{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"3056c89afbe8ac790fd4e4d4bbbfa78f878043d0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    tenant_name\u003dcfg.CONF.keystone_authtoken.admin_tenant_name"},{"line_number":47,"context_line":"                )"},{"line_number":48,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":49,"context_line":"            else:"},{"line_number":50,"context_line":"                kc \u003d v3_client.Password("},{"line_number":51,"context_line":"                    auth_url\u003dcfg.CONF.keystone_authtoken.auth_uri,"},{"line_number":52,"context_line":"                    username\u003dcfg.CONF.keystone_authtoken.admin_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_c29ffb4e","line":49,"updated":"2015-03-31 06:56:23.000000000","message":"While this is sufficient, I would suggest to verify the version to safe guard for bad configurations and different versions. Otherwise, if there is a misconfiguration the error will be thrown else where and maybe not correctly handled. It\u0027s better to catch and warn early. This is really a nit.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ad44af95ec01d9e0e56716ebaf6900934f07e9af","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    tenant_name\u003dcfg.CONF.keystone_authtoken.admin_tenant_name"},{"line_number":47,"context_line":"                )"},{"line_number":48,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":49,"context_line":"            else:"},{"line_number":50,"context_line":"                kc \u003d v3_client.Password("},{"line_number":51,"context_line":"                    auth_url\u003dcfg.CONF.keystone_authtoken.auth_uri,"},{"line_number":52,"context_line":"                    username\u003dcfg.CONF.keystone_authtoken.admin_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_8202130a","line":49,"in_reply_to":"da9b358b_c29ffb4e","updated":"2015-03-31 07:13:50.000000000","message":"not sure what you mean by this.  could you elaborate?","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"3056c89afbe8ac790fd4e4d4bbbfa78f878043d0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    username\u003dcfg.CONF.keystone_authtoken.admin_user,"},{"line_number":53,"context_line":"                    password\u003dcfg.CONF.keystone_authtoken.admin_password,"},{"line_number":54,"context_line":"                    project_id\u003dcfg.CONF.keystone_authtoken.admin_project_id"},{"line_number":55,"context_line":"                )"},{"line_number":56,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_e2cb1f52","line":55,"updated":"2015-03-31 06:56:23.000000000","message":"The arguments are identical, the only difference is the client. Also, \u0027Client\u0027 Should be used here to be \u0027universal\u0027.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ad44af95ec01d9e0e56716ebaf6900934f07e9af","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    username\u003dcfg.CONF.keystone_authtoken.admin_user,"},{"line_number":53,"context_line":"                    password\u003dcfg.CONF.keystone_authtoken.admin_password,"},{"line_number":54,"context_line":"                    project_id\u003dcfg.CONF.keystone_authtoken.admin_project_id"},{"line_number":55,"context_line":"                )"},{"line_number":56,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_02ecc38d","line":55,"in_reply_to":"da9b358b_e2cb1f52","updated":"2015-03-31 07:13:50.000000000","message":"well project_id is different for v3, and tenant_name is differnet for v2.  what do you mean by client should be used here?  if project_id is not needed and the both just take tenant_name, then i see what you mean.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"3056c89afbe8ac790fd4e4d4bbbfa78f878043d0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    password\u003dcfg.CONF.keystone_authtoken.admin_password,"},{"line_number":54,"context_line":"                    project_id\u003dcfg.CONF.keystone_authtoken.admin_project_id"},{"line_number":55,"context_line":"                )"},{"line_number":56,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":59,"context_line":"                LOG.exception(_LE(\"Error creating Keystone session.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_22ffc768","line":56,"updated":"2015-03-31 06:56:23.000000000","message":"nit: the session could be set once after the checks and having a default set before the block.","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ad44af95ec01d9e0e56716ebaf6900934f07e9af","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    password\u003dcfg.CONF.keystone_authtoken.admin_password,"},{"line_number":54,"context_line":"                    project_id\u003dcfg.CONF.keystone_authtoken.admin_project_id"},{"line_number":55,"context_line":"                )"},{"line_number":56,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":59,"context_line":"                LOG.exception(_LE(\"Error creating Keystone session.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_82f8d34a","line":56,"in_reply_to":"da9b358b_22ffc768","updated":"2015-03-31 07:13:50.000000000","message":"good catch","commit_id":"1a6f71e6e3c84922e79b4a662a71321ec263dd88"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"0d6a82afe64a8d0ba79a42f75e3e932f0b98bdc6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if cfg.CONF.keystone_authtoken.auth_version \u003d\u003d \u00272\u0027:"},{"line_number":41,"context_line":"            client \u003d v2_client"},{"line_number":42,"context_line":"        elif cfg.CONF.keystone_authtoken.auth_version \u003d\u003d \u00273\u0027:"},{"line_number":43,"context_line":"            client \u003d v3_client"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            raise Exception(\u0027Unknown keystone version!\u0027)"},{"line_number":46,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_45cbf51e","line":43,"updated":"2015-03-31 07:37:58.000000000","message":"I like it! :)","commit_id":"98792dd46271782cc0810d1433712d269dddf6fb"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"54cfb9bd33c998d5e0aca041697969341f4f760e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if cfg.CONF.keystone_authtoken.auth_version \u003d\u003d \u00272\u0027:"},{"line_number":41,"context_line":"            client \u003d v2_client"},{"line_number":42,"context_line":"        elif cfg.CONF.keystone_authtoken.auth_version \u003d\u003d \u00273\u0027:"},{"line_number":43,"context_line":"            client \u003d v3_client"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            raise Exception(\u0027Unknown keystone version!\u0027)"},{"line_number":46,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_f8f630f8","line":43,"in_reply_to":"da9b358b_45cbf51e","updated":"2015-03-31 07:51:51.000000000","message":"Me too!","commit_id":"98792dd46271782cc0810d1433712d269dddf6fb"}]}