)]}'
{"elements/amphora-agent/install.d/75-run_setup_install":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fa32b979_fba00592","line":15,"updated":"2015-06-25 08:12:20.000000000","message":"ULTIMATE NITPICK: This has two blank lines at the end? :P","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"}],"etc/octavia.conf":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"706dc828197742512216b0d8dfec6735b894db66","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# lb_network_name \u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"[haproxy_amphora]"},{"line_number":119,"context_line":"# Key used to access amphora"},{"line_number":120,"context_line":"# key_name \u003d custom_key"},{"line_number":121,"context_line":"# base_path \u003d /var/lib/octavia"}],"source_content_type":"text/plain","patch_set":7,"id":"7a016987_660c0e43","line":118,"updated":"2015-05-13 23:52:58.000000000","message":"There is already an haproxy_amphora section above -- probably from the SSH driver merging -- this needs to be merged with the one above.","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d4eba1ef2ae4dc7a43dd1098ca8910bd10e8f3da","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# lb_network_name \u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"[haproxy_amphora]"},{"line_number":119,"context_line":"# Key used to access amphora"},{"line_number":120,"context_line":"# key_name \u003d custom_key"},{"line_number":121,"context_line":"# base_path \u003d /var/lib/octavia"}],"source_content_type":"text/plain","patch_set":7,"id":"7a016987_a512aa07","line":118,"in_reply_to":"7a016987_660c0e43","updated":"2015-05-15 20:10:17.000000000","message":"Done","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"}],"octavia/amphorae/drivers/haproxy/exceptions.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def check_exception(response):"},{"line_number":20,"context_line":"    status_code \u003d response.status_code"},{"line_number":21,"context_line":"    if status_code \u003d\u003d 401:"},{"line_number":22,"context_line":"        raise Unauthorized()"},{"line_number":23,"context_line":"    if status_code \u003d\u003d 403:"},{"line_number":24,"context_line":"        raise InvalidRequest()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_7bf39573","line":21,"updated":"2015-06-25 08:12:20.000000000","message":"Suggestion for a more \u0027python style\u0027 switch block (to avoid a huge list of \u0027if\u0027 conditionals like this) that seems generally cleaner:\n\nresponses \u003d {\n    401: Unauthorized,\n    403: InvalidRequest,\n    404: NotFound,\n    405: InvalidRequest,\n    409: Conflict,\n    500: InternalServerErrror,\n    503: ServiceUnavailable\n}\nreturn responses.get(status_code, UnexpectedStatusCode)()","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def check_exception(response):"},{"line_number":20,"context_line":"    status_code \u003d response.status_code"},{"line_number":21,"context_line":"    if status_code \u003d\u003d 401:"},{"line_number":22,"context_line":"        raise Unauthorized()"},{"line_number":23,"context_line":"    if status_code \u003d\u003d 403:"},{"line_number":24,"context_line":"        raise InvalidRequest()"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_cf72e9ad","line":21,"in_reply_to":"fa32b979_7bf39573","updated":"2015-06-29 03:53:54.000000000","message":"Done","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d3190546159b1d428f0ed21fd96171241375b911","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def finalize_amphora(self, amphora):"},{"line_number":93,"context_line":"        pass"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def post_vip_plug(self, load_balancer):"},{"line_number":96,"context_line":"        pass"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def post_network_plug(self, amphora):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aa745d1_c95c04f0","line":95,"updated":"2015-04-16 00:08:55.000000000","message":"Don\u0027t you need to bring up the interface?","commit_id":"88480a49fc5237636239821e906e35fc18493442"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":33,"context_line":"API_VERSION \u003d \u00270.5\u0027"},{"line_number":34,"context_line":"OCTAVIA_API_CLIENT \u003d (\"Octavia HaProxy Rest Client/{version} \""},{"line_number":35,"context_line":"                      \"(https://wiki.openstack.org/wiki/Octavia)\").format("},{"line_number":36,"context_line":"    version\u003dAPI_VERSION)"},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":"CONF.import_group(\u0027haproxy_amphora\u0027, \u0027octavia.common.config\u0027)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_c7df5e67","line":36,"updated":"2015-06-25 08:12:20.000000000","message":"Nitpick: is this really valid pep8? This spacing is really awkward.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":33,"context_line":"API_VERSION \u003d \u00270.5\u0027"},{"line_number":34,"context_line":"OCTAVIA_API_CLIENT \u003d (\"Octavia HaProxy Rest Client/{version} \""},{"line_number":35,"context_line":"                      \"(https://wiki.openstack.org/wiki/Octavia)\").format("},{"line_number":36,"context_line":"    version\u003dAPI_VERSION)"},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":"CONF.import_group(\u0027haproxy_amphora\u0027, \u0027octavia.common.config\u0027)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_4f8d797a","line":36,"in_reply_to":"fa32b979_c7df5e67","updated":"2015-06-29 03:53:54.000000000","message":"Pycharm autoformats to that -- but will try to make better","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(HaproxyAmphoraLoadBalancerDriver, self).__init__()"},{"line_number":44,"context_line":"        self.client \u003d AmphoraAPIClient()"},{"line_number":45,"context_line":"        self.barbican_client \u003d barbican.BarbicanCertManager()"},{"line_number":46,"context_line":"        self.jinja \u003d jinja_cfg.JinjaTemplater("},{"line_number":47,"context_line":"            base_amp_path\u003dCONF.haproxy_amphora.base_path,"},{"line_number":48,"context_line":"            base_crt_dir\u003dCONF.haproxy_amphora.base_cert_dir,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_69017dae","line":45,"updated":"2015-06-25 08:12:20.000000000","message":"I\u0027m not clear on why you\u0027re making a Barbican client explicitly -- driver code is only supposed to interface with the CertManager/CertGenerator generics, since it is up to configuration which one is used.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cff6bb8be65423ecf79eb2f464c711cba4011533","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(HaproxyAmphoraLoadBalancerDriver, self).__init__()"},{"line_number":44,"context_line":"        self.client \u003d AmphoraAPIClient()"},{"line_number":45,"context_line":"        self.barbican_client \u003d barbican.BarbicanCertManager()"},{"line_number":46,"context_line":"        self.jinja \u003d jinja_cfg.JinjaTemplater("},{"line_number":47,"context_line":"            base_amp_path\u003dCONF.haproxy_amphora.base_path,"},{"line_number":48,"context_line":"            base_crt_dir\u003dCONF.haproxy_amphora.base_cert_dir,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_f5045ac7","line":45,"in_reply_to":"ba3cc151_2fe7d541","updated":"2015-06-29 05:34:11.000000000","message":"If you can fix it here, I would do that before we merge this, and we can make another patch to fix the SSH driver similarly.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"192452ec79d5042b3613bdd10bfd808f906ba046","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(HaproxyAmphoraLoadBalancerDriver, self).__init__()"},{"line_number":44,"context_line":"        self.client \u003d AmphoraAPIClient()"},{"line_number":45,"context_line":"        self.barbican_client \u003d barbican.BarbicanCertManager()"},{"line_number":46,"context_line":"        self.jinja \u003d jinja_cfg.JinjaTemplater("},{"line_number":47,"context_line":"            base_amp_path\u003dCONF.haproxy_amphora.base_path,"},{"line_number":48,"context_line":"            base_crt_dir\u003dCONF.haproxy_amphora.base_cert_dir,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_036df303","line":45,"in_reply_to":"ba3cc151_f5045ac7","updated":"2015-06-29 16:08:31.000000000","message":"Done","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(HaproxyAmphoraLoadBalancerDriver, self).__init__()"},{"line_number":44,"context_line":"        self.client \u003d AmphoraAPIClient()"},{"line_number":45,"context_line":"        self.barbican_client \u003d barbican.BarbicanCertManager()"},{"line_number":46,"context_line":"        self.jinja \u003d jinja_cfg.JinjaTemplater("},{"line_number":47,"context_line":"            base_amp_path\u003dCONF.haproxy_amphora.base_path,"},{"line_number":48,"context_line":"            base_crt_dir\u003dCONF.haproxy_amphora.base_cert_dir,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_2fe7d541","line":45,"in_reply_to":"fa32b979_69017dae","updated":"2015-06-29 03:53:54.000000000","message":"I did that analog to the SSH driver. This is the part we probably need to refactor out of both. Not sure if we should do this as part of this review or have another one...","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if listener.tls_certificate_id:"},{"line_number":117,"context_line":"            tls_cert \u003d self._map_cert_tls_container("},{"line_number":118,"context_line":"                self.barbican_client.get_cert(listener.tls_certificate_id))"},{"line_number":119,"context_line":"            certs.append(tls_cert)"},{"line_number":120,"context_line":"        if listener.sni_containers:"},{"line_number":121,"context_line":"            for sni_cont in listener.sni_containers:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_69ef3de9","line":118,"updated":"2015-06-25 08:12:20.000000000","message":"This should be using the CertManager client specified from config (I believe we use stevedore or some sort of loader now?), not Barbican directly, as mentioned above.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if listener.tls_certificate_id:"},{"line_number":117,"context_line":"            tls_cert \u003d self._map_cert_tls_container("},{"line_number":118,"context_line":"                self.barbican_client.get_cert(listener.tls_certificate_id))"},{"line_number":119,"context_line":"            certs.append(tls_cert)"},{"line_number":120,"context_line":"        if listener.sni_containers:"},{"line_number":121,"context_line":"            for sni_cont in listener.sni_containers:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_6f72bd7e","line":118,"in_reply_to":"fa32b979_69ef3de9","updated":"2015-06-29 03:53:54.000000000","message":"Understood. see above","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"}],"octavia/amphorae/drivers/haproxy/rest_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73a8c88cc706eec4f71ca48b05644d80bb8d4dd7","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class HaproxyAmphoraLoadBalancerDriver(driver_base.AmphoraLoadBalancerDriver):"},{"line_number":174,"context_line":"    def __init__(self, log):"},{"line_number":175,"context_line":"        super(HaproxyAmphoraLoadBalancerDriver, self).__init__()"},{"line_number":176,"context_line":"        self.log \u003d log"},{"line_number":177,"context_line":"        self.driver \u003d HaproxyManager()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_ed61703a","line":174,"updated":"2015-04-09 23:17:14.000000000","message":"Please remove log here as German has asked Trevor to remove it from his ssh driver.\nI will push a patchset that pulls it from the noop","commit_id":"c26c439a7c8e6b42ed66bc6e2b9f57648c4ad6dc"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"83332d3c5e882f1c0535ce5b1b38c14eaedf1271","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.log \u003d log"},{"line_number":177,"context_line":"        self.driver \u003d HaproxyManager()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get_logger(self):"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        raise NotImplementedError"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_87682cbc","line":179,"updated":"2015-04-10 17:16:10.000000000","message":"ditto. get logger is going away (see merged patch https://review.openstack.org/172237)","commit_id":"c26c439a7c8e6b42ed66bc6e2b9f57648c4ad6dc"}],"octavia/certificates/generator/local.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            pk \u003d crypto.load_privatekey("},{"line_number":161,"context_line":"                crypto.FILETYPE_PEM,"},{"line_number":162,"context_line":"                private_key,"},{"line_number":163,"context_line":"                passphrase"},{"line_number":164,"context_line":"            )"},{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            pk \u003d crypto.load_privatekey("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_29913547","line":163,"updated":"2015-06-25 08:12:20.000000000","message":"does this really need to be split out? If passphrase is None and we pass it through, doesn\u0027t that map exactly the same as not passing it (since the default value for the passphrase arg in load_privatekey is None)?\n\nThe only time I can see this being different is if someone passes emptystring into _generate_csr, but I don\u0027t know if that\u0027s a case we\u0027re trying to catch?","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cff6bb8be65423ecf79eb2f464c711cba4011533","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            pk \u003d crypto.load_privatekey("},{"line_number":161,"context_line":"                crypto.FILETYPE_PEM,"},{"line_number":162,"context_line":"                private_key,"},{"line_number":163,"context_line":"                passphrase"},{"line_number":164,"context_line":"            )"},{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            pk \u003d crypto.load_privatekey("}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_f5d21a34","line":163,"in_reply_to":"ba3cc151_ef2b2d32","updated":"2015-06-29 05:34:11.000000000","message":"Alright, I wonder what\u0027s up... I should actually check crypto.load_privatekey to make sure I\u0027m telling the truth about None being the default value for passphrase. It\u0027s possible they\u0027re doing something tricksy.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            pk \u003d crypto.load_privatekey("},{"line_number":161,"context_line":"                crypto.FILETYPE_PEM,"},{"line_number":162,"context_line":"                private_key,"},{"line_number":163,"context_line":"                passphrase"},{"line_number":164,"context_line":"            )"},{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            pk \u003d crypto.load_privatekey("}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_ef2b2d32","line":163,"in_reply_to":"fa32b979_29913547","updated":"2015-06-29 03:53:54.000000000","message":"This one is puzzling me as well. I tried it without being split out and it recently stopped working in devstack. This seemed to be the most expedient solution -- but it baffles me as well.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"}],"octavia/common/config.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"706dc828197742512216b0d8dfec6735b894db66","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    cfg.FloatOpt(\u0027connection_retry_interval\u0027,"},{"line_number":114,"context_line":"                 default\u003d1,"},{"line_number":115,"context_line":"                 help\u003d_(\u0027Retry timeout between attempts.\u0027)),"},{"line_number":116,"context_line":"    cfg.StrOpt(\u0027key_name\u0027,"},{"line_number":117,"context_line":"               help\u003d_(\u0027Name of key loaded \u0027"},{"line_number":118,"context_line":"                      \u0027on amphora at boot.\u0027)),"},{"line_number":119,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_e6947ee9","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":26},"updated":"2015-05-13 23:52:58.000000000","message":"How does this compare to \"key_path\"? I think this was the old opt, and was carried forward by accident on a rebase possibly?","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d4eba1ef2ae4dc7a43dd1098ca8910bd10e8f3da","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    cfg.FloatOpt(\u0027connection_retry_interval\u0027,"},{"line_number":114,"context_line":"                 default\u003d1,"},{"line_number":115,"context_line":"                 help\u003d_(\u0027Retry timeout between attempts.\u0027)),"},{"line_number":116,"context_line":"    cfg.StrOpt(\u0027key_name\u0027,"},{"line_number":117,"context_line":"               help\u003d_(\u0027Name of key loaded \u0027"},{"line_number":118,"context_line":"                      \u0027on amphora at boot.\u0027)),"},{"line_number":119,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_25a91a7c","line":116,"in_reply_to":"7a016987_e6947ee9","updated":"2015-05-15 20:10:17.000000000","message":"removed","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"706dc828197742512216b0d8dfec6735b894db66","unresolved":false,"context_lines":[{"line_number":122,"context_line":"               help\u003d_(\"The port to bind to\")),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027client_cert\u0027, default\u003d\u0027/etc/octavia/certs/client.pem\u0027,"},{"line_number":124,"context_line":"               help\u003d(\"The client certificate to use\")),"},{"line_number":125,"context_line":"    cfg.StrOpt(\u0027server_ca\u0027, default\u003d\u0027/etc/octavia/certs/ca_01.pem\u0027,"},{"line_number":126,"context_line":"               help\u003d(\"The server ca to use\")),"},{"line_number":127,"context_line":"]"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_2693b6fc","line":125,"updated":"2015-05-13 23:52:58.000000000","message":"ca_01.pem is an interesting default name -- does this imply there are multiple CA pem files?","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d4eba1ef2ae4dc7a43dd1098ca8910bd10e8f3da","unresolved":false,"context_lines":[{"line_number":122,"context_line":"               help\u003d_(\"The port to bind to\")),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027client_cert\u0027, default\u003d\u0027/etc/octavia/certs/client.pem\u0027,"},{"line_number":124,"context_line":"               help\u003d(\"The client certificate to use\")),"},{"line_number":125,"context_line":"    cfg.StrOpt(\u0027server_ca\u0027, default\u003d\u0027/etc/octavia/certs/ca_01.pem\u0027,"},{"line_number":126,"context_line":"               help\u003d(\"The server ca to use\")),"},{"line_number":127,"context_line":"]"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_857d6e1e","line":125,"in_reply_to":"7a016987_2693b6fc","updated":"2015-05-15 20:10:17.000000000","message":"you will have a ca for the client certs the agent server validates against + a ca for the server cert which the client uses to validate --- for simplicity on devstack client and server use the same ca","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"706dc828197742512216b0d8dfec6735b894db66","unresolved":false,"context_lines":[{"line_number":183,"context_line":"cfg.CONF.register_opts(oslo_messaging_opts, group\u003d\u0027oslo_messaging\u0027)"},{"line_number":184,"context_line":"cfg.CONF.register_opts(haproxy_amphora_opts, group\u003d\u0027haproxy_amphora\u0027)"},{"line_number":185,"context_line":"cfg.CONF.register_opts(controller_worker_opts, group\u003d\u0027controller_worker\u0027)"},{"line_number":186,"context_line":"cfg.CONF.register_opts(task_flow_opts, group\u003d\u0027task_flow\u0027)"},{"line_number":187,"context_line":"cfg.CONF.register_cli_opts(core_cli_opts)"},{"line_number":188,"context_line":"cfg.CONF.import_group(\u0027keystone_authtoken\u0027, \u0027keystonemiddleware.auth_token\u0027)"},{"line_number":189,"context_line":"cfg.CONF.register_opts(keystone_authtoken_v3_opts,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_66776ed5","line":186,"updated":"2015-05-13 23:52:58.000000000","message":"Why did oslo_messaging_opts stop being registered, as part of the REST API change?","commit_id":"061f497d62b58f3170ba8964473ee13a53a0f091"}],"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            create_amphora_flow.add(compute_tasks.ComputeCreate("},{"line_number":60,"context_line":"                requires\u003d(constants.AMPHORA_ID),"},{"line_number":61,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":62,"context_line":"        create_amphora_flow.add(database_tasks.MarkAmphoraBootingInDB("},{"line_number":63,"context_line":"            requires\u003d(constants.AMPHORA_ID, constants.COMPUTE_ID)))"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_a9d30503","line":60,"updated":"2015-06-25 08:12:20.000000000","message":"Why did you add parens here around constants.AMPHORA_ID?","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            create_amphora_flow.add(compute_tasks.ComputeCreate("},{"line_number":60,"context_line":"                requires\u003d(constants.AMPHORA_ID),"},{"line_number":61,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":62,"context_line":"        create_amphora_flow.add(database_tasks.MarkAmphoraBootingInDB("},{"line_number":63,"context_line":"            requires\u003d(constants.AMPHORA_ID, constants.COMPUTE_ID)))"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_4f17b9ed","line":60,"in_reply_to":"fa32b979_a9d30503","updated":"2015-06-29 03:53:54.000000000","message":"Done","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            create_amp_for_lb_flow.add(compute_tasks.ComputeCreate("},{"line_number":102,"context_line":"                requires\u003d(constants.AMPHORA_ID),"},{"line_number":103,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":104,"context_line":"        create_amp_for_lb_flow.add(database_tasks.UpdateAmphoraComputeId("},{"line_number":105,"context_line":"            requires\u003d(constants.AMPHORA_ID, constants.COMPUTE_ID)))"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_69d97d21","line":102,"updated":"2015-06-25 08:12:20.000000000","message":"Same.","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a4f0592d2365e7e94635d1ae3e05519c90fd4f63","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            create_amp_for_lb_flow.add(compute_tasks.ComputeCreate("},{"line_number":102,"context_line":"                requires\u003d(constants.AMPHORA_ID),"},{"line_number":103,"context_line":"                provides\u003dconstants.COMPUTE_ID))"},{"line_number":104,"context_line":"        create_amp_for_lb_flow.add(database_tasks.UpdateAmphoraComputeId("},{"line_number":105,"context_line":"            requires\u003d(constants.AMPHORA_ID, constants.COMPUTE_ID)))"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_0fd8d152","line":102,"in_reply_to":"fa32b979_69d97d21","updated":"2015-06-29 03:53:54.000000000","message":"Done","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"}],"test-requirements.txt":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f7f901b1bb727dc6fc4cfa9aecb811b616315321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fa32b979_8942c1a9","line":19,"updated":"2015-06-25 08:12:20.000000000","message":"ULTRA-NITPICK again, same reason, extra blank line. :P","commit_id":"ca54c34a0d40122a6484ee4b2a633d755b6a4764"}]}
