)]}'
{"octavia/amphorae/drivers/noop_driver/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3ab7f1e9a24f8819d8e9006d94b37a06bb3455c0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.driver \u003d NoopManager()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_logger(self):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        raise NotImplementedError"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def update(self, listener, vip):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_08a362b3","line":95,"updated":"2015-04-09 23:56:23.000000000","message":"Err, shouldn\u0027t this get, you know, the logger? \u003e_\u003e","commit_id":"44e33e15c53e9162706c090e4ed78e73fcefe798"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"167113773ae42f2c807e40dd7d2ea4b85754f7e9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.driver \u003d NoopManager()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_logger(self):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        raise NotImplementedError"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def update(self, listener, vip):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_3e565c2a","line":95,"in_reply_to":"9aa53dc9_08a362b3","updated":"2015-04-10 02:20:33.000000000","message":"yeah this method should be removed, and if its in the abstract class remvoed from that, and any implementations.","commit_id":"44e33e15c53e9162706c090e4ed78e73fcefe798"}],"octavia/tests/unit/amphorae/drivers/test_noop_amphoraloadbalancer_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3ab7f1e9a24f8819d8e9006d94b37a06bb3455c0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.vip \u003d models.Vip()"},{"line_number":50,"context_line":"        self.vip.ip_address \u003d \"10.0.0.1\""},{"line_number":51,"context_line":"        self.amphora \u003d models.Amphora()"},{"line_number":52,"context_line":"        self.amphora.id \u003d self.FAKE_UUID_1"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_update(self):"},{"line_number":55,"context_line":"        self.driver.update(self.listener, self.vip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_68942e42","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":20},"updated":"2015-04-09 23:56:23.000000000","message":"Why did that test go away? Now you\u0027re setting the log, but not testing it or allowing it to be retrieved? I am confused.","commit_id":"44e33e15c53e9162706c090e4ed78e73fcefe798"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"167113773ae42f2c807e40dd7d2ea4b85754f7e9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.vip \u003d models.Vip()"},{"line_number":50,"context_line":"        self.vip.ip_address \u003d \"10.0.0.1\""},{"line_number":51,"context_line":"        self.amphora \u003d models.Amphora()"},{"line_number":52,"context_line":"        self.amphora.id \u003d self.FAKE_UUID_1"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_update(self):"},{"line_number":55,"context_line":"        self.driver.update(self.listener, self.vip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_1e53983a","line":52,"in_reply_to":"9aa53dc9_68942e42","updated":"2015-04-10 02:20:33.000000000","message":"where\u0027s the log being set?","commit_id":"44e33e15c53e9162706c090e4ed78e73fcefe798"}]}