)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network noop driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. implement methods in noopr_driver/driver.py"},{"line_number":10,"context_line":"2. add unit test class in test_network_noop_driver"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I48cf1c051e7d3427b918f686bf8788c077e7d829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_5e9f8a5f","line":9,"updated":"2015-04-10 23:46:17.000000000","message":"nit: typo\n1. implement methods in noop_driver/driver.py","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network noop driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. implement methods in noopr_driver/driver.py"},{"line_number":10,"context_line":"2. add unit test class in test_network_noop_driver"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I48cf1c051e7d3427b918f686bf8788c077e7d829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_be39ee43","line":9,"in_reply_to":"7aaa499b_5e9f8a5f","updated":"2015-04-10 23:56:29.000000000","message":"will do","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c6d8709ec5ebc1c0d4813872946a56af4f57d5f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network noop driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. implement methods in noopr_driver/driver.py"},{"line_number":10,"context_line":"2. add unit test class in test_network_noop_driver"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I48cf1c051e7d3427b918f686bf8788c077e7d829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aaa499b_be3faed5","line":9,"updated":"2015-04-11 00:18:17.000000000","message":"This typo is still here","commit_id":"c50207446bde52488edfa9181ddc9a33e8320621"}],"octavia/network/drivers/noop_driver/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027devstack\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_de815afd","line":1,"updated":"2015-04-10 23:46:17.000000000","message":"This should be blank","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027devstack\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_de34ba4b","line":1,"in_reply_to":"7aaa499b_de815afd","updated":"2015-04-10 23:56:29.000000000","message":"will do","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"}],"octavia/network/drivers/noop_driver/driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014,  Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_be868e11","line":1,"updated":"2015-04-10 23:46:17.000000000","message":"This is not right.\n\n# Copyright 2015 Hewlett-Packard Development Company, L.P.","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014,  Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_5e49cacf","line":1,"in_reply_to":"7aaa499b_be868e11","updated":"2015-04-10 23:56:29.000000000","message":"will do","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.networkconfigconfig \u003d {}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def allocate_vip(self, port_id\u003dNone, network_id\u003dNone, ip_address\u003dNone):"},{"line_number":28,"context_line":"        LOG.debug(\"Network % no-op, allocate port_id %s, network_id %s,\""},{"line_number":29,"context_line":"                  \"ip_address %s\","},{"line_number":30,"context_line":"                  self.__class__.__name__, port_id, network_id, ip_address)"},{"line_number":31,"context_line":"        self.networkconfigconfig[(port_id, network_id, ip_address)] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_deaf1a7c","line":28,"updated":"2015-04-10 23:46:17.000000000","message":"Typo:\nLOG.debug(\"Network % no-op, allocate_vip port_id %s, network_id %s,\"","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.networkconfigconfig \u003d {}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def allocate_vip(self, port_id\u003dNone, network_id\u003dNone, ip_address\u003dNone):"},{"line_number":28,"context_line":"        LOG.debug(\"Network % no-op, allocate port_id %s, network_id %s,\""},{"line_number":29,"context_line":"                  \"ip_address %s\","},{"line_number":30,"context_line":"                  self.__class__.__name__, port_id, network_id, ip_address)"},{"line_number":31,"context_line":"        self.networkconfigconfig[(port_id, network_id, ip_address)] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_fe1656a6","line":28,"in_reply_to":"7aaa499b_deaf1a7c","updated":"2015-04-10 23:56:29.000000000","message":"will do","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            port_id, network_id, ip_address, \u0027allocate_vip\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":35,"context_line":"        LOG.debug(\"Network %s ,deallocate_vip no-op,vip %s\","},{"line_number":36,"context_line":"                  self.__class__.__name__, vip.ip_address)"},{"line_number":37,"context_line":"        self.networkconfigconfig[vip.ip_address] \u003d (vip,"},{"line_number":38,"context_line":"                                                    \u0027deallocate_vip\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_1eb6a2dc","line":35,"updated":"2015-04-10 23:46:17.000000000","message":"This log format is different than the others.  Can we update it:\nLOG.debug(\"Network %s no-op, deallocate_vip vip %s\",","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            port_id, network_id, ip_address, \u0027allocate_vip\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":35,"context_line":"        LOG.debug(\"Network %s ,deallocate_vip no-op,vip %s\","},{"line_number":36,"context_line":"                  self.__class__.__name__, vip.ip_address)"},{"line_number":37,"context_line":"        self.networkconfigconfig[vip.ip_address] \u003d (vip,"},{"line_number":38,"context_line":"                                                    \u0027deallocate_vip\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_be10cea9","line":35,"in_reply_to":"7aaa499b_1eb6a2dc","updated":"2015-04-10 23:56:29.000000000","message":"will do","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def plug_network(self, amphora_id, network_id, ip_address\u003dNone):"},{"line_number":57,"context_line":"        LOG.debug(\"Network %s no-op, plug_network amphora_id %s, network_id \""},{"line_number":58,"context_line":"                  \"%s, \""},{"line_number":59,"context_line":"                  \"ip_address %s\","},{"line_number":60,"context_line":"                  self.__class__.__name__,"},{"line_number":61,"context_line":"                  amphora_id, network_id, ip_address)"},{"line_number":62,"context_line":"        self.networkconfigconfig[(amphora_id, network_id, ip_address)] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_be9d6e5b","line":59,"updated":"2015-04-10 23:46:17.000000000","message":"This line and the line above can be concatenated","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def plug_network(self, amphora_id, network_id, ip_address\u003dNone):"},{"line_number":57,"context_line":"        LOG.debug(\"Network %s no-op, plug_network amphora_id %s, network_id \""},{"line_number":58,"context_line":"                  \"%s, \""},{"line_number":59,"context_line":"                  \"ip_address %s\","},{"line_number":60,"context_line":"                  self.__class__.__name__,"},{"line_number":61,"context_line":"                  amphora_id, network_id, ip_address)"},{"line_number":62,"context_line":"        self.networkconfigconfig[(amphora_id, network_id, ip_address)] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_3e1ddebd","line":59,"in_reply_to":"7aaa499b_be9d6e5b","updated":"2015-04-10 23:56:29.000000000","message":"will do","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c6d8709ec5ebc1c0d4813872946a56af4f57d5f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014,  Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_9e2512c4","line":1,"updated":"2015-04-11 00:18:17.000000000","message":"This still needs fixed.","commit_id":"c50207446bde52488edfa9181ddc9a33e8320621"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c6d8709ec5ebc1c0d4813872946a56af4f57d5f5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            port_id, network_id, ip_address, \u0027allocate_vip\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":35,"context_line":"        LOG.debug(\"Network %s no-op ,deallocate_vip no-op,vip %s\","},{"line_number":36,"context_line":"                  self.__class__.__name__, vip.ip_address)"},{"line_number":37,"context_line":"        self.networkconfigconfig[vip.ip_address] \u003d (vip,"},{"line_number":38,"context_line":"                                                    \u0027deallocate_vip\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_3e2cbeaa","line":35,"updated":"2015-04-11 00:18:17.000000000","message":"Please remove the second no-op","commit_id":"c50207446bde52488edfa9181ddc9a33e8320621"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"abedcc1e3bd784f75013d4a7298e8dd5e55945a0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.networkconfigconfig \u003d {}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def allocate_vip(self, port_id\u003dNone, network_id\u003dNone, ip_address\u003dNone):"},{"line_number":28,"context_line":"        LOG.debug(\"Network % no-op, allocate_vip port_id %s, network_id %s,\""},{"line_number":29,"context_line":"                  \"ip_address %s\","},{"line_number":30,"context_line":"                  self.__class__.__name__, port_id, network_id, ip_address)"},{"line_number":31,"context_line":"        self.networkconfigconfig[(port_id, network_id, ip_address)] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_fdbaca6d","line":28,"updated":"2015-04-13 07:04:24.000000000","message":"\"Network % no-op\"","commit_id":"9f0707cdca74361c7fe7dc32f8c600919c480e85"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"97e4f93c1a49f4ce08ba56db1316276b321006fe","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.networkconfigconfig \u003d {}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def allocate_vip(self, port_id\u003dNone, network_id\u003dNone, ip_address\u003dNone):"},{"line_number":28,"context_line":"        LOG.debug(\"Network % no-op, allocate_vip port_id %s, network_id %s,\""},{"line_number":29,"context_line":"                  \"ip_address %s\","},{"line_number":30,"context_line":"                  self.__class__.__name__, port_id, network_id, ip_address)"},{"line_number":31,"context_line":"        self.networkconfigconfig[(port_id, network_id, ip_address)] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_3f93715d","line":28,"in_reply_to":"7aaa499b_fdbaca6d","updated":"2015-04-13 17:21:30.000000000","message":"will correct, thanks for the input Adam","commit_id":"9f0707cdca74361c7fe7dc32f8c600919c480e85"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"abedcc1e3bd784f75013d4a7298e8dd5e55945a0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            port_id, network_id, ip_address, \u0027allocate_vip\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":35,"context_line":"        LOG.debug(\"Network %s no-op ,deallocate_vip vip %s\","},{"line_number":36,"context_line":"                  self.__class__.__name__, vip.ip_address)"},{"line_number":37,"context_line":"        self.networkconfigconfig[vip.ip_address] \u003d (vip,"},{"line_number":38,"context_line":"                                                    \u0027deallocate_vip\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_5d12deb5","line":35,"range":{"start_line":35,"start_character":35,"end_line":35,"end_character":36},"updated":"2015-04-13 07:04:24.000000000","message":"Sorry for another pedantic comment, but there seems to be a typo here: comma after a space.","commit_id":"9f0707cdca74361c7fe7dc32f8c600919c480e85"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"97e4f93c1a49f4ce08ba56db1316276b321006fe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            port_id, network_id, ip_address, \u0027allocate_vip\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":35,"context_line":"        LOG.debug(\"Network %s no-op ,deallocate_vip vip %s\","},{"line_number":36,"context_line":"                  self.__class__.__name__, vip.ip_address)"},{"line_number":37,"context_line":"        self.networkconfigconfig[vip.ip_address] \u003d (vip,"},{"line_number":38,"context_line":"                                                    \u0027deallocate_vip\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_df880d25","line":35,"in_reply_to":"7aaa499b_5d12deb5","updated":"2015-04-13 17:21:30.000000000","message":"will change it, thank you!!","commit_id":"9f0707cdca74361c7fe7dc32f8c600919c480e85"}],"octavia/tests/unit/network/drivers/test_network_noop_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"243b5cbc22d8c5afa9c3b0aa047a1f0a803cbe6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014, Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_9e7cf221","line":1,"updated":"2015-04-10 23:46:17.000000000","message":"This is not right\n\n# Copyright 2015 Hewlett-Packard Development Company, L.P.","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"8d8ffde2750ef5ed5a599ae764ca5857b07bf4c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014, Author: Min Wang,German Eichberger"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_9e3f5225","line":1,"in_reply_to":"7aaa499b_9e7cf221","updated":"2015-04-10 23:56:29.000000000","message":"will change","commit_id":"7cca7dec1c01f3984fc79720d089630d79268beb"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"abedcc1e3bd784f75013d4a7298e8dd5e55945a0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(TestNoopNetworkDriver, self).setUp()"},{"line_number":34,"context_line":"        self.driver \u003d driver.NoopNetworkDriver(LOG)"},{"line_number":35,"context_line":"        self.port_id \u003d 88"},{"line_number":36,"context_line":"        self.network_id \u003d \"10.0.0.3\""},{"line_number":37,"context_line":"        self.ip_address \u003d \"10.0.0.2\""},{"line_number":38,"context_line":"        self.load_balancer \u003d models.LoadBalancer()"},{"line_number":39,"context_line":"        self.load_balancer.id \u003d self.FAKE_UUID_2"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_3de272d6","line":36,"updated":"2015-04-13 07:04:24.000000000","message":"Is network_id supposed to be an IP or a UUID? I know this is the noop driver, so it\u0027s a bit pedantic, but this is somewhat confusing.","commit_id":"9f0707cdca74361c7fe7dc32f8c600919c480e85"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"97e4f93c1a49f4ce08ba56db1316276b321006fe","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(TestNoopNetworkDriver, self).setUp()"},{"line_number":34,"context_line":"        self.driver \u003d driver.NoopNetworkDriver(LOG)"},{"line_number":35,"context_line":"        self.port_id \u003d 88"},{"line_number":36,"context_line":"        self.network_id \u003d \"10.0.0.3\""},{"line_number":37,"context_line":"        self.ip_address \u003d \"10.0.0.2\""},{"line_number":38,"context_line":"        self.load_balancer \u003d models.LoadBalancer()"},{"line_number":39,"context_line":"        self.load_balancer.id \u003d self.FAKE_UUID_2"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_df124db4","line":36,"in_reply_to":"7aaa499b_3de272d6","updated":"2015-04-13 17:21:30.000000000","message":"will change it","commit_id":"9f0707cdca74361c7fe7dc32f8c600919c480e85"}]}