)]}'
{"octavia/common/keystone.py":[{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"f3eefc2f630c92047475c19e85bc0ecd190df441","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    global _SESSION"},{"line_number":39,"context_line":"    if not _SESSION:"},{"line_number":40,"context_line":"        if cfg.CONF.keystone_authtoken.auth_version \u003d\u003d \u00272\u0027:"},{"line_number":41,"context_line":"            client \u003d v2_client"},{"line_number":42,"context_line":"            try:"},{"line_number":43,"context_line":"                kc \u003d client.Password("},{"line_number":44,"context_line":"                    auth_url\u003dcfg.CONF.keystone_authtoken.auth_uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_e9bc336e","line":41,"updated":"2015-04-20 21:32:54.000000000","message":"How is this change different from what was there? If im reading this patch right its the same thing that was there before the \u0027cleanup\u0027 happened. Also, i was mentioning to blogan that i believe the \u0027Client\u0027 should be used here for compatibility issues. Though, I havn\u0027t tested this so i cant really +/-1 and I\u0027m probably overlooking something. \n\nTake a look here to see what im referring to when i mention \u0027Client\u0027:\nhttps://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/common/cert_manager/barbican_cert_manager.py","commit_id":"eed2d1511716e97a39da7c6d196fcefe2efde375"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"13791b70a365804785da646f29dfcad525a1b4ee","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    username\u003dcfg.CONF.keystone_authtoken.admin_user,"},{"line_number":46,"context_line":"                    password\u003dcfg.CONF.keystone_authtoken.admin_password,"},{"line_number":47,"context_line":"                    tenant_name\u003dcfg.CONF.keystone_authtoken.admin_tenant_name"},{"line_number":48,"context_line":"                )"},{"line_number":49,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":50,"context_line":"            except Exception:"},{"line_number":51,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_3724c60b","line":48,"updated":"2015-04-20 22:22:46.000000000","message":"you can simplify this by checking the version before you instantiate the Password object.  if v2 us the v2_client, and build a dictionary with the kwargs for the v2_client.Password, if v3, do the same.  Then instantiate the client\n\n\nkwargs \u003d {\u0027auth_url\u0027: cfg.CONF.keystone_authtoken.auth_uri, \u003cALL COMMON\u003e)\nif v2:\n   client \u003d v2_client\n   kwargs[\u0027tenant_name\u0027] \u003d ...\nif v3:\n   client \u003d v3_client\n   kwargs[\u0027project_name\u0027] \u003d ..\n\nkc \u003d client.Password(**kwargs)","commit_id":"eed2d1511716e97a39da7c6d196fcefe2efde375"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"d7fee3accb547426f05c0f599209ee48e933c98e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                    auth_url\u003dcfg.CONF.keystone_authtoken.auth_uri,"},{"line_number":58,"context_line":"                    username\u003dcfg.CONF.keystone_authtoken.admin_user,"},{"line_number":59,"context_line":"                    password\u003dcfg.CONF.keystone_authtoken.admin_password,"},{"line_number":60,"context_line":"                    project_name\u003dcfg.CONF.keystone_authtoken.admin_tenant_name"},{"line_number":61,"context_line":"                )"},{"line_number":62,"context_line":"                _SESSION \u003d session.Session(auth\u003dkc)"},{"line_number":63,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_0c49b55f","line":60,"updated":"2015-04-20 21:35:52.000000000","message":"Ok, i didnt see the project_name change, i should have read change log. I still believe using the \u0027Client\u0027 will solve the compatibility issues between the both and keep the code DRY.","commit_id":"eed2d1511716e97a39da7c6d196fcefe2efde375"}]}
