)]}'
{"octavia/api/v1/controllers/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return self._convert_db_to_type(db_listeners,"},{"line_number":69,"context_line":"                                        [listener_types.ListenerResponse])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_lb_status_post(self, session, lb_repo):"},{"line_number":72,"context_line":"        \"\"\"Verify load balancer is in a mutable status for post method.\"\"\""},{"line_number":73,"context_line":"        if not lb_repo.test_and_set_provisioning_status("},{"line_number":74,"context_line":"                session, self.load_balancer_id, constants.PENDING_UPDATE):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_89f3699e","line":71,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":78,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def validate_listeners(self, session, lb_repo, listener_dict):"},{"line_number":81,"context_line":"        \"\"\"Validate listeners for wrong protocol or duplicate listeners.\"\"\""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            db_listener \u003d self.repositories.listener.create("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_492c3102","line":80,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return self.validate_listeners(session, lb_repo, listener_dict)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def validate_update_listener(self, session, id, listener_dict):"},{"line_number":138,"context_line":"        \"\"\"Verify load balancer is in a mutable status.\"\"\""},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            self.repositories.listener.update(session, id, **listener_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_29169da7","line":137,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        db_lb \u003d self.repositories.listener.get(session, id\u003ddb_listener.id)"},{"line_number":172,"context_line":"        return self._convert_db_to_type(db_lb, listener_types.ListenerResponse)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_lb_status_put(self, session, id):"},{"line_number":175,"context_line":"        \"\"\"Test load balancer status for put method.\"\"\""},{"line_number":176,"context_line":"        if not self.repositories.test_and_set_lb_and_listener_prov_status("},{"line_number":177,"context_line":"                session, self.load_balancer_id, id, constants.PENDING_UPDATE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_090d1990","line":174,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":78,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _validate_listeners(self, session, lb_repo, listener_dict):"},{"line_number":81,"context_line":"        \"\"\"Validate listeners for wrong protocol or duplicate listeners.\"\"\""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            db_listener \u003d self.repositories.listener.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_987a5cf0","line":80,"updated":"2015-04-24 18:09:39.000000000","message":"since this does the actual insert into the db, at least change the docstring to say it does that.","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":78,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _validate_listeners(self, session, lb_repo, listener_dict):"},{"line_number":81,"context_line":"        \"\"\"Validate listeners for wrong protocol or duplicate listeners.\"\"\""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            db_listener \u003d self.repositories.listener.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_082397a8","line":80,"in_reply_to":"bab921fb_987a5cf0","updated":"2015-04-25 00:13:23.000000000","message":"added","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return self._validate_listeners(session, lb_repo, listener_dict)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _validate_update_listener(self, session, id, listener_dict):"},{"line_number":138,"context_line":"        \"\"\"Verify load balancer is in a mutable status.\"\"\""},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            self.repositories.listener.update(session, id, **listener_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_186f6c2c","line":137,"updated":"2015-04-24 18:09:39.000000000","message":"this method probably won\u0027t even been needed once this review gets merged\n\nhttps://review.openstack.org/#/c/170989/","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return self._validate_listeners(session, lb_repo, listener_dict)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _validate_update_listener(self, session, id, listener_dict):"},{"line_number":138,"context_line":"        \"\"\"Verify load balancer is in a mutable status.\"\"\""},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            self.repositories.listener.update(session, id, **listener_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_882fa787","line":137,"in_reply_to":"bab921fb_186f6c2c","updated":"2015-04-25 00:13:23.000000000","message":"have changed it back","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"}],"octavia/api/v1/controllers/pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return self._convert_db_to_type(default_pool,"},{"line_number":66,"context_line":"                                        [pool_types.PoolResponse])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_lb_status(self, session):"},{"line_number":69,"context_line":"        \"\"\"Verify load balancer is in a mutable status.\"\"\""},{"line_number":70,"context_line":"        if not self.repositories.test_and_set_lb_and_listener_prov_status("},{"line_number":71,"context_line":"                session, self.load_balancer_id, self.listener_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_892129fe","line":68,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":78,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def validate_create_pool(self, session, sp_dict, pool_dict):"},{"line_number":81,"context_line":"        \"\"\"Validate creating pool on load balancer.\"\"\""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            db_pool \u003d self.repositories.create_pool_on_listener("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_497af1f2","line":80,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return self.validate_create_pool(session, sp_dict, pool_dict)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_lb_status_put(self, session):"},{"line_number":137,"context_line":"        \"\"\"Verify load balancer is in a mutable status for put method.\"\"\""},{"line_number":138,"context_line":"        if not self.repositories.test_and_set_lb_and_listener_prov_status("},{"line_number":139,"context_line":"                session, self.load_balancer_id, self.listener_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_c96e012f","line":136,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":146,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def validate_update_pool(self, session, id, pool_dict, sp_dict):"},{"line_number":149,"context_line":"        \"\"\"Validate update pool.\"\"\""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            self.repositories.update_pool_on_listener(session, id, pool_dict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_4961d138","line":148,"updated":"2015-04-23 23:44:19.000000000","message":"This should start with _ as they are only locally used.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _validate_create_pool(self, session, sp_dict, pool_dict):"},{"line_number":81,"context_line":"        \"\"\"Validate creating pool on load balancer.\"\"\""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            db_pool \u003d self.repositories.create_pool_on_listener("},{"line_number":84,"context_line":"                session, self.listener_id, pool_dict, sp_dict\u003dsp_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_b802c009","line":81,"updated":"2015-04-24 18:09:39.000000000","message":"docstring that mentions it is actually doing db calls","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _validate_create_pool(self, session, sp_dict, pool_dict):"},{"line_number":81,"context_line":"        \"\"\"Validate creating pool on load balancer.\"\"\""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            db_pool \u003d self.repositories.create_pool_on_listener("},{"line_number":84,"context_line":"                session, self.listener_id, pool_dict, sp_dict\u003dsp_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_c8aebfe5","line":81,"in_reply_to":"bab921fb_b802c009","updated":"2015-04-25 00:13:23.000000000","message":"will do","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":146,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _validate_update_pool(self, session, id, pool_dict, sp_dict):"},{"line_number":149,"context_line":"        \"\"\"Validate update pool.\"\"\""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            self.repositories.update_pool_on_listener(session, id, pool_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_f808382f","line":148,"updated":"2015-04-24 18:09:39.000000000","message":"this method will end up not being necessary after this review get merged:\n\nhttps://review.openstack.org/#/c/170989/","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":146,"context_line":"                                             id\u003dself.load_balancer_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _validate_update_pool(self, session, id, pool_dict, sp_dict):"},{"line_number":149,"context_line":"        \"\"\"Validate update pool.\"\"\""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            self.repositories.update_pool_on_listener(session, id, pool_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_5c54adfd","line":148,"in_reply_to":"bab921fb_f808382f","updated":"2015-04-25 00:13:23.000000000","message":"have changed it back","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"}],"octavia/certificates/generator/local.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782af80a1e26c1e27760fa3652a1927ee2adda02","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _new_serial(cls):"},{"line_number":39,"context_line":"        return int(binascii.hexlify(os.urandom(20)), 16)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def validate_cert(cls, ca_cert, ca_key, ca_key_pass):"},{"line_number":43,"context_line":"        if not ca_cert:"},{"line_number":44,"context_line":"            LOG.info(_LI(\"Using CA Certificate from config.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_c95f2140","line":41,"updated":"2015-04-23 23:44:19.000000000","message":"I don\u0027t think this needs/should be a classmethod but I might be wrong.","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"98c3d51a8b9a7f0f48ce0c03601f59c3c563e411","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _new_serial(cls):"},{"line_number":39,"context_line":"        return int(binascii.hexlify(os.urandom(20)), 16)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def validate_cert(cls, ca_cert, ca_key, ca_key_pass):"},{"line_number":43,"context_line":"        if not ca_cert:"},{"line_number":44,"context_line":"            LOG.info(_LI(\"Using CA Certificate from config.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_d497b48e","line":41,"in_reply_to":"bab921fb_c95f2140","updated":"2015-04-23 23:51:28.000000000","message":"probably should be private as well aka _validate_cert","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"}],"octavia/common/config.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"core_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,  # NOSONAR"},{"line_number":34,"context_line":"               help\u003d_(\"The host IP to bind to\")),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027bind_port\u0027, default\u003d9876,"},{"line_number":36,"context_line":"               help\u003d_(\"The port to bind to\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_984b7c87","line":33,"updated":"2015-04-24 18:09:39.000000000","message":"are we going to start allowing these types of comment directives for tools anyone wants to use?","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"20206900cde9458adeedd1c6d055590920746f4b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"core_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,  # NOSONAR"},{"line_number":34,"context_line":"               help\u003d_(\"The host IP to bind to\")),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027bind_port\u0027, default\u003d9876,"},{"line_number":36,"context_line":"               help\u003d_(\"The port to bind to\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_fc8b81c1","line":33,"in_reply_to":"bab921fb_984b7c87","updated":"2015-04-24 23:10:32.000000000","message":"I feel a bit dirty about this too (though I told Min how to do this).\nI am in favor of running tools to help us improve code quality, but I also don\u0027t want to end up with a ton of strange test tool comments in the code.\nEven worse this is a workaround for a false positive in the test tool (it says to make the IP configurable).\nI lean towards removing these since it isn\u0027t a tool openstack is using.","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"}],"octavia/common/constants.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"ERROR \u003d \u0027ERROR\u0027"},{"line_number":46,"context_line":"SUPPORTED_PROVISIONING_STATUSES \u003d (ACTIVE, PENDING_DELETE, PENDING_CREATE,"},{"line_number":47,"context_line":"                                   PENDING_UPDATE, DELETED, ERROR)"},{"line_number":48,"context_line":"MUTABLE_STATUSES \u003d ACTIVE"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"ONLINE \u003d \u0027ONLINE\u0027"},{"line_number":51,"context_line":"OFFLINE \u003d \u0027OFFLINE\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_58d284d3","line":48,"updated":"2015-04-24 18:09:39.000000000","message":"well the original use of the parentheses was wrong anyway as it should have been (ACTIVE,) because (ACTIVE) is just the string, not a tuple.  But i think the original intent was to put this in a tuple or it would be a plural variable name, so I think this should just be (ACTIVE,)","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"ERROR \u003d \u0027ERROR\u0027"},{"line_number":46,"context_line":"SUPPORTED_PROVISIONING_STATUSES \u003d (ACTIVE, PENDING_DELETE, PENDING_CREATE,"},{"line_number":47,"context_line":"                                   PENDING_UPDATE, DELETED, ERROR)"},{"line_number":48,"context_line":"MUTABLE_STATUSES \u003d ACTIVE"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"ONLINE \u003d \u0027ONLINE\u0027"},{"line_number":51,"context_line":"OFFLINE \u003d \u0027OFFLINE\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_22ae7298","line":48,"in_reply_to":"bab921fb_58d284d3","updated":"2015-04-25 00:13:23.000000000","message":"will do","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"6dd1b0818917993ea1b3a746754582823b00cb88","unresolved":false,"context_lines":[{"line_number":45,"context_line":"ERROR \u003d \u0027ERROR\u0027"},{"line_number":46,"context_line":"SUPPORTED_PROVISIONING_STATUSES \u003d (ACTIVE, PENDING_DELETE, PENDING_CREATE,"},{"line_number":47,"context_line":"                                   PENDING_UPDATE, DELETED, ERROR)"},{"line_number":48,"context_line":"MUTABLE_STATUSES \u003d (ACTIVE)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"ONLINE \u003d \u0027ONLINE\u0027"},{"line_number":51,"context_line":"OFFLINE \u003d \u0027OFFLINE\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_301d18be","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":16},"updated":"2015-04-27 15:56:28.000000000","message":"Still didn\u0027t actually fix this -- it needs to be (ACTIVE,) to be a tuple.","commit_id":"4ee78636d5c252c5356369d3eac7da4d047b8b48"}],"octavia/common/tls_utils/cert_parser.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"98c3d51a8b9a7f0f48ce0c03601f59c3c563e411","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _read_privatekey(privatekey_pem, passphrase\u003dNone):"},{"line_number":60,"context_line":"    def get_passphrase(*args):"},{"line_number":61,"context_line":"        if passphrase:"},{"line_number":62,"context_line":"            return six.b(passphrase)"},{"line_number":63,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_f4f638f8","line":60,"updated":"2015-04-23 23:51:28.000000000","message":"_ private","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"98c3d51a8b9a7f0f48ce0c03601f59c3c563e411","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    x509 \u003d _get_x509_from_pem_bytes(certificate)"},{"line_number":105,"context_line":"    hostnames \u003d {}"},{"line_number":106,"context_line":"    if hasattr(x509.get_subject(), \u0027CN\u0027):"},{"line_number":107,"context_line":"        hostnames[\u0027cn\u0027] \u003d x509.get_subject().CN"},{"line_number":108,"context_line":"    hostnames[\u0027dns_names\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_54d16456","line":105,"updated":"2015-04-23 23:51:28.000000000","message":"usually I prefer host_names but in this context that will likely work","commit_id":"6ce6d4baeb5973698a0769d72d2d485aa32bf486"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"73d337844c3f4e0c4ab6925512a65244d57fceaa","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    x509 \u003d _get_x509_from_pem_bytes(certificate)"},{"line_number":105,"context_line":"    host_names \u003d {}"},{"line_number":106,"context_line":"    if hasattr(x509.get_subject(), \u0027CN\u0027):"},{"line_number":107,"context_line":"        host_names[\u0027cn\u0027] \u003d x509.get_subject().CN"},{"line_number":108,"context_line":"    host_names[\u0027dns_names\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_ee92b29e","line":105,"updated":"2015-04-24 18:36:16.000000000","message":"nit:  I don\u0027t think a distinction is necessary here, personally \"hostnames\" is an appropriate variable name.","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    x509 \u003d _get_x509_from_pem_bytes(certificate)"},{"line_number":105,"context_line":"    host_names \u003d {}"},{"line_number":106,"context_line":"    if hasattr(x509.get_subject(), \u0027CN\u0027):"},{"line_number":107,"context_line":"        host_names[\u0027cn\u0027] \u003d x509.get_subject().CN"},{"line_number":108,"context_line":"    host_names[\u0027dns_names\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_02424eae","line":105,"in_reply_to":"bab921fb_64f24171","updated":"2015-04-25 00:13:23.000000000","message":"change it to be hostnames","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"22be0a1dc0bd2b1d10202633bc6ef345ed1eb25c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    x509 \u003d _get_x509_from_pem_bytes(certificate)"},{"line_number":105,"context_line":"    host_names \u003d {}"},{"line_number":106,"context_line":"    if hasattr(x509.get_subject(), \u0027CN\u0027):"},{"line_number":107,"context_line":"        host_names[\u0027cn\u0027] \u003d x509.get_subject().CN"},{"line_number":108,"context_line":"    host_names[\u0027dns_names\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_64f24171","line":105,"in_reply_to":"bab921fb_ee92b29e","updated":"2015-04-24 20:03:21.000000000","message":"not camel case though, as it was in the original","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"}],"octavia/common/utils.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"73d337844c3f4e0c4ab6925512a65244d57fceaa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Borrowed from nova code base, more utilities will be added/borrowed as and"},{"line_number":17,"context_line":"# when needed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\"Utilities and helper functions.\"\"\""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_eec0727e","line":17,"updated":"2015-04-24 18:36:16.000000000","message":"Is this comment needed?","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    return rndstr[0:length]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class Exception_logger(object):"},{"line_number":52,"context_line":"    \"\"\"Wrap a function and log raised exception"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    :param logger: the logger to log the exception default is LOG.exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_78f2e870","line":51,"updated":"2015-04-24 18:09:39.000000000","message":"i believe the original intent of the naming convent of htis is becaause this is a decorator that would decorate a method, and doing @ExceptionLogger doesn\u0027t conform to decorator convention of using snakecase like @exception_logger would.","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"73d337844c3f4e0c4ab6925512a65244d57fceaa","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    return rndstr[0:length]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class Exception_logger(object):"},{"line_number":52,"context_line":"    \"\"\"Wrap a function and log raised exception"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    :param logger: the logger to log the exception default is LOG.exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_aee39a32","line":51,"in_reply_to":"bab921fb_78f2e870","updated":"2015-04-24 18:36:16.000000000","message":"If at some point we decide this should be camel case instead, it wouldn\u0027t include an underscore, and would be how Brandon said above:  \"ExceptionLogger\"","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    return rndstr[0:length]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class Exception_logger(object):"},{"line_number":52,"context_line":"    \"\"\"Wrap a function and log raised exception"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    :param logger: the logger to log the exception default is LOG.exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_6267ca4d","line":51,"in_reply_to":"bab921fb_aee39a32","updated":"2015-04-25 00:13:23.000000000","message":"will change back to exception_logger","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"}],"octavia/db/base_models.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"73d337844c3f4e0c4ab6925512a65244d57fceaa","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            attr \u003d getattr(self, attr_name)"},{"line_number":41,"context_line":"            if isinstance(attr, OctaviaBase)and attr.__class__ !\u003d _calling_cls:"},{"line_number":42,"context_line":"                    dm_kwargs[attr_name] \u003d attr.to_data_model("},{"line_number":43,"context_line":"                        _calling_cls\u003dself.__class__)"},{"line_number":44,"context_line":"            elif isinstance(attr, collections.InstrumentedList):"},{"line_number":45,"context_line":"                dm_kwargs[attr_name] \u003d []"},{"line_number":46,"context_line":"                for item in attr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_4e42be11","line":43,"updated":"2015-04-24 18:36:16.000000000","message":"After combining here, you can de-indent the body once.","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            attr \u003d getattr(self, attr_name)"},{"line_number":41,"context_line":"            if isinstance(attr, OctaviaBase)and attr.__class__ !\u003d _calling_cls:"},{"line_number":42,"context_line":"                    dm_kwargs[attr_name] \u003d attr.to_data_model("},{"line_number":43,"context_line":"                        _calling_cls\u003dself.__class__)"},{"line_number":44,"context_line":"            elif isinstance(attr, collections.InstrumentedList):"},{"line_number":45,"context_line":"                dm_kwargs[attr_name] \u003d []"},{"line_number":46,"context_line":"                for item in attr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_3dfc5371","line":43,"in_reply_to":"bab921fb_4e42be11","updated":"2015-04-25 00:13:23.000000000","message":"have changed","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"73d337844c3f4e0c4ab6925512a65244d57fceaa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                dm_kwargs[attr_name] \u003d []"},{"line_number":46,"context_line":"                for item in attr:"},{"line_number":47,"context_line":"                    if isinstance(item, OctaviaBase"},{"line_number":48,"context_line":"                                  )and attr.__class__ !\u003d _calling_cls:"},{"line_number":49,"context_line":"                            dm_kwargs[attr_name].append("},{"line_number":50,"context_line":"                                item.to_data_model("},{"line_number":51,"context_line":"                                    _calling_cls\u003dself.__class__))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_ce6dae99","line":48,"updated":"2015-04-24 18:36:16.000000000","message":"I think you can leave the parenthesis at the end of \"OctaviaBase\" and then new-line the \"and\" portion of the conditional.  If you decide to keep it the way it is, it needs a space before \"and\"","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                dm_kwargs[attr_name] \u003d []"},{"line_number":46,"context_line":"                for item in attr:"},{"line_number":47,"context_line":"                    if isinstance(item, OctaviaBase"},{"line_number":48,"context_line":"                                  )and attr.__class__ !\u003d _calling_cls:"},{"line_number":49,"context_line":"                            dm_kwargs[attr_name].append("},{"line_number":50,"context_line":"                                item.to_data_model("},{"line_number":51,"context_line":"                                    _calling_cls\u003dself.__class__))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_3d81f3c3","line":48,"in_reply_to":"bab921fb_ce6dae99","updated":"2015-04-25 00:13:23.000000000","message":"I tried to do that, and pep8 complains","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"6dd1b0818917993ea1b3a746754582823b00cb88","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      if not attr_name.startswith(\u0027_\u0027)]"},{"line_number":39,"context_line":"        for attr_name in attr_names:"},{"line_number":40,"context_line":"            attr \u003d getattr(self, attr_name)"},{"line_number":41,"context_line":"            if isinstance(attr, OctaviaBase)and attr.__class__ !\u003d _calling_cls:"},{"line_number":42,"context_line":"                dm_kwargs[attr_name] \u003d attr.to_data_model("},{"line_number":43,"context_line":"                    _calling_cls\u003dself.__class__)"},{"line_number":44,"context_line":"            elif isinstance(attr, collections.InstrumentedList):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_d09ee406","line":41,"updated":"2015-04-27 15:56:28.000000000","message":"space before \"and\"","commit_id":"4ee78636d5c252c5356369d3eac7da4d047b8b48"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"6dd1b0818917993ea1b3a746754582823b00cb88","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                dm_kwargs[attr_name] \u003d []"},{"line_number":46,"context_line":"                for item in attr:"},{"line_number":47,"context_line":"                    if isinstance(item, OctaviaBase"},{"line_number":48,"context_line":"                                  )and attr.__class__ !\u003d _calling_cls:"},{"line_number":49,"context_line":"                        dm_kwargs[attr_name].append("},{"line_number":50,"context_line":"                            item.to_data_model("},{"line_number":51,"context_line":"                                _calling_cls\u003dself.__class__))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_b0a3684f","line":48,"updated":"2015-04-27 15:56:28.000000000","message":"space before \"and\"","commit_id":"4ee78636d5c252c5356369d3eac7da4d047b8b48"}],"octavia/hacking/checks.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e77c2f146f92e4d1209dd6baee2acb203ac7dae8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    * This check assumes that \u0027LOG\u0027 is a logger."},{"line_number":117,"context_line":"    O319"},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    if _directory_to_check_translation(filename)and logical_line.startswith("},{"line_number":120,"context_line":"            \"LOG.debug(_(\"):"},{"line_number":121,"context_line":"            yield(0, \"O319 Don\u0027t translate debug level logs\")"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_38ec708e","line":119,"updated":"2015-04-24 18:09:39.000000000","message":"should be a space before the and","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"3e88b48eff610b348cdd38516ff47c0709fecf2d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    * This check assumes that \u0027LOG\u0027 is a logger."},{"line_number":117,"context_line":"    O319"},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    if _directory_to_check_translation(filename)and logical_line.startswith("},{"line_number":120,"context_line":"            \"LOG.debug(_(\"):"},{"line_number":121,"context_line":"            yield(0, \"O319 Don\u0027t translate debug level logs\")"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_9d491fba","line":119,"in_reply_to":"bab921fb_38ec708e","updated":"2015-04-25 00:13:23.000000000","message":"good catch, will change it","commit_id":"0cda7ff1ddda9c51b065cfb81dc1ab10a9699bf4"}]}
