)]}'
{"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4a180ca89abf56a2dbf98df86c0b13b94bb3cc27","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"            create_amp_lb_tf \u003d self._taskflow_load("},{"line_number":267,"context_line":"                self._amphora_flows.get_create_amphora_for_lb_flow(),"},{"line_number":268,"context_line":"                store\u003d{\u0027loadbalancer_id\u0027: lb.id})"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"            with tf_logging.DynamicLoggingListener(create_amp_lb_tf,"},{"line_number":271,"context_line":"                                                   log\u003dLOG):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_63c6da4a","line":268,"updated":"2015-05-01 20:55:43.000000000","message":"I prefer if parameters like that are constants to minimize typing errors","commit_id":"2c49ae8d551ef6064a8f7f7a202cc6949e2f8b5b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6289d437a605e493898a8df3d1b8810195ecca0","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"            create_amp_lb_tf \u003d self._taskflow_load("},{"line_number":267,"context_line":"                self._amphora_flows.get_create_amphora_for_lb_flow(),"},{"line_number":268,"context_line":"                store\u003d{\u0027loadbalancer_id\u0027: lb.id})"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"            with tf_logging.DynamicLoggingListener(create_amp_lb_tf,"},{"line_number":271,"context_line":"                                                   log\u003dLOG):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_dd733814","line":268,"in_reply_to":"3acd31a7_63c6da4a","updated":"2015-05-04 06:42:06.000000000","message":"Done","commit_id":"2c49ae8d551ef6064a8f7f7a202cc6949e2f8b5b"}],"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4a180ca89abf56a2dbf98df86c0b13b94bb3cc27","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        create_amp_for_lb_flow \u003d linear_flow.Flow(constants."},{"line_number":71,"context_line":"                                                  CREATE_AMPHORA_FOR_LB_FLOW)"},{"line_number":72,"context_line":"        create_amp_for_lb_flow.add(database_tasks.CreateAmphoraInDB("},{"line_number":73,"context_line":"            provides\u003d\u0027amphora_id\u0027))"},{"line_number":74,"context_line":"        create_amp_for_lb_flow.add(compute_tasks.ComputeCreate("},{"line_number":75,"context_line":"            provides\u003d\u0027compute_id\u0027))"},{"line_number":76,"context_line":"        create_amp_for_lb_flow.add(database_tasks.UpdateAmphoraComputeId())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_e3e0aace","line":73,"updated":"2015-05-01 20:55:43.000000000","message":"constants?","commit_id":"2c49ae8d551ef6064a8f7f7a202cc6949e2f8b5b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6289d437a605e493898a8df3d1b8810195ecca0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        create_amp_for_lb_flow \u003d linear_flow.Flow(constants."},{"line_number":71,"context_line":"                                                  CREATE_AMPHORA_FOR_LB_FLOW)"},{"line_number":72,"context_line":"        create_amp_for_lb_flow.add(database_tasks.CreateAmphoraInDB("},{"line_number":73,"context_line":"            provides\u003d\u0027amphora_id\u0027))"},{"line_number":74,"context_line":"        create_amp_for_lb_flow.add(compute_tasks.ComputeCreate("},{"line_number":75,"context_line":"            provides\u003d\u0027compute_id\u0027))"},{"line_number":76,"context_line":"        create_amp_for_lb_flow.add(database_tasks.UpdateAmphoraComputeId())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_9d64a049","line":73,"in_reply_to":"3acd31a7_e3e0aace","updated":"2015-05-04 06:42:06.000000000","message":"Done","commit_id":"2c49ae8d551ef6064a8f7f7a202cc6949e2f8b5b"}],"octavia/controller/worker/flows/load_balancer_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fbb8b94f334da8705d8d71d6897a94c9c9a3c02","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            provides\u003d\u0027amps_data\u0027))"},{"line_number":88,"context_line":"        new_LB_net_subflow.add(database_tasks.UpdateAmphoraVIPData("},{"line_number":89,"context_line":"            requires\u003d\u0027amps_data\u0027))"},{"line_number":90,"context_line":"        # TODO(blogan): yuck, reload in some other way. taskflow doesn\u0027t allow"},{"line_number":91,"context_line":"        # using the same task in the same flow."},{"line_number":92,"context_line":"        new_LB_net_subflow.add(database_tasks.ReloadLoadBalancer2("},{"line_number":93,"context_line":"            provides\u003d\u0027loadbalancer\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_63ab7ad7","line":90,"updated":"2015-05-01 20:48:27.000000000","message":"You can if you name it.","commit_id":"2c49ae8d551ef6064a8f7f7a202cc6949e2f8b5b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6289d437a605e493898a8df3d1b8810195ecca0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            provides\u003d\u0027amps_data\u0027))"},{"line_number":88,"context_line":"        new_LB_net_subflow.add(database_tasks.UpdateAmphoraVIPData("},{"line_number":89,"context_line":"            requires\u003d\u0027amps_data\u0027))"},{"line_number":90,"context_line":"        # TODO(blogan): yuck, reload in some other way. taskflow doesn\u0027t allow"},{"line_number":91,"context_line":"        # using the same task in the same flow."},{"line_number":92,"context_line":"        new_LB_net_subflow.add(database_tasks.ReloadLoadBalancer2("},{"line_number":93,"context_line":"            provides\u003d\u0027loadbalancer\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_7d5b0488","line":90,"in_reply_to":"3acd31a7_63ab7ad7","updated":"2015-05-04 06:42:06.000000000","message":"Thanks, makes this so much better :)","commit_id":"2c49ae8d551ef6064a8f7f7a202cc6949e2f8b5b"}],"octavia/controller/worker/tasks/compute_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2dcc76907a4dfb2af1a33fc6453858d8b4b5087","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        LOG.debug(\"Nova Create execute for amphora with id %s\" % amphora_id)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            # todo(german): add security groups"},{"line_number":58,"context_line":"            compute_id \u003d self.compute.build("},{"line_number":59,"context_line":"                name\u003d\"amphora-\" + amphora_id,"},{"line_number":60,"context_line":"                amphora_flavor\u003dCONF.controller_worker.amp_flavor_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_097f6fab","line":57,"updated":"2015-05-06 22:58:11.000000000","message":"This can go","commit_id":"d3750685c48729b6576e0f4cf31c0b8655f4524b"}],"octavia/controller/worker/tasks/network_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2dcc76907a4dfb2af1a33fc6453858d8b4b5087","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def execute(self, loadbalancer):"},{"line_number":184,"context_line":"        \"\"\"Plumb a vip to an amphora.\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Likely needs to be a subflow!"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        LOG.debug(\"Plumbing VIP for loadbalancer id: %s\" % loadbalancer.id)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_ec2681b9","line":186,"updated":"2015-05-06 22:58:11.000000000","message":"This can go","commit_id":"d3750685c48729b6576e0f4cf31c0b8655f4524b"}]}
