)]}'
{"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fe34f3db754d6a8f323e28ef1e72f22d2230021a","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                                      \u0027listener\u0027: listener,"},{"line_number":351,"context_line":"                                                      \u0027loadbalancer\u0027:"},{"line_number":352,"context_line":"                                                          load_balancer,"},{"line_number":353,"context_line":"                                                      \u0027vip\u0027: vip})"},{"line_number":354,"context_line":"        with tf_logging.DynamicLoggingListener(delete_member_tf,"},{"line_number":355,"context_line":"                                               log\u003dLOG):"},{"line_number":356,"context_line":"            delete_member_tf.run()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_6c738616","line":353,"updated":"2015-06-03 05:30:55.000000000","message":"should use constants for all of these, and all the requires/provides in the flows themselves.  Also, since member is already being passed in, the id can easily be retrieved from that.  same with vip and load_balancer (i.e. load_balancer.vip).  Wonder if we can declutter the variables a bit.","commit_id":"02e48035f3346e4aeb0f96b11489599491311634"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"39c651cace7be8a152b232ca48c0e3583a03605e","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                                      \u0027listener\u0027: listener,"},{"line_number":351,"context_line":"                                                      \u0027loadbalancer\u0027:"},{"line_number":352,"context_line":"                                                          load_balancer,"},{"line_number":353,"context_line":"                                                      \u0027vip\u0027: vip})"},{"line_number":354,"context_line":"        with tf_logging.DynamicLoggingListener(delete_member_tf,"},{"line_number":355,"context_line":"                                               log\u003dLOG):"},{"line_number":356,"context_line":"            delete_member_tf.run()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_46d88cef","line":353,"in_reply_to":"5afe65bd_3a5b6956","updated":"2015-06-03 16:41:47.000000000","message":"I wasn\u0027t saying change all the flows, just the delete member flow.  Kind of makes sense doing it in this review as the bug is really just to fix the delete member issue.  I think fixing these minor technical debts with this flow do fall in within the scope.  It\u0027s really not going to take much to change just this one flow.","commit_id":"02e48035f3346e4aeb0f96b11489599491311634"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9cfb1d693777a41c7e673cef36426fe1fc4f349a","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                                      \u0027listener\u0027: listener,"},{"line_number":351,"context_line":"                                                      \u0027loadbalancer\u0027:"},{"line_number":352,"context_line":"                                                          load_balancer,"},{"line_number":353,"context_line":"                                                      \u0027vip\u0027: vip})"},{"line_number":354,"context_line":"        with tf_logging.DynamicLoggingListener(delete_member_tf,"},{"line_number":355,"context_line":"                                               log\u003dLOG):"},{"line_number":356,"context_line":"            delete_member_tf.run()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_3a5b6956","line":353,"in_reply_to":"5afe65bd_6c738616","updated":"2015-06-03 15:20:10.000000000","message":"I agree with the use of constants and I spearheaded that in my PoC. However, we can always fix that after the merge (and as Michael said this is out of scope of the bug)","commit_id":"02e48035f3346e4aeb0f96b11489599491311634"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e72eed8909fca5aca65a7de24cd5472e165ca820","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                                      \u0027listener\u0027: listener,"},{"line_number":351,"context_line":"                                                      \u0027loadbalancer\u0027:"},{"line_number":352,"context_line":"                                                          load_balancer,"},{"line_number":353,"context_line":"                                                      \u0027vip\u0027: vip})"},{"line_number":354,"context_line":"        with tf_logging.DynamicLoggingListener(delete_member_tf,"},{"line_number":355,"context_line":"                                               log\u003dLOG):"},{"line_number":356,"context_line":"            delete_member_tf.run()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_3a6a491b","line":353,"in_reply_to":"5afe65bd_6c738616","updated":"2015-06-03 15:14:59.000000000","message":"I don\u0027t disagree with your comments, but I think they are out of scope for this bug.  What you are asking for is a complete refactor of all of the flows to switch to constants and optimize the data storage.  I would recommend we open another bug to track that work.","commit_id":"02e48035f3346e4aeb0f96b11489599491311634"}]}