)]}'
{"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2679a0d5cacff63db1e065f2f2c900dd7e97c130","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        delete_listener_tf \u003d self._taskflow_load("},{"line_number":202,"context_line":"            self._listener_flows.get_delete_listener_flow(),"},{"line_number":203,"context_line":"            store\u003d{\u0027load_balancer\u0027: load_balancer, \u0027listener\u0027: listener,"},{"line_number":204,"context_line":"                   \u0027vip\u0027: vip})"},{"line_number":205,"context_line":"        with tf_logging.DynamicLoggingListener(delete_listener_tf,"},{"line_number":206,"context_line":"                                               log\u003dLOG):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_86df2ad5","line":203,"updated":"2015-06-10 21:57:42.000000000","message":"Actually, can we update these for the constants as well?","commit_id":"323eecf14c0b157ece6b211d99bd33182b86aacd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f3d1b09b3b1f9704ab45de773e96351622551cd5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        listener \u003d self._listener_repo.get(db_apis.get_session(),"},{"line_number":197,"context_line":"                                           id\u003dlistener_id)"},{"line_number":198,"context_line":"        load_balancer \u003d listener.load_balancer"},{"line_number":199,"context_line":"        vip \u003d listener.load_balancer.vip"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        delete_listener_tf \u003d self._taskflow_load("},{"line_number":202,"context_line":"            self._listener_flows.get_delete_listener_flow(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_bf48e52e","line":199,"updated":"2015-06-14 12:02:39.000000000","message":"You literally just pulled the LB, \"listener.\" is redudant. :P","commit_id":"1b2e8769acbf7d3cd085dbabaeaadd083791807d"}],"octavia/controller/worker/tasks/database_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f3d1b09b3b1f9704ab45de773e96351622551cd5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"#                                operating_status\u003dconstants.ERROR)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"class DeleteListenerInDB(BaseDatabaseTask):"},{"line_number":157,"context_line":"    \"\"\"Delete the listener in the DB.\"\"\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def execute(self, listener):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_bff6a5d5","line":156,"updated":"2015-06-14 12:02:39.000000000","message":"Does this not need a revert function? I see that most of the other \"delete\" revert functions are just a logging function (possibly because that is the only thing necessary?) but they are *present*.","commit_id":"1b2e8769acbf7d3cd085dbabaeaadd083791807d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3c2360cf57cfa27eeebb249cb597c0dfcafe269a","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        :returns: None"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.warn(_LW("},{"line_number":175,"context_line":"            \"Reverting mark listener delete in DB for listener id %s\"),"},{"line_number":176,"context_line":"            listener_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_4e04f448","line":173,"updated":"2015-06-17 16:26:49.000000000","message":"shouldn\u0027t this set the LB and Listener to ERROR provisioning status?","commit_id":"d020ceb41cf998fe5c7c4109ab06d3f3bd1db997"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0abb2259999478c91a8741a6654118d05bd333f0","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        :returns: None"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.warn(_LW("},{"line_number":175,"context_line":"            \"Reverting mark listener delete in DB for listener id %s\"),"},{"line_number":176,"context_line":"            listener_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_90fe92ac","line":173,"in_reply_to":"fa32b979_3f675cb8","updated":"2015-06-17 19:13:12.000000000","message":"you know this is actaully a tough one to decide what to do, if the listener can\u0027t be deleted then its either some kind of contraint, or the db down.  if its a constraint then cleanup didn\u0027t happen correctly, and if its down then the update to ERROR woudln\u0027t work either.\n\nIf there are other tasks after this one and one of those fails then this revert method will run and the listener would have already been deleted so should we insert it back in and set it to ERROR then?  kind of a tough one.\n\nI\u0027m more than okay just leaving it logging right now until we figure out the best thing to do.","commit_id":"d020ceb41cf998fe5c7c4109ab06d3f3bd1db997"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9a7d48b40b4fe34615f02d6eb727b292f14519f8","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        :returns: None"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.warn(_LW("},{"line_number":175,"context_line":"            \"Reverting mark listener delete in DB for listener id %s\"),"},{"line_number":176,"context_line":"            listener_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_3f675cb8","line":173,"in_reply_to":"fa32b979_4e04f448","updated":"2015-06-17 17:15:40.000000000","message":"None of the other revert methods do anything yet either -- so I am not sure what this is supposed to do, but I assume if this is wrong then ALL of them are wrong. Anyone who is working on this area have a better idea what this is supposed to do?","commit_id":"d020ceb41cf998fe5c7c4109ab06d3f3bd1db997"}],"octavia/tests/unit/controller/worker/tasks/test_database_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f3d1b09b3b1f9704ab45de773e96351622551cd5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"_loadbalancer_mock.amphorae \u003d [_amphora_mock]"},{"line_number":43,"context_line":"_listener_mock \u003d mock.MagicMock()"},{"line_number":44,"context_line":"_listener_mock.id \u003d LISTENER_ID"},{"line_number":45,"context_line":"_listener_mock.__class__ \u003d data_models.Listener"},{"line_number":46,"context_line":"_tf_failure_mock \u003d mock.Mock(spec\u003dfailure.Failure)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_3f3135a3","line":45,"updated":"2015-06-14 12:02:39.000000000","message":"These don\u0027t just use Mock\u0027s spec/autospec functionality?","commit_id":"1b2e8769acbf7d3cd085dbabaeaadd083791807d"}],"octavia/tests/unit/controller/worker/test_controller_worker.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2679a0d5cacff63db1e065f2f2c900dd7e97c130","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        (base_taskflow.BaseTaskFlowEngine._taskflow_load."},{"line_number":271,"context_line":"         assert_called_once_with("},{"line_number":272,"context_line":"             _flow_mock, store\u003d{\u0027listener\u0027: _listener_mock,"},{"line_number":273,"context_line":"                                \u0027vip\u0027: _vip_mock,"},{"line_number":274,"context_line":"                                \u0027load_balancer\u0027: _load_balancer_mock}))"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_6698ae1c","line":272,"updated":"2015-06-10 21:57:42.000000000","message":"Can we update for constants?","commit_id":"323eecf14c0b157ece6b211d99bd33182b86aacd"}]}