)]}'
{"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b40bfef191269107cb2f1eaf3073ab37be3115a0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.session_persistence \u003d session_persistence"},{"line_number":108,"context_line":"        self.listener \u003d listener"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def delete(self):"},{"line_number":111,"context_line":"        self.listener.default_pool \u003d None"},{"line_number":112,"context_line":"        self.listener.default_pool_id \u003d None"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_6c4bcf2c","line":110,"updated":"2015-06-11 22:47:43.000000000","message":"nit: Test update?","commit_id":"c0a8f8642e7be53d1f3b5352c370736bc6428e94"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"a0507dd8dfd737053b1fdf9decf79a44329221de","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.session_persistence \u003d session_persistence"},{"line_number":108,"context_line":"        self.listener \u003d listener"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def delete(self):"},{"line_number":111,"context_line":"        self.listener.default_pool \u003d None"},{"line_number":112,"context_line":"        self.listener.default_pool_id \u003d None"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_482b44ec","line":110,"in_reply_to":"1af86dd1_6c4bcf2c","updated":"2015-06-12 14:56:06.000000000","message":"We haven\u0027t written tests for data_models.  I can make a test class for this one test, if you feel that strongly about it.","commit_id":"c0a8f8642e7be53d1f3b5352c370736bc6428e94"}],"octavia/controller/worker/flows/pool_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"521e2f23e7139e6bcdc8edce72dd58ddaadd24eb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        delete_pool_flow \u003d linear_flow.Flow(constants.DELETE_POOL_FLOW)"},{"line_number":45,"context_line":"        delete_pool_flow.add(model_tasks."},{"line_number":46,"context_line":"                             DeleteModelObject(rebind\u003d{\u0027object\u0027: \u0027pool\u0027}))"},{"line_number":47,"context_line":"        delete_pool_flow.add(amphora_driver_tasks.ListenerUpdate("},{"line_number":48,"context_line":"            requires\u003d[\u0027listener\u0027, \u0027vip\u0027]))"},{"line_number":49,"context_line":"        delete_pool_flow.add(database_tasks.DeletePoolInDB(requires\u003d\u0027pool_id\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_c50cc63d","side":"PARENT","line":46,"updated":"2015-06-11 20:35:59.000000000","message":"Removing this will cause the ListenerUpdate to push the pool into the haproxy config.  We need to make sure the model is updated before the ListenerUpdate.","commit_id":"d44b53fa92091ee618f817daf2f72c067016684b"}],"octavia/controller/worker/tasks/model_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b40bfef191269107cb2f1eaf3073ab37be3115a0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            setattr(object, key, value)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class RemovePoolFromListener(task.Task):"},{"line_number":37,"context_line":"    \"\"\"Task to remove pool from listener.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def execute(self, listener, pool_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_0c69fb8b","line":36,"updated":"2015-06-11 22:47:43.000000000","message":"Is this necessary?  I don\u0027t see it being used.\nIf it is needed unit test?","commit_id":"c0a8f8642e7be53d1f3b5352c370736bc6428e94"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"a0507dd8dfd737053b1fdf9decf79a44329221de","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            setattr(object, key, value)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class RemovePoolFromListener(task.Task):"},{"line_number":37,"context_line":"    \"\"\"Task to remove pool from listener.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def execute(self, listener, pool_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_a83cf82f","line":36,"in_reply_to":"1af86dd1_0c69fb8b","updated":"2015-06-12 14:56:06.000000000","message":"This isn\u0027t necessary, good catch.  I added this before brandon and I sat down to fix the models, adding a \"delete\" method there.","commit_id":"c0a8f8642e7be53d1f3b5352c370736bc6428e94"}],"octavia/tests/unit/controller/worker/flows/test_pool_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b40bfef191269107cb2f1eaf3073ab37be3115a0","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.assertIn(\u0027listener\u0027, pool_flow.requires)"},{"line_number":49,"context_line":"        self.assertIn(\u0027loadbalancer\u0027, pool_flow.requires)"},{"line_number":50,"context_line":"        self.assertIn(\u0027pool\u0027, pool_flow.requires)"},{"line_number":51,"context_line":"        self.assertIn(\u0027pool_id\u0027, pool_flow.requires)"},{"line_number":52,"context_line":"        self.assertIn(\u0027vip\u0027, pool_flow.requires)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_ec369fb3","side":"PARENT","line":50,"updated":"2015-06-11 22:47:43.000000000","message":"Pool is still used.","commit_id":"d44b53fa92091ee618f817daf2f72c067016684b"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"a0507dd8dfd737053b1fdf9decf79a44329221de","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.assertIn(\u0027listener\u0027, pool_flow.requires)"},{"line_number":49,"context_line":"        self.assertIn(\u0027loadbalancer\u0027, pool_flow.requires)"},{"line_number":50,"context_line":"        self.assertIn(\u0027pool\u0027, pool_flow.requires)"},{"line_number":51,"context_line":"        self.assertIn(\u0027pool_id\u0027, pool_flow.requires)"},{"line_number":52,"context_line":"        self.assertIn(\u0027vip\u0027, pool_flow.requires)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_28cc8834","side":"PARENT","line":50,"in_reply_to":"1af86dd1_ec369fb3","updated":"2015-06-12 14:56:06.000000000","message":"Missed that.  Thanks for the catch.","commit_id":"d44b53fa92091ee618f817daf2f72c067016684b"}]}