)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    echo"},{"line_number":22,"context_line":"    echo \"Usage: $(basename $0)\""},{"line_number":23,"context_line":"    echo \"            [-a i386 | **amd64** | armhf ]\""},{"line_number":24,"context_line":"    echo \"            [-b **haproxy** | haproxy ]\""},{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-h]\""},{"line_number":27,"context_line":"    echo \"            [-i **ubuntu** | fedora | centos ]\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_3ccb8820","line":24,"updated":"2015-07-16 17:40:03.000000000","message":"Why did we change this?","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    echo"},{"line_number":22,"context_line":"    echo \"Usage: $(basename $0)\""},{"line_number":23,"context_line":"    echo \"            [-a i386 | **amd64** | armhf ]\""},{"line_number":24,"context_line":"    echo \"            [-b **haproxy** | haproxy ]\""},{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-h]\""},{"line_number":27,"context_line":"    echo \"            [-i **ubuntu** | fedora | centos ]\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_d758378d","line":24,"in_reply_to":"9a41bdd9_3ccb8820","updated":"2015-07-16 18:04:57.000000000","message":"Done","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-h]\""},{"line_number":27,"context_line":"    echo \"            [-i **ubuntu** | fedora | centos ]\""},{"line_number":28,"context_line":"    echo \"            [-o **amphora-x86-haproxy** | \u003cfilename\u003e ]\""},{"line_number":29,"context_line":"    echo \"            [-r \u003croot password\u003e ]\""},{"line_number":30,"context_line":"    echo \"            [-s **5** | \u003csize in GB\u003e ]\""},{"line_number":31,"context_line":"    echo \"            [-t **qcow2** | tar ]\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_dc105c5c","line":28,"updated":"2015-07-16 17:40:03.000000000","message":"This is x64 below, so why did this change?","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-h]\""},{"line_number":27,"context_line":"    echo \"            [-i **ubuntu** | fedora | centos ]\""},{"line_number":28,"context_line":"    echo \"            [-o **amphora-x86-haproxy** | \u003cfilename\u003e ]\""},{"line_number":29,"context_line":"    echo \"            [-r \u003croot password\u003e ]\""},{"line_number":30,"context_line":"    echo \"            [-s **5** | \u003csize in GB\u003e ]\""},{"line_number":31,"context_line":"    echo \"            [-t **qcow2** | tar ]\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_f75d3b7a","line":28,"in_reply_to":"9a41bdd9_dc105c5c","updated":"2015-07-16 18:04:57.000000000","message":"Corrected","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    echo \"            [-t **qcow2** | tar ]\""},{"line_number":32,"context_line":"    echo \"            [-v]\""},{"line_number":33,"context_line":"    echo \"            [-w \u003cworking directory\u003e ]\""},{"line_number":34,"context_line":"    echo \"            [-f]\""},{"line_number":35,"context_line":"    echo"},{"line_number":36,"context_line":"    echo \"        \u0027-a\u0027 is the architecture type for the image (default: amd64)\""},{"line_number":37,"context_line":"    echo \"        \u0027-b\u0027 is the backend type (default: haproxy)\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_f70c5b3d","line":34,"updated":"2015-07-16 17:40:03.000000000","message":"This should be in alphabetical order\n\nI don\u0027t think we need this to be a flag.  I think it is ok to have the package always installed.","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    echo \"            [-t **qcow2** | tar ]\""},{"line_number":32,"context_line":"    echo \"            [-v]\""},{"line_number":33,"context_line":"    echo \"            [-w \u003cworking directory\u003e ]\""},{"line_number":34,"context_line":"    echo \"            [-f]\""},{"line_number":35,"context_line":"    echo"},{"line_number":36,"context_line":"    echo \"        \u0027-a\u0027 is the architecture type for the image (default: amd64)\""},{"line_number":37,"context_line":"    echo \"        \u0027-b\u0027 is the backend type (default: haproxy)\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_3735e3f6","line":34,"in_reply_to":"9a41bdd9_f70c5b3d","updated":"2015-07-16 18:04:57.000000000","message":"This was the initial plan. I am also in favor of having keepalived installed in the image in all cases. The drawbacks of this (image size, creation time) are actually negligible.","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-t\u0027 is the image type (default: qcow2)\""},{"line_number":45,"context_line":"    echo \"        \u0027-v\u0027 display the script version\""},{"line_number":46,"context_line":"    echo \"        \u0027-w\u0027 working directory for image building (default: .)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 enables active_passive mode in amphora (default: .)\""},{"line_number":48,"context_line":"    echo"},{"line_number":49,"context_line":"    exit 1"},{"line_number":50,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_778ccb7f","line":47,"updated":"2015-07-16 17:40:03.000000000","message":"This should be in alphabetical order\n\nThe description should say it installs keepalived instead of enables.\nWe also need to update the default descriptor to be accurate.","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"        \u0027-t\u0027 is the image type (default: qcow2)\""},{"line_number":45,"context_line":"    echo \"        \u0027-v\u0027 display the script version\""},{"line_number":46,"context_line":"    echo \"        \u0027-w\u0027 working directory for image building (default: .)\""},{"line_number":47,"context_line":"    echo \"        \u0027-f\u0027 enables active_passive mode in amphora (default: .)\""},{"line_number":48,"context_line":"    echo"},{"line_number":49,"context_line":"    exit 1"},{"line_number":50,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_572e67a6","line":47,"in_reply_to":"9a41bdd9_778ccb7f","updated":"2015-07-16 18:04:57.000000000","message":"Removed in the new revision.","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    OCTAVIA_REPO_PATH\u003d${OCTAVIA_REPO_PATH:-${AMP_DIR%/*}}"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"echo $OCTAVIA_REPO_PATH"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"while getopts \"a:b:c:hi:o:t:r:s:vw:f\" opt; do"},{"line_number":67,"context_line":"    case $opt in"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_57e66745","line":64,"updated":"2015-07-16 17:40:03.000000000","message":"This should probably be removed.","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    OCTAVIA_REPO_PATH\u003d${OCTAVIA_REPO_PATH:-${AMP_DIR%/*}}"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"echo $OCTAVIA_REPO_PATH"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"while getopts \"a:b:c:hi:o:t:r:s:vw:f\" opt; do"},{"line_number":67,"context_line":"    case $opt in"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_772b6b95","line":64,"in_reply_to":"9a41bdd9_57e66745","updated":"2015-07-16 18:04:57.000000000","message":"Done","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            fi"},{"line_number":76,"context_line":"        ;;"},{"line_number":77,"context_line":"        b)"},{"line_number":78,"context_line":"            if [ $OPTARG \u003d\u003d \"haproxy\" ] || [ $OPTARG \u003d\u003d \"haproxy-vrrp\" ]; then"},{"line_number":79,"context_line":"                AMP_BACKEND\u003d$OPTARG-octavia"},{"line_number":80,"context_line":"            else"},{"line_number":81,"context_line":"                echo \"Error: Unsupported backend type \" $AMP_BACKEND \" specified\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_d73fd785","line":78,"updated":"2015-07-16 17:40:03.000000000","message":"Remove this.  It is duplicate to the -f flag","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            fi"},{"line_number":76,"context_line":"        ;;"},{"line_number":77,"context_line":"        b)"},{"line_number":78,"context_line":"            if [ $OPTARG \u003d\u003d \"haproxy\" ] || [ $OPTARG \u003d\u003d \"haproxy-vrrp\" ]; then"},{"line_number":79,"context_line":"                AMP_BACKEND\u003d$OPTARG-octavia"},{"line_number":80,"context_line":"            else"},{"line_number":81,"context_line":"                echo \"Error: Unsupported backend type \" $AMP_BACKEND \" specified\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_970b8f2b","line":78,"in_reply_to":"9a41bdd9_d73fd785","updated":"2015-07-16 18:04:57.000000000","message":"Done","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        ;;"},{"line_number":127,"context_line":"        f)"},{"line_number":128,"context_line":"            IS_ACTIVE_PASSIVE\u003dtrue"},{"line_number":129,"context_line":"        ;;"},{"line_number":130,"context_line":"        *)"},{"line_number":131,"context_line":"            usage"},{"line_number":132,"context_line":"        ;;"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_d255a5fa","line":129,"updated":"2015-07-16 18:04:57.000000000","message":"Removed in the revision, keepalived is installed by default.","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"OCTAVIA_ELEMENTS_PATH\u003d$OCTAVIA_REPO_PATH/elements"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"IS_ACTIVE_PASSIVE\u003dfalse"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"if ! [ -d $OCTAVIA_ELEMENTS_PATH ]; then"},{"line_number":161,"context_line":"    echo \"ERROR: Octavia elements directory not found at: \" $OCTAVIA_ELEMENTS_PATH \" Exiting.\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_175d3fec","line":158,"updated":"2015-07-16 17:40:03.000000000","message":"This should be removed, it overrides the -f flag","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"OCTAVIA_ELEMENTS_PATH\u003d$OCTAVIA_REPO_PATH/elements"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"IS_ACTIVE_PASSIVE\u003dfalse"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"if ! [ -d $OCTAVIA_ELEMENTS_PATH ]; then"},{"line_number":161,"context_line":"    echo \"ERROR: Octavia elements directory not found at: \" $OCTAVIA_ELEMENTS_PATH \" Exiting.\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_f25a292a","line":158,"in_reply_to":"9a41bdd9_175d3fec","updated":"2015-07-16 18:04:57.000000000","message":"Done","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d5a7f3802dfacc7281f40370c943b32edbfb936","unresolved":false,"context_lines":[{"line_number":337,"context_line":"# Add the Octavia Amphora agent.py element"},{"line_number":338,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"if [ \"$IS_ACTIVE_PASSIVE\" \u003d true]; then "},{"line_number":341,"context_line":"    # Add the vrrp Octacia element"},{"line_number":342,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence vrrp-octavia\""},{"line_number":343,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_97714f7a","line":340,"updated":"2015-07-16 17:40:03.000000000","message":"Please remove the extra space","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"423fa571020fcfad1a18db57b33f6591d65a75cd","unresolved":false,"context_lines":[{"line_number":337,"context_line":"# Add the Octavia Amphora agent.py element"},{"line_number":338,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"if [ \"$IS_ACTIVE_PASSIVE\" \u003d true]; then "},{"line_number":341,"context_line":"    # Add the vrrp Octacia element"},{"line_number":342,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence vrrp-octavia\""},{"line_number":343,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a41bdd9_524af556","line":340,"in_reply_to":"9a41bdd9_97714f7a","updated":"2015-07-16 18:04:57.000000000","message":"Done","commit_id":"32d46dc30d13aeb9dd179e7126aa95b3d4dc9337"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a797b448a8d0b66cf7213e3f998ec24265cd7913","unresolved":false,"context_lines":[{"line_number":330,"context_line":"# Add the Octavia Amphora agent.py element"},{"line_number":331,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"# Add the vrrp Octacia element"},{"line_number":334,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence vrrp-octavia\""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"# Allow full elements override"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a41bdd9_a6e69e14","line":333,"updated":"2015-07-16 22:16:56.000000000","message":"nit: typo","commit_id":"3ba75057618604041eb50d8861dad7a857fc6c3d"}],"elements/vrrp-octavia/README.rst":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"0160df9ca64fe7e4d993a099d33909fb98682c7c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Element to install keepalive."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a41bdd9_f77a1677","line":1,"updated":"2015-07-16 19:44:11.000000000","message":"NIT: Isn\u0027t it called keepalived?","commit_id":"e9a156378927d40749113f5ff094479303dcb22a"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"d49d43ce60017de4ba9d02c9471adb998f04a196","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Element to install keepalive."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a41bdd9_97a94a7e","line":1,"in_reply_to":"9a41bdd9_f77a1677","updated":"2015-07-16 19:54:38.000000000","message":"It is, I will fix this typo.","commit_id":"e9a156378927d40749113f5ff094479303dcb22a"}],"elements/vrrp-octavia/install.d/77-vrrp":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"0160df9ca64fe7e4d993a099d33909fb98682c7c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"cd /opt/vrrp-octavia/"},{"line_number":5,"context_line":"git checkout v1.2.13"},{"line_number":6,"context_line":"./configure"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a41bdd9_d7d91285","line":3,"updated":"2015-07-16 19:44:11.000000000","message":"Comments?\n# This clones keeplaived and compiles it...","commit_id":"e9a156378927d40749113f5ff094479303dcb22a"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"d49d43ce60017de4ba9d02c9471adb998f04a196","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"cd /opt/vrrp-octavia/"},{"line_number":5,"context_line":"git checkout v1.2.13"},{"line_number":6,"context_line":"./configure"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a41bdd9_b7d00ef9","line":3,"in_reply_to":"9a41bdd9_d7d91285","updated":"2015-07-16 19:54:38.000000000","message":"Added #Checks out keepalived version 1.2.13, compiles and installs binaries.","commit_id":"e9a156378927d40749113f5ff094479303dcb22a"}]}