)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e7ecde3b3dbb22cbdc0965017ef648cd34e04308","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     stack \u003ceranra@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-29 16:51:40 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug 1474876 - Use subnet_id in CalculateDelta"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change network_tasks.py to use get_network(subnet_id) function"},{"line_number":10,"context_line":"Change unit-test TestNetworkTasks:test_calculate_delta"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a50d1a3_694de73c","line":7,"updated":"2015-07-29 18:47:37.000000000","message":"remove the first part of this that references the bug","commit_id":"ced808fe35f1a9bbc425f62eb2fef51afcfaabf2"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e7ecde3b3dbb22cbdc0965017ef648cd34e04308","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change network_tasks.py to use get_network(subnet_id) function"},{"line_number":10,"context_line":"Change unit-test TestNetworkTasks:test_calculate_delta"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I32a12147e73362a6def767316d78e43ed982b88c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a50d1a3_a93e8f88","line":11,"updated":"2015-07-29 18:47:37.000000000","message":"add Closes-Bug: 1474876 here","commit_id":"ced808fe35f1a9bbc425f62eb2fef51afcfaabf2"}],"octavia/tests/unit/controller/worker/tasks/test_network_tasks.py":[{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"956af94043fd920c7c6290fd215b2a9af6b152d2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.assertEqual([ndm], net.execute(self.load_balancer_mock))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        mock_driver.get_network.assert_any_call(subnet_id\u003d1)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        mock_driver.get_plugged_networks.return_value \u003d _interface(2)"},{"line_number":113,"context_line":"        self.assertEqual(empty_deltas, net.execute(self.load_balancer_mock))"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_f0178fa0","line":111,"updated":"2015-07-23 18:47:48.000000000","message":"Curious why assert_any_call was used here. assert_called_once_with should verify that the method was called with that specific arg. You want to verify that with the changes made the method called is the correct one for that run. With assert any call, you verify that it was called at some point in the test which, to me, is a little less ensuring.","commit_id":"f669a024505490b2a6c92b5170e71f16ec5cb83a"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e7ecde3b3dbb22cbdc0965017ef648cd34e04308","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertEqual([ndm], net.execute(self.load_balancer_mock))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        calls \u003d [mock.call(subnet_id\u003d3), mock.call(subnet_id\u003d1)]"},{"line_number":112,"context_line":"        mock_driver.get_network.assert_has_calls(calls)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        mock_driver.get_plugged_networks.return_value \u003d _interface(2)"},{"line_number":115,"context_line":"        self.assertEqual(empty_deltas, net.execute(self.load_balancer_mock))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_29efdfe9","line":112,"updated":"2015-07-29 18:47:37.000000000","message":"how did this go from being called once to being called at least 2 times (maybe even more)?\n\nIf this is true, I\u0027d also assert that the get_network.call_count \u003d\u003d 2.","commit_id":"ced808fe35f1a9bbc425f62eb2fef51afcfaabf2"}]}
