)]}'
{"octavia/controller/worker/tasks/network_tasks.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"bd5b9abc31a41dd86b0929f14f68a154c441a761","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            # seed with lb network(s)"},{"line_number":75,"context_line":"            subnet \u003d self.network_driver.get_subnet(loadbalancer.vip.subnet_id)"},{"line_number":76,"context_line":"            desired_network_ids \u003d {CONF.controller_worker.amp_network,"},{"line_number":77,"context_line":"                                   subnet.network_id}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            if not loadbalancer.listeners:"},{"line_number":80,"context_line":"                return {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_31c73266","line":77,"updated":"2015-07-23 23:44:46.000000000","message":"vrrp net?","commit_id":"75d782bce492e9966dd53ab11c084ec490598e1c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"445d451d738fded633e1dfb59c80e2622e18f271","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            # seed with lb network(s)"},{"line_number":75,"context_line":"            subnet \u003d self.network_driver.get_subnet(loadbalancer.vip.subnet_id)"},{"line_number":76,"context_line":"            desired_network_ids \u003d {CONF.controller_worker.amp_network,"},{"line_number":77,"context_line":"                                   subnet.network_id}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            if not loadbalancer.listeners:"},{"line_number":80,"context_line":"                return {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_b21c9d14","line":77,"in_reply_to":"3a50d1a3_31c73266","updated":"2015-07-24 02:21:53.000000000","message":"honestly, i think that handling should come in the active standby patch.  I know this review kind of touches on it as well but not nearly to the focus the active standby patch would.","commit_id":"75d782bce492e9966dd53ab11c084ec490598e1c"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"18585461e378946f91165da4136d3ed921964611","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :returns the delta"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        deltas \u003d {}"},{"line_number":68,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(\"Calculating network delta for amphora id: %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_b6a89f78","line":67,"updated":"2015-07-27 18:46:37.000000000","message":"Change to dict must be reflected in the HandleNetworkDeltas task. It passed tests, but deltas in HandleNetworkDeltas\u0027s execute method is still dealt with as a list.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"381fb7d26d6cfe9bdcd3089848cdf6b6ffd9712b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :returns the delta"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        deltas \u003d {}"},{"line_number":68,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(\"Calculating network delta for amphora id: %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_7feb92dc","line":67,"in_reply_to":"3a50d1a3_04158ce3","updated":"2015-07-28 19:07:10.000000000","message":"I don\u0027t think it will be handled as it should, current code will iterate on keys, not values as it is supposed to was with the list implementation. Am I missing something here?","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"90567674f68fa37509c361d2b61bf4a92b001831","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :returns the delta"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        deltas \u003d {}"},{"line_number":68,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(\"Calculating network delta for amphora id: %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_42959d30","line":67,"in_reply_to":"3a50d1a3_7feb92dc","updated":"2015-07-28 19:25:11.000000000","message":"for amp_id, delta in six.iteritems(deltas)\n\n\nthat iterates on key and value as tuples","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"d6f9eda0ebc5d314a471eba362cde72a1803d572","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :returns the delta"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        deltas \u003d {}"},{"line_number":68,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(\"Calculating network delta for amphora id: %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_04158ce3","line":67,"in_reply_to":"3a50d1a3_b2a4284b","updated":"2015-07-28 05:55:35.000000000","message":"I was used to the method since I had to make a bunch of changes to it, I should have looked at the other methods changes.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"59d4f90f31e4af0d829e0dbbc9138fafb36e244b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :returns the delta"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        deltas \u003d {}"},{"line_number":68,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(\"Calculating network delta for amphora id: %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_d2b0d445","line":67,"in_reply_to":"3a50d1a3_b6a89f78","updated":"2015-07-27 19:15:57.000000000","message":"good catch!","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"70612bdcff001a814d0f6efa4afd333b9d03fda8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :returns the delta"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        deltas \u003d {}"},{"line_number":68,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            LOG.debug(\"Calculating network delta for amphora id: %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_b2a4284b","line":67,"in_reply_to":"3a50d1a3_d2b0d445","updated":"2015-07-27 19:34:29.000000000","message":"it is being handled as a dict in HandleNetworkDeltas, six.iteritems works on dicts.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"90567674f68fa37509c361d2b61bf4a92b001831","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def execute(self, deltas):"},{"line_number":202,"context_line":"        \"\"\"Handle network plugging based off deltas.\"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        for amp_id, delta in six.iteritems(deltas):"},{"line_number":205,"context_line":"            for nic in delta.add_nics:"},{"line_number":206,"context_line":"                self.network_driver.plug_network(delta.compute_id,"},{"line_number":207,"context_line":"                                                 nic.network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_029b1567","line":204,"updated":"2015-07-28 19:25:11.000000000","message":"right here","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"02757dad37a60ea97ebe62a4b52dc19f6b3e0298","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def execute(self, deltas):"},{"line_number":202,"context_line":"        \"\"\"Handle network plugging based off deltas.\"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        for amp_id, delta in six.iteritems(deltas):"},{"line_number":205,"context_line":"            for nic in delta.add_nics:"},{"line_number":206,"context_line":"                self.network_driver.plug_network(delta.compute_id,"},{"line_number":207,"context_line":"                                                 nic.network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_78be48af","line":204,"in_reply_to":"3a50d1a3_029b1567","updated":"2015-07-28 20:07:42.000000000","message":"OK lgtm","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            nics \u003d self.network_driver.get_plugged_networks(amphora.compute_id)"},{"line_number":96,"context_line":"            # assume we don\u0027t have two nics in the same network"},{"line_number":97,"context_line":"            actual_network_nics \u003d dict((nic.network_id, nic) for nic in nics)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            del_ids \u003d set(actual_network_nics) - desired_network_ids"},{"line_number":100,"context_line":"            delete_nics \u003d list("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_69040749","line":97,"range":{"start_line":97,"start_character":12,"end_line":97,"end_character":31},"updated":"2015-07-29 19:00:04.000000000","message":"Nit: We don\u0027t support py26 anymore, right? So this could use real dict-comprehension syntax instead of the backwards-compatible workaround like you have here?","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            nics \u003d self.network_driver.get_plugged_networks(amphora.compute_id)"},{"line_number":96,"context_line":"            # assume we don\u0027t have two nics in the same network"},{"line_number":97,"context_line":"            actual_network_nics \u003d dict((nic.network_id, nic) for nic in nics)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            del_ids \u003d set(actual_network_nics) - desired_network_ids"},{"line_number":100,"context_line":"            delete_nics \u003d list("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_2f327ff2","line":97,"in_reply_to":"3a50d1a3_69040749","updated":"2015-07-29 19:06:31.000000000","message":"well its not really part of this review, but you\u0027re more than welcome to change it :)","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        self.network_driver.update_vip(loadbalancer)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"class GetAmphoraeNetworkConfigs(BaseNetworkTask):"},{"line_number":321,"context_line":"    \"\"\"Task to retrieve amphorae network details.\"\"\""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def execute(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_74b13a46","line":320,"updated":"2015-07-29 19:00:04.000000000","message":"I approve of this pluralization. :P","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        self.network_driver.update_vip(loadbalancer)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"class GetAmphoraeNetworkConfigs(BaseNetworkTask):"},{"line_number":321,"context_line":"    \"\"\"Task to retrieve amphorae network details.\"\"\""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def execute(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8f3e33b6","line":320,"in_reply_to":"3a50d1a3_74b13a46","updated":"2015-07-29 19:06:31.000000000","message":"yes I agree with Configs as the plural for Config as well :)","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"}],"octavia/network/base.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param subnet_id: id of a subnet to retrieve"},{"line_number":199,"context_line":"        :return: octavia.network.data_models.Subnet"},{"line_number":200,"context_line":"        :raises: NetworkException, NetworkNotFound"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        pass"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_9448862e","line":200,"updated":"2015-07-29 19:00:04.000000000","message":"Should this be SubnetNotFound (and PortNotFound in the function below) rather than reusing NetworkNotFound, or do we not care?","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param subnet_id: id of a subnet to retrieve"},{"line_number":199,"context_line":"        :return: octavia.network.data_models.Subnet"},{"line_number":200,"context_line":"        :raises: NetworkException, NetworkNotFound"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        pass"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_ef9c97c1","line":200,"in_reply_to":"3a50d1a3_9448862e","updated":"2015-07-29 19:06:31.000000000","message":"oye yes it should be, good catch.","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7b891e0affbb54f6978d8c2b9ccb86c17b9f08bc","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        :param port_id: id of a port to retrieve"},{"line_number":213,"context_line":"        :return: octavia.network.data_models.Port"},{"line_number":214,"context_line":"        :raises: NetworkException, NetworkNotFound"},{"line_number":215,"context_line":"        \"\"\""},{"line_number":216,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a1fb037a","line":214,"updated":"2015-07-29 19:41:46.000000000","message":"You didn\u0027t do PortNotFound...","commit_id":"d70ba4dca987e393bb703db7b03dd29873906f26"}],"octavia/network/data_models.py":[{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"18585461e378946f91165da4136d3ed921964611","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.status \u003d status"},{"line_number":84,"context_line":"        self.tenant_id \u003d tenant_id"},{"line_number":85,"context_line":"        self.admin_state_up \u003d admin_state_up"},{"line_number":86,"context_line":"        self.fixed_ips \u003d fixed_ips or []"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_subnet_id(self, fixed_ip_address):"},{"line_number":89,"context_line":"        for fixed_ip in self.fixed_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_4c9c2fc0","line":86,"updated":"2015-07-27 18:46:37.000000000","message":"We need allow_address_pair and security_group_id fields here too. The allow_address_pair is generic for floating ips, but also important for Active_Standby configuration. Security group will also make it easier for adding/deleting security rules and is safer for not missing-up configuration of the wrong security group.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"70612bdcff001a814d0f6efa4afd333b9d03fda8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.status \u003d status"},{"line_number":84,"context_line":"        self.tenant_id \u003d tenant_id"},{"line_number":85,"context_line":"        self.admin_state_up \u003d admin_state_up"},{"line_number":86,"context_line":"        self.fixed_ips \u003d fixed_ips or []"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_subnet_id(self, fixed_ip_address):"},{"line_number":89,"context_line":"        for fixed_ip in self.fixed_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_720a208c","line":86,"in_reply_to":"3a50d1a3_4c9c2fc0","updated":"2015-07-27 19:34:29.000000000","message":"i know this is a direct copy of what neutron is, but I also want to keep this as generic as possible and adding extension support for allowed address pairs would undo that.  I think the allowed address pairs management and security group rules management can be managed successfully with trivial naming of security groups and ports.\n\nIn the future we may find out this is not the case and we need to store that information in the db, or you might already have a case in which it wouldn\u0027t work that way.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"18585461e378946f91165da4136d3ed921964611","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        pass"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _map_network_to_data_model(self, network):"},{"line_number":192,"context_line":"        pass"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":195,"context_line":"        port \u003d self.neutron_client.show_port(vip.port_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_2c7e836a","line":192,"updated":"2015-07-27 18:46:37.000000000","message":"What are these methods for? Please add comments.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"70612bdcff001a814d0f6efa4afd333b9d03fda8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        pass"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _map_network_to_data_model(self, network):"},{"line_number":192,"context_line":"        pass"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def deallocate_vip(self, vip):"},{"line_number":195,"context_line":"        port \u003d self.neutron_client.show_port(vip.port_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_1232bc5e","line":192,"in_reply_to":"3a50d1a3_2c7e836a","updated":"2015-07-27 19:34:29.000000000","message":"whoops a missed artifact of a merge.  i need to remove them.","commit_id":"60c74dd78243fd91e8052016d56a77cbb8932f02"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                fixed_ip \u003d port_fixed_ip"},{"line_number":68,"context_line":"                break"},{"line_number":69,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":70,"context_line":"        return data_models.Vip(ip_address\u003dfixed_ip.get(\u0027ip_address\u0027),"},{"line_number":71,"context_line":"                               subnet_id\u003dfixed_ip.get(\u0027subnet_id\u0027),"},{"line_number":72,"context_line":"                               port_id\u003dport_id,"},{"line_number":73,"context_line":"                               load_balancer_id\u003dload_balancer.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_14655643","line":70,"updated":"2015-07-29 19:00:04.000000000","message":"Is returning a Vip full of None data what we\u0027d expect if we don\u0027t find a matching fixed-ip, or should this cause an exception of some type? Or will that happen implicitly down the line when something attempts to use this?","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                          \u0027(subnet id: {subnet_id}.\u0027).format("},{"line_number":425,"context_line":"                subnet_id\u003dsubnet_id)"},{"line_number":426,"context_line":"            LOG.exception(message)"},{"line_number":427,"context_line":"            raise base.NetworkException(message)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def get_port(self, port_id):"},{"line_number":430,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_54f51e4e","line":427,"updated":"2015-07-29 19:00:04.000000000","message":"Same comment as last file -- NetworkException is fine for this and the below function, or should there be SubnetException/PortException? I guess maybe we don\u0027t have to get too specific, just want someone to confirm this is enough.","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                          \u0027(subnet id: {subnet_id}.\u0027).format("},{"line_number":425,"context_line":"                subnet_id\u003dsubnet_id)"},{"line_number":426,"context_line":"            LOG.exception(message)"},{"line_number":427,"context_line":"            raise base.NetworkException(message)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def get_port(self, port_id):"},{"line_number":430,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_4fb26b4a","line":427,"in_reply_to":"3a50d1a3_54f51e4e","updated":"2015-07-29 19:06:31.000000000","message":"NetworkException is the generic i dont know what this is, so tha thsould be fine, but it Should be SubnetNotFound in the first one.  Good catch.","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7b891e0affbb54f6978d8c2b9ccb86c17b9f08bc","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                          \u0027(network id: {network_id}.\u0027).format("},{"line_number":402,"context_line":"                network_id\u003dnetwork_id)"},{"line_number":403,"context_line":"            LOG.exception(message)"},{"line_number":404,"context_line":"            raise base.SubnetNotFound(message)"},{"line_number":405,"context_line":"        except Exception:"},{"line_number":406,"context_line":"            message \u003d _LE(\u0027Error retrieving network \u0027"},{"line_number":407,"context_line":"                          \u0027(network id: {network_id}.\u0027).format("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_e12cab03","line":404,"updated":"2015-07-29 19:41:46.000000000","message":"Wait, why did this get replaced here? Did you mean to do this BELOW?","commit_id":"d70ba4dca987e393bb703db7b03dd29873906f26"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"0622fa27985952ff2efac454d33d9574fee2f7ab","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                          \u0027(network id: {network_id}.\u0027).format("},{"line_number":402,"context_line":"                network_id\u003dnetwork_id)"},{"line_number":403,"context_line":"            LOG.exception(message)"},{"line_number":404,"context_line":"            raise base.Network(message)"},{"line_number":405,"context_line":"        except Exception:"},{"line_number":406,"context_line":"            message \u003d _LE(\u0027Error retrieving network \u0027"},{"line_number":407,"context_line":"                          \u0027(network id: {network_id}.\u0027).format("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_249dc165","line":404,"updated":"2015-07-29 20:00:38.000000000","message":"You mean base.NetworkNotFound ?","commit_id":"dec8962f178652a25bca5b84c7b9ec1687b06c5e"}],"octavia/network/drivers/noop_driver/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.networkconfigconfig[network_id] \u003d (network_id, \u0027get_network\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":86,"context_line":"        LOG.debug(\"subnet %s no-op, get_subnet subnet_id %s\","},{"line_number":87,"context_line":"                  self.__class__.__name__, subnet_id)"},{"line_number":88,"context_line":"        self.networkconfigconfig[subnet_id] \u003d (subnet_id, \u0027get_subnet\u0027)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_1468f6f3","line":86,"updated":"2015-07-29 19:00:04.000000000","message":"Nit: all of the network function debugs capitalize Network. :P","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.networkconfigconfig[network_id] \u003d (network_id, \u0027get_network\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":86,"context_line":"        LOG.debug(\"subnet %s no-op, get_subnet subnet_id %s\","},{"line_number":87,"context_line":"                  self.__class__.__name__, subnet_id)"},{"line_number":88,"context_line":"        self.networkconfigconfig[subnet_id] \u003d (subnet_id, \u0027get_subnet\u0027)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_aff0cffd","line":86,"in_reply_to":"3a50d1a3_1468f6f3","updated":"2015-07-29 19:06:31.000000000","message":"-_-\n\nsee what I did there?","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.networkconfigconfig[subnet_id] \u003d (subnet_id, \u0027get_subnet\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_port(self, port_id):"},{"line_number":91,"context_line":"        LOG.debug(\"port %s no-op, get_port port_id %s\","},{"line_number":92,"context_line":"                  self.__class__.__name__, port_id)"},{"line_number":93,"context_line":"        self.networkconfigconfig[port_id] \u003d (port_id, \u0027get_port\u0027)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_947406cf","line":91,"updated":"2015-07-29 19:00:04.000000000","message":"^^","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"}],"octavia/tests/unit/network/drivers/neutron/test_allowed_address_pairs.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":38,"context_line":"MOCK_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":39,"context_line":"MOCK_MAC_ADDR \u003d \u0027fe:16:3e:00:95:5c\u0027"},{"line_number":40,"context_line":"MOCK_NOVA_INTERFACE \u003d MockNovaInterface()"},{"line_number":41,"context_line":"MOCK_SUBNET \u003d {\u0027subnet\u0027: {\u0027id\u0027: \u002710\u0027, \u0027network_id\u0027: MOCK_NETWORK_ID}}"},{"line_number":42,"context_line":"MOCK_NOVA_INTERFACE.net_id \u003d MOCK_NETWORK_ID"},{"line_number":43,"context_line":"MOCK_NOVA_INTERFACE.port_id \u003d MOCK_PORT_ID"},{"line_number":44,"context_line":"MOCK_NOVA_INTERFACE.fixed_ips \u003d [{\u0027ip_address\u0027: MOCK_IP_ADDRESS}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_9422c6b7","line":41,"updated":"2015-07-29 19:00:04.000000000","message":"Should the id for this subnet be using MOCK_SUBNET_ID?","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":38,"context_line":"MOCK_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":39,"context_line":"MOCK_MAC_ADDR \u003d \u0027fe:16:3e:00:95:5c\u0027"},{"line_number":40,"context_line":"MOCK_NOVA_INTERFACE \u003d MockNovaInterface()"},{"line_number":41,"context_line":"MOCK_SUBNET \u003d {\u0027subnet\u0027: {\u0027id\u0027: \u002710\u0027, \u0027network_id\u0027: MOCK_NETWORK_ID}}"},{"line_number":42,"context_line":"MOCK_NOVA_INTERFACE.net_id \u003d MOCK_NETWORK_ID"},{"line_number":43,"context_line":"MOCK_NOVA_INTERFACE.port_id \u003d MOCK_PORT_ID"},{"line_number":44,"context_line":"MOCK_NOVA_INTERFACE.fixed_ips \u003d [{\u0027ip_address\u0027: MOCK_IP_ADDRESS}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8fdab376","line":41,"in_reply_to":"3a50d1a3_9422c6b7","updated":"2015-07-29 19:06:31.000000000","message":"grrrr","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"}],"specs/version0.5/network-driver-interface.rst":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3beea1d57e8379d001170d4bd22859b635760a08","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* UnplugNetworkException"},{"line_number":133,"context_line":"* VIPInUse"},{"line_number":134,"context_line":"* PortNotFound"},{"line_number":135,"context_line":"* SubnetNotFound"},{"line_number":136,"context_line":"* NetworkNotFound"},{"line_number":137,"context_line":"* VIPConfigurationNotFound"},{"line_number":138,"context_line":"* AmphoraNotFound"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_94096633","line":135,"updated":"2015-07-29 19:00:04.000000000","message":"I see you defined this exception here in the doc, so I am guessing my comments in the earlier files about using more specific exception types are valid?","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a1afec7590e9cf999b3439a130cbdf73dce69733","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* UnplugNetworkException"},{"line_number":133,"context_line":"* VIPInUse"},{"line_number":134,"context_line":"* PortNotFound"},{"line_number":135,"context_line":"* SubnetNotFound"},{"line_number":136,"context_line":"* NetworkNotFound"},{"line_number":137,"context_line":"* VIPConfigurationNotFound"},{"line_number":138,"context_line":"* AmphoraNotFound"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_efd1f757","line":135,"in_reply_to":"3a50d1a3_94096633","updated":"2015-07-29 19:06:31.000000000","message":"Yes indeed","commit_id":"c441295415a924dea9d34d1f54165f3edbf73554"}]}
