)]}'
{"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":17041,"name":"Sherif Abdelwahab","email":"selgohari@ieee.org","username":"sherif"},"change_message_id":"660424c97d785a1c64a0c227f7183ee2bb9625f7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    # Find the interface which is down"},{"line_number":132,"context_line":"    down \u003d [interface for interface in netifaces.interfaces() if"},{"line_number":133,"context_line":"            netifaces.AF_INET not in netifaces.ifaddresses(interface)]"},{"line_number":134,"context_line":"    if len(down) \u003e 1:"},{"line_number":135,"context_line":"        # There should only be ONE interface being plugged; if there is"},{"line_number":136,"context_line":"        # none down or more than one we have a problem..."},{"line_number":137,"context_line":"        raise exceptions.HTTPException("}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8190b544","line":134,"updated":"2015-09-04 00:19:08.000000000","message":"I think this should be kept strictly 1 to capture errors. If no interface was actually created, then plug_network shouldn\u0027t be called at all. If we just called plug_network anyway (as I understood from this change), we would also have performance issues trying to unnecessarily connect to amphorae.","commit_id":"a9db910745483d4a2f9a51c73ebe3b03c62bdb86"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"75e56e8f12f7ed94f72852037d48f1e4ce8da8f2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    # Find the interface which is down"},{"line_number":132,"context_line":"    down \u003d [interface for interface in netifaces.interfaces() if"},{"line_number":133,"context_line":"            netifaces.AF_INET not in netifaces.ifaddresses(interface)]"},{"line_number":134,"context_line":"    if len(down) \u003e 1:"},{"line_number":135,"context_line":"        # There should only be ONE interface being plugged; if there is"},{"line_number":136,"context_line":"        # none down or more than one we have a problem..."},{"line_number":137,"context_line":"        raise exceptions.HTTPException("}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_21d0c9f5","line":134,"updated":"2015-09-04 00:19:02.000000000","message":"I worry about the implications of this.  I think it would be returning None.\n\nI would really prefer to leave it !\u003d1 and fix it from getting called if there are no interfaces down.\n\nAt a minimum I guess put in docstring that documents that the result could be None and update plug_network to not do something stupid with the template.  But I really like having an exception if we call this expecting a down interface, but there isn\u0027t one on the amp.","commit_id":"a9db910745483d4a2f9a51c73ebe3b03c62bdb86"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7bc74e99436de6b236f2c28c515237b69c634661","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    # Find the interface which is down"},{"line_number":132,"context_line":"    down \u003d [interface for interface in netifaces.interfaces() if"},{"line_number":133,"context_line":"            netifaces.AF_INET not in netifaces.ifaddresses(interface)]"},{"line_number":134,"context_line":"    if len(down) \u003e 1:"},{"line_number":135,"context_line":"        # There should only be ONE interface being plugged; if there is"},{"line_number":136,"context_line":"        # none down or more than one we have a problem..."},{"line_number":137,"context_line":"        raise exceptions.HTTPException("}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_012825e1","line":134,"in_reply_to":"da20952f_8190b544","updated":"2015-09-04 00:21:41.000000000","message":"yeah i mentioned this in the commit message that it probably makes more sense for the controller worker to not call post_network_plug if there werent any plugged networks.  I can make this change in this same review, though I think sherif already has this done in his active passive review.  I\u0027d prefer that in a separate review though, if you havent already.","commit_id":"a9db910745483d4a2f9a51c73ebe3b03c62bdb86"}]}