)]}'
{"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3786d93da176aa8b48a01f2122b92d535d31baf6","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def _interface_by_mac(mac):"},{"line_number":131,"context_line":"    for interface in netifaces.interfaces():"},{"line_number":132,"context_line":"        if netifaces.AF_LINK in netifaces.ifaddresses(interface):"},{"line_number":133,"context_line":"            for link in netifaces.ifaddresses(interface)[netifaces.AF_LINK]:"},{"line_number":134,"context_line":"                if link.get(\u0027addr\u0027) \u003d\u003d mac:"},{"line_number":135,"context_line":"                    return interface"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_d95d8649","line":132,"updated":"2015-09-09 20:26:02.000000000","message":"can remove this `if` by doing:\n\nfor link in netifaces.ifaddresses(interface).get(netifaces.AF_LINK, []):","commit_id":"3b23de32b81cc476d7cb9474575fc2f789b0cb99"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3ff306db1c91f0d2f6242fcb41f1df08a8f7ff56","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def _interface_by_mac(mac):"},{"line_number":131,"context_line":"    for interface in netifaces.interfaces():"},{"line_number":132,"context_line":"        if netifaces.AF_LINK in netifaces.ifaddresses(interface):"},{"line_number":133,"context_line":"            for link in netifaces.ifaddresses(interface)[netifaces.AF_LINK]:"},{"line_number":134,"context_line":"                if link.get(\u0027addr\u0027) \u003d\u003d mac:"},{"line_number":135,"context_line":"                    return interface"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_0f4c0b9c","line":132,"in_reply_to":"da20952f_d95d8649","updated":"2015-09-09 20:36:41.000000000","message":"good one, will do if another patchset is needed.","commit_id":"3b23de32b81cc476d7cb9474575fc2f789b0cb99"}],"octavia/controller/worker/tasks/amphora_driver_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3786d93da176aa8b48a01f2122b92d535d31baf6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def execute(self, loadbalancer, added_ports):"},{"line_number":169,"context_line":"        \"\"\"Execute post_network_plug routine.\"\"\""},{"line_number":170,"context_line":"        for amphora in loadbalancer.amphorae:"},{"line_number":171,"context_line":"            if amphora.id in added_ports:"},{"line_number":172,"context_line":"                for port in added_ports[amphora.id]:"},{"line_number":173,"context_line":"                    self.amphora_driver.post_network_plug(amphora, port)"},{"line_number":174,"context_line":"                    LOG.debug("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_193a1ee8","line":171,"updated":"2015-09-09 20:26:02.000000000","message":"same as my other comment, can remove an `if` here:\n\nfor port in added_ports.get(amphora.id, []):","commit_id":"3b23de32b81cc476d7cb9474575fc2f789b0cb99"}],"octavia/tests/unit/amphorae/drivers/haproxy/test_rest_api_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3786d93da176aa8b48a01f2122b92d535d31baf6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"FAKE_PEM_FILENAME \u003d \"file_name\""},{"line_number":32,"context_line":"FAKE_SUBNET_INFO \u003d {\u0027subnet_cidr\u0027: FAKE_CIDR,"},{"line_number":33,"context_line":"                    \u0027gateway\u0027: FAKE_GATEWAY,"},{"line_number":34,"context_line":"                    \u0027mac_address\u0027: \u0027123\u0027}"},{"line_number":35,"context_line":"FAKE_UUID_1 \u003d uuidutils.generate_uuid()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_d90b462a","line":34,"updated":"2015-09-09 20:26:02.000000000","message":"Not using a constant? :P","commit_id":"3b23de32b81cc476d7cb9474575fc2f789b0cb99"}],"octavia/tests/unit/amphorae/drivers/haproxy/test_ssh_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3786d93da176aa8b48a01f2122b92d535d31baf6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.driver.client.exec_command.return_value \u003d ("},{"line_number":66,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":67,"context_line":"        self.driver.amp_config \u003d mock.MagicMock()"},{"line_number":68,"context_line":"        self.port \u003d network_models.Port(mac_address\u003d\u0027123\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_update(self):"},{"line_number":71,"context_line":"        with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_2fac6f8b","line":68,"updated":"2015-09-09 20:26:02.000000000","message":"same as other testfile -- constant for this? :P","commit_id":"3b23de32b81cc476d7cb9474575fc2f789b0cb99"}]}
