)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"13f90a69fd99bc4ca7c75ce19c8bd9b1c8768e79","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    nova keypair-add --pub-key ${OCTAVIA_AMP_SSH_KEY_PATH}.pub ${OCTAVIA_AMP_SSH_KEY_NAME}"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    if ! [ $AMPHORA_IMAGE_NAME \u003d\u003d \u0027amphora-x64-haproxy\u0027 ]; then"},{"line_number":157,"context_line":"        build_octavia_worker_image"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_d46749b5","line":156,"updated":"2015-09-16 15:22:34.000000000","message":"this script will trigger an error in case of empty value.\n\ns/$AMPHORA_IMAGE_NAME/\"$AMPHORA_IMAGE_NAME\"/","commit_id":"6b24f3d342541f32b71f719419d9397ba86f970a"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"1c37f0501106ec937918cc53d310b4b1ead9ded5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    # TODO(ptoohill): Tempfix..? -o option stopped working and it no longer saves image to working dir..."},{"line_number":22,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":23,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh -s 2"},{"line_number":24,"context_line":"        # $OCTAVIA_DIR/diskimage-create/diskimage-create.sh -o $OCTAVIA_AMP_IMAGE_NAME"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ba15a1d1_f51eeb6e","line":23,"updated":"2015-09-17 08:20:14.000000000","message":"I would prefer --image-size","commit_id":"530c631543c306910dd94fef4fc3ba9004a94d3c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"14823eb1eb064bf281553ea959771e322fc95d96","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    # TODO(ptoohill): Tempfix..? -o option stopped working and it no longer saves image to working dir..."},{"line_number":22,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":23,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh -s 2"},{"line_number":24,"context_line":"        # $OCTAVIA_DIR/diskimage-create/diskimage-create.sh -o $OCTAVIA_AMP_IMAGE_NAME"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ba15a1d1_17d01cc8","line":23,"in_reply_to":"ba15a1d1_f51eeb6e","updated":"2015-09-17 23:02:49.000000000","message":"Hi.  That script doesn\u0027t currently support --image-size.  That could be added as an enhancement.","commit_id":"530c631543c306910dd94fef4fc3ba9004a94d3c"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"1c37f0501106ec937918cc53d310b4b1ead9ded5","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    BUILD_AMP_IMAGE\u003d\u0027True\u0027"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if ! [ \u0027$AMPHORA_IMAGE_NAME\u0027 \u003d\u003d \u0027amphora-x64-haproxy\u0027 ]; then"},{"line_number":248,"context_line":"        BUILD_AMP_IMAGE\u003d\u0027False\u0027"},{"line_number":249,"context_line":"    fi"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ba15a1d1_f0883973","line":247,"updated":"2015-09-17 08:20:14.000000000","message":"I think you don\u0027t want to build another image if it\u0027s already exists.\n\nHence negation (!) seems wrong in this test.","commit_id":"530c631543c306910dd94fef4fc3ba9004a94d3c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"14823eb1eb064bf281553ea959771e322fc95d96","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    BUILD_AMP_IMAGE\u003d\u0027True\u0027"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if ! [ \u0027$AMPHORA_IMAGE_NAME\u0027 \u003d\u003d \u0027amphora-x64-haproxy\u0027 ]; then"},{"line_number":248,"context_line":"        BUILD_AMP_IMAGE\u003d\u0027False\u0027"},{"line_number":249,"context_line":"    fi"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ba15a1d1_97e42cac","line":247,"in_reply_to":"ba15a1d1_f0883973","updated":"2015-09-17 23:02:49.000000000","message":"Yes, that was a typo.  I have corrected that in the current patch.","commit_id":"530c631543c306910dd94fef4fc3ba9004a94d3c"}]}