)]}'
{".coveragerc":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5479df7886e49ffb91b0f20a160448e58d0add26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"omit \u003d octavia/tests/*,octavia/openstack/*"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[report]"},{"line_number":7,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a1a9d01_2e1ed1ba","line":7,"updated":"2015-09-25 15:46:14.000000000","message":"Can you depend on this patch instead?\nhttps://review.openstack.org/#/c/225548/","commit_id":"de6375aca5d80c12ad3548d85b0673fb83a9f527"}],"octavia/cmd/agent.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5479df7886e49ffb91b0f20a160448e58d0add26","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.debug(\"Processes running on port: {0}\".format(proc))"},{"line_number":75,"context_line":"            pid \u003d proc.split()[1]"},{"line_number":76,"context_line":"            LOG.debug(\"Killing process {0}\".format(pid))"},{"line_number":77,"context_line":"            os.kill(int(pid), 9)"},{"line_number":78,"context_line":"    except subprocess.CalledProcessError as e:"},{"line_number":79,"context_line":"        LOG.debug(\"Failed to stop dhclient: {0}\".format(e))"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_0e598d5a","line":77,"updated":"2015-09-25 15:46:14.000000000","message":"We have seen the process that grabs the socket be dhclient.  Do we know that just killing this won\u0027t cause side effects like loosing the IP addresss?","commit_id":"de6375aca5d80c12ad3548d85b0673fb83a9f527"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"b2eeeff9d08c27d972cf8f4832129893db4342e8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    # comment out to improve logging"},{"line_number":66,"context_line":"    service.prepare_service(sys.argv)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Workaround to kill the annoying dhclient"},{"line_number":69,"context_line":"    cmd \u003d \"/usr/bin/lsof -i :{0}\".format(CONF.haproxy_amphora.bind_port)"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        proc \u003d subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_f0daa6e7","line":68,"updated":"2015-09-28 22:46:03.000000000","message":"I agree with johnsom here.  I\u0027m not convinced nuking dh client is the right idea. Maybe change the port for the haproxy binding instead.","commit_id":"9d90c0974deb3c8aba6d33de1bbf0b93590eff93"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"64879460a2e79d7bcf8c6f482fd185eeab996921","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    # comment out to improve logging"},{"line_number":66,"context_line":"    service.prepare_service(sys.argv)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Workaround to kill the annoying dhclient"},{"line_number":69,"context_line":"    cmd \u003d \"/usr/bin/lsof -i :{0}\".format(CONF.haproxy_amphora.bind_port)"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        proc \u003d subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_56beea65","line":68,"in_reply_to":"9a1a9d01_f0daa6e7","updated":"2015-09-29 00:06:49.000000000","message":"We tried to no effect. There is some voodoo beyond our comprehension --","commit_id":"9d90c0974deb3c8aba6d33de1bbf0b93590eff93"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ae6c941109547fe1cda2d51816c0388430c5cf6a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    service.prepare_service(sys.argv)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Workaround to kill the annoying dhclient"},{"line_number":69,"context_line":"    cmd \u003d \"/usr/bin/lsof -i :{0}\".format(CONF.haproxy_amphora.bind_port)"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        proc \u003d subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT)"},{"line_number":72,"context_line":"        if proc:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a5b84976","line":69,"updated":"2015-09-29 17:35:59.000000000","message":"What voodoo?","commit_id":"9d90c0974deb3c8aba6d33de1bbf0b93590eff93"}]}