)]}'
{"octavia/compute/drivers/noop_driver/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7a79304b5ca9ef97f97e07b30312f08b6251c727","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  self.__class__.__name__, name, amphora_flavor, image_id,"},{"line_number":37,"context_line":"                  key_name, sec_groups, network_ids, config_drive_files,"},{"line_number":38,"context_line":"                  user_data, port_ids)"},{"line_number":39,"context_line":"        self.computeconfig[(name, amphora_flavor, image_id, key_name,"},{"line_number":40,"context_line":"                            user_data)] \u003d ("},{"line_number":41,"context_line":"            name, amphora_flavor,"},{"line_number":42,"context_line":"            image_id, key_name, sec_groups,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8c3885d4","line":39,"updated":"2015-10-01 06:58:26.000000000","message":"We stop recording some of these values?\n\nsec_groups, network_ids, config_drive_files","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"99524fbf5b862ea3c6ee4e55eeeed246e20073e3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  self.__class__.__name__, name, amphora_flavor, image_id,"},{"line_number":37,"context_line":"                  key_name, sec_groups, network_ids, config_drive_files,"},{"line_number":38,"context_line":"                  user_data, port_ids)"},{"line_number":39,"context_line":"        self.computeconfig[(name, amphora_flavor, image_id, key_name,"},{"line_number":40,"context_line":"                            user_data)] \u003d ("},{"line_number":41,"context_line":"            name, amphora_flavor,"},{"line_number":42,"context_line":"            image_id, key_name, sec_groups,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_b78032f8","line":39,"in_reply_to":"9a1a9d01_2c193922","updated":"2015-10-01 07:33:51.000000000","message":"Oh man, missed that they were still part of the key. That is one heck of a key. Yeah, nevermind.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f0c9d0aeb8aff144c8dc15fa417f9736eb11bfba","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  self.__class__.__name__, name, amphora_flavor, image_id,"},{"line_number":37,"context_line":"                  key_name, sec_groups, network_ids, config_drive_files,"},{"line_number":38,"context_line":"                  user_data, port_ids)"},{"line_number":39,"context_line":"        self.computeconfig[(name, amphora_flavor, image_id, key_name,"},{"line_number":40,"context_line":"                            user_data)] \u003d ("},{"line_number":41,"context_line":"            name, amphora_flavor,"},{"line_number":42,"context_line":"            image_id, key_name, sec_groups,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_2c193922","line":39,"in_reply_to":"9a1a9d01_8c3885d4","updated":"2015-10-01 07:08:23.000000000","message":"since they\u0027re lists they became unhashable types so couldn\u0027t be used as keys.  i removed them for that reason.  i don\u0027t think its going to make the key have a much more chance for a collision.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7a79304b5ca9ef97f97e07b30312f08b6251c727","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return data_models.Amphora("},{"line_number":64,"context_line":"            compute_id\u003damphora_id,"},{"line_number":65,"context_line":"            status\u003dconstants.ACTIVE,"},{"line_number":66,"context_line":"            lb_network_ip\u003d\u0027192.0.2.1\u0027"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_0c7a3588","line":66,"updated":"2015-10-01 06:58:26.000000000","message":"Does setting a static IP here cause any problems when creating multiple amphorae using noop?","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f0c9d0aeb8aff144c8dc15fa417f9736eb11bfba","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return data_models.Amphora("},{"line_number":64,"context_line":"            compute_id\u003damphora_id,"},{"line_number":65,"context_line":"            status\u003dconstants.ACTIVE,"},{"line_number":66,"context_line":"            lb_network_ip\u003d\u0027192.0.2.1\u0027"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_acdb094e","line":66,"in_reply_to":"9a1a9d01_0c7a3588","updated":"2015-10-01 07:08:23.000000000","message":"i originally was giong to make a dynamic data store that would just generate an ip.  Then i realized that if its static it doesn\u0027t matter because this IP is not used outside of drivers.  And even then it doesn\u0027t matter if it is the same across many amphorae.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"}],"octavia/controller/worker/tasks/compute_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7a79304b5ca9ef97f97e07b30312f08b6251c727","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def execute(self, loadbalancer):"},{"line_number":126,"context_line":"        for amp in loadbalancer.amphorae:"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_eceb4111","line":128,"updated":"2015-10-01 06:58:26.000000000","message":"Is it typical to standardize the param names for an interface? I really assume it is -- in which case it would be better to fix the noop driver to be compute_id to match the interface (not that there was any reason to specify it as a named arg here to begin with).","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f0c9d0aeb8aff144c8dc15fa417f9736eb11bfba","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def execute(self, loadbalancer):"},{"line_number":126,"context_line":"        for amp in loadbalancer.amphorae:"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_cc83dd01","line":128,"in_reply_to":"9a1a9d01_eceb4111","updated":"2015-10-01 07:08:23.000000000","message":"Yeah I agree, but then I felt it should be addressed in another review because it is out of scope of this one.  I can be flexible on this though, just didn\u0027t want to lose the focus and intent of this patch.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7a79304b5ca9ef97f97e07b30312f08b6251c727","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"},{"line_number":132,"context_line":"                raise e"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_6cb2d14d","line":130,"updated":"2015-10-01 06:58:26.000000000","message":"Uhh, this is generic but the log messages mention Nova specifically? I know this isn\u0027t your code here, but... :/\nSame below.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f0c9d0aeb8aff144c8dc15fa417f9736eb11bfba","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"},{"line_number":132,"context_line":"                raise e"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8c93a55a","line":130,"in_reply_to":"9a1a9d01_6cb2d14d","updated":"2015-10-01 07:08:23.000000000","message":"Good point on this, but I don\u0027t want this going out of its original scope.  I think there should be a review that goes through a lot of the flows and tasks to generically just fix and clean them up.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"89e6d1375410a92f340b29f18b8359606e272f5d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"},{"line_number":132,"context_line":"                raise e"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c3caac6e","line":130,"in_reply_to":"9a1a9d01_77cdba64","updated":"2015-10-01 19:28:17.000000000","message":"https://review.openstack.org/#/c/230096/\n\nthere you go!","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"99524fbf5b862ea3c6ee4e55eeeed246e20073e3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"},{"line_number":132,"context_line":"                raise e"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_77cdba64","line":130,"in_reply_to":"9a1a9d01_8c93a55a","updated":"2015-10-01 07:33:51.000000000","message":"Both of the above are a tough call -- I am afraid if we don\u0027t fix this stuff as we run across it, it will NEVER be fixed, because who has time to go through and do patches just to find and fix this kind of thing? It\u0027s true that CRs really should have limited scope, but sometimes I feel like it\u0027s best to just hit things while you\u0027re there.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"952cad94813bd9fcbaf473cf341e9043351f468d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                self.compute.delete(amp.compute_id)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                LOG.error(_LE(\"Nova delete for amphora id: %(amp)s failed:\""},{"line_number":131,"context_line":"                              \"%(exp)s\"), {\u0027amp\u0027: amp.id, \u0027exp\u0027: e})"},{"line_number":132,"context_line":"                raise e"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_127b0b7d","line":130,"in_reply_to":"9a1a9d01_c3caac6e","updated":"2015-10-01 20:11:17.000000000","message":"also this one:\nhttps://review.openstack.org/229774","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"}],"octavia/network/drivers/noop_driver/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7a79304b5ca9ef97f97e07b30312f08b6251c727","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  self.__class__.__name__, load_balancer)"},{"line_number":33,"context_line":"        self.networkconfigconfig[load_balancer] \u003d ("},{"line_number":34,"context_line":"            load_balancer, \u0027allocate_vip\u0027)"},{"line_number":35,"context_line":"        return data_models.Vip(ip_address\u003d\u0027198.51.100.1\u0027,"},{"line_number":36,"context_line":"                               subnet_id\u003duuidutils.generate_uuid(),"},{"line_number":37,"context_line":"                               port_id\u003duuidutils.generate_uuid(),"},{"line_number":38,"context_line":"                               load_balancer_id\u003dload_balancer.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_acc8e9a8","line":35,"updated":"2015-10-01 06:58:26.000000000","message":"Same question as in the compute driver -- is having this address be static going to cause problems if multiple VIPs are allocated using this driver?","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f0c9d0aeb8aff144c8dc15fa417f9736eb11bfba","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  self.__class__.__name__, load_balancer)"},{"line_number":33,"context_line":"        self.networkconfigconfig[load_balancer] \u003d ("},{"line_number":34,"context_line":"            load_balancer, \u0027allocate_vip\u0027)"},{"line_number":35,"context_line":"        return data_models.Vip(ip_address\u003d\u0027198.51.100.1\u0027,"},{"line_number":36,"context_line":"                               subnet_id\u003duuidutils.generate_uuid(),"},{"line_number":37,"context_line":"                               port_id\u003duuidutils.generate_uuid(),"},{"line_number":38,"context_line":"                               load_balancer_id\u003dload_balancer.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_ac978938","line":35,"in_reply_to":"9a1a9d01_acc8e9a8","updated":"2015-10-01 07:08:23.000000000","message":"nope, tested and fine.  i had same worry too when i first did it but quickly realized it\u0027d be fine, and tests prove it is.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7a79304b5ca9ef97f97e07b30312f08b6251c727","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                id\u003damphora.id,"},{"line_number":57,"context_line":"                compute_id\u003damphora.compute_id,"},{"line_number":58,"context_line":"                vrrp_ip\u003d\u0027198.51.100.1\u0027,"},{"line_number":59,"context_line":"                ha_ip\u003d\u0027198.51.100.1\u0027,"},{"line_number":60,"context_line":"                vrrp_port_id\u003duuidutils.generate_uuid(),"},{"line_number":61,"context_line":"                ha_port_id\u003duuidutils.generate_uuid()"},{"line_number":62,"context_line":"            ))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_6cc73196","line":59,"updated":"2015-10-01 06:58:26.000000000","message":"Same as above. Thinking of DB constraints/queries, etc, as this stuff does still end up in the DB, right?","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f0c9d0aeb8aff144c8dc15fa417f9736eb11bfba","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                id\u003damphora.id,"},{"line_number":57,"context_line":"                compute_id\u003damphora.compute_id,"},{"line_number":58,"context_line":"                vrrp_ip\u003d\u0027198.51.100.1\u0027,"},{"line_number":59,"context_line":"                ha_ip\u003d\u0027198.51.100.1\u0027,"},{"line_number":60,"context_line":"                vrrp_port_id\u003duuidutils.generate_uuid(),"},{"line_number":61,"context_line":"                ha_port_id\u003duuidutils.generate_uuid()"},{"line_number":62,"context_line":"            ))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_0cbc75b9","line":59,"in_reply_to":"9a1a9d01_6cc73196","updated":"2015-10-01 07:08:23.000000000","message":"yes but not unique constraints for these fields, just the id, i dont think compute_id is unique.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"ffe03a4f7bc5f284def5c427cdf143d1d6045db9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                  self.__class__.__name__, compute_id)"},{"line_number":97,"context_line":"        self.networkconfigconfig[compute_id] \u003d ("},{"line_number":98,"context_line":"            compute_id, \u0027get_plugged_networks\u0027)"},{"line_number":99,"context_line":"        return []"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def update_vip(self, load_balancer):"},{"line_number":102,"context_line":"        LOG.debug(\"Network %s no-op, update_vip load_balancer %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_720927dd","line":99,"updated":"2015-10-01 20:20:38.000000000","message":"Shouldn\u0027t this return some kind of spoofed plugged network in this list maybe?  Especially if you could have called \"plug_network\" before this call?  Just curious, as a noop it may not want to do anything at all, but you return things all over the place otherwise.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"78e80382332b02b2e8494a531d0fba5ee605809c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                  self.__class__.__name__, compute_id)"},{"line_number":97,"context_line":"        self.networkconfigconfig[compute_id] \u003d ("},{"line_number":98,"context_line":"            compute_id, \u0027get_plugged_networks\u0027)"},{"line_number":99,"context_line":"        return []"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def update_vip(self, load_balancer):"},{"line_number":102,"context_line":"        LOG.debug(\"Network %s no-op, update_vip load_balancer %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5278a3f8","line":99,"in_reply_to":"9a1a9d01_720927dd","updated":"2015-10-01 20:25:44.000000000","message":"i could return spoofed values but I think it would cause issues with some of the tasks that calculate deltas, but I haven\u0027t tested it out.  I don\u0027t think its of any value to have it though, unless its used as a reference to see what a driver should return.","commit_id":"0c80a3bff14188ee6839c04b0ed931a5387c97d7"}]}
