)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"b9241b1141b4765ab68ed65e3fe49b8ff9726aa7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LOG.debug messages were not correctly formatting a string.  The type of"},{"line_number":10,"context_line":"formatting expected is only for the localization functions"},{"line_number":11,"context_line":"(_LI, _LW, _LE, _).  Since debug logs do not use localization, they just"},{"line_number":12,"context_line":"need to do normal string formatting.  To keep consistency with how other"},{"line_number":13,"context_line":"LOG messages format, the % operator is used."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_7680daf7","line":11,"updated":"2015-11-06 10:00:55.000000000","message":"This is an awful practice. It has nothing to do with localization, we should use:\n\n LOG.debug(\u0027...\u0027, args)\n ...\n LOG.error(_LE(\u0027...\u0027), args)\n\ninstead of:\n\n LOG.debug(\u0027...\u0027 % args)\n ...\n LOG.error(_LE(\u0027...\u0027) % args)\n\nbecause it delegates string formatting to logger which lazily performs it when needed (so in general doesn\u0027t do it for debug messages)","commit_id":"d65c8caa2a9fa9c32178282a9bf1389c5fbf638e"}],"octavia/controller/worker/tasks/compute_tasks.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"8c43a8daecda12b903490250a4be5075e0353a92","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                port_ids\u003d[port.id for port in ports],"},{"line_number":71,"context_line":"                config_drive_files\u003dconfig_drive_files)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            LOG.debug(\"Server created with id: %s for amphora id: %s\" %"},{"line_number":74,"context_line":"                      (compute_id, amphora_id))"},{"line_number":75,"context_line":"            return compute_id"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_09c7fa96","line":73,"updated":"2015-11-06 04:12:24.000000000","message":"Nit: aren\u0027t we using .format() everywhere?","commit_id":"f5bb88d8183f956331a958f40d096d50d10025b1"}]}