)]}'
{"octavia/controller/queue/consumer.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"c185854ce82b9a051f753bf6d2c88453695782a8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def listen(self):"},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            LOG.info(_LI(\u0027Starting consumer...\u0027))"},{"line_number":41,"context_line":"            service.launch(cfg.CONF, self.server).wait()"},{"line_number":42,"context_line":"        finally:"},{"line_number":43,"context_line":"            LOG.info(_LI(\u0027Stopping consumer...\u0027))"},{"line_number":44,"context_line":"            self.server.stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_7f17d1ed","line":41,"updated":"2015-11-07 23:42:53.000000000","message":"Do we need any exception handling here? just in case if we have any prob with starting the server? And does this method of using the service to suppress the warning msg is correct? as wait is meant to be used after stop only.","commit_id":"e2453a0cc8d6cf60d627683eff0cc1b3933ed179"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"39d43a2d81b826e9a52d2bf8385dbac1abc63aac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def listen(self):"},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            LOG.info(_LI(\u0027Starting consumer...\u0027))"},{"line_number":41,"context_line":"            service.launch(cfg.CONF, self.server).wait()"},{"line_number":42,"context_line":"        finally:"},{"line_number":43,"context_line":"            LOG.info(_LI(\u0027Stopping consumer...\u0027))"},{"line_number":44,"context_line":"            self.server.stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b1a7e5bb","line":41,"in_reply_to":"da85f559_2496f54c","updated":"2015-11-19 16:39:46.000000000","message":"Brandon pointed out that this ALREADY behaves in this way, as any exception would be uncaught and so would be thrown already.","commit_id":"e2453a0cc8d6cf60d627683eff0cc1b3933ed179"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5e1b8509e82e5cc0211bafd41f0dd0fc98d55f2e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def listen(self):"},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            LOG.info(_LI(\u0027Starting consumer...\u0027))"},{"line_number":41,"context_line":"            service.launch(cfg.CONF, self.server).wait()"},{"line_number":42,"context_line":"        finally:"},{"line_number":43,"context_line":"            LOG.info(_LI(\u0027Stopping consumer...\u0027))"},{"line_number":44,"context_line":"            self.server.stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_2496f54c","line":41,"in_reply_to":"da85f559_7f17d1ed","updated":"2015-11-09 15:03:59.000000000","message":"Maybe just an except that literally LOGs the exception message and says something about it so it doesn\u0027t just look like it successfully stopped would be good.","commit_id":"e2453a0cc8d6cf60d627683eff0cc1b3933ed179"}]}