)]}'
{"octavia/common/constants.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d397e980b8d82e6ecbf65362fd1c1ea8306c1159","unresolved":false,"context_lines":[{"line_number":91,"context_line":"L7RULE_COMPARE_TYPE_EQUALS_TO \u003d \u0027EQUALS_TO\u0027"},{"line_number":92,"context_line":"L7RULE_COMPARE_TYPE_GREATER_THAN \u003d \u0027GREATER_THAN\u0027"},{"line_number":93,"context_line":"L7RULE_COMPARE_TYPE_LESS_THAN \u003d \u0027LESS_THAN\u0027"},{"line_number":94,"context_line":"L7RULE_COMPARE_TYPE_GREATER_OR_EQUALS_TO \u003d \u0027GREATER_OR_EQUALS_TO\u0027"},{"line_number":95,"context_line":"L7RULE_COMPARE_TYPE_LESS_OR_EQUALS_TO \u003d \u0027LESS_OR_EQUALS_TO\u0027"},{"line_number":96,"context_line":"SUPPORTED_L7RULE_COMPARE_TYPES \u003d (L7RULE_COMPARE_TYPE_REGEX,"},{"line_number":97,"context_line":"                                  L7RULE_COMPARE_TYPE_STARTS_WITH,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_e4032f75","line":94,"updated":"2016-02-03 05:42:06.000000000","message":"I guess I have a nit that I\u0027d prefer \"GREATER_OR_EQUAL\" (\"equals\" sounds weird when it is not the lone verb in a full English sentence).\n\nSame below, obviously.","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"d5aa90af4ae61731c892eb53033c4e1bfaf08126","unresolved":false,"context_lines":[{"line_number":91,"context_line":"L7RULE_COMPARE_TYPE_EQUALS_TO \u003d \u0027EQUALS_TO\u0027"},{"line_number":92,"context_line":"L7RULE_COMPARE_TYPE_GREATER_THAN \u003d \u0027GREATER_THAN\u0027"},{"line_number":93,"context_line":"L7RULE_COMPARE_TYPE_LESS_THAN \u003d \u0027LESS_THAN\u0027"},{"line_number":94,"context_line":"L7RULE_COMPARE_TYPE_GREATER_OR_EQUALS_TO \u003d \u0027GREATER_OR_EQUALS_TO\u0027"},{"line_number":95,"context_line":"L7RULE_COMPARE_TYPE_LESS_OR_EQUALS_TO \u003d \u0027LESS_OR_EQUALS_TO\u0027"},{"line_number":96,"context_line":"SUPPORTED_L7RULE_COMPARE_TYPES \u003d (L7RULE_COMPARE_TYPE_REGEX,"},{"line_number":97,"context_line":"                                  L7RULE_COMPARE_TYPE_STARTS_WITH,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_e280ff48","line":94,"in_reply_to":"5a5ae5dd_e4032f75","updated":"2016-02-03 06:35:04.000000000","message":"Yeah, actually-- I agree with you on this one. I was going off of the same name that\u0027s used in Evgeny\u0027s Neutron LBaaS patch (at least, I think that\u0027s where I got this name from);  I\u0027ll add a note there for him to change it as well.","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"}],"octavia/common/data_models.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"6bf1f0f6323fd505d0d7c93c7cb5e504bc3c5804","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class L7Rule(BaseDataModel):"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def __init__(self, id\u003dNone, l7policy_id\u003dNone, type\u003dNone,"},{"line_number":295,"context_line":"                 compare_type\u003dNone, key\u003dNone, value\u003dNone, l7policy\u003dNone,"},{"line_number":296,"context_line":"                 invert\u003dFalse):"},{"line_number":297,"context_line":"        self.id \u003d id"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_8dee0921","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":54},"updated":"2016-01-27 21:55:04.000000000","message":"Is this problematic with type keyword?  Might need a rename to \"rule_type\" or something?  Trust me, I hate it, but wouldn\u0027t want any issues, you know?","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"bef433dc11a4bf51ea55e4ca71006f9df6f38ee1","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class L7Rule(BaseDataModel):"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def __init__(self, id\u003dNone, l7policy_id\u003dNone, type\u003dNone,"},{"line_number":295,"context_line":"                 compare_type\u003dNone, key\u003dNone, value\u003dNone, l7policy\u003dNone,"},{"line_number":296,"context_line":"                 invert\u003dFalse):"},{"line_number":297,"context_line":"        self.id \u003d id"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_7b26d969","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":54},"in_reply_to":"7a5de9d1_3bb06143","updated":"2016-01-28 05:16:30.000000000","message":"Actually-- I\u0027m going to reverse that:  Both heath_monitors and session_persistence have a \u0027type\u0027 field. No reason we can\u0027t do the same with L7Rules.","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"db675983a88dd8dfa791eb1c4cb96c09542bb725","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class L7Rule(BaseDataModel):"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def __init__(self, id\u003dNone, l7policy_id\u003dNone, type\u003dNone,"},{"line_number":295,"context_line":"                 compare_type\u003dNone, key\u003dNone, value\u003dNone, l7policy\u003dNone,"},{"line_number":296,"context_line":"                 invert\u003dFalse):"},{"line_number":297,"context_line":"        self.id \u003d id"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_6214c843","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":54},"in_reply_to":"7a5de9d1_7b26d969","updated":"2016-01-28 16:08:29.000000000","message":"Fair enough, no problems here.  I was honestly just curious if there COULD be any issues, you know?","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"52fc500f6ba5528a64a6faf33fe1a349224b4a77","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class L7Rule(BaseDataModel):"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def __init__(self, id\u003dNone, l7policy_id\u003dNone, type\u003dNone,"},{"line_number":295,"context_line":"                 compare_type\u003dNone, key\u003dNone, value\u003dNone, l7policy\u003dNone,"},{"line_number":296,"context_line":"                 invert\u003dFalse):"},{"line_number":297,"context_line":"        self.id \u003d id"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_3bb06143","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":54},"in_reply_to":"7a5de9d1_8dee0921","updated":"2016-01-28 05:14:34.000000000","message":"It actually seems to work fine, though I did take my naming from what Evgeny wrote into the Neutron LBaaS L7 patch he\u0027s written. I was thinking about keyword usage here as I was writing it and frankly would prefer to avoid using keywords like this... so...  yeah, I\u0027ll change the name.","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c52d4076e1d96c1e85b62d77272df3d583d6867e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"},{"line_number":131,"context_line":"                l7policy.action \u003d constants.L7POLICY_ACTION_REJECT"},{"line_number":132,"context_line":"                l7policy.redirect_pool \u003d None"},{"line_number":133,"context_line":"                l7policy.redirect_pool_id \u003d None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class Member(BaseDataModel):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a57f1b5_7f85d3cc","line":133,"updated":"2016-02-12 18:15:11.000000000","message":"I have a question about this. I\u0027m not suggesting you change it, just looking for clarification: is setting redirect_pool_id necessary or does SQLAlchemy take care of clearing that when you clear the pool? In my testing on other objects, the _id variables seem to be auto-cleaned, and in fact if you were to set just the _id on some things it doesn\u0027t ever write any changes to the DB...","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"18cfd864bc96025f694e0714fd840a4bc9a3d0e4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"},{"line_number":131,"context_line":"                l7policy.action \u003d constants.L7POLICY_ACTION_REJECT"},{"line_number":132,"context_line":"                l7policy.redirect_pool \u003d None"},{"line_number":133,"context_line":"                l7policy.redirect_pool_id \u003d None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class Member(BaseDataModel):"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a54edaf_b787b0d6","line":133,"in_reply_to":"3a57f1b5_7f85d3cc","updated":"2016-02-13 06:58:24.000000000","message":"This is the data model, so I don\u0027t think we actually have SQLAlchemy helpers here--  so I\u0027m pretty sure I need to clear the redirect_pool_id (though I didn\u0027t actually check this that closely.)","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c52d4076e1d96c1e85b62d77272df3d583d6867e","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.description \u003d description"},{"line_number":322,"context_line":"        self.listener_id \u003d listener_id"},{"line_number":323,"context_line":"        self.action \u003d action"},{"line_number":324,"context_line":"        self.redirect_pool_id \u003d redirect_pool_id"},{"line_number":325,"context_line":"        self.redirect_url \u003d redirect_url"},{"line_number":326,"context_line":"        self.position \u003d position"},{"line_number":327,"context_line":"        self.listener \u003d listener"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a57f1b5_3f5d1b47","line":324,"updated":"2016-02-12 18:15:11.000000000","message":"Also out of curiosity, is redirect_pool accessible from this object too as a backref or something?","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"18cfd864bc96025f694e0714fd840a4bc9a3d0e4","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.description \u003d description"},{"line_number":322,"context_line":"        self.listener_id \u003d listener_id"},{"line_number":323,"context_line":"        self.action \u003d action"},{"line_number":324,"context_line":"        self.redirect_pool_id \u003d redirect_pool_id"},{"line_number":325,"context_line":"        self.redirect_url \u003d redirect_url"},{"line_number":326,"context_line":"        self.position \u003d position"},{"line_number":327,"context_line":"        self.listener \u003d listener"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a54edaf_776a981c","line":324,"in_reply_to":"3a57f1b5_3f5d1b47","updated":"2016-02-13 06:58:24.000000000","message":"It is on the database model, but again, this is the data model here, eh.","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac0d2772abf901a6376d659f7a0227f243d7f7d8","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            if pool.id \u003d\u003d self.id:"},{"line_number":215,"context_line":"                self.load_balancer.pools.remove(pool)"},{"line_number":216,"context_line":"                break"},{"line_number":217,"context_line":"        for l7policy in self.l7policies:"},{"line_number":218,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"},{"line_number":219,"context_line":"                l7policy.action \u003d constants.L7POLICY_ACTION_REJECT"},{"line_number":220,"context_line":"                l7policy.redirect_pool \u003d None"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_8b1467a0","line":217,"updated":"2016-02-23 05:21:06.000000000","message":"This isn\u0027t covered by unit tests per the coverage report:\nhttp://sonar.octavia.io/archive/octavia/0732e81bcd03c4a78a2257b5eccf958478735dd7/352/cover/octavia_common_data_models_py.html#n217","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5ed80a7759288b9ea810232beec088c31479d6f1","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                break"},{"line_number":217,"context_line":"        for l7policy in self.l7policies:"},{"line_number":218,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"},{"line_number":219,"context_line":"                l7policy.action \u003d constants.L7POLICY_ACTION_REJECT"},{"line_number":220,"context_line":"                l7policy.redirect_pool \u003d None"},{"line_number":221,"context_line":"                l7policy.redirect_pool_id \u003d None"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_e8e6d913","line":219,"updated":"2016-02-23 05:14:07.000000000","message":"This is a bit strange.  I get why you did it, but I feel like we should just delete the policy and direct the traffic back to the default pool (if there is one).","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"7fa352cf0c05471217999d244fb579e7f4d02c94","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                break"},{"line_number":217,"context_line":"        for l7policy in self.l7policies:"},{"line_number":218,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"},{"line_number":219,"context_line":"                l7policy.action \u003d constants.L7POLICY_ACTION_REJECT"},{"line_number":220,"context_line":"                l7policy.redirect_pool \u003d None"},{"line_number":221,"context_line":"                l7policy.redirect_pool_id \u003d None"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_5f1fb2b6","line":219,"in_reply_to":"bae84128_e8e6d913","updated":"2016-02-23 09:09:22.000000000","message":"Discussed this with Evgeny back in the day:\n\n1. This is an unusual thing to happen in the first place; If someone deletes a pool it is likely because they\u0027re about to delete the whole listener anyway, or because they\u0027ve created a new pool that they want to point l7policies like this after.\n\n2. This mirrors the behavior of a listener with no default pool (and we don\u0027t delete listeners when we delete their default pools).\n\n3. If this was done in error (as is likely to occasionally happen when there\u0027s GUI support for the L7 stuff), we wanted to make it as easy as possible to recover from that.\n\n4. If the intent really is to delete the policy, that can be done simply enough afterward.","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5ed80a7759288b9ea810232beec088c31479d6f1","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                   len(p.l7rules) \u003e 0 and p.enabled is True]"},{"line_number":285,"context_line":"                    old_pool \u003d self.default_pool"},{"line_number":286,"context_line":"                    if old_pool.id not in l7_pool_ids:"},{"line_number":287,"context_line":"                        self.pools.remove(old_pool)"},{"line_number":288,"context_line":"                        old_pool.listeners.remove(self)"},{"line_number":289,"context_line":"                pool \u003d self._find_in_graph(\u0027Pool\u0027 + value)"},{"line_number":290,"context_line":"                setattr(self, \u0027default_pool\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_e8f7f988","line":287,"updated":"2016-02-23 05:14:07.000000000","message":"Is this right?  It seems odd that a listener update would delete a pool from the model.","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a92ea3a50062ee60a25bcb1ca88542319ea0b373","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                   len(p.l7rules) \u003e 0 and p.enabled is True]"},{"line_number":285,"context_line":"                    old_pool \u003d self.default_pool"},{"line_number":286,"context_line":"                    if old_pool.id not in l7_pool_ids:"},{"line_number":287,"context_line":"                        self.pools.remove(old_pool)"},{"line_number":288,"context_line":"                        old_pool.listeners.remove(self)"},{"line_number":289,"context_line":"                pool \u003d self._find_in_graph(\u0027Pool\u0027 + value)"},{"line_number":290,"context_line":"                setattr(self, \u0027default_pool\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_3933ca63","line":287,"in_reply_to":"bae84128_054c9f9c","updated":"2016-02-23 19:29:56.000000000","message":"Ok, in order to understand what\u0027s going on here, you need to understand what the listener.pools SQLAlchemy (repository) relationship really is, as well as what all these update and delete methods on the data model really are:\n\nlistener.pools (sqlalchemy model) is the list of pools the listener is referencing *right now* in some way. This means the listener\u0027s default_pool plus any pools referenced by *active* l7policies. Active in this case means \"is enabled and has at least one l7rule\" \n\nThe update and delete methods in this file are only called by controller worker flows because we want to simulate transient (ie. non-permanent) changes to the underlying database in a way that does not actually change the database, thus making it easier to \"roll-back\" the database if a flow needs to be reverted. Literally everywhere else in our entire code tree when we manipulate Octavia\u0027s objects, we want to do that in a \"permanent\" way-- meaning we will manipulate the sqlalchemy models (ie. repository) because we do want changes stored \"permanently\" as it were. (In fact, you could say that the whole reason any of these data model manipulations are being done is so that we can hand a \u0027pre-DB-updated\u0027 data model graph to the code which renders haproxy jinja templates.)\n\nYou may also notice that the delete and update methods in this file (ie. on the data model) are almost entirely concerned with managing the relationships between linked objects that can happen when one object in the data model graph is changed. This is done because we don\u0027t have SQLAlchemy\u0027s logic and helper methods here which manage all of this for us when we manipulate the repository.\n\nIn this particular update method, we need to discover whether changing the listener\u0027s default_pool will also remove the old pool that was referenced here from the current object\u0027s listener.pools list. It only does this if the old pool is not also being referenced by a currently-active l7policy.\n\nAnd again, remember that the list.remove(something) method does not \"delete\" that something from the rest of the object graph, it only removes the reference to it that is in the list.\n\nDoes this make more sense to you now?","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e7ca6548553aaa812c049841e794148d7cf92f1c","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                   len(p.l7rules) \u003e 0 and p.enabled is True]"},{"line_number":285,"context_line":"                    old_pool \u003d self.default_pool"},{"line_number":286,"context_line":"                    if old_pool.id not in l7_pool_ids:"},{"line_number":287,"context_line":"                        self.pools.remove(old_pool)"},{"line_number":288,"context_line":"                        old_pool.listeners.remove(self)"},{"line_number":289,"context_line":"                pool \u003d self._find_in_graph(\u0027Pool\u0027 + value)"},{"line_number":290,"context_line":"                setattr(self, \u0027default_pool\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_05df7f0d","line":287,"in_reply_to":"bae84128_5d1fbab6","updated":"2016-02-23 17:51:06.000000000","message":"This feels messy. I would assume an update to provide a list of all the pools we want. So a call like this would override the pools... so why do we need to remove that pool?","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e1d05f4f2e614bdf0f8e4c08b30eb84989f346e2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                   len(p.l7rules) \u003e 0 and p.enabled is True]"},{"line_number":285,"context_line":"                    old_pool \u003d self.default_pool"},{"line_number":286,"context_line":"                    if old_pool.id not in l7_pool_ids:"},{"line_number":287,"context_line":"                        self.pools.remove(old_pool)"},{"line_number":288,"context_line":"                        old_pool.listeners.remove(self)"},{"line_number":289,"context_line":"                pool \u003d self._find_in_graph(\u0027Pool\u0027 + value)"},{"line_number":290,"context_line":"                setattr(self, \u0027default_pool\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_054c9f9c","line":287,"in_reply_to":"bae84128_5d1fbab6","updated":"2016-02-23 17:56:05.000000000","message":"model !\u003d SQLAlchemy or the database.\n\nI am asking about why a listener update would remove a pool from the model.  Just because it is only being called from one place today doesn\u0027t mean it couldn\u0027t be called for some other reason later.  I just want to understand why this method would have a side effect on the pools in the current model.","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"6f5e57784770a7bf362795b3c4cfbd6743f568b6","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                   len(p.l7rules) \u003e 0 and p.enabled is True]"},{"line_number":285,"context_line":"                    old_pool \u003d self.default_pool"},{"line_number":286,"context_line":"                    if old_pool.id not in l7_pool_ids:"},{"line_number":287,"context_line":"                        self.pools.remove(old_pool)"},{"line_number":288,"context_line":"                        old_pool.listeners.remove(self)"},{"line_number":289,"context_line":"                pool \u003d self._find_in_graph(\u0027Pool\u0027 + value)"},{"line_number":290,"context_line":"                setattr(self, \u0027default_pool\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_5d1fbab6","line":287,"in_reply_to":"bae84128_e8f7f988","updated":"2016-02-23 09:50:17.000000000","message":"\"remove\" just removes an item from a list, it doesn\u0027t actually \"delete\" the underlying object. If that object is referenced elsewhere it will still exist in the graph. Further, we can be somewhat less careful here because the only time this method is called is in the listener update flow (specifically when a listener object itself has been altered)... and this doesn\u0027t actually affect the database. Database changes are of an entirely different nature because SQLAlchemy handles the maintenance of relationships, eh.","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac0d2772abf901a6376d659f7a0227f243d7f7d8","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.l7policy \u003d l7policy"},{"line_number":425,"context_line":"        self.invert \u003d invert"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def delete(self):"},{"line_number":428,"context_line":"        if len(self.l7policy.l7rules) \u003d\u003d 1:"},{"line_number":429,"context_line":"            # l7policy should disappear from pool and listener lists. Since"},{"line_number":430,"context_line":"            # we are operating only on the data model, we can fake this by"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_ab0fab86","line":427,"updated":"2016-02-23 05:21:06.000000000","message":"This method is missing unit tests.","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5ed80a7759288b9ea810232beec088c31479d6f1","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            # l7policy should disappear from pool and listener lists. Since"},{"line_number":430,"context_line":"            # we are operating only on the data model, we can fake this by"},{"line_number":431,"context_line":"            # calling the policy\u0027s delete method."},{"line_number":432,"context_line":"            self.l7policy.delete()"},{"line_number":433,"context_line":"        for r in self.l7policy.l7rules:"},{"line_number":434,"context_line":"            if r.id \u003d\u003d self.id:"},{"line_number":435,"context_line":"                self.l7policy.l7rules.remove(r)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_284a81ac","line":432,"updated":"2016-02-23 05:14:07.000000000","message":"Why would we delete the policy if we are deleting the rule?  Isn\u0027t it ok to have an empty policy that rules can be re-added to?","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e7ca6548553aaa812c049841e794148d7cf92f1c","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            # l7policy should disappear from pool and listener lists. Since"},{"line_number":430,"context_line":"            # we are operating only on the data model, we can fake this by"},{"line_number":431,"context_line":"            # calling the policy\u0027s delete method."},{"line_number":432,"context_line":"            self.l7policy.delete()"},{"line_number":433,"context_line":"        for r in self.l7policy.l7rules:"},{"line_number":434,"context_line":"            if r.id \u003d\u003d self.id:"},{"line_number":435,"context_line":"                self.l7policy.l7rules.remove(r)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_65cdab84","line":432,"in_reply_to":"bae84128_1f57ea58","updated":"2016-02-23 17:51:06.000000000","message":"Same why don\u0027t we just remove the policy from the rule? Deleting it and then relying on the model not finding it seems messy and might bite us afterwards","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"7fa352cf0c05471217999d244fb579e7f4d02c94","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            # l7policy should disappear from pool and listener lists. Since"},{"line_number":430,"context_line":"            # we are operating only on the data model, we can fake this by"},{"line_number":431,"context_line":"            # calling the policy\u0027s delete method."},{"line_number":432,"context_line":"            self.l7policy.delete()"},{"line_number":433,"context_line":"        for r in self.l7policy.l7rules:"},{"line_number":434,"context_line":"            if r.id \u003d\u003d self.id:"},{"line_number":435,"context_line":"                self.l7policy.l7rules.remove(r)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_1f57ea58","line":432,"in_reply_to":"bae84128_284a81ac","updated":"2016-02-23 09:09:22.000000000","message":"Please read the comment immediately preceeding this line as well as the if statement above that.","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a92ea3a50062ee60a25bcb1ca88542319ea0b373","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            # l7policy should disappear from pool and listener lists. Since"},{"line_number":430,"context_line":"            # we are operating only on the data model, we can fake this by"},{"line_number":431,"context_line":"            # calling the policy\u0027s delete method."},{"line_number":432,"context_line":"            self.l7policy.delete()"},{"line_number":433,"context_line":"        for r in self.l7policy.l7rules:"},{"line_number":434,"context_line":"            if r.id \u003d\u003d self.id:"},{"line_number":435,"context_line":"                self.l7policy.l7rules.remove(r)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_74971748","line":432,"in_reply_to":"bae84128_65cdab84","updated":"2016-02-23 19:29:56.000000000","message":"Ok, continuing on the above comment:\n\nWhen we delete an l7rule, it might be the last rule in its parent l7policy (ie. if statement). If that is the case, then the act of deleting an l7rule may also affect whether the l7policy is \"active,\" which in turn would affect the l7policy\u0027s parent and grandparent relationships. (Said another way, if we delete the l7rule, then l7rule.l7policy.listener.pools and l7rule.l7policy.redirect_pool.listeners may also be affected.)\n\nIt turns out all of the logic for managing these relationships is already in the l7policy (data model) delete method, and if we are in fact deleting the last l7rule off an l7policy, for the purposes of this one action we are having an effect on the data model graph that exactly matches the effect of deleting the l7policy. So yes-- calling the l7policy data model\u0027s delete() method here is a shortcut, but it\u0027s one that logically fits, and saves us from having to duplicate the logic in the l7policy update or delete method below.\n\nDoes this make more sense now?","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac0d2772abf901a6376d659f7a0227f243d7f7d8","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.enabled \u003d enabled"},{"line_number":456,"context_line":"        self.l7rules \u003d l7rules or []"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _conditionally_remove_pool_links(self, pool):"},{"line_number":459,"context_line":"        \"\"\"Removes links to the given pool from parent objects."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        Note this only happens if our listener isn\u0027t referencing the pool"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_0b2977e6","line":458,"updated":"2016-02-23 05:21:06.000000000","message":"Missing unit tests.\nhttp://sonar.octavia.io/archive/octavia/0732e81bcd03c4a78a2257b5eccf958478735dd7/352/cover/octavia_common_data_models_py.html#n458","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"7fa352cf0c05471217999d244fb579e7f4d02c94","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.enabled \u003d enabled"},{"line_number":456,"context_line":"        self.l7rules \u003d l7rules or []"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _conditionally_remove_pool_links(self, pool):"},{"line_number":459,"context_line":"        \"\"\"Removes links to the given pool from parent objects."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        Note this only happens if our listener isn\u0027t referencing the pool"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_9f065a84","line":458,"in_reply_to":"bae84128_0b2977e6","updated":"2016-02-23 09:09:22.000000000","message":"Michael-- can we talk about this?","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac0d2772abf901a6376d659f7a0227f243d7f7d8","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                self.listener.pools.remove(pool)"},{"line_number":475,"context_line":"                pool.listeners.remove(self.listener)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def update(self, update_dict):"},{"line_number":478,"context_line":"        for key, value in update_dict.items():"},{"line_number":479,"context_line":"            if key \u003d\u003d \u0027redirect_pool_id\u0027:"},{"line_number":480,"context_line":"                self._conditionally_remove_pool_links(self.redirect_pool)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_eb253309","line":477,"updated":"2016-02-23 05:21:06.000000000","message":"Missing unit tests.\nhttp://sonar.octavia.io/archive/octavia/0732e81bcd03c4a78a2257b5eccf958478735dd7/352/cover/octavia_common_data_models_py.html#n477","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac0d2772abf901a6376d659f7a0227f243d7f7d8","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                self.redirect_pool.listeners.append(self.listener)"},{"line_number":522,"context_line":"            setattr(self, key, value)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def delete(self):"},{"line_number":525,"context_line":"        self._conditionally_remove_pool_links(self.redirect_pool)"},{"line_number":526,"context_line":"        if self.redirect_pool:"},{"line_number":527,"context_line":"            for p in self.redirect_pool.l7policies:"}],"source_content_type":"text/x-python","patch_set":34,"id":"bae84128_4b1fffb6","line":524,"updated":"2016-02-23 05:21:06.000000000","message":"Missing unit tests.\nhttp://sonar.octavia.io/archive/octavia/0732e81bcd03c4a78a2257b5eccf958478735dd7/352/cover/octavia_common_data_models_py.html#n524","commit_id":"0732e81bcd03c4a78a2257b5eccf958478735dd7"}],"octavia/db/migration/alembic_migrations/versions/458c9ee2a011_l7_policies_and_rules.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d397e980b8d82e6ecbf65362fd1c1ea8306c1159","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# revision identifiers, used by Alembic."},{"line_number":24,"context_line":"revision \u003d \u0027458c9ee2a011\u0027"},{"line_number":25,"context_line":"down_revision \u003d \u002729ff921a6eb\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from alembic import op"},{"line_number":28,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_441d63bc","line":25,"updated":"2016-02-03 05:42:06.000000000","message":"I\u0027m still not clear on whether we are supposed to be explicitly removing down_revision or not. Do we just leave it and say we don\u0027t support downgrades, or are we actually supposed to remove the line from this generated file?","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"d5aa90af4ae61731c892eb53033c4e1bfaf08126","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# revision identifiers, used by Alembic."},{"line_number":24,"context_line":"revision \u003d \u0027458c9ee2a011\u0027"},{"line_number":25,"context_line":"down_revision \u003d \u002729ff921a6eb\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from alembic import op"},{"line_number":28,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_82c4ab92","line":25,"in_reply_to":"5a5ae5dd_441d63bc","updated":"2016-02-03 06:35:04.000000000","message":"Again, you\u0027re thinking of the \u0027downgrade\u0027 method, which we don\u0027t do. We still have to mention the down_revision because alembic uses these for piecing together the migration chain so it knows the order in which these migrations should be applied.","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f1f0382a3daeb93f549cbcdaa3181cb2c4868bae","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# revision identifiers, used by Alembic."},{"line_number":24,"context_line":"revision \u003d \u0027458c9ee2a011\u0027"},{"line_number":25,"context_line":"down_revision \u003d \u002729ff921a6eb\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from alembic import op"},{"line_number":28,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_466bfe1e","line":25,"in_reply_to":"5a5ae5dd_82c4ab92","updated":"2016-02-03 20:13:29.000000000","message":"Ah, gotcha. Still having a hard time with keeping them straight. T_T","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d397e980b8d82e6ecbf65362fd1c1ea8306c1159","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    op.bulk_insert("},{"line_number":48,"context_line":"        insert_table,"},{"line_number":49,"context_line":"        ["},{"line_number":50,"context_line":"            {\u0027name\u0027: \u0027HOST_NAME\u0027},"},{"line_number":51,"context_line":"            {\u0027name\u0027: \u0027PATH\u0027},"},{"line_number":52,"context_line":"            {\u0027name\u0027: \u0027FILE_TYPE\u0027},"},{"line_number":53,"context_line":"            {\u0027name\u0027: \u0027HEADER\u0027},"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_04cc4b34","line":50,"updated":"2016-02-03 05:42:06.000000000","message":"We give these tables a name and a description, and we don\u0027t load up the description for any of them? :/","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"d5aa90af4ae61731c892eb53033c4e1bfaf08126","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    op.bulk_insert("},{"line_number":48,"context_line":"        insert_table,"},{"line_number":49,"context_line":"        ["},{"line_number":50,"context_line":"            {\u0027name\u0027: \u0027HOST_NAME\u0027},"},{"line_number":51,"context_line":"            {\u0027name\u0027: \u0027PATH\u0027},"},{"line_number":52,"context_line":"            {\u0027name\u0027: \u0027FILE_TYPE\u0027},"},{"line_number":53,"context_line":"            {\u0027name\u0027: \u0027HEADER\u0027},"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_02375bb1","line":50,"in_reply_to":"5a5ae5dd_04cc4b34","updated":"2016-02-03 06:35:04.000000000","message":"...so exactly like every other lookup table in Octavia.\n\nAnyone looking for ATC credit still? It\u0027d be a thing to do a migration which adds descriptions to all these lookup tables.","commit_id":"9c30a08b415b355f9595159503214586c4dd6073"}],"octavia/db/models.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c52d4076e1d96c1e85b62d77272df3d583d6867e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    # *actually* using the pool."},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def listeners(self):"},{"line_number":242,"context_line":"        _listeners \u003d self._default_listeners"},{"line_number":243,"context_line":"        _l_ids \u003d [l.id for l in _listeners]"},{"line_number":244,"context_line":"        l7_listeners \u003d [p.listener for p in self.l7policies"},{"line_number":245,"context_line":"                        if len(p.l7rules) \u003e 0 and p.enabled is True]"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a57f1b5_a2ec922a","line":242,"updated":"2016-02-12 18:15:11.000000000","message":"Is this intended to prevent changes from being saved in the class scope variable, or is it just a shortcut? If it\u0027s the former, this doesn\u0027t work. If it\u0027s the latter... I guess that\u0027s fine, but it seems unnecessary. :P\n\nAlso, where is self._default_listeners defined? I assume this is a backref or something since I don\u0027t see it above?","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"44938f4729490e0b1498cae2250456bd504fc3b3","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    # *actually* using the pool."},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def listeners(self):"},{"line_number":242,"context_line":"        _listeners \u003d self._default_listeners"},{"line_number":243,"context_line":"        _l_ids \u003d [l.id for l in _listeners]"},{"line_number":244,"context_line":"        l7_listeners \u003d [p.listener for p in self.l7policies"},{"line_number":245,"context_line":"                        if len(p.l7rules) \u003e 0 and p.enabled is True]"}],"source_content_type":"text/x-python","patch_set":28,"id":"dae33548_7b0aa822","line":242,"in_reply_to":"1a54edaf_d75fcc73","updated":"2016-02-16 23:53:56.000000000","message":"Yeah, determined you were trying to copy the list. Use copy.copy() or use a list-comprehension to remake the list in this case.","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"18cfd864bc96025f694e0714fd840a4bc9a3d0e4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    # *actually* using the pool."},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def listeners(self):"},{"line_number":242,"context_line":"        _listeners \u003d self._default_listeners"},{"line_number":243,"context_line":"        _l_ids \u003d [l.id for l in _listeners]"},{"line_number":244,"context_line":"        l7_listeners \u003d [p.listener for p in self.l7policies"},{"line_number":245,"context_line":"                        if len(p.l7rules) \u003e 0 and p.enabled is True]"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a54edaf_d75fcc73","line":242,"in_reply_to":"3a57f1b5_a2ec922a","updated":"2016-02-13 06:58:24.000000000","message":"Self _default_listeners is a backref from the Listener model (line 369 in this file, actually). What I\u0027m doing in this method is compiling a unique list of all the listeners that reference this pool either via default_pool assignments, or via active / enabled L7Policies. This is primarily used when determining which listeners need to have their configuration updated if something about the pool or one of its children changes.","commit_id":"f592a0cd433e7fc78a3fc007a9b742c319651eed"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"abd3bce5e074626ea12c9395c4e61a0581ee6fbf","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    # *actually* using the pool."},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def listeners(self):"},{"line_number":242,"context_line":"        _listeners \u003d self._default_listeners"},{"line_number":243,"context_line":"        _l_ids \u003d [l.id for l in _listeners]"},{"line_number":244,"context_line":"        l7_listeners \u003d [p.listener for p in self.l7policies"},{"line_number":245,"context_line":"                        if len(p.l7rules) \u003e 0 and p.enabled is True]"}],"source_content_type":"text/x-python","patch_set":29,"id":"dae33548_1b2a7c7e","line":242,"updated":"2016-02-16 23:54:37.000000000","message":"Need to actually copy the list not just re-reference it.","commit_id":"f7c938ac244e51904ea62ee025395e120f3635ae"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a8040a4960b780cfd70b213462dac82db2c07c25","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    # *actually* using the pool."},{"line_number":240,"context_line":"    @property"},{"line_number":241,"context_line":"    def listeners(self):"},{"line_number":242,"context_line":"        _listeners \u003d self._default_listeners"},{"line_number":243,"context_line":"        _l_ids \u003d [l.id for l in _listeners]"},{"line_number":244,"context_line":"        l7_listeners \u003d [p.listener for p in self.l7policies"},{"line_number":245,"context_line":"                        if len(p.l7rules) \u003e 0 and p.enabled is True]"}],"source_content_type":"text/x-python","patch_set":29,"id":"dae33548_4597faeb","line":242,"in_reply_to":"dae33548_1b2a7c7e","updated":"2016-02-17 04:50:06.000000000","message":"Great catch, eh! Next revision has this fixed.","commit_id":"f7c938ac244e51904ea62ee025395e120f3635ae"}],"octavia/tests/functional/db/test_models.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"6bf1f0f6323fd505d0d7c93c7cb5e504bc3c5804","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        self.listener \u003d self.create_listener(self.session)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_create(self):"},{"line_number":623,"context_line":"        self.create_l7policy(self.session, self.listener.id)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_update(self):"},{"line_number":626,"context_line":"        l7policy \u003d self.create_l7policy(self.session, self.listener.id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_feaf25e1","line":623,"updated":"2016-01-27 21:55:04.000000000","message":"No assertions?!?!","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"db675983a88dd8dfa791eb1c4cb96c09542bb725","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        self.listener \u003d self.create_listener(self.session)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_create(self):"},{"line_number":623,"context_line":"        self.create_l7policy(self.session, self.listener.id)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_update(self):"},{"line_number":626,"context_line":"        l7policy \u003d self.create_l7policy(self.session, self.listener.id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_62428840","line":623,"in_reply_to":"7a5de9d1_1b8ec578","updated":"2016-01-28 16:08:29.000000000","message":"I did NOT see that, but now it saddens me.  They aren\u0027t tests if they don\u0027t assert... they just, might critically fail instead.  That\u0027s kinda bad.","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"0f4f5081ba0040923fe06f929c08d555c4123c5e","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        self.listener \u003d self.create_listener(self.session)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_create(self):"},{"line_number":623,"context_line":"        self.create_l7policy(self.session, self.listener.id)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_update(self):"},{"line_number":626,"context_line":"        l7policy \u003d self.create_l7policy(self.session, self.listener.id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_6b47c31d","line":623,"in_reply_to":"7a5de9d1_62428840","updated":"2016-01-28 16:45:49.000000000","message":"Well, at least it\u0027s a problem easily corrected (as I have done for the stuff I added in my latest patchset, per your comment). Have anyone on the team still in need of ATC credit who\u0027s up for an easy patch? ;)","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"52fc500f6ba5528a64a6faf33fe1a349224b4a77","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        self.listener \u003d self.create_listener(self.session)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_create(self):"},{"line_number":623,"context_line":"        self.create_l7policy(self.session, self.listener.id)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_update(self):"},{"line_number":626,"context_line":"        l7policy \u003d self.create_l7policy(self.session, self.listener.id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_1b8ec578","line":623,"in_reply_to":"7a5de9d1_feaf25e1","updated":"2016-01-28 05:14:34.000000000","message":"Aah-- must have missed this. I\u0027ll add one.\n\nEr... you know that almost none of the test_create methods in this file have any assertions, right?","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"6bf1f0f6323fd505d0d7c93c7cb5e504bc3c5804","unresolved":false,"context_lines":[{"line_number":659,"context_line":"            models.L7Policy).filter_by(id\u003dl7policy.id).first()"},{"line_number":660,"context_line":"        self.assertIsNotNone(new_l7policy.l7rules)"},{"line_number":661,"context_line":"        self.assertEqual(2, len(new_l7policy.l7rules))"},{"line_number":662,"context_line":"        self.assertIsInstance(new_l7policy.l7rules[0], models.L7Rule)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def test_pool_relationship(self):"},{"line_number":665,"context_line":"        l7policy \u003d self.create_l7policy(self.session, self.listener.id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_deaa6970","line":662,"updated":"2016-01-27 21:55:04.000000000","message":"Should add another assertion for the second rule to be in the list.","commit_id":"28955f2d47282490154fda974934f2ce7455f759"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"52fc500f6ba5528a64a6faf33fe1a349224b4a77","unresolved":false,"context_lines":[{"line_number":659,"context_line":"            models.L7Policy).filter_by(id\u003dl7policy.id).first()"},{"line_number":660,"context_line":"        self.assertIsNotNone(new_l7policy.l7rules)"},{"line_number":661,"context_line":"        self.assertEqual(2, len(new_l7policy.l7rules))"},{"line_number":662,"context_line":"        self.assertIsInstance(new_l7policy.l7rules[0], models.L7Rule)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def test_pool_relationship(self):"},{"line_number":665,"context_line":"        l7policy \u003d self.create_l7policy(self.session, self.listener.id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_db3cad95","line":662,"in_reply_to":"7a5de9d1_deaa6970","updated":"2016-01-28 05:14:34.000000000","message":"Done","commit_id":"28955f2d47282490154fda974934f2ce7455f759"}]}
