)]}'
{"etc/octavia.conf":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e47b4277d5d7946a5b78a69be8589ad1e355acf5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# os_region_name \u003d"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Endpoint type to use for communication with the Barbican service."},{"line_number":19,"context_line":"# barbican_endpoint_type \u003d public"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# Hostname to be used by the host machine for services running on it."},{"line_number":22,"context_line":"# The default value is the hostname of the host machine."}],"source_content_type":"text/plain","patch_set":4,"id":"5a5ae5dd_241dc766","line":19,"updated":"2016-02-03 05:03:24.000000000","message":"This option should be in the [certificates] section (probably right below \"barbican_auth\".","commit_id":"7f0a53856cd0259f3489995cd95e8e7862375be8"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"0782fc54e13b4b2e126a1fea840752f80ded503d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# os_region_name \u003d"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Endpoint type to use for communication with the Barbican service."},{"line_number":19,"context_line":"# barbican_endpoint_type \u003d public"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# Hostname to be used by the host machine for services running on it."},{"line_number":22,"context_line":"# The default value is the hostname of the host machine."}],"source_content_type":"text/plain","patch_set":4,"id":"5a5ae5dd_843efbb6","line":19,"in_reply_to":"5a5ae5dd_241dc766","updated":"2016-02-03 05:05:31.000000000","message":"+1 (per our new scheme established in the neutron and nova endpoint patch)","commit_id":"7f0a53856cd0259f3489995cd95e8e7862375be8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"df378bcfea7dfcf98134cf53a1d4e23d728d6696","unresolved":false,"context_lines":[{"line_number":86,"context_line":"# region_name \u003d"},{"line_number":87,"context_line":"#"},{"line_number":88,"context_line":"# Endpoint type to use for communication with the Barbican service."},{"line_number":89,"context_line":"# endpoint_type \u003d public"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[anchor]"}],"source_content_type":"text/plain","patch_set":6,"id":"5a5ae5dd_586b1f85","line":89,"updated":"2016-02-08 18:04:11.000000000","message":"I think maybe this should be \"publicURL\"? Just looking at https://review.openstack.org/#/c/271476/8/etc/octavia.conf which I think is correct.","commit_id":"9a5a767f2b5163ae4c374575e99987dd1eeb7d0f"}],"octavia/certificates/common/auth/barbican_acl.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a610bc825c85bc85fa9c7025552ad12094240b36","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class BarbicanACLAuth(barbican_common.BarbicanAuth):"},{"line_number":35,"context_line":"    _barbican_client \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_cea6600e","line":32,"updated":"2016-02-08 20:45:43.000000000","message":"need to import group, e.g. CONF.import_group(\u0027certificates\u0027, \u0027octavia.common.config\u0027)","commit_id":"1f50e3108133a18aacea74ca7ca43d6a3275cd5e"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"ac4f26c09d41d6803c60fe7dea255dabafa30cb6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class BarbicanACLAuth(barbican_common.BarbicanAuth):"},{"line_number":35,"context_line":"    _barbican_client \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_ce45006f","line":32,"in_reply_to":"5a5ae5dd_cea6600e","updated":"2016-02-08 21:06:38.000000000","message":"I agree..","commit_id":"1f50e3108133a18aacea74ca7ca43d6a3275cd5e"}],"octavia/common/config.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"1bbf5541afec1fa085508aa8b00beaee352a1ee7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               help\u003d_(\u0027CA file for novaclient to verify server certificates\u0027)),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027nova_api_insecure\u0027, default\u003dFalse,"},{"line_number":74,"context_line":"                help\u003d_(\"If True, ignore any SSL validation issues\")),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Region in Identity service catalog to use for \u0027"},{"line_number":77,"context_line":"                      \u0027communication with the OpenStack services.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027os_endpoint_type\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_99de0810","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":30},"updated":"2016-01-28 23:07:44.000000000","message":"Do we need any default values here ?","commit_id":"9bfa47cf51cc0d93dd73439a68f3b45dbb15a26d"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"1bbf5541afec1fa085508aa8b00beaee352a1ee7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.StrOpt(\u0027os_endpoint_type\u0027,"},{"line_number":79,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027The endpoint_type to be used.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027octavia_plugins\u0027,"},{"line_number":82,"context_line":"               default\u003d\u0027hot_plug_plugin\u0027,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Name of the controller plugin to use\u0027))"},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_b9642449","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":31},"updated":"2016-01-28 23:07:44.000000000","message":"Can we add this parameter in the sample octavia.conf","commit_id":"9bfa47cf51cc0d93dd73439a68f3b45dbb15a26d"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e47b4277d5d7946a5b78a69be8589ad1e355acf5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Region in Identity service catalog to use for \u0027"},{"line_number":77,"context_line":"                      \u0027communication with the OpenStack services.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027barbican_endpoint_type\u0027,"},{"line_number":79,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027The endpoint_type to be used for barbican.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027octavia_plugins\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_84103b50","line":78,"updated":"2016-02-03 05:03:24.000000000","message":"This option should be in the [certificates] section (certificate_opts).","commit_id":"7f0a53856cd0259f3489995cd95e8e7862375be8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"df378bcfea7dfcf98134cf53a1d4e23d728d6696","unresolved":false,"context_lines":[{"line_number":289,"context_line":"               help\u003d\u0027Region in Identity service catalog to use for \u0027"},{"line_number":290,"context_line":"                    \u0027communication with the barbican service.\u0027),"},{"line_number":291,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027,"},{"line_number":292,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027The endpoint_type to be used for barbican service.\u0027)"},{"line_number":294,"context_line":"]"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_3832e3a7","line":292,"updated":"2016-02-08 18:04:11.000000000","message":"publicURL ?","commit_id":"9a5a767f2b5163ae4c374575e99987dd1eeb7d0f"}],"octavia/tests/unit/certificates/common/auth/test_barbican_acl.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"df378bcfea7dfcf98134cf53a1d4e23d728d6696","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        keystone._SESSION \u003d None"},{"line_number":32,"context_line":"        CONF.set_override(\u0027region_name\u0027, None,"},{"line_number":33,"context_line":"                          group\u003d\u0027certificates\u0027)"},{"line_number":34,"context_line":"        CONF.set_override(\u0027endpoint_type\u0027, \"public\","},{"line_number":35,"context_line":"                          group\u003d\u0027certificates\u0027)"},{"line_number":36,"context_line":"        super(TestBarbicanACLAuth, self).setUp()"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_5819df20","line":34,"updated":"2016-02-08 18:04:11.000000000","message":"publicURL ?","commit_id":"9a5a767f2b5163ae4c374575e99987dd1eeb7d0f"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a610bc825c85bc85fa9c7025552ad12094240b36","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from octavia.common import keystone"},{"line_number":22,"context_line":"import octavia.tests.unit.base as base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestBarbicanACLAuth(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_ee847c5e","line":24,"range":{"start_line":24,"start_character":11,"end_line":24,"end_character":15},"updated":"2016-02-08 20:45:43.000000000","message":"need to import group","commit_id":"1f50e3108133a18aacea74ca7ca43d6a3275cd5e"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"ac4f26c09d41d6803c60fe7dea255dabafa30cb6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # Reset the client"},{"line_number":31,"context_line":"        keystone._SESSION \u003d None"},{"line_number":32,"context_line":"        CONF.set_override(\u0027region_name\u0027, None,"},{"line_number":33,"context_line":"                          group\u003d\u0027certificates\u0027)"},{"line_number":34,"context_line":"        CONF.set_override(\u0027endpoint_type\u0027, \"publicURL\","},{"line_number":35,"context_line":"                          group\u003d\u0027certificates\u0027)"},{"line_number":36,"context_line":"        super(TestBarbicanACLAuth, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_0ef47858","line":33,"updated":"2016-02-08 21:06:38.000000000","message":"While addressing German\u0027s nit, update this with keyword args to avoid confusions..\n\nCONF.set_override(name\u003d\u0027region_name\u0027, \n                          override\u003dNone, group\u003d\u0027certificates\u0027)","commit_id":"1f50e3108133a18aacea74ca7ca43d6a3275cd5e"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"ac4f26c09d41d6803c60fe7dea255dabafa30cb6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        CONF.set_override(\u0027region_name\u0027, None,"},{"line_number":33,"context_line":"                          group\u003d\u0027certificates\u0027)"},{"line_number":34,"context_line":"        CONF.set_override(\u0027endpoint_type\u0027, \"publicURL\","},{"line_number":35,"context_line":"                          group\u003d\u0027certificates\u0027)"},{"line_number":36,"context_line":"        super(TestBarbicanACLAuth, self).setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_get_barbican_client(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_0e9b1819","line":35,"updated":"2016-02-08 21:06:38.000000000","message":"Same as above.\n\nCONF.set_override(name\u003d\u0027endpoint_type\u0027, \n                          override\u003d\u0027publicURL\u0027, group\u003d\u0027certificates\u0027)","commit_id":"1f50e3108133a18aacea74ca7ca43d6a3275cd5e"}]}