)]}'
{"elements/apt-mirror/finalise.d/98-setup":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4c4ba5b4ca074ded104b11cee9dc79b728ef2c74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_957f7565","updated":"2016-01-29 21:48:20.000000000","message":"nit This probably doesn\u0027t need to change now.","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"173d6b2c45ec6d432198110bd76776c3e7e46a8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_55d1fdf8","in_reply_to":"7a5de9d1_957f7565","updated":"2016-01-29 21:57:24.000000000","message":"Aah-- you are correct. This finalize script doesn\u0027t depend on DNS working. :)","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"}],"elements/no-resolvconf/finalise.d/99-disable-resolv-conf":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"c21ef4cc5d1c0f56c0b2cca9c22d33a3efee737a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_4442b1af","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":11},"updated":"2016-01-29 20:38:36.000000000","message":"Please address johnsom\u0027s comments","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a798d4bf6ba4a73d48959ea0673482af711cdc3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_e46abded","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":11},"in_reply_to":"7a5de9d1_4442b1af","updated":"2016-01-29 20:39:44.000000000","message":"Dude, I *did* address his comments!","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"bd3f55d5209480ab9c686b11dd63e5e1aec50c08","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_35b3219a","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":11},"in_reply_to":"7a5de9d1_958695d9","updated":"2016-01-29 22:03:15.000000000","message":"Heh! Made it a 1-liner anyway. XD","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"173d6b2c45ec6d432198110bd76776c3e7e46a8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_958695d9","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":11},"in_reply_to":"7a5de9d1_b53951a6","updated":"2016-01-29 21:57:24.000000000","message":"Actually, I spoke with him on IRC--  he was looking at an old patchset and hadn\u0027t seen my comments to you.\n\nThe make_resolv_conf() script below works without the semicolon because there\u0027s a carriage return after the :\nI could probably make it a 1-liner if y\u0027all want, but I know that this works right now (as I\u0027m running it in a loop in devstack).","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"310bf733edcdef9475fef36437376fa830d3bcc7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_ffb7aa37","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":11},"in_reply_to":"7a5de9d1_e46abded","updated":"2016-01-29 20:46:14.000000000","message":"oops sorry :/","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4c4ba5b4ca074ded104b11cee9dc79b728ef2c74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_b53951a6","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":11},"in_reply_to":"7a5de9d1_ffb7aa37","updated":"2016-01-29 21:48:20.000000000","message":"I think he meant the comment about the missing \u0027;\u0027 below in the make_resolv_conf function.\nNot 100% sure it is needed, but it exists in the original \"resolvconf\" script.","commit_id":"a4b6a49d8b5d7b63010bc78080e5084e6c6f9236"}],"elements/no-resolvconf/finalise.d/99-setup":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"45b86db02946f2696a1dcb1faa0d1858fe3f1acd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a5de9d1_6b0c6041","updated":"2016-01-29 19:28:46.000000000","message":"It would be better to give this a descriptive filename.  Maybe:\n99-disable-resolv-conf","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"82bc2e623034e94bb0e4f4745f0a15263e8f285c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a5de9d1_2ee3d634","in_reply_to":"7a5de9d1_6b0c6041","updated":"2016-01-29 19:39:47.000000000","message":"Will do.","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"37ba8a518062ac8a75a6716128ca6af5f5c2c239","unresolved":false,"context_lines":[{"line_number":2,"context_line":"echo \"\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"echo \"#!/bin/sh"},{"line_number":4,"context_line":"make_resolv_conf(){"},{"line_number":5,"context_line":"    :"},{"line_number":6,"context_line":"}\" \u003e /etc/dhcp/dhclient-enter-hooks.d/noresolvconf"},{"line_number":7,"context_line":"chmod +x /etc/dhcp/dhclient-enter-hooks.d/noresolvconf"},{"line_number":8,"context_line":"rm -f /etc/dhcp/dhclient-enter-hooks.d/resolvconf"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_014d8bc3","line":5,"updated":"2016-01-29 20:08:47.000000000","message":"Do you need a \u0027;\u0027 after \u0027:\u0027?","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"}],"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"45b86db02946f2696a1dcb1faa0d1858fe3f1acd","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"[controller_worker]"},{"line_number":122,"context_line":"# amp_active_retries \u003d 100"},{"line_number":123,"context_line":"# amp_active_wait_sec \u003d 1"},{"line_number":124,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":125,"context_line":"# amp_flavor_id \u003d"},{"line_number":126,"context_line":"# amp_image_id \u003d"}],"source_content_type":"text/plain","patch_set":1,"id":"7a5de9d1_4beac4dc","line":123,"updated":"2016-01-29 19:28:46.000000000","message":"I think this is too aggressive.  This is hitting the nova api and I worry that rate limiting could impact us/ban us.","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"82bc2e623034e94bb0e4f4745f0a15263e8f285c","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"[controller_worker]"},{"line_number":122,"context_line":"# amp_active_retries \u003d 100"},{"line_number":123,"context_line":"# amp_active_wait_sec \u003d 1"},{"line_number":124,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":125,"context_line":"# amp_flavor_id \u003d"},{"line_number":126,"context_line":"# amp_image_id \u003d"}],"source_content_type":"text/plain","patch_set":1,"id":"7a5de9d1_eeda9e4b","line":123,"in_reply_to":"7a5de9d1_4beac4dc","updated":"2016-01-29 19:39:47.000000000","message":"In a busy production environment, maybe--  but definitely not in a devstack. I have been running this continuously for the past 10 hours and have not seen any rate limiting.\n\nI could update the devstack plugin.sh to adjust these values if you want so that in devstack they\u0027re lower, but by default (ie. production... where people probably want to tweak these anyway, but I digress) they\u0027re not. Would that be acceptable?\n\nI really want to keep this and the other wait timeout-related optimization because I\u0027m noticing it making a 1-10 second difference per test in the total time it takes to complete tempest runs.","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"735ff3b16aa468c7de90c653b030a8c8b97c8e0c","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"[controller_worker]"},{"line_number":122,"context_line":"# amp_active_retries \u003d 100"},{"line_number":123,"context_line":"# amp_active_wait_sec \u003d 1"},{"line_number":124,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":125,"context_line":"# amp_flavor_id \u003d"},{"line_number":126,"context_line":"# amp_image_id \u003d"}],"source_content_type":"text/plain","patch_set":1,"id":"7a5de9d1_a17fd764","line":123,"in_reply_to":"7a5de9d1_eeda9e4b","updated":"2016-01-29 19:57:48.000000000","message":"I would be ok with the plugin.sh approach.\nI would like others to comment on this too as I know there was some concern about hitting the APIs too hard in previous conversations.","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"45b86db02946f2696a1dcb1faa0d1858fe3f1acd","unresolved":false,"context_lines":[{"line_number":210,"context_line":"               default\u003d100,"},{"line_number":211,"context_line":"               help\u003d_(\u0027Retry attempts to wait for Amphora to become active\u0027)),"},{"line_number":212,"context_line":"    cfg.IntOpt(\u0027amp_active_wait_sec\u0027,"},{"line_number":213,"context_line":"               default\u003d1,"},{"line_number":214,"context_line":"               help\u003d_(\u0027Seconds to wait between checks on whether an Amphora \u0027"},{"line_number":215,"context_line":"                      \u0027has become active\u0027)),"},{"line_number":216,"context_line":"    cfg.StrOpt(\u0027amp_flavor_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_2bed08ef","line":213,"updated":"2016-01-29 19:28:46.000000000","message":"I think this is too aggressive.  This is hitting the nova api and I worry that rate limiting could impact us/ban us.","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"82bc2e623034e94bb0e4f4745f0a15263e8f285c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"               default\u003d100,"},{"line_number":211,"context_line":"               help\u003d_(\u0027Retry attempts to wait for Amphora to become active\u0027)),"},{"line_number":212,"context_line":"    cfg.IntOpt(\u0027amp_active_wait_sec\u0027,"},{"line_number":213,"context_line":"               default\u003d1,"},{"line_number":214,"context_line":"               help\u003d_(\u0027Seconds to wait between checks on whether an Amphora \u0027"},{"line_number":215,"context_line":"                      \u0027has become active\u0027)),"},{"line_number":216,"context_line":"    cfg.StrOpt(\u0027amp_flavor_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_eec13e55","line":213,"in_reply_to":"7a5de9d1_2bed08ef","updated":"2016-01-29 19:39:47.000000000","message":"(see my previous comment.)","commit_id":"aa755c8eda4f2fafa6f170d9b75baf08c7a7a67a"}]}