)]}'
{"octavia/common/constants.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2037e24633c8f00cc0cb1f84ac1017d5922784f4","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# See RFCs 2616, 2965, 6265, 7230: Should match characters valid in a"},{"line_number":113,"context_line":"# http header or cookie name."},{"line_number":114,"context_line":"HTTP_HEADER_NAME_REGEX \u003d r\u0027\\A[a-zA-Z0-9!#$%\u0026\\\u0027*+-.^_`|~]+\\Z\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# See RFCs 2616, 2965, 6265: Should match characters valid in a cookie value."},{"line_number":117,"context_line":"HTTP_COOKIE_VALUE_REGEX \u003d r\u0027\\A[a-zA-Z0-9!#$%\u0026\\\u0027()*+-./:\u003c\u003d\u003e?@[\\]^_`{|}~]+\\Z\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_1f0c1fec","line":114,"updated":"2016-02-22 21:23:02.000000000","message":"I trust you.","commit_id":"17e9cff26e19d0ef849f79c18da75cbd51b2b8e6"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1b153a5fd5756816fcbf07b332ea5a1e90cc9364","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# See RFCs 2616, 2965, 6265, 7230: Should match characters valid in a"},{"line_number":113,"context_line":"# http header or cookie name."},{"line_number":114,"context_line":"HTTP_HEADER_NAME_REGEX \u003d r\u0027\\A[a-zA-Z0-9!#$%\u0026\\\u0027*+-.^_`|~]+\\Z\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# See RFCs 2616, 2965, 6265: Should match characters valid in a cookie value."},{"line_number":117,"context_line":"HTTP_COOKIE_VALUE_REGEX \u003d r\u0027\\A[a-zA-Z0-9!#$%\u0026\\\u0027()*+-./:\u003c\u003d\u003e?@[\\]^_`{|}~]+\\Z\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_4aa387b2","line":114,"in_reply_to":"bae84128_1f0c1fec","updated":"2016-02-22 21:45:08.000000000","message":"Many bogons died to bring you this regex.","commit_id":"17e9cff26e19d0ef849f79c18da75cbd51b2b8e6"}],"octavia/common/validate.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"65c137eb3a6fa7ee3f9adfa8e7e7c6d9435ab820","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Note that we can evaluate this outside the context of any L7 Policy because"},{"line_number":71,"context_line":"# L7 rules must be internally consistent."},{"line_number":72,"context_line":"def l7rule_data(l7rule):"},{"line_number":73,"context_line":"    \"\"\"Raises an error if the l7rule given is invalid in some way.\"\"\""},{"line_number":74,"context_line":"    if l7rule.type \u003d\u003d constants.L7RULE_TYPE_HEADER:"},{"line_number":75,"context_line":"        if not l7rule.key:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_16ba3a0a","line":72,"updated":"2016-02-23 05:49:10.000000000","message":"I think we should restrict string lengths somewhere in the chain.  It looks like this is the first validation in the chain (api, etc.).  I worry about the security of open string input and would like to lock it down as much as possible early in the processing.  Maybe I am missing the validation somewhere in the Octavia API.","commit_id":"17e9cff26e19d0ef849f79c18da75cbd51b2b8e6"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"4965c0fa2c8b11a2efa5c15c38ddc5ad9f054ca4","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Note that we can evaluate this outside the context of any L7 Policy because"},{"line_number":71,"context_line":"# L7 rules must be internally consistent."},{"line_number":72,"context_line":"def l7rule_data(l7rule):"},{"line_number":73,"context_line":"    \"\"\"Raises an error if the l7rule given is invalid in some way.\"\"\""},{"line_number":74,"context_line":"    if l7rule.type \u003d\u003d constants.L7RULE_TYPE_HEADER:"},{"line_number":75,"context_line":"        if not l7rule.key:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_2216154c","line":72,"in_reply_to":"bae84128_16ba3a0a","updated":"2016-02-23 09:15:33.000000000","message":"You are. Please see octavia/api/v1/types/l7rule.py","commit_id":"17e9cff26e19d0ef849f79c18da75cbd51b2b8e6"}],"octavia/common/validations.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"1ffa6497fce36b9fca915cc2614b4d3169a25b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a5ae5dd_3b8b066a","updated":"2016-02-05 20:03:30.000000000","message":"just a minor opinion, what do you think of calling this module \"validate.py\" and then all the method names just aren\u0027t prepended with \"validate_\"?  So when this module is imported, and used it\u0027d be used like validate.url(), validate.header_name(), etc.\n\nNot a big deal just wanted to see opinions? less character count and all.","commit_id":"0281fb99ac3ab9b70d39bebf78621a47717e8baf"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"56376dd5d4975f6a76148f5321ff519d781b81d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a5ae5dd_f0fb3f79","in_reply_to":"5a5ae5dd_3b8b066a","updated":"2016-02-06 07:11:37.000000000","message":"That sounds like a good idea to me. I\u0027ll make that change, eh!","commit_id":"0281fb99ac3ab9b70d39bebf78621a47717e8baf"}],"octavia/db/repositories.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"65c137eb3a6fa7ee3f9adfa8e7e7c6d9435ab820","unresolved":false,"context_lines":[{"line_number":611,"context_line":"            l7rule_dict \u003d l7rule_db.to_data_model().to_dict()"},{"line_number":612,"context_line":"            # Ignore values that are None"},{"line_number":613,"context_line":"            for k, v in model_kwargs.items():"},{"line_number":614,"context_line":"                if v is not None:"},{"line_number":615,"context_line":"                    l7rule_dict.update({k: v})"},{"line_number":616,"context_line":"            # Clear out the \u0027key\u0027 attribute for rule types that don\u0027t use it."},{"line_number":617,"context_line":"            if (\u0027type\u0027 in l7rule_dict.keys() and"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_b656eecb","line":614,"updated":"2016-02-23 05:49:10.000000000","message":"Some minor branch unit test misses here.\nhttp://sonar.octavia.io/archive/octavia/17e9cff26e19d0ef849f79c18da75cbd51b2b8e6/358/cover/octavia_db_repositories_py.html#n614","commit_id":"17e9cff26e19d0ef849f79c18da75cbd51b2b8e6"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"4965c0fa2c8b11a2efa5c15c38ddc5ad9f054ca4","unresolved":false,"context_lines":[{"line_number":611,"context_line":"            l7rule_dict \u003d l7rule_db.to_data_model().to_dict()"},{"line_number":612,"context_line":"            # Ignore values that are None"},{"line_number":613,"context_line":"            for k, v in model_kwargs.items():"},{"line_number":614,"context_line":"                if v is not None:"},{"line_number":615,"context_line":"                    l7rule_dict.update({k: v})"},{"line_number":616,"context_line":"            # Clear out the \u0027key\u0027 attribute for rule types that don\u0027t use it."},{"line_number":617,"context_line":"            if (\u0027type\u0027 in l7rule_dict.keys() and"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_023af1cb","line":614,"in_reply_to":"bae84128_b656eecb","updated":"2016-02-23 09:15:33.000000000","message":"Again, I would like to chat with you about this in the morning.","commit_id":"17e9cff26e19d0ef849f79c18da75cbd51b2b8e6"}]}