)]}'
{"octavia/controller/healthmanager/update_db.py":[{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"22089be8b52002d17610dba41318d13dc57c4109","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        listeners \u003d health[\u0027listeners\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Do not update ampohra health if the reporting listener count"},{"line_number":102,"context_line":"        # does not match the expected listener count"},{"line_number":103,"context_line":"        if len(listeners) \u003d\u003d expected_listener_count:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a8946936","line":101,"range":{"start_line":101,"start_character":24,"end_line":101,"end_character":31},"updated":"2016-02-18 19:14:01.000000000","message":"nit: Not related to this patch but if pushing another patch, please fix this typo.","commit_id":"4672d88c38cdfcce6ee14bbea1f01fe1a2373ef1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a62976130decb8932846f19b37890974dcf92f03","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        listeners \u003d health[\u0027listeners\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Do not update ampohra health if the reporting listener count"},{"line_number":102,"context_line":"        # does not match the expected listener count"},{"line_number":103,"context_line":"        if len(listeners) \u003d\u003d expected_listener_count:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_dc45326f","line":101,"range":{"start_line":101,"start_character":24,"end_line":101,"end_character":31},"in_reply_to":"dae33548_a8946936","updated":"2016-02-18 19:58:40.000000000","message":"Done","commit_id":"4672d88c38cdfcce6ee14bbea1f01fe1a2373ef1"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"22089be8b52002d17610dba41318d13dc57c4109","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":197,"context_line":"                    LOG.error(_LE(\"Pool %s is not in DB\"), pool_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # Update the load balancer status last"},{"line_number":200,"context_line":"        # TODO(sbalukoff): This logic will need to be adjusted if we"},{"line_number":201,"context_line":"        # start supporting multiple load balancers per amphora"},{"line_number":202,"context_line":"        lb_id \u003d self.amphora_repo.get("},{"line_number":203,"context_line":"            session, id\u003dhealth[\u0027id\u0027]).load_balancer_id"},{"line_number":204,"context_line":"        if lb_id is not None:"},{"line_number":205,"context_line":"            try:"},{"line_number":206,"context_line":"                self._update_status_and_emit_event("},{"line_number":207,"context_line":"                    session, self.loadbalancer_repo,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_c8a3adb0","line":204,"range":{"start_line":199,"start_character":8,"end_line":204,"end_character":28},"updated":"2016-02-18 19:14:01.000000000","message":"I am still catching up with past Octavia arch discussions. So, pardon me If I am wrong.. \n\nI understand it\u0027s currently one LB per Amphora but L92 assumes multiple LBs per amphora. For consistency, what about writing a for loop to get all lbs\u0027 of amp and update the status ?","commit_id":"4672d88c38cdfcce6ee14bbea1f01fe1a2373ef1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a62976130decb8932846f19b37890974dcf92f03","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":197,"context_line":"                    LOG.error(_LE(\"Pool %s is not in DB\"), pool_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # Update the load balancer status last"},{"line_number":200,"context_line":"        # TODO(sbalukoff): This logic will need to be adjusted if we"},{"line_number":201,"context_line":"        # start supporting multiple load balancers per amphora"},{"line_number":202,"context_line":"        lb_id \u003d self.amphora_repo.get("},{"line_number":203,"context_line":"            session, id\u003dhealth[\u0027id\u0027]).load_balancer_id"},{"line_number":204,"context_line":"        if lb_id is not None:"},{"line_number":205,"context_line":"            try:"},{"line_number":206,"context_line":"                self._update_status_and_emit_event("},{"line_number":207,"context_line":"                    session, self.loadbalancer_repo,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_9f3c3c94","line":204,"range":{"start_line":199,"start_character":8,"end_line":204,"end_character":28},"in_reply_to":"dae33548_c8a3adb0","updated":"2016-02-18 19:58:40.000000000","message":"I thought about doing that, but didn\u0027t in this case because:\n\n1. Right now the amphora object actually has a load_balancer_id field. If we refactor and allow multiple load balancers per amphora, this structure will need to change and this code will need to be updated. As I\u0027m not sure at this point what form such a refactor might take, it didn\u0027t seem worth it to me to try to predict that here (or even to make a new repo method which would return the list you describe).\n\n2. As the resource footprint of amphorae shrinks, there may be less and less reason to consider an architecture that allows multiple load balancers per amphora. Such a change would both increase complexity and decrease security-- so it may be that we never go down this path in the first place. As such, I thought writing code here which anticipates it is premature. If we go down that path, this code will need to be refactored-- but that\u0027s OK!\n\nThe code near L92 is somewhat troubling to me because I suspect it doesn\u0027t do what the original author intended it to do. But I didn\u0027t think it was worth refactoring at this time. If y\u0027all disagree, I can refactor it-- but I\u0027d probably change it to assume 1 LB per amp. What do y\u0027all think?","commit_id":"4672d88c38cdfcce6ee14bbea1f01fe1a2373ef1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a8ebdba6976e17ad32690f92f5b24876684879f9","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # We need to see if all of the listeners are reporting in"},{"line_number":91,"context_line":"        expected_listener_count \u003d 0"},{"line_number":92,"context_line":"        lbs_on_amp \u003d self.amphora_repo.get_all_lbs_on_amphora(session,"},{"line_number":93,"context_line":"                                                              health[\u0027id\u0027])"},{"line_number":94,"context_line":"        for lb in lbs_on_amp:"},{"line_number":95,"context_line":"            listener_count \u003d self.listener_repo.count(session,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_905727c9","line":92,"updated":"2016-02-24 09:35:01.000000000","message":"Yeah, this really is interesting -- we should try to remember this so we can clean it up, but I don\u0027t think this patch is the place.","commit_id":"2e23ede4c32d941eedc4d6bf16a3b4d9c62438ec"}]}