)]}'
{"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6cdb3e37eb677464a0a1ea65f0188d33675efa6f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                               log\u003dLOG):"},{"line_number":222,"context_line":"            delete_listener_tf.run()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def delete_listener_internal(self, listener_id):"},{"line_number":225,"context_line":"        \"\"\"Deletes a listener as part of an LB delete call"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        :param listener_id: ID of the listener to delete"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_380662ce","line":224,"updated":"2016-02-28 21:17:06.000000000","message":"Missing unit test","commit_id":"7ca43d208fcedc628dc0b9f60f80ffa5ae1c1865"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"87e824824f424ccb38ff20afc1ff11920a4759b1","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                               log\u003dLOG):"},{"line_number":222,"context_line":"            delete_listener_tf.run()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def delete_listener_internal(self, listener_id):"},{"line_number":225,"context_line":"        \"\"\"Deletes a listener as part of an LB delete call"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        :param listener_id: ID of the listener to delete"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_72c806a9","line":224,"in_reply_to":"9aed3d3a_380662ce","updated":"2016-02-29 01:21:36.000000000","message":"I am removing that method in the subsequent patch: https://review.openstack.org/#/c/282587/7/octavia/controller/worker/controller_worker.py -- so we can either assume we merge them more or less together or I can abandon this patch and merge it in the other. If we will not merge both in L I am happy to add a unit test as a bug fix --","commit_id":"7ca43d208fcedc628dc0b9f60f80ffa5ae1c1865"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"512473e08cca03735dc64c26b2b9ac5a56a13f49","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                               log\u003dLOG):"},{"line_number":222,"context_line":"            delete_listener_tf.run()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def delete_listener_internal(self, listener_id):"},{"line_number":225,"context_line":"        \"\"\"Deletes a listener as part of an LB delete call"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        :param listener_id: ID of the listener to delete"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_388f782b","line":224,"in_reply_to":"9aed3d3a_72c806a9","updated":"2016-02-29 07:24:52.000000000","message":"Agreed-- unless this is super simple for German to do tomorrow, I don\u0027t think we should block merging this feature over a unit test. Let\u0027s open a bug and assign it to him to add in the next two weeks while we\u0027ve got a bugfix window.","commit_id":"7ca43d208fcedc628dc0b9f60f80ffa5ae1c1865"}],"octavia/controller/worker/flows/listener_flows.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"f8b02d5f892c58025a892974d65268c8ba30df6d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def get_delete_listener_internal_flow(self):"},{"line_number":61,"context_line":"        \"\"\"Create a flow to delete a listener internally"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"           (will skip deletion on the amp and marking LB active)"},{"line_number":64,"context_line":"        :returns: The flow for deleting a listener"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        delete_listener_flow \u003d linear_flow.Flow(constants.DELETE_LISTENER_FLOW)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_8c36d600","line":63,"range":{"start_line":63,"start_character":42,"end_line":63,"end_character":45},"updated":"2016-02-24 17:11:39.000000000","message":"Might want to say that this is intended to be used in the cascading LB delete feature, and that some other flow needs to ensure that LB and amp status is updated / deleted appropriately (which is what you\u0027re doing, I presume).","commit_id":"f9a5c6baaff62549576824e66c01f9e6f25bb66f"}],"octavia/controller/worker/tasks/controller_tasks.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"f8b02d5f892c58025a892974d65268c8ba30df6d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                               load_balancer_id\u003d("},{"line_number":65,"context_line":"                                                   loadbalancer.id))"},{"line_number":66,"context_line":"        for listener in listeners:"},{"line_number":67,"context_line":"            self.cntrlr_worker.delete_listener_internal(listener.id)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class DisableEnableLB(BaseControllerTask):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_474f8733","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":55},"updated":"2016-02-24 17:11:39.000000000","message":"Ok-- I see this class is only called from the larger delete load balancer class... so I think we\u0027re OK here.","commit_id":"f9a5c6baaff62549576824e66c01f9e6f25bb66f"}]}