)]}'
{"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"4a6b5530b9831f380b230cdf66970156a3ffeb66","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                     # confuse other protocols with None ports"},{"line_number":131,"context_line":"                     # with the egress rules.  VRRP uses protocol"},{"line_number":132,"context_line":"                     # 51 and 112"},{"line_number":133,"context_line":"                     if rule.get(\u0027direction\u0027) !\u003d \u0027egress\u0027 and"},{"line_number":134,"context_line":"                     rule.get(\u0027protocol\u0027).lower() \u003d\u003d \u0027tcp\u0027]"},{"line_number":135,"context_line":"        add_ports \u003d set(updated_ports) - set(old_ports)"},{"line_number":136,"context_line":"        del_ports \u003d set(old_ports) - set(updated_ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_92d224ff","line":133,"range":{"start_line":133,"start_character":50,"end_line":133,"end_character":56},"updated":"2016-02-20 23:55:47.000000000","message":"Does it make sense to use constants here instead of literal strings?","commit_id":"cc32f276191f1730b0e02fa388b6b07aeae276e5"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"ab60e8af7229a6cd7e147ba001000797bb1f0d04","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                     # confuse other protocols with None ports"},{"line_number":131,"context_line":"                     # with the egress rules.  VRRP uses protocol"},{"line_number":132,"context_line":"                     # 51 and 112"},{"line_number":133,"context_line":"                     if rule.get(\u0027direction\u0027) !\u003d \u0027egress\u0027 and"},{"line_number":134,"context_line":"                     rule.get(\u0027protocol\u0027).lower() \u003d\u003d \u0027tcp\u0027]"},{"line_number":135,"context_line":"        add_ports \u003d set(updated_ports) - set(old_ports)"},{"line_number":136,"context_line":"        del_ports \u003d set(old_ports) - set(updated_ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_9842423d","line":133,"range":{"start_line":133,"start_character":50,"end_line":133,"end_character":56},"in_reply_to":"bae84128_029fe3b4","updated":"2016-02-21 07:53:48.000000000","message":"Ok!","commit_id":"cc32f276191f1730b0e02fa388b6b07aeae276e5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"855bb48e8951fa82837c1a2d771214c4c2df760c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                     # confuse other protocols with None ports"},{"line_number":131,"context_line":"                     # with the egress rules.  VRRP uses protocol"},{"line_number":132,"context_line":"                     # 51 and 112"},{"line_number":133,"context_line":"                     if rule.get(\u0027direction\u0027) !\u003d \u0027egress\u0027 and"},{"line_number":134,"context_line":"                     rule.get(\u0027protocol\u0027).lower() \u003d\u003d \u0027tcp\u0027]"},{"line_number":135,"context_line":"        add_ports \u003d set(updated_ports) - set(old_ports)"},{"line_number":136,"context_line":"        del_ports \u003d set(old_ports) - set(updated_ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ff8b781c","line":133,"range":{"start_line":133,"start_character":50,"end_line":133,"end_character":56},"in_reply_to":"bae84128_92d224ff","updated":"2016-02-21 02:48:28.000000000","message":"Maybe? I think for typical network lingo that might be overkill... Making a constant for \"tcp\" seems a bit on the ridiculous side. :P","commit_id":"cc32f276191f1730b0e02fa388b6b07aeae276e5"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"0480e86de533ccfda52a5022fcb4b1241fa72264","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                     # confuse other protocols with None ports"},{"line_number":131,"context_line":"                     # with the egress rules.  VRRP uses protocol"},{"line_number":132,"context_line":"                     # 51 and 112"},{"line_number":133,"context_line":"                     if rule.get(\u0027direction\u0027) !\u003d \u0027egress\u0027 and"},{"line_number":134,"context_line":"                     rule.get(\u0027protocol\u0027).lower() \u003d\u003d \u0027tcp\u0027]"},{"line_number":135,"context_line":"        add_ports \u003d set(updated_ports) - set(old_ports)"},{"line_number":136,"context_line":"        del_ports \u003d set(old_ports) - set(updated_ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_029fe3b4","line":133,"range":{"start_line":133,"start_character":50,"end_line":133,"end_character":56},"in_reply_to":"bae84128_ff8b781c","updated":"2016-02-21 04:11:49.000000000","message":"agreed overkill...","commit_id":"cc32f276191f1730b0e02fa388b6b07aeae276e5"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"4a6b5530b9831f380b230cdf66970156a3ffeb66","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                     # with the egress rules.  VRRP uses protocol"},{"line_number":132,"context_line":"                     # 51 and 112"},{"line_number":133,"context_line":"                     if rule.get(\u0027direction\u0027) !\u003d \u0027egress\u0027 and"},{"line_number":134,"context_line":"                     rule.get(\u0027protocol\u0027).lower() \u003d\u003d \u0027tcp\u0027]"},{"line_number":135,"context_line":"        add_ports \u003d set(updated_ports) - set(old_ports)"},{"line_number":136,"context_line":"        del_ports \u003d set(old_ports) - set(updated_ports)"},{"line_number":137,"context_line":"        for rule in rules.get(\u0027security_group_rules\u0027, []):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_72cde05c","line":134,"range":{"start_line":134,"start_character":54,"end_line":134,"end_character":57},"updated":"2016-02-20 23:55:47.000000000","message":"Also here?","commit_id":"cc32f276191f1730b0e02fa388b6b07aeae276e5"}]}