)]}'
{"etc/octavia.conf":[{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"7924cfe67477906d5eeddf16035863fcac87b153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9aed3d3a_f414e24d","line":251,"updated":"2016-02-29 15:46:48.000000000","message":"[glance] section is missing","commit_id":"2c86f65fb909476d6c6b39fb3de683a88b46ae01"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9979dc270a701da6d1761ce3d84e239cfb3c21d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9aed3d3a_5fe967e5","line":251,"in_reply_to":"9aed3d3a_f414e24d","updated":"2016-02-29 15:51:11.000000000","message":"Doh, I am dumb. :)\n\nDone.","commit_id":"2c86f65fb909476d6c6b39fb3de683a88b46ae01"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"f6e098aaf8eb22b4869b02639e0ad70d0816a5be","unresolved":false,"context_lines":[{"line_number":135,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":136,"context_line":"# amp_flavor_id \u003d"},{"line_number":137,"context_line":"# amp_image_id \u003d"},{"line_number":138,"context_line":"# amp_image_tag \u003d"},{"line_number":139,"context_line":"# amp_ssh_key_name \u003d"},{"line_number":140,"context_line":"# amp_ssh_allowed_access \u003d True"},{"line_number":141,"context_line":"# amp_network \u003d"}],"source_content_type":"text/plain","patch_set":9,"id":"9aed3d3a_3f0a8c79","line":138,"range":{"start_line":138,"start_character":2,"end_line":138,"end_character":15},"updated":"2016-02-29 22:29:52.000000000","message":"Nit: If this is glance-specific, it should be in the glance section below.","commit_id":"83c8a3c6adc60cd33aee2a5650814cc21984d76b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"eb7cc35941ffe527a37a415dc00b45bc4d8f3a7e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":136,"context_line":"# amp_flavor_id \u003d"},{"line_number":137,"context_line":"# amp_image_id \u003d"},{"line_number":138,"context_line":"# amp_image_tag \u003d"},{"line_number":139,"context_line":"# amp_ssh_key_name \u003d"},{"line_number":140,"context_line":"# amp_ssh_allowed_access \u003d True"},{"line_number":141,"context_line":"# amp_network \u003d"}],"source_content_type":"text/plain","patch_set":9,"id":"9aed3d3a_7ad0a21f","line":138,"range":{"start_line":138,"start_character":2,"end_line":138,"end_character":15},"in_reply_to":"9aed3d3a_3f0a8c79","updated":"2016-02-29 22:33:11.000000000","message":"there\u0027s an argument to be made that this is galnce specific or its not.  i don\u0027t think it has to be, but we don\u0027t really have any other image repository services to compare against","commit_id":"83c8a3c6adc60cd33aee2a5650814cc21984d76b"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"a6fdea4c813b10e70b1cf4291f6b0dd94dbd1c6b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":136,"context_line":"# amp_flavor_id \u003d"},{"line_number":137,"context_line":"# amp_image_id \u003d"},{"line_number":138,"context_line":"# amp_image_tag \u003d"},{"line_number":139,"context_line":"# amp_ssh_key_name \u003d"},{"line_number":140,"context_line":"# amp_ssh_allowed_access \u003d True"},{"line_number":141,"context_line":"# amp_network \u003d"}],"source_content_type":"text/plain","patch_set":9,"id":"9aed3d3a_87a1ce48","line":138,"range":{"start_line":138,"start_character":2,"end_line":138,"end_character":15},"in_reply_to":"9aed3d3a_7ad0a21f","updated":"2016-03-01 00:23:48.000000000","message":"I agree with Brandon here. Atleast at this point, just like flavor_id is under controller_worker, it makes sense to have image_tag (and other CW specific attributes) under CW section too.. Glance, Nova and Neutron section currently just define attribs to initiate their respective session clients. We can revisit this in the future if needed.","commit_id":"83c8a3c6adc60cd33aee2a5650814cc21984d76b"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c8e7fc2abefe9cb7ad2ea2234a98307dc46235e0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":136,"context_line":"# amp_flavor_id \u003d"},{"line_number":137,"context_line":"# amp_image_id \u003d"},{"line_number":138,"context_line":"# amp_image_tag \u003d"},{"line_number":139,"context_line":"# amp_ssh_key_name \u003d"},{"line_number":140,"context_line":"# amp_ssh_allowed_access \u003d True"},{"line_number":141,"context_line":"# amp_network \u003d"}],"source_content_type":"text/plain","patch_set":9,"id":"9aed3d3a_ea57bf55","line":138,"range":{"start_line":138,"start_character":2,"end_line":138,"end_character":15},"in_reply_to":"9aed3d3a_87a1ce48","updated":"2016-03-01 00:53:11.000000000","message":"+1 image_id is here as well but that was before we started the nova specific section... nevertheless I would like to see some comment to explain that either image_id or image_tag are needed. The way it looks now would make people believe they need both. For a template see where we give  a few options below...","commit_id":"83c8a3c6adc60cd33aee2a5650814cc21984d76b"}],"octavia/common/clients.py":[{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"141e7d9f0d4a020939b7e21608486de8221a0a8d","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @classmethod"},{"line_number":96,"context_line":"    def get_glance_client(cls, region, service_name\u003dNone, endpoint\u003dNone,"},{"line_number":97,"context_line":"                          endpoint_type\u003dNone):"},{"line_number":98,"context_line":"        \"\"\"Create glance client object."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param region: The region of the service"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_65a07544","line":97,"range":{"start_line":97,"start_character":26,"end_line":97,"end_character":44},"updated":"2016-02-26 18:35:01.000000000","message":"What about using a default param value and removing an extra condition check ?","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c18ec5de7fdaae469887e6dbe85082abe7cd124","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @classmethod"},{"line_number":96,"context_line":"    def get_glance_client(cls, region, service_name\u003dNone, endpoint\u003dNone,"},{"line_number":97,"context_line":"                          endpoint_type\u003dNone):"},{"line_number":98,"context_line":"        \"\"\"Create glance client object."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param region: The region of the service"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_aabe8062","line":97,"range":{"start_line":97,"start_character":26,"end_line":97,"end_character":44},"in_reply_to":"9aed3d3a_65a07544","updated":"2016-02-29 14:37:43.000000000","message":"Done","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"}],"octavia/common/config.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"56ea42ae572a87d35583fc50bc0c6f882aee48d6","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    cfg.StrOpt(\u0027amp_image_id\u0027,"},{"line_number":214,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":215,"context_line":"               help\u003d_(\u0027Glance image id for the Amphora image to boot\u0027)),"},{"line_number":216,"context_line":"    cfg.StrOpt(\u0027amp_image_tag\u0027,"},{"line_number":217,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":218,"context_line":"               help\u003d_(\u0027Glance image tag for the Amphora image to boot. \u0027"},{"line_number":219,"context_line":"                      \u0027Not used if amp_image_id is defined.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_9ae1a401","line":216,"updated":"2016-02-25 15:32:50.000000000","message":"I would change the order so this key appears before the \u0027id\u0027 one, and add some more info to the help text to explain why this option is preferable.\n\nA follow up question is, do we want to support both options indefinitely?","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e5daa856caf03e86b8209d0fa6ecce01100fce85","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    cfg.StrOpt(\u0027amp_image_tag\u0027,"},{"line_number":217,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":218,"context_line":"               help\u003d_(\u0027Glance image tag for the Amphora image to boot. \u0027"},{"line_number":219,"context_line":"                      \u0027Not used if amp_image_id is defined.\u0027)),"},{"line_number":220,"context_line":"    cfg.StrOpt(\u0027amp_ssh_key_name\u0027,"},{"line_number":221,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":222,"context_line":"               help\u003d_(\u0027SSH key name used to boot the Amphora\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_5a08bc91","line":219,"updated":"2016-02-25 15:27:27.000000000","message":"shall we perhaps fail if both are defined?","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"aac0e0d255914c9e0490b7359dea0cf7b92e04e9","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    cfg.StrOpt(\u0027amp_image_tag\u0027,"},{"line_number":217,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":218,"context_line":"               help\u003d_(\u0027Glance image tag for the Amphora image to boot. \u0027"},{"line_number":219,"context_line":"                      \u0027Not used if amp_image_id is defined.\u0027)),"},{"line_number":220,"context_line":"    cfg.StrOpt(\u0027amp_ssh_key_name\u0027,"},{"line_number":221,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":222,"context_line":"               help\u003d_(\u0027SSH key name used to boot the Amphora\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_783ae9ce","line":219,"updated":"2016-02-25 15:29:47.000000000","message":"shall we perhaps fail or log something if both are defined?\n\nFailing would require a sanity check at start.","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7ee710616ddcccd069d4f5e750cb46e371a4e9","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    cfg.StrOpt(\u0027amp_image_tag\u0027,"},{"line_number":217,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":218,"context_line":"               help\u003d_(\u0027Glance image tag for the Amphora image to boot. \u0027"},{"line_number":219,"context_line":"                      \u0027Not used if amp_image_id is defined.\u0027)),"},{"line_number":220,"context_line":"    cfg.StrOpt(\u0027amp_ssh_key_name\u0027,"},{"line_number":221,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":222,"context_line":"               help\u003d_(\u0027SSH key name used to boot the Amphora\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0c8f1f24","line":219,"in_reply_to":"bae84128_783ae9ce","updated":"2016-02-25 16:50:49.000000000","message":"Done","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"f6e098aaf8eb22b4869b02639e0ad70d0816a5be","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    cfg.StrOpt(\u0027amp_flavor_id\u0027,"},{"line_number":211,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":212,"context_line":"               help\u003d_(\u0027Nova instance flavor id for the Amphora\u0027)),"},{"line_number":213,"context_line":"    cfg.StrOpt(\u0027amp_image_tag\u0027,"},{"line_number":214,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":215,"context_line":"               help\u003d_(\u0027Glance image tag for the Amphora image to boot. \u0027"},{"line_number":216,"context_line":"                      \u0027Use this option to be able to update the image \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_ff4b0485","line":213,"range":{"start_line":213,"start_character":16,"end_line":213,"end_character":29},"updated":"2016-02-29 22:29:52.000000000","message":"Similar comment as before...","commit_id":"83c8a3c6adc60cd33aee2a5650814cc21984d76b"}],"octavia/common/exceptions.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a1e8a3e09e8b28770ef3b1ea1465d4dd272030bb","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"class GlanceTooManyTaggedImages(OctaviaException):"},{"line_number":178,"context_line":"    message \u003d _(\"Only single Glance image should be tagged with %(tag)s tag.\")"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class NoSuitableAmphoraException(OctaviaException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c908902b","line":178,"updated":"2016-02-25 14:40:16.000000000","message":"What type is this? We typically use _LI or _LE, I don\u0027t actually know what this does exactly.","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5fb6e2e7dc37bce6519fa98c3073c7ad9635a3e8","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"class GlanceTooManyTaggedImages(OctaviaException):"},{"line_number":178,"context_line":"    message \u003d _(\"Only single Glance image should be tagged with %(tag)s tag.\")"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class NoSuitableAmphoraException(OctaviaException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_84cf8db2","line":178,"in_reply_to":"bae84128_c908902b","updated":"2016-02-25 14:53:53.000000000","message":"Done","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"4263ac25ea753879d5b6226c3f61ddfd1f71087d","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"class GlanceTooManyTaggedImages(OctaviaException):"},{"line_number":178,"context_line":"    message \u003d _LE(\"Only single Glance image should be tagged \""},{"line_number":179,"context_line":"                  \"with %(tag)s tag.\")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_3f34cadc","line":178,"range":{"start_line":178,"start_character":24,"end_line":178,"end_character":30},"updated":"2016-02-25 15:08:39.000000000","message":"\"a single\" or \"one\"","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7ee710616ddcccd069d4f5e750cb46e371a4e9","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"class GlanceTooManyTaggedImages(OctaviaException):"},{"line_number":178,"context_line":"    message \u003d _LE(\"Only single Glance image should be tagged \""},{"line_number":179,"context_line":"                  \"with %(tag)s tag.\")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_7fb5b2ce","line":178,"range":{"start_line":178,"start_character":24,"end_line":178,"end_character":30},"in_reply_to":"bae84128_3f34cadc","updated":"2016-02-25 16:50:49.000000000","message":"Done","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"141e7d9f0d4a020939b7e21608486de8221a0a8d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF.import_group(\u0027keystone_authtoken\u0027, \u0027octavia.common.config\u0027)"},{"line_number":30,"context_line":"CONF.import_group(\u0027networking\u0027, \u0027octavia.common.config\u0027)"},{"line_number":31,"context_line":"CONF.import_group(\u0027nova\u0027, \u0027octavia.common.config\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def _extract_amp_image_id_by_tag(client, image_tag):"},{"line_number":35,"context_line":"    images \u003d list(client.images.list("}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_896dd39a","line":32,"updated":"2016-02-26 18:35:01.000000000","message":"Import_group for glance missing","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c18ec5de7fdaae469887e6dbe85082abe7cd124","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF.import_group(\u0027keystone_authtoken\u0027, \u0027octavia.common.config\u0027)"},{"line_number":30,"context_line":"CONF.import_group(\u0027networking\u0027, \u0027octavia.common.config\u0027)"},{"line_number":31,"context_line":"CONF.import_group(\u0027nova\u0027, \u0027octavia.common.config\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def _extract_amp_image_id_by_tag(client, image_tag):"},{"line_number":35,"context_line":"    images \u003d list(client.images.list("}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_aa4cc09e","line":32,"in_reply_to":"9aed3d3a_896dd39a","updated":"2016-02-29 14:37:43.000000000","message":"Done","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"}],"octavia/controller/worker/tasks/compute_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a1e8a3e09e8b28770ef3b1ea1465d4dd272030bb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"CONF.import_group(\u0027controller_worker\u0027, \u0027octavia.common.config\u0027)"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"_SESSION \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _get_glance_client():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_0972787c","line":37,"updated":"2016-02-25 14:40:16.000000000","message":"I think it would be better to use our internal keystone session code. \n\nfrom octavia.common import keystone\nsession \u003d keystone.get_session()\n\nYou shouldn\u0027t have to handle auth and session management yourself.\nYou can look at how this is handled for example in:\noctavia/certificates/common/auth/barbican_acl.py","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5fb6e2e7dc37bce6519fa98c3073c7ad9635a3e8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"CONF.import_group(\u0027controller_worker\u0027, \u0027octavia.common.config\u0027)"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"_SESSION \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _get_glance_client():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_241a016f","line":37,"in_reply_to":"bae84128_0972787c","updated":"2016-02-25 14:53:53.000000000","message":"Didn\u0027t know we have it in the tree already. Done.","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e5daa856caf03e86b8209d0fa6ecce01100fce85","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    client \u003d _get_glance_client()"},{"line_number":54,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":55,"context_line":"    if len(images) \u003e 1:"},{"line_number":56,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":57,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1ae2b49f","line":56,"updated":"2016-02-25 15:27:27.000000000","message":"Isn\u0027t it a bit to harsh crash?, what about logging and taking the first one?","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e5daa856caf03e86b8209d0fa6ecce01100fce85","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def _get_image_uuid():"},{"line_number":61,"context_line":"    image_id \u003d CONF.controller_worker.amp_image_id"},{"line_number":62,"context_line":"    if image_id:"},{"line_number":63,"context_line":"        return image_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    tag \u003d CONF.controller_worker.amp_image_tag"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_5a355cf5","line":62,"updated":"2016-02-25 15:27:27.000000000","message":"may be we should at least log an error if ID + tag is set?","commit_id":"69e25257346bdfa49e86528cfbf270494aaf2db4"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"4263ac25ea753879d5b6226c3f61ddfd1f71087d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def _extract_amp_image_id_by_tag(tag):"},{"line_number":44,"context_line":"    client \u003d _get_glance_client()"},{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_3fb96a2f","line":47,"range":{"start_line":46,"start_character":4,"end_line":47,"end_character":59},"updated":"2016-02-25 15:08:39.000000000","message":"I think I\u0027d prefer to see a warning here, and then return the first in the list, so that if this happens to hit while I\u0027m migrating to a new image, there\u0027s a warning log for the admin instead of an error for the user.","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"aac0e0d255914c9e0490b7359dea0cf7b92e04e9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def _extract_amp_image_id_by_tag(tag):"},{"line_number":44,"context_line":"    client \u003d _get_glance_client()"},{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f881d94e","line":47,"range":{"start_line":46,"start_character":4,"end_line":47,"end_character":59},"in_reply_to":"bae84128_3fb96a2f","updated":"2016-02-25 15:29:47.000000000","message":"Agreed, sorry, I made same comment in PS2 by mistake.","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7ee710616ddcccd069d4f5e750cb46e371a4e9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def _extract_amp_image_id_by_tag(tag):"},{"line_number":44,"context_line":"    client \u003d _get_glance_client()"},{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0cb6ffdb","line":47,"range":{"start_line":46,"start_character":4,"end_line":47,"end_character":59},"in_reply_to":"bae84128_e1a3e4af","updated":"2016-02-25 16:50:49.000000000","message":"Done","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ff609668ed847c078037fd3b21ccd3bc71e814c7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def _extract_amp_image_id_by_tag(tag):"},{"line_number":44,"context_line":"    client \u003d _get_glance_client()"},{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e1a3e4af","line":47,"range":{"start_line":46,"start_character":4,"end_line":47,"end_character":59},"in_reply_to":"bae84128_f881d94e","updated":"2016-02-25 16:28:24.000000000","message":"Yes, we need to make sure that while the tag is transitioning amphroa can still be built.","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f3ccb1d3f0bdb478b4e792216d2117c80ad7c818","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_5f2a6e7f","line":48,"updated":"2016-02-25 15:06:11.000000000","message":"Is it possible for the images list to be empty? If so, there should probably be another exception here like \"GlanceNoTaggedImage\" or something, because an indexerror here will be unhelpful.","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ff609668ed847c078037fd3b21ccd3bc71e814c7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_ac5d5317","line":48,"in_reply_to":"bae84128_5f2a6e7f","updated":"2016-02-25 16:28:24.000000000","message":"+1 for \"no image found\" error","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7ee710616ddcccd069d4f5e750cb46e371a4e9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_bfaf3a7c","line":48,"in_reply_to":"bae84128_5f2a6e7f","updated":"2016-02-25 16:50:49.000000000","message":"Done","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7ee710616ddcccd069d4f5e750cb46e371a4e9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    images \u003d list(client.images.list(filters\u003d{\u0027tag\u0027: [tag]}))"},{"line_number":46,"context_line":"    if len(images) \u003e 1:"},{"line_number":47,"context_line":"        raise exceptions.GlanceTooManyTaggedImages(tag\u003dtag)"},{"line_number":48,"context_line":"    return images[0][\u0027id\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_ecdf5b0a","line":48,"in_reply_to":"bae84128_ac5d5317","updated":"2016-02-25 16:50:49.000000000","message":"Done","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"aac0e0d255914c9e0490b7359dea0cf7b92e04e9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"},{"line_number":52,"context_line":"    image_id \u003d CONF.controller_worker.amp_image_id"},{"line_number":53,"context_line":"    if image_id:"},{"line_number":54,"context_line":"        return image_id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tag \u003d CONF.controller_worker.amp_image_tag"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_98e24d2e","line":53,"updated":"2016-02-25 15:29:47.000000000","message":"may be we should at least log an error if ID + tag is set?","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ff609668ed847c078037fd3b21ccd3bc71e814c7","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"},{"line_number":52,"context_line":"    image_id \u003d CONF.controller_worker.amp_image_id"},{"line_number":53,"context_line":"    if image_id:"},{"line_number":54,"context_line":"        return image_id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tag \u003d CONF.controller_worker.amp_image_tag"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_a171dc46","line":53,"in_reply_to":"bae84128_98e24d2e","updated":"2016-02-25 16:28:24.000000000","message":"Logging this would be good.  I don\u0027t think we need to block startup however.","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7ee710616ddcccd069d4f5e750cb46e371a4e9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_image_uuid():"},{"line_number":52,"context_line":"    image_id \u003d CONF.controller_worker.amp_image_id"},{"line_number":53,"context_line":"    if image_id:"},{"line_number":54,"context_line":"        return image_id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tag \u003d CONF.controller_worker.amp_image_tag"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_6ccceb61","line":53,"in_reply_to":"bae84128_a171dc46","updated":"2016-02-25 16:50:49.000000000","message":"Done","commit_id":"1558e0aa75a1db1f6eca02c34dbbcda94894a495"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ffe74ca33d8abc01be3160da3d47ad7cab64ba9c","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_glance_client():"},{"line_number":39,"context_line":"    session \u003d keystone.get_session()"},{"line_number":40,"context_line":"    return glance_client.Client(session\u003dsession, version\u003d2)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _extract_amp_image_id_by_tag(tag):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_8fece1c8","line":40,"updated":"2016-02-26 06:47:20.000000000","message":"also, there is an octavia.common.clients module that the glance client can be put in.  There might also need to be some extra arguments passed to the glance client, like region, service_name, endpoint_override, etc.","commit_id":"979c4181f9f636aa12e5214bd0997c0404fe0919"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8be7dd4c822c1cad52fa80a7be1b6d64bd82ec9a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_glance_client():"},{"line_number":39,"context_line":"    session \u003d keystone.get_session()"},{"line_number":40,"context_line":"    return glance_client.Client(session\u003dsession, version\u003d2)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _extract_amp_image_id_by_tag(tag):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_98e700e4","line":40,"in_reply_to":"9aed3d3a_8fece1c8","updated":"2016-02-26 09:47:47.000000000","message":"Done","commit_id":"979c4181f9f636aa12e5214bd0997c0404fe0919"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"012d5c98914f5e1cedd8e5094d5b8c69b0c404f6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if num_images \u003e 1:"},{"line_number":50,"context_line":"        LOG.warn("},{"line_number":51,"context_line":"            _LW(\"A single Glance image should be tagged with %(tag)s tag, \""},{"line_number":52,"context_line":"                \"but %(num)d found.\"),"},{"line_number":53,"context_line":"            {\u0027tag\u0027: tag, \u0027num\u0027: num_images}"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":"    return images[0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_84468821","line":52,"updated":"2016-02-26 06:10:14.000000000","message":"extra-nit: Could we put in the warning the final uuid we selected? images[0][\u0027id\u0027] ? \n\nSo the admin would be able to understand what was really spawned?\n\nIt\u0027d be awesome if we could order them by inverse creation date (when asking to glance), this way we increase the chances of grabbing the right one.","commit_id":"979c4181f9f636aa12e5214bd0997c0404fe0919"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8be7dd4c822c1cad52fa80a7be1b6d64bd82ec9a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if num_images \u003e 1:"},{"line_number":50,"context_line":"        LOG.warn("},{"line_number":51,"context_line":"            _LW(\"A single Glance image should be tagged with %(tag)s tag, \""},{"line_number":52,"context_line":"                \"but %(num)d found.\"),"},{"line_number":53,"context_line":"            {\u0027tag\u0027: tag, \u0027num\u0027: num_images}"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":"    return images[0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_448f5b23","line":52,"in_reply_to":"9aed3d3a_84468821","updated":"2016-02-26 09:47:47.000000000","message":"Done","commit_id":"979c4181f9f636aa12e5214bd0997c0404fe0919"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"c854e155bf0db7ac2a0088bbd7895a0148f737df","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    \"Using the former.\"))"},{"line_number":66,"context_line":"        return image_id"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return _extract_amp_image_id_by_tag(tag)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class BaseComputeTask(task.Task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_7f79502f","line":68,"updated":"2016-02-26 04:00:21.000000000","message":"I don\u0027t think it fits in with the design to instantiate the glance client in this file.  All the taskflow tasks and flows shouldn\u0027t need to know what clients to use.  This should be done in the nova compute driver.  This makes it a bit more difficult though.  However, you could change the compute.build method to accept an image_tag kwarg and then do this same logic in that method for the nova compute driver.  It\u0027s a bit hacky, but it gets the glance code into the nova compute driver.","commit_id":"979c4181f9f636aa12e5214bd0997c0404fe0919"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"972976dd584e8e8648d101a401d712380ef36714","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    \"Using the former.\"))"},{"line_number":66,"context_line":"        return image_id"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return _extract_amp_image_id_by_tag(tag)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class BaseComputeTask(task.Task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_93f3630a","line":68,"in_reply_to":"9aed3d3a_7f79502f","updated":"2016-02-26 09:47:55.000000000","message":"Done","commit_id":"979c4181f9f636aa12e5214bd0997c0404fe0919"}],"octavia/tests/unit/common/test_clients.py":[{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"141e7d9f0d4a020939b7e21608486de8221a0a8d","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        super(TestGlanceAuth, self).setUp()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_get_neutron_client(self):"},{"line_number":116,"context_line":"        # There should be no existing client"},{"line_number":117,"context_line":"        self.assertIsNone("},{"line_number":118,"context_line":"            clients.GlanceAuth.glance_client"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_c9887b25","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":31},"updated":"2016-02-26 18:35:01.000000000","message":"Should be test_get_glance_client","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c18ec5de7fdaae469887e6dbe85082abe7cd124","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        super(TestGlanceAuth, self).setUp()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_get_neutron_client(self):"},{"line_number":116,"context_line":"        # There should be no existing client"},{"line_number":117,"context_line":"        self.assertIsNone("},{"line_number":118,"context_line":"            clients.GlanceAuth.glance_client"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_0a5e8c43","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":31},"in_reply_to":"9aed3d3a_c9887b25","updated":"2016-02-29 14:37:43.000000000","message":"Done","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"}],"octavia/tests/unit/compute/drivers/test_nova_driver.py":[{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"141e7d9f0d4a020939b7e21608486de8221a0a8d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Test_GetImageUuid(base.TestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test__get_image_uuid_tag(self):"},{"line_number":34,"context_line":"        client \u003d mock.Mock()"},{"line_number":35,"context_line":"        with mock.patch.object(nova_common,"},{"line_number":36,"context_line":"                               \u0027_extract_amp_image_id_by_tag\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_e9b3bfe7","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":14},"updated":"2016-02-26 18:35:01.000000000","message":"nit: any reason for 2 underscores\u0027 ? As in below two methods as well.","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c18ec5de7fdaae469887e6dbe85082abe7cd124","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Test_GetImageUuid(base.TestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test__get_image_uuid_tag(self):"},{"line_number":34,"context_line":"        client \u003d mock.Mock()"},{"line_number":35,"context_line":"        with mock.patch.object(nova_common,"},{"line_number":36,"context_line":"                               \u0027_extract_amp_image_id_by_tag\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_8d06361b","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":14},"in_reply_to":"9aed3d3a_e9b3bfe7","updated":"2016-02-29 14:37:43.000000000","message":"First underscore is a separator between \u0027test\u0027 and the description of the test case, and the second one belongs to the name of the method being tested.","commit_id":"a209cfe8faed4ab5e04f7183a5aa92da9176e013"}]}
