)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"f0c77acfb11554a206b3cecf6eb6752896fb078b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add pre_test_hook to run gate jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include set of services with plugins to run gate jobs"},{"line_number":10,"context_line":"for Octavia"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibaecb2e0141e3ff9a19acf4c2b63aeae60e6ed9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_f7f2b66e","line":10,"updated":"2016-02-25 22:21:12.000000000","message":"Is this specifically for TLS test for octavia, if so, maybe better to say it explicitly, otherwise give more description for this gate jobs for, like for scenario test for octavia or other objectives.","commit_id":"87259231ae0162b66d82414ef1dc3df3a9e1f3c9"}],"octavia/tests/contrib/pre_test_hook.sh":[{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"d580feecc652e335fd187dc1e8d879cc170ba1f6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Below projects are required for setting up environment"},{"line_number":14,"context_line":"export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":15,"context_line":"export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# These are not needed for api and scenario tests"},{"line_number":18,"context_line":"ENABLED_SERVICES+\u003d\"-c-api,-c-bak,-c-sch,-c-vol,-cinder\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9aed3d3a_b3391444","line":15,"updated":"2016-02-27 01:37:49.000000000","message":"Nit: Generally prefer already exists checks to avoid duplication when adding to existing, i.e:\ncase $PROJECTS in\n    *openstack/barbican* ) ;;\n    * ) export PROJECTS\u003d\"openstack/barbican $PROJECTS\"\nesac","commit_id":"6df36bbeaef35e4650d08b3201df7f445189eda2"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"f5186b0b3b3863d2d0a51faa70ea7e924910b5dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Below projects are required for setting up environment"},{"line_number":14,"context_line":"export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":15,"context_line":"export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# These are not needed for api and scenario tests"},{"line_number":18,"context_line":"ENABLED_SERVICES+\u003d\"-c-api,-c-bak,-c-sch,-c-vol,-cinder\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7af24918_94eed1b2","line":15,"in_reply_to":"7af24918_b9a94827","updated":"2016-03-04 21:58:50.000000000","message":"Yeah, duplicating will not have an adverse effect, but its good to implement what James suggested as a good practice. Re spinning once again..","commit_id":"6df36bbeaef35e4650d08b3201df7f445189eda2"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e9de2f504d3b2da4632f206429832b13d40e52c1","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Below projects are required for setting up environment"},{"line_number":14,"context_line":"export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":15,"context_line":"export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# These are not needed for api and scenario tests"},{"line_number":18,"context_line":"ENABLED_SERVICES+\u003d\"-c-api,-c-bak,-c-sch,-c-vol,-cinder\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7af24918_b9a94827","line":15,"in_reply_to":"9aed3d3a_b3391444","updated":"2016-03-04 21:29:26.000000000","message":"Me too, though I think duplicating projects here does not have an adverse effect?","commit_id":"6df36bbeaef35e4650d08b3201df7f445189eda2"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"f5186b0b3b3863d2d0a51faa70ea7e924910b5dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Below projects are required for setting up environment"},{"line_number":14,"context_line":"export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":15,"context_line":"export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# These are not needed for api and scenario tests"},{"line_number":18,"context_line":"ENABLED_SERVICES+\u003d\"-c-api,-c-bak,-c-sch,-c-vol,-cinder\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7af24918_34341d49","line":15,"in_reply_to":"9aed3d3a_b3391444","updated":"2016-03-04 21:58:50.000000000","message":"Sounds good James. Will re-spin it :)","commit_id":"6df36bbeaef35e4650d08b3201df7f445189eda2"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"89a83901499e0eab3761e75f9327743ea47f0834","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        ;;"},{"line_number":17,"context_line":"    * )"},{"line_number":18,"context_line":"        export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":19,"context_line":"        export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":20,"context_line":"        ;;"},{"line_number":21,"context_line":"esac"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7af24918_12e80e16","line":19,"updated":"2016-03-05 00:00:14.000000000","message":"Teeeeeechnically these should maybe have been separate, but I have no cares to give here.","commit_id":"d013927a7baa62adb6938bddc745938356522633"}]}