)]}'
{"octavia/api/v1/types/l7policy.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"f617b17c194651361cffbc209ae885d64b1e2d87","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class L7PolicyResponse(base.BaseType):"},{"line_number":24,"context_line":"    \"\"\"Defines which attributes are to be shown on any response.\"\"\""},{"line_number":25,"context_line":"    id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":26,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":27,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":28,"context_line":"    enabled \u003d wtypes.wsattr(bool)"},{"line_number":29,"context_line":"    action \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_43d5341a","line":26,"range":{"start_line":26,"start_character":43,"end_line":26,"end_character":57},"updated":"2016-03-03 01:34:05.000000000","message":"should we remove length from response ?","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"3a4faf0a18de088327a5a1e4d82a251398c388e9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class L7PolicyResponse(base.BaseType):"},{"line_number":24,"context_line":"    \"\"\"Defines which attributes are to be shown on any response.\"\"\""},{"line_number":25,"context_line":"    id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":26,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":27,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":28,"context_line":"    enabled \u003d wtypes.wsattr(bool)"},{"line_number":29,"context_line":"    action \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_7fb720f5","line":26,"range":{"start_line":26,"start_character":43,"end_line":26,"end_character":57},"in_reply_to":"7af24918_248f4b76","updated":"2016-03-03 02:39:57.000000000","message":"ok.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"8e8d829795d2da9ea47f8f851e8afdb8ea06bcae","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class L7PolicyResponse(base.BaseType):"},{"line_number":24,"context_line":"    \"\"\"Defines which attributes are to be shown on any response.\"\"\""},{"line_number":25,"context_line":"    id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":26,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":27,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":28,"context_line":"    enabled \u003d wtypes.wsattr(bool)"},{"line_number":29,"context_line":"    action \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_248f4b76","line":26,"range":{"start_line":26,"start_character":43,"end_line":26,"end_character":57},"in_reply_to":"7af24918_43d5341a","updated":"2016-03-03 02:15:17.000000000","message":"There is another patch under review which removes the length check from these responses.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"84e41ff483d697272626a94cfbe074e337c6016f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # here if you\u0027re using MySQL, as most probably are. This just needs"},{"line_number":71,"context_line":"    # to be larger than any existing rule position numbers which will"},{"line_number":72,"context_line":"    # definitely be the case with 2147483647"},{"line_number":73,"context_line":"    position \u003d wtypes.wsattr(wtypes.IntegerType(), default\u003d2147483647)"},{"line_number":74,"context_line":"    redirect_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":75,"context_line":"    l7rules \u003d wtypes.wsattr([l7rule.L7RulePOST], default\u003d[])"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_2e672c4e","line":73,"updated":"2016-03-03 01:32:31.000000000","message":"I hate this, but I think it will be ok.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2465c9a3d6e7f7932912184a0d400ccb76b55c66","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # here if you\u0027re using MySQL, as most probably are. This just needs"},{"line_number":71,"context_line":"    # to be larger than any existing rule position numbers which will"},{"line_number":72,"context_line":"    # definitely be the case with 2147483647"},{"line_number":73,"context_line":"    position \u003d wtypes.wsattr(wtypes.IntegerType(), default\u003d2147483647)"},{"line_number":74,"context_line":"    redirect_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":75,"context_line":"    l7rules \u003d wtypes.wsattr([l7rule.L7RulePOST], default\u003d[])"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_b4acad8d","line":73,"in_reply_to":"7af24918_145be12f","updated":"2016-03-04 21:53:07.000000000","message":"Oh and yes-- a renumber occurs immediately after the l7policy is added.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"b9875fa0eeb9fb3cf221fa1c8432ff66c55aa9d3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # here if you\u0027re using MySQL, as most probably are. This just needs"},{"line_number":71,"context_line":"    # to be larger than any existing rule position numbers which will"},{"line_number":72,"context_line":"    # definitely be the case with 2147483647"},{"line_number":73,"context_line":"    position \u003d wtypes.wsattr(wtypes.IntegerType(), default\u003d2147483647)"},{"line_number":74,"context_line":"    redirect_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":75,"context_line":"    l7rules \u003d wtypes.wsattr([l7rule.L7RulePOST], default\u003d[])"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_e4d3a302","line":73,"in_reply_to":"7af24918_2e672c4e","updated":"2016-03-03 02:18:32.000000000","message":"Yeah, I\u0027d rather go with sys.maxsize as well, but unfortunately that explodes MySQL.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"f92b0594298ca8eef4050e866a843963217bafe8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # here if you\u0027re using MySQL, as most probably are. This just needs"},{"line_number":71,"context_line":"    # to be larger than any existing rule position numbers which will"},{"line_number":72,"context_line":"    # definitely be the case with 2147483647"},{"line_number":73,"context_line":"    position \u003d wtypes.wsattr(wtypes.IntegerType(), default\u003d2147483647)"},{"line_number":74,"context_line":"    redirect_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":75,"context_line":"    l7rules \u003d wtypes.wsattr([l7rule.L7RulePOST], default\u003d[])"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_145be12f","line":73,"in_reply_to":"7af24918_99456cb5","updated":"2016-03-04 21:35:21.000000000","message":"Aah-- that is a good point. Will update this momentarily.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e99e8e0c7a26227aa3df6db1ef365e1355bd7152","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # here if you\u0027re using MySQL, as most probably are. This just needs"},{"line_number":71,"context_line":"    # to be larger than any existing rule position numbers which will"},{"line_number":72,"context_line":"    # definitely be the case with 2147483647"},{"line_number":73,"context_line":"    position \u003d wtypes.wsattr(wtypes.IntegerType(), default\u003d2147483647)"},{"line_number":74,"context_line":"    redirect_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":75,"context_line":"    l7rules \u003d wtypes.wsattr([l7rule.L7RulePOST], default\u003d[])"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_99456cb5","line":73,"in_reply_to":"7af24918_e4d3a302","updated":"2016-03-04 21:26:28.000000000","message":"I assume we then re-number it to ACTUALLY be the last in the chain?\nAlso, could it *at least* be a CONSTANT so it doesn\u0027t show up explicitly like 5 times in the code (testing, etc)?","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"}],"octavia/common/validate.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"f617b17c194651361cffbc209ae885d64b1e2d87","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def sanitize_l7policy_api_args(l7policy, create\u003dFalse):"},{"line_number":135,"context_line":"    \"\"\"Validate and make consistent L7Policy API arguments."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This method is mainly meant to sanitize L7 Policy create and update"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c30e643a","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":55},"updated":"2016-03-03 01:34:05.000000000","message":"I think we are correcting the user input in here. I feel it\u0027ll be better to just tell the user that your inputs are not valid hence we can\u0027t process it. Otherwise user might keep passing the invalid data and he might expect different behavior.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"3a4faf0a18de088327a5a1e4d82a251398c388e9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def sanitize_l7policy_api_args(l7policy, create\u003dFalse):"},{"line_number":135,"context_line":"    \"\"\"Validate and make consistent L7Policy API arguments."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This method is mainly meant to sanitize L7 Policy create and update"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_bf952888","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":55},"in_reply_to":"7af24918_443ed78c","updated":"2016-03-03 02:39:57.000000000","message":"What I was trying to say is, let\u0027s say it\u0027s  a create request and action is REDIRECT_TO_URL and lets say user also provides redirect_pool_id data in the request along with redirect_url, my thinking was we should throw an error saying you can\u0027t specify the redirect_pool_id. It might lead to a lot of confusion if it just works fine.  Please do let me know if my understanding is wrong.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"5e51b14d3ce30475557395b312f990a916c76ff1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def sanitize_l7policy_api_args(l7policy, create\u003dFalse):"},{"line_number":135,"context_line":"    \"\"\"Validate and make consistent L7Policy API arguments."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This method is mainly meant to sanitize L7 Policy create and update"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c9112d54","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":55},"in_reply_to":"7af24918_5a84f25c","updated":"2016-03-03 17:38:37.000000000","message":"oh I see. Got it.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"34d006508c18b33f21f5fc6991d7cd04c5efe3c8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def sanitize_l7policy_api_args(l7policy, create\u003dFalse):"},{"line_number":135,"context_line":"    \"\"\"Validate and make consistent L7Policy API arguments."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This method is mainly meant to sanitize L7 Policy create and update"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_ff2a108f","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":55},"in_reply_to":"7af24918_bf952888","updated":"2016-03-03 02:55:11.000000000","message":"See I disagree on that: To me the intent is clear from the action being set to REDIRECT_TO_URL, so we discard the unneeded redirect_pool_id. Again, I\u0027m less inclined to throw an error when intent is clear and we have enough information to move forward.\n\nNow if the user doesn\u0027t specify an action but does supply both a redirect_pool_id and redirect_url, then the intent is not clear, and we throw an error.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"8e8d829795d2da9ea47f8f851e8afdb8ea06bcae","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def sanitize_l7policy_api_args(l7policy, create\u003dFalse):"},{"line_number":135,"context_line":"    \"\"\"Validate and make consistent L7Policy API arguments."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This method is mainly meant to sanitize L7 Policy create and update"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_443ed78c","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":55},"in_reply_to":"7af24918_c30e643a","updated":"2016-03-03 02:15:17.000000000","message":"I don\u0027t follow what you mean. The whole point of this method is to sanitize user input so that other code which follows doesn\u0027t have to worry about having conflicting and/or incomplete information herein. This is the nature of allowing different types of actions which require different inputs which fill different fields. It\u0027s not so much \"correcting\" as it is making sure it is complete and specifies only what is necessary. I\u0027m less inclined to throw an error when it\u0027s obvious from what is specified what the intent is. And since this method is called both from create and update commands, sometimes it\u0027s perfectly appropriate for a given input to only specify part of what could be considered to be \"required\" data:  For example, if your policy is already \"REDIRECT_TO_POOL\" and you just want to change the pool you\u0027re redirecting to, it makes sense that in the API you should only have to specify a new redirect_pool_id. But we fill out the whole update object here so that we can make assumptions about what will be in it later in the code. Hence the \"sanitize\" in the method name.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"eecb013307f0710caf9fcf9a04d59dada5da942e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def sanitize_l7policy_api_args(l7policy, create\u003dFalse):"},{"line_number":135,"context_line":"    \"\"\"Validate and make consistent L7Policy API arguments."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This method is mainly meant to sanitize L7 Policy create and update"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_5a84f25c","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":55},"in_reply_to":"7af24918_ff2a108f","updated":"2016-03-03 03:00:03.000000000","message":"I should note: This actually makes our API easier to work with. For example, if someone writing code to interface with our API knows that they will sometimes need to specify action, redirect_pool_id or redirect_url, they don\u0027t have to duplicate the logic here to prune unneeded parameters from their request: They can trust that as long as they supply everything (even if some fields are filled with None values) our API will do the right thing.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"f617b17c194651361cffbc209ae885d64b1e2d87","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        raise exceptions.InvalidL7PolicyArgs("},{"line_number":169,"context_line":"            msg\u003d\u0027Cannot specify redirect_pool_id and redirect_url \u0027"},{"line_number":170,"context_line":"                \u0027at the same time\u0027)"},{"line_number":171,"context_line":"    if \u0027redirect_pool_id\u0027 in l7policy.keys():"},{"line_number":172,"context_line":"        if l7policy[\u0027redirect_pool_id\u0027] is not None:"},{"line_number":173,"context_line":"            l7policy.update({"},{"line_number":174,"context_line":"                \u0027action\u0027: constants.L7POLICY_ACTION_REDIRECT_TO_POOL})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_eec38455","line":171,"range":{"start_line":171,"start_character":4,"end_line":171,"end_character":45},"updated":"2016-03-03 01:34:05.000000000","message":"Is this condition true for other cases where there might not be \u0027action\u0027 in l7policy .keys() ?","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"8e8d829795d2da9ea47f8f851e8afdb8ea06bcae","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        raise exceptions.InvalidL7PolicyArgs("},{"line_number":169,"context_line":"            msg\u003d\u0027Cannot specify redirect_pool_id and redirect_url \u0027"},{"line_number":170,"context_line":"                \u0027at the same time\u0027)"},{"line_number":171,"context_line":"    if \u0027redirect_pool_id\u0027 in l7policy.keys():"},{"line_number":172,"context_line":"        if l7policy[\u0027redirect_pool_id\u0027] is not None:"},{"line_number":173,"context_line":"            l7policy.update({"},{"line_number":174,"context_line":"                \u0027action\u0027: constants.L7POLICY_ACTION_REDIRECT_TO_POOL})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_84e0dffb","line":171,"range":{"start_line":171,"start_character":4,"end_line":171,"end_character":45},"in_reply_to":"7af24918_eec38455","updated":"2016-03-03 02:15:17.000000000","message":"See the above comment, especially regarding update requests.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"f617b17c194651361cffbc209ae885d64b1e2d87","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            raise exceptions.InvalidL7PolicyArgs("},{"line_number":216,"context_line":"                msg\u003d\u0027redirect_url must not be None\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # If we are creating, we need an action at this point"},{"line_number":219,"context_line":"    if create and \u0027action\u0027 not in l7policy.keys():"},{"line_number":220,"context_line":"        raise exceptions.InvalidL7PolicyAction(action\u003d\u0027None\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # See if we have anything left after that..."},{"line_number":223,"context_line":"    if len(l7policy.keys()) \u003d\u003d 0:"},{"line_number":224,"context_line":"        raise exceptions.InvalidL7PolicyArgs(msg\u003d\u0027Invalid update options\u0027)"},{"line_number":225,"context_line":"    return l7policy"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_4e2d58fd","line":224,"range":{"start_line":218,"start_character":0,"end_line":224,"end_character":74},"updated":"2016-03-03 01:34:05.000000000","message":"Should we do these checks in beginning ?","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"8e8d829795d2da9ea47f8f851e8afdb8ea06bcae","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            raise exceptions.InvalidL7PolicyArgs("},{"line_number":216,"context_line":"                msg\u003d\u0027redirect_url must not be None\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # If we are creating, we need an action at this point"},{"line_number":219,"context_line":"    if create and \u0027action\u0027 not in l7policy.keys():"},{"line_number":220,"context_line":"        raise exceptions.InvalidL7PolicyAction(action\u003d\u0027None\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # See if we have anything left after that..."},{"line_number":223,"context_line":"    if len(l7policy.keys()) \u003d\u003d 0:"},{"line_number":224,"context_line":"        raise exceptions.InvalidL7PolicyArgs(msg\u003d\u0027Invalid update options\u0027)"},{"line_number":225,"context_line":"    return l7policy"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_a4b23b04","line":224,"range":{"start_line":218,"start_character":0,"end_line":224,"end_character":74},"in_reply_to":"7af24918_4e2d58fd","updated":"2016-03-03 02:15:17.000000000","message":"No. The way this method flows, some of the keys in the l7policy update/create request may have been removed by sanitization. As such, it\u0027s important to make sure that we have the ones we really need at the end.\n\nSee the myriad of unit tests I added to cover this method to see illustrations of what I mean.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"3a4faf0a18de088327a5a1e4d82a251398c388e9","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            raise exceptions.InvalidL7PolicyArgs("},{"line_number":216,"context_line":"                msg\u003d\u0027redirect_url must not be None\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # If we are creating, we need an action at this point"},{"line_number":219,"context_line":"    if create and \u0027action\u0027 not in l7policy.keys():"},{"line_number":220,"context_line":"        raise exceptions.InvalidL7PolicyAction(action\u003d\u0027None\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # See if we have anything left after that..."},{"line_number":223,"context_line":"    if len(l7policy.keys()) \u003d\u003d 0:"},{"line_number":224,"context_line":"        raise exceptions.InvalidL7PolicyArgs(msg\u003d\u0027Invalid update options\u0027)"},{"line_number":225,"context_line":"    return l7policy"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_3f0c78ec","line":224,"range":{"start_line":218,"start_character":0,"end_line":224,"end_character":74},"in_reply_to":"7af24918_a4b23b04","updated":"2016-03-03 02:39:57.000000000","message":"Ok.","commit_id":"4b6c1a0b9079f615c0bde21100a7e7f3918d0ed0"}]}
