)]}'
{"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b7bac1c3688cddbb7d3948077a932c7bf64db057","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# admin_password \u003d password"},{"line_number":56,"context_line":"# admin_tenant_name \u003d service"},{"line_number":57,"context_line":"# insecure \u003d False"},{"line_number":58,"context_line":"# cafile \u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[keystone_authtoken_v3]"},{"line_number":61,"context_line":"# If using Keystone v3"}],"source_content_type":"text/plain","patch_set":2,"id":"5aef4532_c60bf4d4","line":58,"updated":"2016-03-09 18:03:31.000000000","message":"Can we add a comment at the top of this block about the fact that this is an imported group and why some names may be different than the rest of the file?\nJust a quick glance at this makes me ask why this is \"cafile\" and the others are \"ca_certificates_file\".\n\nSince the APIs are not consistent, I think a comment is ok.","commit_id":"944e946aabe0c73c14c59e5c70487a27136bf43f"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"87a3da95dce1c73d93064023ff7da266032d6562","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# admin_password \u003d password"},{"line_number":56,"context_line":"# admin_tenant_name \u003d service"},{"line_number":57,"context_line":"# insecure \u003d False"},{"line_number":58,"context_line":"# cafile \u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[keystone_authtoken_v3]"},{"line_number":61,"context_line":"# If using Keystone v3"}],"source_content_type":"text/plain","patch_set":2,"id":"5aef4532_fa1de462","line":58,"in_reply_to":"5aef4532_c60bf4d4","updated":"2016-03-09 18:07:45.000000000","message":"Will do in next patch.","commit_id":"944e946aabe0c73c14c59e5c70487a27136bf43f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b7bac1c3688cddbb7d3948077a932c7bf64db057","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# REST Driver specific"},{"line_number":116,"context_line":"# bind_host \u003d 0.0.0.0"},{"line_number":117,"context_line":"# bind_port \u003d 9443"},{"line_number":118,"context_line":"# haproxy_cmd \u003d /usr/sbin/haproxy"},{"line_number":119,"context_line":"# respawn_count \u003d 2"},{"line_number":120,"context_line":"# respawn_interval \u003d 2"}],"source_content_type":"text/plain","patch_set":2,"id":"5aef4532_46c36489","line":117,"updated":"2016-03-09 18:03:31.000000000","message":"Unrelated change, please comment in commit message.","commit_id":"944e946aabe0c73c14c59e5c70487a27136bf43f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1e6e61ad6e434753dabe4d1be1091f2037470350","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[keystone_authtoken]"},{"line_number":53,"context_line":"# This group of config options are imported from keystone middleware. Thus the"},{"line_number":54,"context_line":"# option names should match the names declared in the middleware."},{"line_number":55,"context_line":"# auth_uri \u003d https://localhost:5000/v3"},{"line_number":56,"context_line":"# admin_user \u003d octavia"}],"source_content_type":"text/plain","patch_set":3,"id":"5aef4532_c42da747","line":53,"updated":"2016-03-09 19:53:55.000000000","message":"Nit: I would have put this above the section marker","commit_id":"f4da51c27d289b662d9998463d66374a70ba43ac"}],"octavia/common/keystone.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"f43ce41ce0dd3583a746949aa61527dc07623b57","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            kc \u003d client.Password(**kwargs)"},{"line_number":63,"context_line":"            _SESSION \u003d session.Session("},{"line_number":64,"context_line":"                auth\u003dkc, verify\u003d(cfg.CONF.keystone_authtoken.cafile or"},{"line_number":65,"context_line":"                                 not cfg.CONF.keystone_authtoken.insecure))"},{"line_number":66,"context_line":"        except Exception:"},{"line_number":67,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_1887a8b5","line":64,"range":{"start_line":64,"start_character":33,"end_line":64,"end_character":36},"updated":"2016-03-04 16:01:39.000000000","message":"need to set parameter cert","commit_id":"b9905ac1799f8566e399b6aa46a94e1179ba1ee8"},{"author":{"_account_id":15226,"name":"Bharath M","email":"bharath.stacker@gmail.com","username":"bharath"},"change_message_id":"a0639f72acf66d67789548c1ca6956494ae8af9e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            kc \u003d client.Password(**kwargs)"},{"line_number":63,"context_line":"            _SESSION \u003d session.Session("},{"line_number":64,"context_line":"                auth\u003dkc, verify\u003d(cfg.CONF.keystone_authtoken.cafile or"},{"line_number":65,"context_line":"                                 not cfg.CONF.keystone_authtoken.insecure))"},{"line_number":66,"context_line":"        except Exception:"},{"line_number":67,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_586c8536","line":64,"range":{"start_line":64,"start_character":33,"end_line":64,"end_character":36},"in_reply_to":"7af24918_1887a8b5","updated":"2016-03-04 19:17:43.000000000","message":"No need. The way keystone logic works is, if \"verify\" is a string, use it as cacert. Otherwise, read it as boolean to perform \"insecure\" connection.","commit_id":"b9905ac1799f8566e399b6aa46a94e1179ba1ee8"}]}
