)]}'
{"octavia/common/jinja/haproxy/templates/haproxy.cfg.j2":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"ee20d4b706c860e6e2202bdb8674f1b6d640ce2a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% block proxies %}"},{"line_number":34,"context_line":"    {% if loadbalancer.enabled and loadbalancer.listener.enabled %}"},{"line_number":35,"context_line":"    {{- frontend_macro(constants, loadbalancer.listener,"},{"line_number":36,"context_line":"                       loadbalancer.vip_address) }}"},{"line_number":37,"context_line":"    {% for pool in loadbalancer.listener.pools if pool.enabled%}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3afc51ec_3364cce2","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":67},"updated":"2016-03-14 20:24:26.000000000","message":"I realize that we don\u0027t have strict pep8 spacing on jinja templates (and in many cases that would be inappropriate anyway). However, in this case I really would like to see the indentation followed, as doing so here should not disrupt the rest of the haproxy config.","commit_id":"f93bd2967cb5c9b6c4e6a2bc7c97d9e99abb2572"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"44f2eb72662abe9d692a3aa04c7f6f500ed8d53b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{% block proxies %}"},{"line_number":34,"context_line":"    {% if loadbalancer.enabled and loadbalancer.listener.enabled %}"},{"line_number":35,"context_line":"        {{- frontend_macro(constants, loadbalancer.listener,"},{"line_number":36,"context_line":"                           loadbalancer.vip_address) }}"},{"line_number":37,"context_line":"        {% for pool in loadbalancer.listener.pools if pool.enabled%}"},{"line_number":38,"context_line":"            {{- backend_macro(constants, loadbalancer.listener, pool) }}"},{"line_number":39,"context_line":"        {% endfor %}"},{"line_number":40,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3afc51ec_7ece1bb5","line":37,"range":{"start_line":36,"start_character":55,"end_line":37,"end_character":68},"updated":"2016-03-14 20:43:19.000000000","message":"Nit: space between pool.enabled and %}","commit_id":"313f792b073ee9618810286ad82eb515a89154a5"}],"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"ee20d4b706c860e6e2202bdb8674f1b6d640ce2a","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        lb \u003d self._lb_repo.get(db_apis.get_session(),"},{"line_number":356,"context_line":"                               id\u003dload_balancer_id)"},{"line_number":357,"context_line":"        listeners \u003d self._listener_repo.get_all("},{"line_number":358,"context_line":"            db_apis.get_session(),"},{"line_number":359,"context_line":"            load_balancer_id\u003dload_balancer_id)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_935cc0ee","line":357,"range":{"start_line":357,"start_character":0,"end_line":357,"end_character":48},"updated":"2016-03-14 20:24:26.000000000","message":"Ok, I thought we specifically did not want to grab listener information from the database (repo), as it won\u0027t reflect any changes occurring in the current request. Are you certain this is OK to do here?","commit_id":"f93bd2967cb5c9b6c4e6a2bc7c97d9e99abb2572"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"24e4a8ab3021d7e61409c8608958b51d302f55fd","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        lb \u003d self._lb_repo.get(db_apis.get_session(),"},{"line_number":356,"context_line":"                               id\u003dload_balancer_id)"},{"line_number":357,"context_line":"        listeners \u003d self._listener_repo.get_all("},{"line_number":358,"context_line":"            db_apis.get_session(),"},{"line_number":359,"context_line":"            load_balancer_id\u003dload_balancer_id)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_d385a8ad","line":357,"range":{"start_line":357,"start_character":0,"end_line":357,"end_character":48},"in_reply_to":"3afc51ec_935cc0ee","updated":"2016-03-14 20:33:42.000000000","message":"I felt uncomfortable with that as well. But we would get the same from loadbalancer.listeners... so that is not really that wrong (except the performance hit). Personally, I would like us to preserve the flow and adapt the task... but as such this is fine","commit_id":"f93bd2967cb5c9b6c4e6a2bc7c97d9e99abb2572"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3642e908fdf343bedb41c4c136730e5aa78fcfef","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        lb \u003d self._lb_repo.get(db_apis.get_session(),"},{"line_number":356,"context_line":"                               id\u003dload_balancer_id)"},{"line_number":357,"context_line":"        listeners \u003d self._listener_repo.get_all("},{"line_number":358,"context_line":"            db_apis.get_session(),"},{"line_number":359,"context_line":"            load_balancer_id\u003dload_balancer_id)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_9e27a763","line":357,"range":{"start_line":357,"start_character":0,"end_line":357,"end_character":48},"in_reply_to":"3afc51ec_935cc0ee","updated":"2016-03-14 20:45:28.000000000","message":"We re-use the task \"UpdateListener\" for flows that impact just one of the listeners on an LB, so for code re-use we don\u0027t want to extract the listeners from the lb inside the task.  This is why it is injected into the flow.","commit_id":"f93bd2967cb5c9b6c4e6a2bc7c97d9e99abb2572"}]}