)]}'
{"octavia/api/v1/controllers/l7rule.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"662c545f52a4bf06d03b5b2cef7a907af34b74c5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":129,"context_line":"        db_l7rule \u003d self._get_db_l7rule(context.session, id)"},{"line_number":130,"context_line":"        new_l7rule \u003d data_models.L7Rule(**l7rule.to_dict())"},{"line_number":131,"context_line":"        # NOTE(blogan): backfill existing values from the db into values that"},{"line_number":132,"context_line":"        # were not specified so that validation works as intended"},{"line_number":133,"context_line":"        if db_l7rule:"},{"line_number":134,"context_line":"            if not new_l7rule.type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_df00bb36","line":131,"range":{"start_line":131,"start_character":24,"end_line":131,"end_character":32},"updated":"2016-03-10 07:48:35.000000000","message":"blogan: Why don\u0027t we just do something like:\n\nnew_l7rule \u003d db_l7rule.to_dict()\nnew_l7rule.update(l7rule.to_dict())\n\n(and then try the validation)\n\nThe _get_db_l7rule() method will raise an error if the rule is not found in the database (as it should: This is a PUT request after all). The rest of the attributes will get overridden by the dict.update method as necessary (ie. as specified in the API request).","commit_id":"b52e8e090603127a67364e5d822f4fece91f38aa"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f59d2be044c8e9e867956b4915ff0166112079bd","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":129,"context_line":"        db_l7rule \u003d self._get_db_l7rule(context.session, id)"},{"line_number":130,"context_line":"        new_l7rule \u003d data_models.L7Rule(**l7rule.to_dict())"},{"line_number":131,"context_line":"        # NOTE(blogan): backfill existing values from the db into values that"},{"line_number":132,"context_line":"        # were not specified so that validation works as intended"},{"line_number":133,"context_line":"        if db_l7rule:"},{"line_number":134,"context_line":"            if not new_l7rule.type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_31c3d358","line":131,"range":{"start_line":131,"start_character":24,"end_line":131,"end_character":32},"in_reply_to":"5aef4532_df00bb36","updated":"2016-03-10 08:49:55.000000000","message":"good idea, had to convert it to data model so i didn\u0027t have to modify the validate method to accept a dictionary.","commit_id":"b52e8e090603127a67364e5d822f4fece91f38aa"}]}