)]}'
{"octavia/api/v1/controllers/load_balancer.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"fa855240d319e9ef3e91deb47dc9c8347b4df752","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_db import exception as odb_exceptions"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_10c7df96","line":16,"updated":"2016-03-31 03:20:47.000000000","message":"ditto","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"54c50bda40ff3f84f6d496c005fd7b92d8a781c6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_db import exception as odb_exceptions"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_4e07ba81","line":16,"in_reply_to":"ba0121b8_10c7df96","updated":"2016-04-01 07:18:40.000000000","message":"will correct them in next patch.","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"fa855240d319e9ef3e91deb47dc9c8347b4df752","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from octavia.db import prepare as db_prepare"},{"line_number":33,"context_line":"from octavia.i18n import _LI"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from stevedore import driver as stevedore_driver"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_f0c34b87","line":35,"updated":"2016-03-31 03:20:47.000000000","message":"ditto","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"}],"octavia/api/v1/controllers/member.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"fa855240d319e9ef3e91deb47dc9c8347b4df752","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import oslo_db.exception as oslo_exc"},{"line_number":21,"context_line":"from oslo_utils import excutils"},{"line_number":22,"context_line":"import pecan"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_50e67744","line":19,"updated":"2016-03-31 03:20:47.000000000","message":"hmm...I don\u0027t think it is the right import order according to https://www.python.org/dev/peps/pep-0008/#imports","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"54c50bda40ff3f84f6d496c005fd7b92d8a781c6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import oslo_db.exception as oslo_exc"},{"line_number":21,"context_line":"from oslo_utils import excutils"},{"line_number":22,"context_line":"import pecan"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_6e00be66","line":19,"in_reply_to":"ba0121b8_50e67744","updated":"2016-04-01 07:18:40.000000000","message":"noted","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"fa855240d319e9ef3e91deb47dc9c8347b4df752","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from octavia.db import prepare as db_prepare"},{"line_number":31,"context_line":"from octavia.i18n import _LI"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from stevedore import driver as stevedore_driver"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_d0c8c7aa","line":33,"updated":"2016-03-31 03:20:47.000000000","message":"ditto","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"4e377e78db7f65e19a393add730f0645cd59b777","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def post(self, member):"},{"line_number":102,"context_line":"        \"\"\"Creates a pool member on a pool.\"\"\""},{"line_number":103,"context_line":"        # Validating the subnet id by trying to get it from neutron"},{"line_number":104,"context_line":"        self.network_driver.get_subnet(member.subnet_id)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":"        member_dict \u003d db_prepare.create_member(member.to_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_90c92f29","line":104,"updated":"2016-03-31 03:48:38.000000000","message":"I have another question, what if the \u0027address\u0027 of the member is not belong to the subnet cidr? Should we also check that?","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"513b7a7c8474bcc4be769a6df1fc8a8515ba09c0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def post(self, member):"},{"line_number":102,"context_line":"        \"\"\"Creates a pool member on a pool.\"\"\""},{"line_number":103,"context_line":"        # Validating the subnet id by trying to get it from neutron"},{"line_number":104,"context_line":"        self.network_driver.get_subnet(member.subnet_id)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":"        member_dict \u003d db_prepare.create_member(member.to_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_a225cd5c","line":104,"in_reply_to":"ba0121b8_90c92f29","updated":"2016-04-01 04:11:33.000000000","message":"whats the API error message look like when this fails? seems like just allowing the exception to bubble up isn\u0027t going to give a good error message.","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"54c50bda40ff3f84f6d496c005fd7b92d8a781c6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def post(self, member):"},{"line_number":102,"context_line":"        \"\"\"Creates a pool member on a pool.\"\"\""},{"line_number":103,"context_line":"        # Validating the subnet id by trying to get it from neutron"},{"line_number":104,"context_line":"        self.network_driver.get_subnet(member.subnet_id)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":"        member_dict \u003d db_prepare.create_member(member.to_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_aed936f5","line":104,"in_reply_to":"ba0121b8_a225cd5c","updated":"2016-04-01 07:18:40.000000000","message":"@kong: Neutron also allows this kind of behavior, I am not sure why do they it.\nI tried this and neutron cli didn\u0027t complain abt it. \nneutron lbaas-member-create --subnet private-subnet --address 11.0.0.12 --protocol-port 80 test_pool\n  \n@bogan: It\u0027s actually a well made error message saying subnet id does not exist. I ll update it with the exact error msg.","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5899419759d7f77f1db466d1757b48a59414d80e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def post(self, member):"},{"line_number":102,"context_line":"        \"\"\"Creates a pool member on a pool.\"\"\""},{"line_number":103,"context_line":"        # Validating the subnet id by trying to get it from neutron"},{"line_number":104,"context_line":"        self.network_driver.get_subnet(member.subnet_id)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":"        member_dict \u003d db_prepare.create_member(member.to_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_6743876d","line":104,"in_reply_to":"ba0121b8_aed936f5","updated":"2016-04-03 09:37:54.000000000","message":"I think it\u0027s ok that we don\u0027t check that, think about if we config the wrong backend member address on purpose in haproxy, there won\u0027t be any error message, neither.","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"161d6c1a5fd5e437ad6ef9d1ae2f0c0e61cc7b0d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def post(self, member):"},{"line_number":102,"context_line":"        \"\"\"Creates a pool member on a pool.\"\"\""},{"line_number":103,"context_line":"        # Validating the subnet id by trying to get it from neutron"},{"line_number":104,"context_line":"        self.network_driver.get_subnet(member.subnet_id)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":"        member_dict \u003d db_prepare.create_member(member.to_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_4ec02c7d","line":104,"in_reply_to":"ba0121b8_aed936f5","updated":"2016-04-02 04:29:32.000000000","message":"Oh, is it the exception that the network driver throws?  I was thinking it was going to be the NotFound exception for the neutronclient (or whatever the driver got implemented with).  Sadly, I think I put that exception in Octavia and the code to throw it in the network driver, but I forgot lol.","commit_id":"a9c6a0899a597b7f24dc4ceec14692f426ca2df6"}]}
