)]}'
{"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c1952e9d36a806629aabca76a7475fe99c9f7aa7","unresolved":false,"context_lines":[{"line_number":443,"context_line":"            self.nova_client.servers.interface_attach("},{"line_number":444,"context_line":"                server\u003damphora.compute_id, port_id\u003dport.id)"},{"line_number":445,"context_line":"        except nova_client_exceptions.NotFound as e:"},{"line_number":446,"context_line":"            if \u0027Instance\u0027 in e.message:"},{"line_number":447,"context_line":"                raise base.AmphoraNotFound(e.message)"},{"line_number":448,"context_line":"            elif \u0027Network\u0027 in e.message:"},{"line_number":449,"context_line":"                raise base.NetworkNotFound(e.message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_d96dfd05","line":446,"range":{"start_line":446,"start_character":16,"end_line":446,"end_character":24},"updated":"2016-03-21 20:52:33.000000000","message":"that feels a bit crude...isn\u0027t there any Exception Hierarchy we can take advantage of","commit_id":"c1c5206aa5ae72467d40c31d1b42bfa6e993b86c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5d81d4f203107a9ddcb19fd6d1ed160cffd2a86f","unresolved":false,"context_lines":[{"line_number":443,"context_line":"            self.nova_client.servers.interface_attach("},{"line_number":444,"context_line":"                server\u003damphora.compute_id, port_id\u003dport.id)"},{"line_number":445,"context_line":"        except nova_client_exceptions.NotFound as e:"},{"line_number":446,"context_line":"            if \u0027Instance\u0027 in e.message:"},{"line_number":447,"context_line":"                raise base.AmphoraNotFound(e.message)"},{"line_number":448,"context_line":"            elif \u0027Network\u0027 in e.message:"},{"line_number":449,"context_line":"                raise base.NetworkNotFound(e.message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_5acc3835","line":446,"range":{"start_line":446,"start_character":16,"end_line":446,"end_character":24},"in_reply_to":"fa0719c6_d96dfd05","updated":"2016-03-21 23:42:25.000000000","message":"Not that I could find (btw, this is similar to an above method).","commit_id":"c1c5206aa5ae72467d40c31d1b42bfa6e993b86c"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1475be3340a9a1c1f4817d3f5fe47b1ebcf29efc","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            try:"},{"line_number":435,"context_line":"                self.nova_client.servers.interface_detach("},{"line_number":436,"context_line":"                    server\u003damphora.compute_id, port\u003dport.id)"},{"line_number":437,"context_line":"            except Exception as e:"},{"line_number":438,"context_line":"                LOG.warning(_LW(\u0027Failed to detach port %(portid)s from \u0027"},{"line_number":439,"context_line":"                                \u0027instance %(compid)s.  Error: \u0027"},{"line_number":440,"context_line":"                                \u0027%(error)s\u0027) % {\u0027portid\u0027: port.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_55040914","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":34},"updated":"2016-03-21 23:51:21.000000000","message":"Just to clarify: We\u0027re not failing on this exception because the old amphora may have gone away in a \"graceful\" way that already cleaned up the port, right? Does it make sense to check to see whether the old port is properly detached already, or do you think that\u0027s just a waste of time here?","commit_id":"95828fe76be8f3c6e9d83143f787632ab29cf0b3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"63d5dde4fda6779c2fe15856d8f348a7201eebd9","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            try:"},{"line_number":435,"context_line":"                self.nova_client.servers.interface_detach("},{"line_number":436,"context_line":"                    server\u003damphora.compute_id, port\u003dport.id)"},{"line_number":437,"context_line":"            except Exception as e:"},{"line_number":438,"context_line":"                LOG.warning(_LW(\u0027Failed to detach port %(portid)s from \u0027"},{"line_number":439,"context_line":"                                \u0027instance %(compid)s.  Error: \u0027"},{"line_number":440,"context_line":"                                \u0027%(error)s\u0027) % {\u0027portid\u0027: port.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_b582c5fe","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":34},"in_reply_to":"fa0719c6_55040914","updated":"2016-03-22 00:13:44.000000000","message":"Yeah, it doesn\u0027t really matter to us if it was already detached in some other way.  If this is failing due to some odd way, the plug later in the flow will raise an exception.","commit_id":"95828fe76be8f3c6e9d83143f787632ab29cf0b3"}]}