)]}'
{"octavia/common/data_models.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"e73b28aa1c23b2699ea8bbf57b90bd8f13bbf891","unresolved":false,"context_lines":[{"line_number":120,"context_line":"class SessionPersistence(BaseDataModel):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def __init__(self, pool_id\u003dNone, type\u003dNone, cookie_name\u003dNone,"},{"line_number":123,"context_line":"                 pool\u003dNone, **kwargs):"},{"line_number":124,"context_line":"        self.pool_id \u003d pool_id"},{"line_number":125,"context_line":"        self.type \u003d type"},{"line_number":126,"context_line":"        self.cookie_name \u003d cookie_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_002a0790","line":123,"range":{"start_line":123,"start_character":28,"end_line":123,"end_character":36},"updated":"2016-04-26 12:37:18.000000000","message":"why are we adding this args ?","commit_id":"8c8dd0bb55554a5367b8a59a556d7df622e48653"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"87b9060c8caa28f8b7525d888bdb819947ad3aaa","unresolved":false,"context_lines":[{"line_number":120,"context_line":"class SessionPersistence(BaseDataModel):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def __init__(self, pool_id\u003dNone, type\u003dNone, cookie_name\u003dNone,"},{"line_number":123,"context_line":"                 pool\u003dNone, **kwargs):"},{"line_number":124,"context_line":"        self.pool_id \u003d pool_id"},{"line_number":125,"context_line":"        self.type \u003d type"},{"line_number":126,"context_line":"        self.cookie_name \u003d cookie_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_f287cfb2","line":123,"range":{"start_line":123,"start_character":28,"end_line":123,"end_character":36},"in_reply_to":"1a122d0e_002a0790","updated":"2016-04-26 21:24:25.000000000","message":"because in initialization of these DataModel classes(https://github.com/openstack/octavia/blob/master/octavia/db/base_models.py#L73), they won\u0027t recognize the new columns(created_at and updated_at)","commit_id":"8c8dd0bb55554a5367b8a59a556d7df622e48653"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2db824bd8cd268e8cfd4ef0578db4fc104bd3612","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                 operating_status\u003dNone, members\u003dNone, health_monitor\u003dNone,"},{"line_number":177,"context_line":"                 session_persistence\u003dNone, load_balancer_id\u003dNone,"},{"line_number":178,"context_line":"                 load_balancer\u003dNone, listeners\u003dNone, l7policies\u003dNone,"},{"line_number":179,"context_line":"                 **kwargs):"},{"line_number":180,"context_line":"        self.id \u003d id"},{"line_number":181,"context_line":"        self.project_id \u003d project_id"},{"line_number":182,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_98d207d0","line":179,"updated":"2016-05-05 05:40:37.000000000","message":"can you explain why we now need kwargs since they are not used anywhere below.","commit_id":"08a700fd379270221db84676b1c0ded9577b75f0"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"110476db20b8db5d0174ef3af46a4c263523fe6a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                 operating_status\u003dNone, members\u003dNone, health_monitor\u003dNone,"},{"line_number":177,"context_line":"                 session_persistence\u003dNone, load_balancer_id\u003dNone,"},{"line_number":178,"context_line":"                 load_balancer\u003dNone, listeners\u003dNone, l7policies\u003dNone,"},{"line_number":179,"context_line":"                 **kwargs):"},{"line_number":180,"context_line":"        self.id \u003d id"},{"line_number":181,"context_line":"        self.project_id \u003d project_id"},{"line_number":182,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_909fed5e","line":179,"in_reply_to":"1a122d0e_98d207d0","updated":"2016-05-06 02:16:39.000000000","message":"Please see my answer to Banashankar in patchset4.","commit_id":"08a700fd379270221db84676b1c0ded9577b75f0"}],"octavia/db/migration/alembic_migrations/versions/36b94648fef8_add_timestamp.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"e73b28aa1c23b2699ea8bbf57b90bd8f13bbf891","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def downgrade():"},{"line_number":53,"context_line":"    for name in tables:"},{"line_number":54,"context_line":"        op.drop_column(name, u\u0027created_at\u0027)"},{"line_number":55,"context_line":"        op.drop_column(name, u\u0027updated_at\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4066bf51","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":16},"updated":"2016-04-26 12:37:18.000000000","message":"you can actually skip downgrade as it is depreciated.","commit_id":"8c8dd0bb55554a5367b8a59a556d7df622e48653"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"87b9060c8caa28f8b7525d888bdb819947ad3aaa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def downgrade():"},{"line_number":53,"context_line":"    for name in tables:"},{"line_number":54,"context_line":"        op.drop_column(name, u\u0027created_at\u0027)"},{"line_number":55,"context_line":"        op.drop_column(name, u\u0027updated_at\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b2b8b776","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":16},"in_reply_to":"1a122d0e_4066bf51","updated":"2016-04-26 21:24:25.000000000","message":"Done","commit_id":"8c8dd0bb55554a5367b8a59a556d7df622e48653"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"150351b6504eb3c66b53e1629ad47efb0dcdaf6a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def upgrade():"},{"line_number":41,"context_line":"    for name in tables:"},{"line_number":42,"context_line":"        op.add_column("},{"line_number":43,"context_line":"            name,"},{"line_number":44,"context_line":"            sa.Column(u\u0027created_at\u0027, sa.DateTime(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_fe9c5a0f","line":41,"updated":"2016-04-29 20:07:17.000000000","message":"I don\u0027t like this.  This will add created_at and updated_at columns to parameter tables such as \u0027provisioning_status\u0027.\nWe should only add these columns to tables that need them.","commit_id":"03cfccef1c4886cc10287a735347aaa0c10ad082"}],"octavia/tests/functional/api/v1/test_pool.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"81704a39b1a2f0ca8d1aae33979eae45599a902c","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        self.assertIsNone(api_pool.pop(\u0027updated_at\u0027))"},{"line_number":299,"context_line":"        self.assertIsNotNone(pool.pop(\u0027updated_at\u0027))"},{"line_number":300,"context_line":"        self.assertEqual(api_pool, pool)"},{"line_number":301,"context_line":"        self.delete(self.pool_path.format(pool_id\u003dapi_pool.get(\u0027id\u0027)))"},{"line_number":302,"context_line":"        self.assert_correct_lb_status(self.lb.get(\u0027id\u0027),"},{"line_number":303,"context_line":"                                      constants.PENDING_UPDATE,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_3a822a95","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":33},"updated":"2016-05-29 12:28:11.000000000","message":"confused: how does it happen if the updated_at is not the same?","commit_id":"1c67df237014c2fc503d448b90b87504019d3af1"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"7514648e7dc3ad1de7c452a55554cc4ab0cd36b9","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        self.assertIsNone(api_pool.pop(\u0027updated_at\u0027))"},{"line_number":299,"context_line":"        self.assertIsNotNone(pool.pop(\u0027updated_at\u0027))"},{"line_number":300,"context_line":"        self.assertEqual(api_pool, pool)"},{"line_number":301,"context_line":"        self.delete(self.pool_path.format(pool_id\u003dapi_pool.get(\u0027id\u0027)))"},{"line_number":302,"context_line":"        self.assert_correct_lb_status(self.lb.get(\u0027id\u0027),"},{"line_number":303,"context_line":"                                      constants.PENDING_UPDATE,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_4be2c2d6","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":33},"in_reply_to":"9abb7d3a_3a822a95","updated":"2016-05-29 21:24:39.000000000","message":"\u0027updated_at\u0027 were poped from both of the two object.","commit_id":"1c67df237014c2fc503d448b90b87504019d3af1"}]}