)]}'
{"octavia/controller/worker/tasks/network_tasks.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e8a7bcf0ff04d46ca05de5c8e136cb5533f32b63","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if CONF.controller_worker.amp_network:"},{"line_number":61,"context_line":"            desired_network_ids.add(CONF.controller_worker.amp_network)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if not loadbalancer.listeners:"},{"line_number":64,"context_line":"            return n_data_models.Delta()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        for listener in loadbalancer.listeners:"},{"line_number":67,"context_line":"            if (not listener.default_pool) or ("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_5b1a7b19","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":40},"updated":"2016-05-03 14:46:34.000000000","message":"i feel like it\u0027d be better to just remove these two lines and do what i suggest below.","commit_id":"9688667188e210720ac5f3779e73a6789e1e3629"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e8a7bcf0ff04d46ca05de5c8e136cb5533f32b63","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if not loadbalancer.listeners:"},{"line_number":64,"context_line":"            return n_data_models.Delta()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        for listener in loadbalancer.listeners:"},{"line_number":67,"context_line":"            if (not listener.default_pool) or ("},{"line_number":68,"context_line":"                    not listener.default_pool.members):"},{"line_number":69,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_dbd4cb20","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":47},"updated":"2016-05-03 14:46:34.000000000","message":"Will probably be better to just loop through loadbalancer.pools and not worry about the listener at all.  Change the body of the loop to reflect that too.","commit_id":"9688667188e210720ac5f3779e73a6789e1e3629"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"29c457f22524a2b5f6897380b6b80aa39fabcbdc","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if not loadbalancer.listeners:"},{"line_number":64,"context_line":"            return n_data_models.Delta()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        for listener in loadbalancer.listeners:"},{"line_number":67,"context_line":"            if (not listener.default_pool) or ("},{"line_number":68,"context_line":"                    not listener.default_pool.members):"},{"line_number":69,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_b33806a1","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":47},"in_reply_to":"1a122d0e_3076ac3f","updated":"2016-05-03 22:38:52.000000000","message":"I think Brandon\u0027s comments are the correct solution to this problem.  They both should be done in this patch to fix the bug #1572342.","commit_id":"9688667188e210720ac5f3779e73a6789e1e3629"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"652d0555756ee586f36a938a97a3925a2b7fd385","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if not loadbalancer.listeners:"},{"line_number":64,"context_line":"            return n_data_models.Delta()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        for listener in loadbalancer.listeners:"},{"line_number":67,"context_line":"            if (not listener.default_pool) or ("},{"line_number":68,"context_line":"                    not listener.default_pool.members):"},{"line_number":69,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_3076ac3f","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":47},"in_reply_to":"1a122d0e_dbd4cb20","updated":"2016-05-03 22:12:32.000000000","message":"So, it is a bug that adding members to shared pool won\u0027t add member port to amphora, right? can I fire a new bug and fix in another patch? I don\u0027t see it\u0027s related to bug #1572342, agree?","commit_id":"9688667188e210720ac5f3779e73a6789e1e3629"}]}