)]}'
{"octavia/network/base.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"009086ce3d7387aff84b013654356e430062d6f9","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        pass"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @abc.abstractmethod"},{"line_number":240,"context_line":"    def get_network_configs(self, load_balancer):"},{"line_number":241,"context_line":"        \"\"\"Retrieve network configurations"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        This method assumes that a dictionary of AmphoraNetworkConfigs keyed"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_821408a0","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":27},"updated":"2016-05-17 04:26:46.000000000","message":"can we come up with a better name for this? i created the original name bc i suck with naming. one probably awful name i came up with is get_networking_state","commit_id":"e9cd4aec912024ac0a9a404c3236fc06fadd1a5e"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"006df6614e2bced954248e1c8dfdf38892444223","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        pass"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @abc.abstractmethod"},{"line_number":240,"context_line":"    def get_network_configs(self, load_balancer):"},{"line_number":241,"context_line":"        \"\"\"Retrieve network configurations"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        This method assumes that a dictionary of AmphoraNetworkConfigs keyed"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c210d05b","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":27},"in_reply_to":"dab17558_821408a0","updated":"2016-05-17 04:38:35.000000000","message":"I really don\u0027t think this needs to be changed, it describes whats coming back, unless you think we should rename the object and method to better reflect the data.","commit_id":"e9cd4aec912024ac0a9a404c3236fc06fadd1a5e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"009086ce3d7387aff84b013654356e430062d6f9","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        :param load_balancer: The load_balancer configuration"},{"line_number":255,"context_line":"        :return: dict of octavia.network.data_models.AmphoraNetworkConfig"},{"line_number":256,"context_line":"        keyed off of the amphora the config is associated with."},{"line_number":257,"context_line":"        :raises: NotFound, NetworkNotFound, SubnetNotFound, PortNotFound"},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_daa7274e","line":256,"range":{"start_line":256,"start_character":25,"end_line":256,"end_character":32},"updated":"2016-05-17 04:26:46.000000000","message":"amphora_id","commit_id":"e9cd4aec912024ac0a9a404c3236fc06fadd1a5e"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"006df6614e2bced954248e1c8dfdf38892444223","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        :param load_balancer: The load_balancer configuration"},{"line_number":255,"context_line":"        :return: dict of octavia.network.data_models.AmphoraNetworkConfig"},{"line_number":256,"context_line":"        keyed off of the amphora the config is associated with."},{"line_number":257,"context_line":"        :raises: NotFound, NetworkNotFound, SubnetNotFound, PortNotFound"},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a23cace1","line":256,"range":{"start_line":256,"start_character":25,"end_line":256,"end_character":32},"in_reply_to":"dab17558_daa7274e","updated":"2016-05-17 04:38:35.000000000","message":"Done","commit_id":"e9cd4aec912024ac0a9a404c3236fc06fadd1a5e"}],"octavia/tests/unit/network/drivers/neutron/test_allowed_address_pairs.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"0ff4816935f097d4fb5da993f43db9bb76dd6cb7","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.assertEqual(1, len(configs))"},{"line_number":651,"context_line":"        config \u003d configs[222]"},{"line_number":652,"context_line":"        # mock/test limitation, reuse return for multilple calls,"},{"line_number":653,"context_line":"        # need to make this better"},{"line_number":654,"context_line":"        expected_port_id \u003d n_constants.MOCK_NEUTRON_PORT[\u0027port\u0027][\u0027id\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(expected_port_id, config.ha_port.id)"},{"line_number":656,"context_line":"        self.assertEqual(expected_port_id, config.vrrp_port.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_14c6d467","line":653,"updated":"2016-05-25 21:17:09.000000000","message":"I don\u0027t understand the comment... As in, \"I need to make this better\" or \"mock needs a better way to handle this\"?","commit_id":"b4de17b4da37b025e9915e34b2ab944af427de68"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c9efb7de02e993851752f098e2917bf0b0d990d6","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.assertEqual(1, len(configs))"},{"line_number":651,"context_line":"        config \u003d configs[222]"},{"line_number":652,"context_line":"        # mock/test limitation, reuse return for multilple calls,"},{"line_number":653,"context_line":"        # need to make this better"},{"line_number":654,"context_line":"        expected_port_id \u003d n_constants.MOCK_NEUTRON_PORT[\u0027port\u0027][\u0027id\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(expected_port_id, config.ha_port.id)"},{"line_number":656,"context_line":"        self.assertEqual(expected_port_id, config.vrrp_port.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_da73d57e","line":653,"in_reply_to":"bab6814e_14c6d467","updated":"2016-05-25 22:16:20.000000000","message":"both probably, this is just a weak test and im not quite sure how to do it better.. mostly because I didnt dig too deep.","commit_id":"b4de17b4da37b025e9915e34b2ab944af427de68"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"b3d7ba992252c2960636cfc4587065d94b622eff","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.assertEqual(1, len(configs))"},{"line_number":651,"context_line":"        config \u003d configs[222]"},{"line_number":652,"context_line":"        # mock/test limitation, reuse return for multilple calls,"},{"line_number":653,"context_line":"        # need to make this better"},{"line_number":654,"context_line":"        expected_port_id \u003d n_constants.MOCK_NEUTRON_PORT[\u0027port\u0027][\u0027id\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(expected_port_id, config.ha_port.id)"},{"line_number":656,"context_line":"        self.assertEqual(expected_port_id, config.vrrp_port.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_fcce842b","line":653,"in_reply_to":"bab6814e_610af28b","updated":"2016-05-26 09:23:49.000000000","message":"Done","commit_id":"b4de17b4da37b025e9915e34b2ab944af427de68"},{"author":{"_account_id":13438,"name":"Kobi Samoray","email":"kobi.samoray@broadcom.com","username":"ksamoray"},"change_message_id":"c38ede56cc367b43edd024a44a46d7b4a453e882","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.assertEqual(1, len(configs))"},{"line_number":651,"context_line":"        config \u003d configs[222]"},{"line_number":652,"context_line":"        # mock/test limitation, reuse return for multilple calls,"},{"line_number":653,"context_line":"        # need to make this better"},{"line_number":654,"context_line":"        expected_port_id \u003d n_constants.MOCK_NEUTRON_PORT[\u0027port\u0027][\u0027id\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(expected_port_id, config.ha_port.id)"},{"line_number":656,"context_line":"        self.assertEqual(expected_port_id, config.vrrp_port.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_610af28b","line":653,"in_reply_to":"bab6814e_da73d57e","updated":"2016-05-26 07:59:19.000000000","message":"a TODO explaining what improvements are needed will be nice. Just in case that anyone gets to this before you do...","commit_id":"b4de17b4da37b025e9915e34b2ab944af427de68"}]}