)]}'
{"octavia/distributor/drivers/ovs_driver/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.client.get_info(distributor)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_details(self, distributor):"},{"line_number":57,"context_line":"        self.client.get_info(distributor)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def finalize_distributor(self, distributor):"},{"line_number":60,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_a1173dec","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":41},"updated":"2016-10-10 23:40:44.000000000","message":"This speaks to my comments on the base driver.\nFrom the description, this should be get_status and not get_details.  If you feel it should be get_details, please describe why it would return anything different than get_info above.  You could be consistent with the amphora API and call it get_diagnostics","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.client.get_info(distributor)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_details(self, distributor):"},{"line_number":57,"context_line":"        self.client.get_info(distributor)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def finalize_distributor(self, distributor):"},{"line_number":60,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_534ab028","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":41},"in_reply_to":"fa6399be_a1173dec","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def get_details(self, distributor):"},{"line_number":57,"context_line":"        self.client.get_info(distributor)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def finalize_distributor(self, distributor):"},{"line_number":60,"context_line":"        pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def post_vip_plug(self, distributor, load_balancer, distributor_mac,"},{"line_number":63,"context_line":"                      alg_extra):"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_01dd4942","line":60,"range":{"start_line":59,"start_character":0,"end_line":60,"end_character":12},"updated":"2016-10-10 23:40:44.000000000","message":"Do we need this?  Can it be removed from the base, noop, and here?","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def get_details(self, distributor):"},{"line_number":57,"context_line":"        self.client.get_info(distributor)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def finalize_distributor(self, distributor):"},{"line_number":60,"context_line":"        pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def post_vip_plug(self, distributor, load_balancer, distributor_mac,"},{"line_number":63,"context_line":"                      alg_extra):"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_b35144db","line":60,"range":{"start_line":59,"start_character":0,"end_line":60,"end_character":12},"in_reply_to":"fa6399be_01dd4942","updated":"2016-11-22 08:09:26.000000000","message":"I remove it","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def post_vip_plug(self, distributor, load_balancer, distributor_mac,"},{"line_number":63,"context_line":"                      alg_extra):"},{"line_number":64,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"},{"line_number":65,"context_line":"        extras \u003d {\u0027subnet_cidr\u0027: subnet.cidr,"},{"line_number":66,"context_line":"                  \u0027gateway\u0027: subnet.gateway_ip,"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_21e24d04","line":63,"range":{"start_line":63,"start_character":22,"end_line":63,"end_character":31},"updated":"2016-10-10 23:40:44.000000000","message":"No, this is too vague and will lead to failures and mistakes.  I.e. how would a caller know what topology manager is used in this distributor?\nThis breaks the interface definition.","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def post_vip_plug(self, distributor, load_balancer, distributor_mac,"},{"line_number":63,"context_line":"                      alg_extra):"},{"line_number":64,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"},{"line_number":65,"context_line":"        extras \u003d {\u0027subnet_cidr\u0027: subnet.cidr,"},{"line_number":66,"context_line":"                  \u0027gateway\u0027: subnet.gateway_ip,"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_f361fca9","line":63,"range":{"start_line":63,"start_character":22,"end_line":63,"end_character":31},"in_reply_to":"fa6399be_21e24d04","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                      load_balancer.vip.ip_address,"},{"line_number":75,"context_line":"                                      extras)"},{"line_number":76,"context_line":"        except Exception:"},{"line_number":77,"context_line":"            LOG.debug(\"post_vip_plug: Ignoring exceptions for now\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def pre_vip_unplug(self, distributor, load_balancer):"},{"line_number":80,"context_line":"        extras \u003d {\u0027lb_id\u0027: load_balancer.id}"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_e1be95d3","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":67},"updated":"2016-10-10 23:40:44.000000000","message":"Nope.  We can\u0027t just eat exceptions here.\nIf you don\u0027t know how to handle them, let them raise up.","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                      load_balancer.vip.ip_address,"},{"line_number":75,"context_line":"                                      extras)"},{"line_number":76,"context_line":"        except Exception:"},{"line_number":77,"context_line":"            LOG.debug(\"post_vip_plug: Ignoring exceptions for now\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def pre_vip_unplug(self, distributor, load_balancer):"},{"line_number":80,"context_line":"        extras \u003d {\u0027lb_id\u0027: load_balancer.id}"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_b3686489","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":67},"in_reply_to":"fa6399be_e1be95d3","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                       load_balancer.vip.ip_address,"},{"line_number":86,"context_line":"                                       extras)"},{"line_number":87,"context_line":"        except Exception:"},{"line_number":88,"context_line":"            LOG.debug(\"pre_vip_unplug: Ignoring exceptions for now\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def register_amphora(self, distributor, load_balancer, amphora, alg_extra):"},{"line_number":91,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_61cb6573","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":68},"updated":"2016-10-10 23:40:44.000000000","message":"Nope.  We can\u0027t just eat exceptions here.\nIf you don\u0027t know how to handle them, let them raise up","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                       load_balancer.vip.ip_address,"},{"line_number":86,"context_line":"                                       extras)"},{"line_number":87,"context_line":"        except Exception:"},{"line_number":88,"context_line":"            LOG.debug(\"pre_vip_unplug: Ignoring exceptions for now\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def register_amphora(self, distributor, load_balancer, amphora, alg_extra):"},{"line_number":91,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_d30320bd","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":68},"in_reply_to":"fa6399be_61cb6573","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        except Exception:"},{"line_number":88,"context_line":"            LOG.debug(\"pre_vip_unplug: Ignoring exceptions for now\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def register_amphora(self, distributor, load_balancer, amphora, alg_extra):"},{"line_number":91,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"},{"line_number":92,"context_line":"        amphora_mac \u003d self.network_driver.get_port("},{"line_number":93,"context_line":"            amphora.vrrp_port_id).mac_address"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_a1c57d5c","line":90,"range":{"start_line":90,"start_character":68,"end_line":90,"end_character":77},"updated":"2016-10-10 23:40:44.000000000","message":"No, this is too vague and will lead to failures and mistakes.  I.e. how would a caller know what topology manager is used in this distributor?\nThis breaks the interface definition.","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        except Exception:"},{"line_number":88,"context_line":"            LOG.debug(\"pre_vip_unplug: Ignoring exceptions for now\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def register_amphora(self, distributor, load_balancer, amphora, alg_extra):"},{"line_number":91,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"},{"line_number":92,"context_line":"        amphora_mac \u003d self.network_driver.get_port("},{"line_number":93,"context_line":"            amphora.vrrp_port_id).mac_address"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_130e78e5","line":90,"range":{"start_line":90,"start_character":68,"end_line":90,"end_character":77},"in_reply_to":"fa6399be_a1c57d5c","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                         load_balancer.vip.ip_address,"},{"line_number":105,"context_line":"                                         extras)"},{"line_number":106,"context_line":"        except Exception:"},{"line_number":107,"context_line":"            LOG.debug(\"register_amphora: Ignoring exceptions for now\")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def unregister_amphora(self, distributor, load_balancer, amphora,"},{"line_number":110,"context_line":"                           alg_extra):"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_01ab898a","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":70},"updated":"2016-10-10 23:40:44.000000000","message":"Nope.  We can\u0027t just eat exceptions here.\nIf you don\u0027t know how to handle them, let them raise up","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                         load_balancer.vip.ip_address,"},{"line_number":105,"context_line":"                                         extras)"},{"line_number":106,"context_line":"        except Exception:"},{"line_number":107,"context_line":"            LOG.debug(\"register_amphora: Ignoring exceptions for now\")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def unregister_amphora(self, distributor, load_balancer, amphora,"},{"line_number":110,"context_line":"                           alg_extra):"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_3313740f","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":70},"in_reply_to":"fa6399be_01ab898a","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            LOG.debug(\"register_amphora: Ignoring exceptions for now\")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def unregister_amphora(self, distributor, load_balancer, amphora,"},{"line_number":110,"context_line":"                           alg_extra):"},{"line_number":111,"context_line":"        subnet \u003d self.network_driver.get_subnet(load_balancer.vip.subnet_id)"},{"line_number":112,"context_line":"        extras \u003d {\u0027subnet_cidr\u0027: subnet.cidr,"},{"line_number":113,"context_line":"                  \u0027gateway\u0027: subnet.gateway_ip,"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_21b08df4","line":110,"range":{"start_line":110,"start_character":27,"end_line":110,"end_character":36},"updated":"2016-10-10 23:40:44.000000000","message":"No, this is too vague and will lead to failures and mistakes.  I.e. how would a caller know what topology manager is used in this distributor?\nThis breaks the interface definition.","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                           load_balancer.vip.ip_address,"},{"line_number":122,"context_line":"                                           extras)"},{"line_number":123,"context_line":"        except Exception:"},{"line_number":124,"context_line":"            LOG.debug(\"unregister_amphora: Ignoring exceptions for now\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Check a custom hostname"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_819f995e","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":72},"updated":"2016-10-10 23:40:44.000000000","message":"Nope.  We can\u0027t just eat exceptions here.\nIf you don\u0027t know how to handle them, let them raise up","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                           load_balancer.vip.ip_address,"},{"line_number":122,"context_line":"                                           extras)"},{"line_number":123,"context_line":"        except Exception:"},{"line_number":124,"context_line":"            LOG.debug(\"unregister_amphora: Ignoring exceptions for now\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Check a custom hostname"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_73f5ecc9","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":72},"in_reply_to":"fa6399be_819f995e","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":135,"context_line":"class DistributorAPIClient(object):"},{"line_number":136,"context_line":"    def __init__(self):"},{"line_number":137,"context_line":"        super(DistributorAPIClient, self).__init__()"},{"line_number":138,"context_line":"        self.secure \u003d False"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self.get \u003d functools.partial(self.request, \u0027get\u0027)"},{"line_number":141,"context_line":"        self.post \u003d functools.partial(self.request, \u0027post\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_a19c9d6a","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":27},"updated":"2016-10-10 23:40:44.000000000","message":"Is this used?","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"class DistributorAPIClient(object):"},{"line_number":136,"context_line":"    def __init__(self):"},{"line_number":137,"context_line":"        super(DistributorAPIClient, self).__init__()"},{"line_number":138,"context_line":"        self.secure \u003d False"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self.get \u003d functools.partial(self.request, \u0027get\u0027)"},{"line_number":141,"context_line":"        self.post \u003d functools.partial(self.request, \u0027post\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_9319a825","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":27},"in_reply_to":"fa6399be_a19c9d6a","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        headers[\u0027User-Agent\u0027] \u003d OCTAVIA_API_CLIENT"},{"line_number":177,"context_line":"        self.ssl_adapter.uuid \u003d dist.id"},{"line_number":178,"context_line":"        # Keep retrying"},{"line_number":179,"context_line":"        for a in six.moves.xrange(CONF.distributor.connection_max_retries):"},{"line_number":180,"context_line":"            try:"},{"line_number":181,"context_line":"                r \u003d _request(**reqargs)"},{"line_number":182,"context_line":"            except requests.ConnectionError:"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_e18cd537","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":75},"updated":"2016-10-10 23:40:44.000000000","message":"You might want to incorporate the change here:\nhttps://review.openstack.org/#/c/383940","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        headers[\u0027User-Agent\u0027] \u003d OCTAVIA_API_CLIENT"},{"line_number":177,"context_line":"        self.ssl_adapter.uuid \u003d dist.id"},{"line_number":178,"context_line":"        # Keep retrying"},{"line_number":179,"context_line":"        for a in six.moves.xrange(CONF.distributor.connection_max_retries):"},{"line_number":180,"context_line":"            try:"},{"line_number":181,"context_line":"                r \u003d _request(**reqargs)"},{"line_number":182,"context_line":"            except requests.ConnectionError:"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_be8cab80","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":75},"in_reply_to":"fa6399be_e18cd537","updated":"2016-11-22 08:09:26.000000000","message":"We have a bit different code here. I prefer to leave it our way if it is not something impotent.","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                if a \u003e\u003d CONF.distributor.connection_max_retries:"},{"line_number":186,"context_line":"                    raise driver_except.TimeOutException()"},{"line_number":187,"context_line":"            else:"},{"line_number":188,"context_line":"                LOG.debug(\"OVS_DRIVER / REST / Got response [%s] \","},{"line_number":189,"context_line":"                          r.content)"},{"line_number":190,"context_line":"                return r"},{"line_number":191,"context_line":"        raise driver_except.UnavailableException()"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_417ca120","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":36},"updated":"2016-10-10 23:40:44.000000000","message":"This doesn\u0027t include the response code and will be blank if the server returns 500 for example.\nWe should log this better.","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                if a \u003e\u003d CONF.distributor.connection_max_retries:"},{"line_number":186,"context_line":"                    raise driver_except.TimeOutException()"},{"line_number":187,"context_line":"            else:"},{"line_number":188,"context_line":"                LOG.debug(\"OVS_DRIVER / REST / Got response [%s] \","},{"line_number":189,"context_line":"                          r.content)"},{"line_number":190,"context_line":"                return r"},{"line_number":191,"context_line":"        raise driver_except.UnavailableException()"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_7ee3f305","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":36},"in_reply_to":"fa6399be_417ca120","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"}],"octavia/tests/unit/distributor/drivers/test_distributor_rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.subnet \u003d network_models.Subnet(cidr\u003dFAKE_CIDR,"},{"line_number":59,"context_line":"                                            gateway_ip\u003dFAKE_GATEWAY)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":62,"context_line":"        return self.subnet"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_port(self, port_id):"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_81c4f940","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":36},"updated":"2016-10-10 23:40:44.000000000","message":"Not used?","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.subnet \u003d network_models.Subnet(cidr\u003dFAKE_CIDR,"},{"line_number":59,"context_line":"                                            gateway_ip\u003dFAKE_GATEWAY)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":62,"context_line":"        return self.subnet"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_port(self, port_id):"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_3dade188","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":36},"in_reply_to":"fa6399be_81c4f940","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":62,"context_line":"        return self.subnet"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_port(self, port_id):"},{"line_number":65,"context_line":"        return self.port"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_get_info(self):"},{"line_number":68,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_a1c1fd30","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":24},"updated":"2016-10-10 23:40:44.000000000","message":"Not used?","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"abbff9e7ccbf1365430c5d8074bbd72c2aff44d4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":62,"context_line":"        return self.subnet"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_port(self, port_id):"},{"line_number":65,"context_line":"        return self.port"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_get_info(self):"},{"line_number":68,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a77a97e_5daa9d71","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":24},"in_reply_to":"fa6399be_a1c1fd30","updated":"2016-11-22 08:09:26.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def get_port(self, port_id):"},{"line_number":65,"context_line":"        return self.port"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_get_info(self):"},{"line_number":68,"context_line":"        pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_get_diagnostics(self):"},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_a1aadd6e","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":12},"updated":"2016-10-10 23:40:44.000000000","message":"WIP?\nThis is needed to cover the code","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def test_get_info(self):"},{"line_number":68,"context_line":"        pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_get_diagnostics(self):"},{"line_number":71,"context_line":"        pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_finalize_distributor(self):"},{"line_number":74,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_e193f54d","line":71,"range":{"start_line":70,"start_character":1,"end_line":71,"end_character":12},"updated":"2016-10-10 23:40:44.000000000","message":"Testing the amphora driver?","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b0abb6fcc70997d3273673c198575d2b3a956058","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def test_get_diagnostics(self):"},{"line_number":71,"context_line":"        pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_finalize_distributor(self):"},{"line_number":74,"context_line":"        pass"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_post_vip_plug(self):"},{"line_number":77,"context_line":"        extras \u003d {\u0027subnet_cidr\u0027: self.subnet.cidr,"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_01e709e5","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":12},"updated":"2016-10-10 23:40:44.000000000","message":"Needed?  Remove","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"0605fe0c14998448a52bd4ca97aec3cdd9843f83","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def test_get_diagnostics(self):"},{"line_number":71,"context_line":"        pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_finalize_distributor(self):"},{"line_number":74,"context_line":"        pass"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_post_vip_plug(self):"},{"line_number":77,"context_line":"        extras \u003d {\u0027subnet_cidr\u0027: self.subnet.cidr,"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a71b18c_04d68d4e","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":12},"in_reply_to":"3a71b18c_76c8f322","updated":"2016-12-12 14:46:51.000000000","message":"we do use it","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"},{"author":{"_account_id":24261,"name":"Abed Abu dbai","email":"abeda@il.ibm.com","username":"abeda"},"change_message_id":"9d8008de7c675cee7ef2b205ad976284ed9500ff","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def test_get_diagnostics(self):"},{"line_number":71,"context_line":"        pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_finalize_distributor(self):"},{"line_number":74,"context_line":"        pass"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_post_vip_plug(self):"},{"line_number":77,"context_line":"        extras \u003d {\u0027subnet_cidr\u0027: self.subnet.cidr,"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a71b18c_76c8f322","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":12},"in_reply_to":"fa6399be_01e709e5","updated":"2016-12-12 13:32:56.000000000","message":"Done","commit_id":"a7bd0bb7023259be777fd1310cb4591201640074"}]}