)]}'
{"octavia/controller/worker/controller_worker.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        :param amphora_id: ID of the amphora to delete"},{"line_number":97,"context_line":"        :returns: None"},{"line_number":98,"context_line":"        :raises ComputeNodeNotFound: The referenced Amphora was not found"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        amphora \u003d self._amphora_repo.get(db_apis.get_session(),"},{"line_number":101,"context_line":"                                         id\u003damphora_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_8acc656b","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":27},"updated":"2016-10-07 18:51:57.000000000","message":"Its driver specific so we cannot tell that it\u0027s Compute Node - what if someone will make a driver to Bare Metal?","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"f7127c48cdb94286ac8c824f13f677c5d67de2bd","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        :param amphora_id: ID of the amphora to delete"},{"line_number":97,"context_line":"        :returns: None"},{"line_number":98,"context_line":"        :raises ComputeNodeNotFound: The referenced Amphora was not found"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        amphora \u003d self._amphora_repo.get(db_apis.get_session(),"},{"line_number":101,"context_line":"                                         id\u003damphora_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_366c819b","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":27},"in_reply_to":"1a95cdbc_8acc656b","updated":"2016-10-09 11:43:07.000000000","message":"I am using in the allowed_address_pair the same methods for Distributor and for Amphora.\nIn the passed we discussed it widely and came to conclusion that to call Distributor a type of Amphora is wrong and will make things unclear. \nIn order not to write many wrappers and to be able to reuse the same code I have invented the new term \"compute\" :)\nI see that it is really very appropriate for the case when it is bare metal. but now Amphora is also not so appropriate.\nPlease, propose what it should be... Maybe just Node?\nThanks!\nLera","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        :param amphora_id: ID for amphora to failover"},{"line_number":613,"context_line":"        :returns: None"},{"line_number":614,"context_line":"        :raises ComputeNodeNotFound: The referenced amphora was not found"},{"line_number":615,"context_line":"        \"\"\""},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_eabfa9a7","line":614,"range":{"start_line":614,"start_character":16,"end_line":614,"end_character":27},"updated":"2016-10-07 18:51:57.000000000","message":"The same here","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":24261,"name":"Abed Abu dbai","email":"abeda@il.ibm.com","username":"abeda"},"change_message_id":"9c3ba3a9244399977c8cbe312ae2136db2bcdd2a","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        :param amphora_id: ID for amphora to failover"},{"line_number":613,"context_line":"        :returns: None"},{"line_number":614,"context_line":"        :raises ComputeNodeNotFound: The referenced amphora was not found"},{"line_number":615,"context_line":"        \"\"\""},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_65fd8db0","line":614,"range":{"start_line":614,"start_character":16,"end_line":614,"end_character":27},"in_reply_to":"1a95cdbc_eabfa9a7","updated":"2016-12-12 13:33:37.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        :param amphora_id: ID for amphora to rotate"},{"line_number":639,"context_line":"        :returns: None"},{"line_number":640,"context_line":"        :raises ComputeNodeNotFound: The referenced amphora was not found"},{"line_number":641,"context_line":"        \"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        amp \u003d self._amphora_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_8ad38503","line":640,"range":{"start_line":640,"start_character":16,"end_line":640,"end_character":35},"updated":"2016-10-07 18:51:57.000000000","message":"And here","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":24261,"name":"Abed Abu dbai","email":"abeda@il.ibm.com","username":"abeda"},"change_message_id":"9c3ba3a9244399977c8cbe312ae2136db2bcdd2a","unresolved":false,"context_lines":[{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        :param amphora_id: ID for amphora to rotate"},{"line_number":639,"context_line":"        :returns: None"},{"line_number":640,"context_line":"        :raises ComputeNodeNotFound: The referenced amphora was not found"},{"line_number":641,"context_line":"        \"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        amp \u003d self._amphora_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_a5d88554","line":640,"range":{"start_line":640,"start_character":16,"end_line":640,"end_character":35},"in_reply_to":"1a95cdbc_56674db6","updated":"2016-12-12 13:33:37.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"f7127c48cdb94286ac8c824f13f677c5d67de2bd","unresolved":false,"context_lines":[{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        :param amphora_id: ID for amphora to rotate"},{"line_number":639,"context_line":"        :returns: None"},{"line_number":640,"context_line":"        :raises ComputeNodeNotFound: The referenced amphora was not found"},{"line_number":641,"context_line":"        \"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        amp \u003d self._amphora_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_56674db6","line":640,"range":{"start_line":640,"start_character":16,"end_line":640,"end_character":35},"in_reply_to":"1a95cdbc_8ad38503","updated":"2016-10-09 11:43:07.000000000","message":"OK, same reply :)","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"}],"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        This should be configurable in the config file"},{"line_number":256,"context_line":"        :returns: The flow for deleting the amphora"},{"line_number":257,"context_line":"        :raises ComputeNodeNotFound: The referenced Amphora was not found"},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        delete_amphora_flow \u003d linear_flow.Flow(constants.DELETE_AMPHORA_FLOW)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_0a069585","line":257,"range":{"start_line":257,"start_character":16,"end_line":257,"end_character":35},"updated":"2016-10-07 18:51:57.000000000","message":"Same","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"f7127c48cdb94286ac8c824f13f677c5d67de2bd","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        This should be configurable in the config file"},{"line_number":256,"context_line":"        :returns: The flow for deleting the amphora"},{"line_number":257,"context_line":"        :raises ComputeNodeNotFound: The referenced Amphora was not found"},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        delete_amphora_flow \u003d linear_flow.Flow(constants.DELETE_AMPHORA_FLOW)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_7608c9da","line":257,"range":{"start_line":257,"start_character":16,"end_line":257,"end_character":35},"in_reply_to":"1a95cdbc_0a069585","updated":"2016-10-09 11:43:07.000000000","message":"Same","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":24261,"name":"Abed Abu dbai","email":"abeda@il.ibm.com","username":"abeda"},"change_message_id":"9c3ba3a9244399977c8cbe312ae2136db2bcdd2a","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        This should be configurable in the config file"},{"line_number":256,"context_line":"        :returns: The flow for deleting the amphora"},{"line_number":257,"context_line":"        :raises ComputeNodeNotFound: The referenced Amphora was not found"},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        delete_amphora_flow \u003d linear_flow.Flow(constants.DELETE_AMPHORA_FLOW)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_25cc7588","line":257,"range":{"start_line":257,"start_character":16,"end_line":257,"end_character":35},"in_reply_to":"1a95cdbc_7608c9da","updated":"2016-12-12 13:33:37.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"}],"octavia/network/base.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    pass"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class ComputeNodeNotFound(NetworkException):"},{"line_number":71,"context_line":"    pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_aaf76189","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":25},"updated":"2016-10-07 18:51:57.000000000","message":"It\u0027s Nova driver specific like the rest descriptions.","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":24261,"name":"Abed Abu dbai","email":"abeda@il.ibm.com","username":"abeda"},"change_message_id":"9c3ba3a9244399977c8cbe312ae2136db2bcdd2a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    pass"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class ComputeNodeNotFound(NetworkException):"},{"line_number":71,"context_line":"    pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_858f0922","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":25},"in_reply_to":"1a95cdbc_aaf76189","updated":"2016-12-12 13:33:37.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"f7127c48cdb94286ac8c824f13f677c5d67de2bd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    pass"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class ComputeNodeNotFound(NetworkException):"},{"line_number":71,"context_line":"    pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_d6119d05","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":25},"in_reply_to":"1a95cdbc_aaf76189","updated":"2016-10-09 11:43:07.000000000","message":"Same...","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 IBM Corp."},{"line_number":2,"context_line":"#    Copyright 2014 Rackspace"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_6a38f93d","line":1,"updated":"2016-10-07 18:51:57.000000000","message":"Order","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":24261,"name":"Abed Abu dbai","email":"abeda@il.ibm.com","username":"abeda"},"change_message_id":"9c3ba3a9244399977c8cbe312ae2136db2bcdd2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 IBM Corp."},{"line_number":2,"context_line":"#    Copyright 2014 Rackspace"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_05cbf953","line":1,"in_reply_to":"1a95cdbc_16f865c2","updated":"2016-12-12 13:33:37.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"1caae5449d7dbcb51c294d65b407697cbd2b1ba3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 IBM Corp."},{"line_number":2,"context_line":"#    Copyright 2014 Rackspace"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_7b876e0f","line":1,"in_reply_to":"1a95cdbc_16f865c2","updated":"2016-12-12 14:45:18.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"f7127c48cdb94286ac8c824f13f677c5d67de2bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 IBM Corp."},{"line_number":2,"context_line":"#    Copyright 2014 Rackspace"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_16f865c2","line":1,"in_reply_to":"1a95cdbc_6a38f93d","updated":"2016-10-09 11:43:07.000000000","message":"I will check the issue with our legals","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"24b6cbab834cbab5c36c52301e38f28d36c34eaa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            if interface.network_id \u003d\u003d network_id:"},{"line_number":85,"context_line":"                return interface"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _plug_compute_vip(self, compute_node, network_id):"},{"line_number":88,"context_line":"        try:"},{"line_number":89,"context_line":"            port \u003d {\u0027port\u0027: {\u0027name\u0027: \u0027octavia-lb-vip-\u0027 +"},{"line_number":90,"context_line":"                                     compute_node.compute_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_ca474dba","line":87,"updated":"2016-10-07 18:51:57.000000000","message":"It\u0027s nova driver specific again","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"1caae5449d7dbcb51c294d65b407697cbd2b1ba3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            if interface.network_id \u003d\u003d network_id:"},{"line_number":85,"context_line":"                return interface"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _plug_compute_vip(self, compute_node, network_id):"},{"line_number":88,"context_line":"        try:"},{"line_number":89,"context_line":"            port \u003d {\u0027port\u0027: {\u0027name\u0027: \u0027octavia-lb-vip-\u0027 +"},{"line_number":90,"context_line":"                                     compute_node.compute_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_bb790632","line":87,"in_reply_to":"1a95cdbc_ca474dba","updated":"2016-12-12 14:45:18.000000000","message":"Done","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"},{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"f7127c48cdb94286ac8c824f13f677c5d67de2bd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            if interface.network_id \u003d\u003d network_id:"},{"line_number":85,"context_line":"                return interface"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _plug_compute_vip(self, compute_node, network_id):"},{"line_number":88,"context_line":"        try:"},{"line_number":89,"context_line":"            port \u003d {\u0027port\u0027: {\u0027name\u0027: \u0027octavia-lb-vip-\u0027 +"},{"line_number":90,"context_line":"                                     compute_node.compute_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_f6fcd9b9","line":87,"in_reply_to":"1a95cdbc_ca474dba","updated":"2016-10-09 11:43:07.000000000","message":"Same","commit_id":"8335ac7a266d6c0550930292da95d5de5a9cf6c1"}]}