)]}'
{"diskimage-create/README.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"05edd4d49162f54f6f68e2dc8f07149faeaef969","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    - a RHEL 7 base cloud image, manually download from the"},{"line_number":169,"context_line":"      Red Hat Customer Portal. Set the DIB_LOCAL_IMAGE variable"},{"line_number":170,"context_line":"      to point to the file. More details at:"},{"line_number":171,"context_line":"      https://github.com/openstack/diskimage-builder/tree/master/elements/rhel7"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    - a Red Hat subscription for the matching Red Hat OpenStack Platform"},{"line_number":174,"context_line":"      repository. Set the needed registration parameters depending on your"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_ba851408","line":171,"updated":"2016-06-24 01:38:19.000000000","message":"Since we require the user to check out the diskimage-builder repo locally, can we point them to that path as opposed to a direct github path?  This limits the number of places we would need to update in the document should the github path change.  It also makes sure they are looking at the version of the document for the repo they have checked out as opposed to master.","commit_id":"46d93a7878d3a81cb72f5c93d82f2897c2a91696"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"281bee94d13a42e05846cce8a51ac2f9722b57f8","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    - a RHEL 7 base cloud image, manually download from the"},{"line_number":169,"context_line":"      Red Hat Customer Portal. Set the DIB_LOCAL_IMAGE variable"},{"line_number":170,"context_line":"      to point to the file. More details at:"},{"line_number":171,"context_line":"      https://github.com/openstack/diskimage-builder/tree/master/elements/rhel7"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    - a Red Hat subscription for the matching Red Hat OpenStack Platform"},{"line_number":174,"context_line":"      repository. Set the needed registration parameters depending on your"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_b1888b72","line":171,"in_reply_to":"3aaa91ec_ba851408","updated":"2016-06-24 09:16:41.000000000","message":"I put a github link as the elements could be in some random location, but just realized we mention DIB_ELEMENTS variable path before: I will point to it as root, it will be much better","commit_id":"46d93a7878d3a81cb72f5c93d82f2897c2a91696"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"05edd4d49162f54f6f68e2dc8f07149faeaef969","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    - a Red Hat subscription for the matching Red Hat OpenStack Platform"},{"line_number":174,"context_line":"      repository. Set the needed registration parameters depending on your"},{"line_number":175,"context_line":"      configuration. More details at:"},{"line_number":176,"context_line":"      https://github.com/openstack/diskimage-builder/tree/master/elements/rhel-common"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Here is an example with Customer Portal registration and OSP 8 repository:"},{"line_number":179,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_daae2080","line":176,"updated":"2016-06-24 01:38:19.000000000","message":"Same here, can we do a relative path for the user?\n\nAlso, would be be helpful to the user to list those variables out here?  I understand you may want to only include that documentation in the DIB repo if you think it will change over time.","commit_id":"46d93a7878d3a81cb72f5c93d82f2897c2a91696"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"281bee94d13a42e05846cce8a51ac2f9722b57f8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    - a Red Hat subscription for the matching Red Hat OpenStack Platform"},{"line_number":174,"context_line":"      repository. Set the needed registration parameters depending on your"},{"line_number":175,"context_line":"      configuration. More details at:"},{"line_number":176,"context_line":"      https://github.com/openstack/diskimage-builder/tree/master/elements/rhel-common"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Here is an example with Customer Portal registration and OSP 8 repository:"},{"line_number":179,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_31013b39","line":176,"in_reply_to":"3aaa91ec_daae2080","updated":"2016-06-24 09:16:41.000000000","message":"Will fix both pointers :)\nI had a slightly longer version starting to list the variables, but they depend on the registration system used (satellite, customer portal with login/password, portal with activation key). So I moved it to the example below, maybe adding another one for satellite login (the other typical one) would help?","commit_id":"46d93a7878d3a81cb72f5c93d82f2897c2a91696"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"05edd4d49162f54f6f68e2dc8f07149faeaef969","unresolved":false,"context_lines":[{"line_number":198,"context_line":"# Additional RHEL environment checks"},{"line_number":199,"context_line":"if [ \"${AMP_BASEOS}\" \u003d \"rhel\" ]; then"},{"line_number":200,"context_line":"    if [ -z \"${DIB_LOCAL_IMAGE}\" ]; then"},{"line_number":201,"context_line":"        echo \"DIB_LOCAL_IMAGE variable must be set and point to a RHEL 7 base cloud image. Exiting.\""},{"line_number":202,"context_line":"        echo \"For more information, see the README file in ${DIB_ELEMENTS_PATH}/elements/rhel7\""},{"line_number":203,"context_line":"        exit 1"},{"line_number":204,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3aaa91ec_3ad764ee","line":201,"range":{"start_line":201,"start_character":71,"end_line":201,"end_character":72},"updated":"2016-06-24 01:38:19.000000000","message":"Does this only work with 7?  Maybe we should drop the reference to a specific version to make this error message \"future\" compliant.","commit_id":"46d93a7878d3a81cb72f5c93d82f2897c2a91696"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"281bee94d13a42e05846cce8a51ac2f9722b57f8","unresolved":false,"context_lines":[{"line_number":198,"context_line":"# Additional RHEL environment checks"},{"line_number":199,"context_line":"if [ \"${AMP_BASEOS}\" \u003d \"rhel\" ]; then"},{"line_number":200,"context_line":"    if [ -z \"${DIB_LOCAL_IMAGE}\" ]; then"},{"line_number":201,"context_line":"        echo \"DIB_LOCAL_IMAGE variable must be set and point to a RHEL 7 base cloud image. Exiting.\""},{"line_number":202,"context_line":"        echo \"For more information, see the README file in ${DIB_ELEMENTS_PATH}/elements/rhel7\""},{"line_number":203,"context_line":"        exit 1"},{"line_number":204,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3aaa91ec_7653b939","line":201,"range":{"start_line":201,"start_character":71,"end_line":201,"end_character":72},"in_reply_to":"3aaa91ec_3ad764ee","updated":"2016-06-24 09:16:41.000000000","message":"With this patch, yes, the element loaded at line 334 is redhat7 (redhat is the element for RHEL 6). So this will require an update when RHEL8 comes out anyways (same for Centos)","commit_id":"46d93a7878d3a81cb72f5c93d82f2897c2a91696"}],"elements/no-resolvconf/finalise.d/99-disable-resolv-conf":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"bc89285f71d0c5bc367f266e3020409e32f88677","unresolved":false,"context_lines":[{"line_number":3,"context_line":"echo \"\" \u003e /etc/resolv.conf.ORIG"},{"line_number":4,"context_line":"if [ -d /etc/dhcp/dhclient-enter-hooks.d ]"},{"line_number":5,"context_line":"then"},{"line_number":6,"context_line":"\t# Debian/Ubuntu"},{"line_number":7,"context_line":"\techo \"#!/bin/sh"},{"line_number":8,"context_line":"make_resolv_conf() { : ; }\" \u003e /etc/dhcp/dhclient-enter-hooks.d/noresolvconf"},{"line_number":9,"context_line":"\tchmod +x /etc/dhcp/dhclient-enter-hooks.d/noresolvconf"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aa78d24_3e4bf588","line":6,"updated":"2016-07-11 17:35:22.000000000","message":"tabs","commit_id":"faf04722db9e936066651936ef177bd0d118e17c"}]}
