)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"7d439938aaf9eb1ce2695640af80b83151ba3002","unresolved":false,"context_lines":[{"line_number":151,"context_line":"OCTAVIA_ELEMENTS_PATH\u003d$OCTAVIA_REPO_PATH/elements"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# System installation directories"},{"line_number":154,"context_line":"SYSTEM_OCTAVIA_ELEMENTS_PATH\u003d/usr/share/octavia-image-elements"},{"line_number":155,"context_line":"SYSTEM_DIB_ELEMENTS_PATH\u003d/usr/share/diskimage-builder/elements"},{"line_number":156,"context_line":"SYSTEM_TRIPLEO_ELEMENTS_PATH\u003d/usr/share/tripleo-image-elements"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_ec554cc6","line":154,"updated":"2016-07-11 16:17:13.000000000","message":"For this and the tripleo elements, I\u0027d recommend not hard coding a path and instead inspecting an entrypoint in the package. The issue is that /usr/share versus /usr/local/share is distro specific.","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"3cd64de9441b94bc1840c6af4d8a89b3dd0971c5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"OCTAVIA_ELEMENTS_PATH\u003d$OCTAVIA_REPO_PATH/elements"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# System installation directories"},{"line_number":154,"context_line":"SYSTEM_OCTAVIA_ELEMENTS_PATH\u003d/usr/share/octavia-image-elements"},{"line_number":155,"context_line":"SYSTEM_DIB_ELEMENTS_PATH\u003d/usr/share/diskimage-builder/elements"},{"line_number":156,"context_line":"SYSTEM_TRIPLEO_ELEMENTS_PATH\u003d/usr/share/tripleo-image-elements"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_a69dd3bd","line":154,"in_reply_to":"1aa78d24_0dcea42c","updated":"2016-07-12 22:32:15.000000000","message":"hrm, searching a few paths might be the easiest - I don\u0027t think the python dependency is an issue since DIB depends on python anyways, but the entrypoint will require a change to tripleo-image-elements and that might be a bit more work than its worth. As a side note - the trick is to make an entrypoint like tripleo-image-elements-path that just does echo $(dirname $(basename $0)) or similar so you can use it to find the path the package was installed.\n\n\nLonger term - once https://review.openstack.org/#/c/331392/ merges in DIB maybe we can use that and not need any of the repo location logic...\n\n\ntl;dr I like the multiple path searching idea.","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e086b8b46b2a8c6bb206ad6a9cf0213af565c612","unresolved":false,"context_lines":[{"line_number":151,"context_line":"OCTAVIA_ELEMENTS_PATH\u003d$OCTAVIA_REPO_PATH/elements"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# System installation directories"},{"line_number":154,"context_line":"SYSTEM_OCTAVIA_ELEMENTS_PATH\u003d/usr/share/octavia-image-elements"},{"line_number":155,"context_line":"SYSTEM_DIB_ELEMENTS_PATH\u003d/usr/share/diskimage-builder/elements"},{"line_number":156,"context_line":"SYSTEM_TRIPLEO_ELEMENTS_PATH\u003d/usr/share/tripleo-image-elements"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_a9f0e391","line":154,"in_reply_to":"1aa78d24_a69dd3bd","updated":"2016-07-13 13:29:17.000000000","message":"I\u0027ll keep the entrypoint trick in my list, thanks! And keep a look on https://review.openstack.org/#/c/331392/","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"56bbf5034d1e2fc96aba7605f2e7ca44979e7769","unresolved":false,"context_lines":[{"line_number":151,"context_line":"OCTAVIA_ELEMENTS_PATH\u003d$OCTAVIA_REPO_PATH/elements"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# System installation directories"},{"line_number":154,"context_line":"SYSTEM_OCTAVIA_ELEMENTS_PATH\u003d/usr/share/octavia-image-elements"},{"line_number":155,"context_line":"SYSTEM_DIB_ELEMENTS_PATH\u003d/usr/share/diskimage-builder/elements"},{"line_number":156,"context_line":"SYSTEM_TRIPLEO_ELEMENTS_PATH\u003d/usr/share/tripleo-image-elements"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_0dcea42c","line":154,"in_reply_to":"1aa78d24_ec554cc6","updated":"2016-07-12 12:57:39.000000000","message":"I looked at setuptools entry_points, but they seem to be rather aimed at console scripts generation and python libraries function handles? Potentially, DIB parts can be installed on a standalone system, without octavia python parts.\n\nAs an alternative, I can allow OCTAVIA_ELEMENTS_PATH override (already possible for TRIPLEO_ELEMENTS_PATH), else loop on a set of system prefixes (/usr and /usr/local mostly) to search for these directories, what do you think?","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"7d439938aaf9eb1ce2695640af80b83151ba3002","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# System installation directories"},{"line_number":154,"context_line":"SYSTEM_OCTAVIA_ELEMENTS_PATH\u003d/usr/share/octavia-image-elements"},{"line_number":155,"context_line":"SYSTEM_DIB_ELEMENTS_PATH\u003d/usr/share/diskimage-builder/elements"},{"line_number":156,"context_line":"SYSTEM_TRIPLEO_ELEMENTS_PATH\u003d/usr/share/tripleo-image-elements"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"if ! [ -d $OCTAVIA_ELEMENTS_PATH ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_6c579c02","line":155,"updated":"2016-07-11 16:17:13.000000000","message":"This shouldn\u0027t be needed and is best unspecified. DIB will automatically find the system installed elements dir and add it to the ELEMENTS_PATH.","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"56bbf5034d1e2fc96aba7605f2e7ca44979e7769","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# System installation directories"},{"line_number":154,"context_line":"SYSTEM_OCTAVIA_ELEMENTS_PATH\u003d/usr/share/octavia-image-elements"},{"line_number":155,"context_line":"SYSTEM_DIB_ELEMENTS_PATH\u003d/usr/share/diskimage-builder/elements"},{"line_number":156,"context_line":"SYSTEM_TRIPLEO_ELEMENTS_PATH\u003d/usr/share/tripleo-image-elements"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"if ! [ -d $OCTAVIA_ELEMENTS_PATH ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_1232415e","line":155,"in_reply_to":"1aa78d24_6c579c02","updated":"2016-07-12 12:57:39.000000000","message":"Done","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"7d439938aaf9eb1ce2695640af80b83151ba3002","unresolved":false,"context_lines":[{"line_number":177,"context_line":"DIB_ELEMENTS_PATH\u003d${DIB_REPO_PATH:-${OCTAVIA_REPO_PATH%/*}/diskimage-builder/elements}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"if ! [ -d $DIB_ELEMENTS_PATH ]; then"},{"line_number":180,"context_line":"    if ! [ -d ${SYSTEM_DIB_ELEMENTS_PATH} ]; then"},{"line_number":181,"context_line":"        echo \"ERROR: diskimage-builder elements directory not found at: \" $DIB_ELEMENTS_PATH \" Exiting.\""},{"line_number":182,"context_line":"        exit 1"},{"line_number":183,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_8c3c88c0","line":180,"updated":"2016-07-11 16:17:13.000000000","message":"same","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"56bbf5034d1e2fc96aba7605f2e7ca44979e7769","unresolved":false,"context_lines":[{"line_number":177,"context_line":"DIB_ELEMENTS_PATH\u003d${DIB_REPO_PATH:-${OCTAVIA_REPO_PATH%/*}/diskimage-builder/elements}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"if ! [ -d $DIB_ELEMENTS_PATH ]; then"},{"line_number":180,"context_line":"    if ! [ -d ${SYSTEM_DIB_ELEMENTS_PATH} ]; then"},{"line_number":181,"context_line":"        echo \"ERROR: diskimage-builder elements directory not found at: \" $DIB_ELEMENTS_PATH \" Exiting.\""},{"line_number":182,"context_line":"        exit 1"},{"line_number":183,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aa78d24_b2308d57","line":180,"in_reply_to":"1aa78d24_8c3c88c0","updated":"2016-07-12 12:57:39.000000000","message":"Done","commit_id":"18c39c28333b917a9afaf3cba897b41d719bfc51"}]}