)]}'
{"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f0853ba91527ed5e136d533207d749754343054b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            sec_grp \u003d self._create_security_group(sec_grp_name)"},{"line_number":177,"context_line":"        self._update_security_group_rules(load_balancer, sec_grp.get(\u0027id\u0027))"},{"line_number":178,"context_line":"        self._add_vip_security_group_to_port(load_balancer.id, vip.port_id,"},{"line_number":179,"context_line":"                                             sec_grp.get(\u0027id\u0027))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _add_vip_security_group_to_port(self, load_balancer_id, port_id,"},{"line_number":182,"context_line":"                                        sec_grp_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1f76f405","line":179,"updated":"2016-07-29 18:13:42.000000000","message":"I\u0027m asking why you used sec_grp.get(\u0027id\u0027) not sec_grp.id","commit_id":"21078a43d302118df192f160d3eb6d3e0732364d"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f7e4b2e77a310f022d0480ea42f268969fe0060c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            sec_grp \u003d self._create_security_group(sec_grp_name)"},{"line_number":177,"context_line":"        self._update_security_group_rules(load_balancer, sec_grp.get(\u0027id\u0027))"},{"line_number":178,"context_line":"        self._add_vip_security_group_to_port(load_balancer.id, vip.port_id,"},{"line_number":179,"context_line":"                                             sec_grp.get(\u0027id\u0027))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _add_vip_security_group_to_port(self, load_balancer_id, port_id,"},{"line_number":182,"context_line":"                                        sec_grp_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_15b27a94","line":179,"updated":"2016-07-29 04:29:01.000000000","message":"Why get and not sec_grp.id?","commit_id":"21078a43d302118df192f160d3eb6d3e0732364d"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"7b4b93b3fa151262b17a55f16cd3101967e17149","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            sec_grp \u003d self._create_security_group(sec_grp_name)"},{"line_number":177,"context_line":"        self._update_security_group_rules(load_balancer, sec_grp.get(\u0027id\u0027))"},{"line_number":178,"context_line":"        self._add_vip_security_group_to_port(load_balancer.id, vip.port_id,"},{"line_number":179,"context_line":"                                             sec_grp.get(\u0027id\u0027))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _add_vip_security_group_to_port(self, load_balancer_id, port_id,"},{"line_number":182,"context_line":"                                        sec_grp_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_9e1cb414","line":179,"in_reply_to":"bacf61ea_15b27a94","updated":"2016-07-29 13:54:08.000000000","message":"I just added another parameter for quick get sec_grp_id in this function :)","commit_id":"21078a43d302118df192f160d3eb6d3e0732364d"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"0bdc927772c59237a0bd1904ba57b16af5f62234","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            sec_grp \u003d self._create_security_group(sec_grp_name)"},{"line_number":177,"context_line":"        self._update_security_group_rules(load_balancer, sec_grp.get(\u0027id\u0027))"},{"line_number":178,"context_line":"        self._add_vip_security_group_to_port(load_balancer.id, vip.port_id,"},{"line_number":179,"context_line":"                                             sec_grp.get(\u0027id\u0027))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _add_vip_security_group_to_port(self, load_balancer_id, port_id,"},{"line_number":182,"context_line":"                                        sec_grp_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7e4c479e","line":179,"in_reply_to":"bacf61ea_1f76f405","updated":"2016-07-30 01:02:50.000000000","message":"Oh， yes， good suggestion！ I just copy it from the _update_security_group_rules function, I will modify them both.","commit_id":"21078a43d302118df192f160d3eb6d3e0732364d"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"89370843f6fe9226398e2532deb6bef788f5a6b5","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            sec_grp \u003d self._create_security_group(sec_grp_name)"},{"line_number":177,"context_line":"        self._update_security_group_rules(load_balancer, sec_grp.get(\u0027id\u0027))"},{"line_number":178,"context_line":"        self._add_vip_security_group_to_port(load_balancer.id, vip.port_id,"},{"line_number":179,"context_line":"                                             sec_grp.get(\u0027id\u0027))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _add_vip_security_group_to_port(self, load_balancer_id, port_id,"},{"line_number":182,"context_line":"                                        sec_grp_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_19c0c529","line":179,"in_reply_to":"bacf61ea_7e4c479e","updated":"2016-07-30 01:30:16.000000000","message":"After some more thinking， I think we should keep it be sec_grp.get(\u0027id\u0027), because sec_grp is not an object, it\u0027s a dictionary, we cannot use sec_grp.id directly.","commit_id":"21078a43d302118df192f160d3eb6d3e0732364d"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f7e4b2e77a310f022d0480ea42f268969fe0060c","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def _add_vip_security_group_to_port(self, load_balancer_id, port_id,"},{"line_number":182,"context_line":"                                        sec_grp_id\u003dNone):"},{"line_number":183,"context_line":"        sec_grp_id \u003d (sec_grp_id or"},{"line_number":184,"context_line":"                      self._get_lb_security_group(load_balancer_id).get(\u0027id\u0027))"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            self._add_security_group_to_port(sec_grp_id, port_id)"},{"line_number":187,"context_line":"        except base.PortNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f5ac0637","line":184,"updated":"2016-07-29 04:29:01.000000000","message":"^^","commit_id":"21078a43d302118df192f160d3eb6d3e0732364d"}]}