)]}'
{"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"cc513300d040c0acce6038ecdc0f31d6888820fc","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        except base.SubnetNotFound:"},{"line_number":332,"context_line":"            msg \u003d _LE(\"Can\u0027t unplug vip because vip subnet {0} was not \""},{"line_number":333,"context_line":"                      \"found\").format(vip.subnet_id)"},{"line_number":334,"context_line":"            LOG.exception(msg)"},{"line_number":335,"context_line":"            raise base.PluggedVIPNotFound(msg)"},{"line_number":336,"context_line":"        for amphora in six.moves.filter("},{"line_number":337,"context_line":"            lambda amp: amp.status \u003d\u003d constants.AMPHORA_ALLOCATED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_dfdd7ce1","line":334,"updated":"2016-07-29 18:14:59.000000000","message":"But why use LOG.exception? People will thing that it\u0027s real exception which was not catched. If you want you can debug but not exception","commit_id":"e919aba769704a69109bd0617cc6b7099de716f4"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f89fabc76d8d958a01802148779b87bbeeebb4b3","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        except base.SubnetNotFound:"},{"line_number":332,"context_line":"            msg \u003d _LE(\"Can\u0027t unplug vip because vip subnet {0} was not \""},{"line_number":333,"context_line":"                      \"found\").format(vip.subnet_id)"},{"line_number":334,"context_line":"            LOG.exception(msg)"},{"line_number":335,"context_line":"            raise base.PluggedVIPNotFound(msg)"},{"line_number":336,"context_line":"        for amphora in six.moves.filter("},{"line_number":337,"context_line":"            lambda amp: amp.status \u003d\u003d constants.AMPHORA_ALLOCATED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_40b6f23d","line":334,"updated":"2016-07-29 04:41:40.000000000","message":"I can\u0027t understand idea of logging that here. This exception is reraised so why to use exception?","commit_id":"e919aba769704a69109bd0617cc6b7099de716f4"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"748e42d381e976335215a0add65a08966d1ff66d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        except base.SubnetNotFound:"},{"line_number":332,"context_line":"            msg \u003d _LE(\"Can\u0027t unplug vip because vip subnet {0} was not \""},{"line_number":333,"context_line":"                      \"found\").format(vip.subnet_id)"},{"line_number":334,"context_line":"            LOG.exception(msg)"},{"line_number":335,"context_line":"            raise base.PluggedVIPNotFound(msg)"},{"line_number":336,"context_line":"        for amphora in six.moves.filter("},{"line_number":337,"context_line":"            lambda amp: amp.status \u003d\u003d constants.AMPHORA_ALLOCATED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1e51e40e","line":334,"in_reply_to":"bacf61ea_40b6f23d","updated":"2016-07-29 13:50:10.000000000","message":"I just think we should put all error message into log for debug, not only the time exception raised. :)","commit_id":"e919aba769704a69109bd0617cc6b7099de716f4"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"c58e76ad5e1261a8a85ec95d901eb3c629cd8270","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        except base.SubnetNotFound:"},{"line_number":332,"context_line":"            msg \u003d _LE(\"Can\u0027t unplug vip because vip subnet {0} was not \""},{"line_number":333,"context_line":"                      \"found\").format(vip.subnet_id)"},{"line_number":334,"context_line":"            LOG.exception(msg)"},{"line_number":335,"context_line":"            raise base.PluggedVIPNotFound(msg)"},{"line_number":336,"context_line":"        for amphora in six.moves.filter("},{"line_number":337,"context_line":"            lambda amp: amp.status \u003d\u003d constants.AMPHORA_ALLOCATED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7914619f","line":334,"in_reply_to":"bacf61ea_dfdd7ce1","updated":"2016-07-30 01:36:07.000000000","message":"I think you are wrong here...all the exception should be logged with LOG.exception, no matter it\u0027s catched or not. you can find the usage of LOG.exception in this project,then you will see it\u0027s OK here :)","commit_id":"e919aba769704a69109bd0617cc6b7099de716f4"}]}