)]}'
{"octavia/api/v1/controllers/health_monitor.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"75cb42cdcd8a71fe691e285300c4f0a2240006f1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            pool \u003d self._get_db_pool(session, self.pool_id)"},{"line_number":72,"context_line":"            listener_ids \u003d [listener.id for listener in pool.listeners]"},{"line_number":73,"context_line":"        if self.listener_id and self.listener_id not in listener_ids:"},{"line_number":74,"context_line":"            listener_ids.append(self.listener_id)"},{"line_number":75,"context_line":"        return listener_ids"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a0008e02","line":73,"updated":"2016-07-29 04:34:56.000000000","message":"Replace with set","commit_id":"5e31db95d2a729517fc565ee76d53af8ef1f4269"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ff6ceff2b4aa7981436ef7aca56b8af8c019571","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            pool \u003d self._get_db_pool(session, self.pool_id)"},{"line_number":72,"context_line":"            listener_ids \u003d [listener.id for listener in pool.listeners]"},{"line_number":73,"context_line":"        if self.listener_id and self.listener_id not in listener_ids:"},{"line_number":74,"context_line":"            listener_ids.append(self.listener_id)"},{"line_number":75,"context_line":"        return listener_ids"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_0af9e580","line":73,"in_reply_to":"bacf61ea_a0008e02","updated":"2016-08-09 06:39:43.000000000","message":"I\u0027m not sure going from a list to a set and back just to eliminate duplicates buys us much in this instance, and the code seems to be clear enough. :/","commit_id":"5e31db95d2a729517fc565ee76d53af8ef1f4269"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4af800690e4735def00622edcae5963461ea9ad3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            pool \u003d self._get_db_pool(session, self.pool_id)"},{"line_number":72,"context_line":"            listener_ids \u003d [listener.id for listener in pool.listeners]"},{"line_number":73,"context_line":"        if self.listener_id and self.listener_id not in listener_ids:"},{"line_number":74,"context_line":"            listener_ids.append(self.listener_id)"},{"line_number":75,"context_line":"        return listener_ids"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_35d9e9f3","line":73,"in_reply_to":"bacf61ea_a0008e02","updated":"2016-08-11 22:03:33.000000000","message":"Yeah, this could be simplified a bit if listener_ids were a set, but I\u0027m not sure how much it matters.","commit_id":"5e31db95d2a729517fc565ee76d53af8ef1f4269"}]}