)]}'
{"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":21138,"name":"Valleriya Perelman","email":"perelman@il.ibm.com","username":"perelman"},"change_message_id":"b27799ae1f7fb333cc09f36e103c626ceaee25ae","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    with pyroute2.NetNS(consts.AMPHORA_NAMESPACE, flags\u003dos.O_RDONLY) as netns:"},{"line_number":259,"context_line":"        for x in netns.get_links():"},{"line_number":260,"context_line":"            if mac_address \u003d\u003d x.get_attr(\u0027IFLA_ADDRESS\u0027):"},{"line_number":261,"context_line":"                netns_interface \u003d x.get_attr(\u0027IFLA_IFNAME\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    LOG.info(_LI(\u0027Unplugging interface {0} in the \u0027"},{"line_number":264,"context_line":"                 \u0027namespace {1}\u0027).format(netns_interface,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_45cbdc72","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":16},"updated":"2016-08-25 20:20:42.000000000","message":"I would check here that we have found netns_interface, otherwise we might return InternalServerError","commit_id":"6c3d30cc067228e55c68bdb7c9c5ec5e2d8f4440"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"f0734ff00294e3f6520775b75741c88e5c05824d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    with pyroute2.NetNS(consts.AMPHORA_NAMESPACE, flags\u003dos.O_RDONLY) as netns:"},{"line_number":259,"context_line":"        for x in netns.get_links():"},{"line_number":260,"context_line":"            if mac_address \u003d\u003d x.get_attr(\u0027IFLA_ADDRESS\u0027):"},{"line_number":261,"context_line":"                netns_interface \u003d x.get_attr(\u0027IFLA_IFNAME\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    LOG.info(_LI(\u0027Unplugging interface {0} in the \u0027"},{"line_number":264,"context_line":"                 \u0027namespace {1}\u0027).format(netns_interface,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_38aa76d5","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":16},"in_reply_to":"fa7ab95a_45cbdc72","updated":"2016-08-26 01:35:05.000000000","message":"Thanks! Updated!","commit_id":"6c3d30cc067228e55c68bdb7c9c5ec5e2d8f4440"}],"octavia/amphorae/backends/agent/api_server/server.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"9028850946b368b4b4127571516dfc54e78e2011","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                             port_info.get(\u0027fixed_ips\u0027))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"@app.route(\u0027/\u0027 + api_server.VERSION + \u0027/plug/network\u0027, methods\u003d[\u0027DELETE\u0027])"},{"line_number":142,"context_line":"def unplug_network():"},{"line_number":143,"context_line":"    try:"},{"line_number":144,"context_line":"        port_info \u003d flask.request.get_json()"}],"source_content_type":"text/x-python","patch_set":10,"id":"da7fb54a_75bed000","line":141,"range":{"start_line":141,"start_character":39,"end_line":141,"end_character":52},"updated":"2016-09-13 13:51:12.000000000","message":"This endpoint name looks weird. Plug but delete?\nMaybe we should change that for something like /network or /network/manage","commit_id":"8cc86ba482e15f34dc99bbff169194f456bac6b3"}]}
